- 03 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48bbc53ea4d0..904bb9185767 git log 48bbc53ea4d0..904bb9185767 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 jmadill@chromium.org Rename constants in blocklayout.h. Created with: gclient setdep -r src/third_party/angle@904bb9185767 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Ibde0902fa4e4f6713dda961757707a1cfd8b60d6 Reviewed-on: https://chromium-review.googlesource.com/c/1393923Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619589}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e413dae8840a..96345a23dfa9 git log e413dae8840a..96345a23dfa9 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 reed@google.com pass font's explicitly, instead of relying on SkFont::LEGACY_ExtractFromPaint Created with: gclient setdep -r src/third_party/skia@96345a23dfa9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ie129cfb1a5a7e68ef6beb605f0718e9615ffcf43 Reviewed-on: https://chromium-review.googlesource.com/c/1394364Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/479562cc0b31..4b6f54f365ea Created with: gclient setdep -r src-internal@4b6f54f365ea The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibf2916990cbf6faa6981cd6b29f6acfe849f9b94 Reviewed-on: https://chromium-review.googlesource.com/c/1394227Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619587}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a6ba1795b7bc..b7b477b1120e git log a6ba1795b7bc..b7b477b1120e --date=short --no-merges --format='%ad %ae %s' 2019-01-03 eseckler@google.com Merge "service: Flush file descriptor when disabling tracing" Created with: gclient setdep -r src/third_party/perfetto@b7b477b1120e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib10240243f290df678069eb5de1b4099419e00cb Reviewed-on: https://chromium-review.googlesource.com/c/1394204Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ed72ba44. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" 23a658b9 "WebBluetooth Scanning API" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: emircan@chromium.org: external/wpt/screen-capture hbos@chromium.org, hta@chromium.org: external/wpt/webrtc kojii@chromium.org: external/wpt/css/CSS2/text external/wpt/css/css-text/overflow-wrap kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 mstensho@chromium.org: external/wpt/css/css-multicol rego@igalia.com: external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I118d3ec3bfdb8a5f0fac318debd582352b747aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1394189Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619585}
-
Stefan Zager authored
Blur filters do not contribute to visual overflow, so hit testing doesn't account for them, even when the kHitTestVisualOverflow flag is used. This change expands the rect used for occlusion hit testing to include the radius of blur filters. BUG=827639 R=chrishtr@chromium.org Change-Id: I01eb61eacbaac2005a84fa181daa8e6f8765d18d Reviewed-on: https://chromium-review.googlesource.com/c/1364152Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#619584}
-
Dan Beam authored
TBR=michaelpg@chromium.org BUG=916782 Change-Id: I22b4d6cefaf75d1e0331eaddb201643d5bb0d67c Reviewed-on: https://chromium-review.googlesource.com/c/1394193Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#619583}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I6ee0054c1dc9ed5018108b21c6f503444284abca Reviewed-on: https://chromium-review.googlesource.com/c/1394424Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#619582}
-
Dominick Ng authored
This CL addresses a bug where bookmark apps (including desktop PWAs) do not have their navigations record to Chrome history. Chrome Packaged apps do not have a |browser| object, so removing the is_app() check will not affect them. BUG=821685 Change-Id: I87356b6c6d3dad5e4cc321966bf385975adac995 Reviewed-on: https://chromium-review.googlesource.com/c/1388045Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#619581}
-
Dan Beam authored
This is so I prescribe a method for folks to fix their code when updating the chromium-dev@ thread about single-line conditionals: https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/pQMvLrovE48/OuPV1URmAgAJ TBR=dpapad@chromium.org BUG=916782 Change-Id: If777de735b44157fb79365488088174bdef4ac2d Reviewed-on: https://chromium-review.googlesource.com/c/1394228Reviewed-by:
-
Katie D authored
This fixes the constantly onscreen / somewhat noisy autoclick animation to only show up when the user has stopped moving the mouse as rapidly. The click now occurs where the mouse position was when the animation starts. Bug: 915861 Change-Id: I536850bb8a2d0f2cac6add3cf2f693f68f3fb073 Reviewed-on: https://chromium-review.googlesource.com/c/1380950 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#619579}
-
Tom Anderson authored
BUG=webrtc:10165 R=thakis CC=titovartem Change-Id: I72541d412d0f92d94efaadc3fcdc730f8d641e4b Reviewed-on: https://chromium-review.googlesource.com/c/1393805Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#619578}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/191e64b6c6c2..e413dae8840a git log 191e64b6c6c2..e413dae8840a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 04ea03e4e1e1..904bb9185767 (4 commits) 2019-01-02 egdaniel@google.com Move GrVkSecondaryCBDrawContext header into src to hide it. 2019-01-02 reed@google.com hide drawpostext etc. Created with: gclient setdep -r src/third_party/skia@e413dae8840a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Id6af735f939339dc88883a8ac51fc71488d8ef66 Reviewed-on: https://chromium-review.googlesource.com/c/1394225Reviewed-by:
-
Bin Wu authored
For Quic sessions closed with code QUIC_TOO_MANY_RTOS at client side, record (in UMA) the number of packets it sent/received at the time of close. R=zhongyi@chromium.org Change-Id: If735d0d663c74bedf18d40795bdae25aae1edc92 Reviewed-on: https://chromium-review.googlesource.com/c/1392251 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619576}
-
khmel@chromium.org authored
This allows making default app customization based on user type. For example make Youtube TV as default app on nocturne users only for unmanaged apps. This is implemeted similar to crrev.com/c/851338 that introduced the same concept for crx default apps. TEST=Locally (together with crrev.com/i/755690) + unit tests BUG=902978 Change-Id: I78d5e3da4150d6d0e1f374261113d9cdfb80260a Reviewed-on: https://chromium-review.googlesource.com/c/1391870 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#619575}
-
kylechar authored
CallbackTests still use base::Callback/base::Closure instead of base::RepeatingCallback/base::RepeatingClosure. Update tests to set a good example for what type new code should use. Bug: none Change-Id: I36da5d6bad06df0b05137560c0fe5c3840dafbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1340564Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#619574}
-
Paul Miller authored
It's been replaced by NormalizedPermutingEntropyProvider; see commits 7c0efea0 and 43556679. BUG=890413,912368 Change-Id: I962ecdde976f84c0cdadfb6c1a36a3d12246fb0b Reviewed-on: https://chromium-review.googlesource.com/c/1388287Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1d110aee1f7a..f55b6a510625 git log 1d110aee1f7a..f55b6a510625 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 dburger@chromium.org Remove constants now unused with removal of GetAnnotatedBuilds 2019-01-03 lamontjones@chromium.org signing: correctly find the vboot_reference signing scripts 2019-01-03 vapier@chromium.org gerrit: todo: filter out Verified-1 2019-01-03 vapier@chromium.org gerrit: todo: switch to native search syntax 2019-01-03 itspeter@google.com runtime_probe: Add user "runtime_probe" to group "cros-ec_access" Created with: gclient setdep -r src/third_party/chromite@f55b6a510625 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iadc6abd61b46e7330e8ac7d35f32e412e12ec703 Reviewed-on: https://chromium-review.googlesource.com/c/1394226Reviewed-by:
-
dstockwell authored
Bug: 902646 Change-Id: I397bc8d7043ce3a911bfdd5139381f4cae7599bf Reviewed-on: https://chromium-review.googlesource.com/c/1393123 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#619571}
-
dstockwell authored
This will allow the ink component to be unloaded and will prevent any of its globals from intefering with the PDF viewer. Covered by existing tests in annotations_feature_enabled.js Bug: 902646 Change-Id: Ie45067d95df2d91441516714b04e6e5f4f3e459d Reviewed-on: https://chromium-review.googlesource.com/c/1392702Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a70cce175222..479562cc0b31 Created with: gclient setdep -r src-internal@479562cc0b31 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6590331a1e22dda7f16f7413766da3bd133d6539 Reviewed-on: https://chromium-review.googlesource.com/c/1394223Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/392ae31831b7..46a3ae6dffc6 git log 392ae31831b7..46a3ae6dffc6 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 cepheus@frii.com Update copyright years. 2019-01-03 cepheus@frii.com Include the new spv.d file when fixing line endings on Windows. Created with: gclient setdep -r src/third_party/spirv-headers/src@46a3ae6dffc6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I467e0560e7edbad2ef8fc1cc2894133d3d788e84 Reviewed-on: https://chromium-review.googlesource.com/c/1394224Reviewed-by:
-
Dan Beam authored
This CL was generated with: $ eslint --fix chrome/browser/resources $ git cl format --js Note: there are some annoying edge cases that mess up formatting. Specifically: if (blah) // trailing comment <do something> is transformed by eslint --fix into: if (blah) // trailing comment { <do something> } and all other types of things start to get funky. TBR=aee@chromium.org Bug: 916782 Change-Id: I03b591da917d5315616bf5e31566733771dc168c Reviewed-on: https://chromium-review.googlesource.com/c/1393944Reviewed-by: -
edchin authored
This CL simply removes unused/dead code from snapshots. Change-Id: I23d7eebea71d1db42057b5b06750d76fc2081bd0 Reviewed-on: https://chromium-review.googlesource.com/c/1392265Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619566}
-
edchin authored
The default snapshot image is a simply a 2x2 white pixel image. This image is unnecessarily passed around and unnecessarily complicates code. This CL removes use of a default snapshot image, and updates the API contract to use nil as the sentinel value for failed retrieval or generation. Bug: 918032 Change-Id: Ie7d8312cad6d05912474c6205c1bbb4ec9d242e0 Reviewed-on: https://chromium-review.googlesource.com/c/1392264Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
edchin authored
Snapshot coalescing is dead code. It is only enabled when the user enters the tab switcher. A lot of code around entering the tab switcher has changed since this coalescing code was first written. It is no longer the case that multiple snapshots are taken during the transition. Additionally, snapshots are now asynchronous and do not block the UI. This CL removes the dead snapshot coalescing code. Bug: 918032 Change-Id: I766e6b8546c785d9ba25e36c329504cdce7208e4 Reviewed-on: https://chromium-review.googlesource.com/c/1392261Reviewed-by:
-
edchin authored
This CL improves snapshots with the following changes: 1) Snapshots are taken earlier when entering the tab switcher. Snapshots are now taken at the earlier TouchDown event rather than the later TouchUpInside event. This is where the tab grid cells are prepared, so the snapshot is needed at this time. 2) Snapshots are now taken when entering the tab switcher while the page is still loading. Metrics show that 30% of tab switcher entries are while the page is still loading. Previously, we disabled snapshotting while the page is still loading so as to prevent stale snapshots. That means 30% of tab switcher transition animations resulted in a blank snapshot. This CL enables snapshotting in these cases. The page will continue to load even while the tab switcher is shown and will successfully update the snapshot in the tab switcher. 3) Snapshots are no longer removed from the cache when a page begins to load. This supports #2 above. However, snapshots are now removed from the cache when snapshot attempts fail. This ensures that a stale snapshot isn't kept around to retrieve. 4) Histogram metrics at tab switcher entry are updated to capture two dimensions: a) whether the page was loading or not at that time, and b) whether the snapshot was successful. 5) Histogram metrics are added to understand whether stale snapshots are successfully updated at page load. Stale snapshots are defined as snapshots of a previous page, when a new page is loading. Bug: 918032 Change-Id: Ibb1cd267ca37cbd066e047742300967c57ce7962 Reviewed-on: https://chromium-review.googlesource.com/c/1391713 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5dee56f39c42..d238bb67a52a git log 5dee56f39c42..d238bb67a52a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 jiawei.shao@intel.com Support using a layer of a texture as a color attachment on OpenGL Created with: gclient setdep -r src/third_party/dawn@d238bb67a52a The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I2565ffe5f18802812210c0917933f0af7a4dfbde Reviewed-on: https://chromium-review.googlesource.com/c/1393925Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/534e18423b9c..1d110aee1f7a git log 534e18423b9c..1d110aee1f7a --date=short --no-merges --format='%ad %ae %s' 2019-01-02 pprabhu@chromium.org chromeos_config: Stop running HWTests from link-paladin 2019-01-02 jclinton@chromium.org Add Emacs elisp to automate finding compile command Created with: gclient setdep -r src/third_party/chromite@1d110aee1f7a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic18546f18838ed172632ad7db4530ba408708814 Reviewed-on: https://chromium-review.googlesource.com/c/1393924Reviewed-by:
-
Chris Lu authored
Adds class that defines public //ios/web API for FindInPageManager. Bug: 894651 Change-Id: Ie1f750e6ea8953bcbb169bc4c957a6946b217d8f Reviewed-on: https://chromium-review.googlesource.com/c/1387696 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#619560}
-
Lukasz Anforowicz authored
This gives extension authors a way to test whether their extension is ready to be removed from the allowlist. Bug: 846346 Change-Id: Ide112dab32076ac2a554115b7ca815a23385050c Reviewed-on: https://chromium-review.googlesource.com/c/1368783 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619559}
-
Istiaque Ahmed authored
Bug: None Change-Id: I8b5c88b97f0214298264d57212e5aa3b18a31d2d Reviewed-on: https://chromium-review.googlesource.com/c/1387984Reviewed-by:
-
Daniel Ng authored
Modified Crostini registry to store exec data of apps and updated AppSearchProvider to add exec to the searchable words field. Updated the appropriate test files to also test for this new case. Bug: 849936 CQ-DEPEND=CL:1381311 Change-Id: Ice016099aa10a42dabb788c7ae4f05e35b036477 Reviewed-on: https://chromium-review.googlesource.com/c/1382658 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619557}
-
Wez authored
Update the run_all_tests.cc for Blink's heap tests to derive from base::TestSuite and override Initialize/Shutdown to provide the expected environment for the heap tests. Bug: 918724 Change-Id: I3c9bab5e07b828e04473ad61d0dc380f60d34c60 Reviewed-on: https://chromium-review.googlesource.com/c/1393893Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619556}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bbd8fc1f9fa4..a70cce175222 Created with: gclient setdep -r src-internal@a70cce175222 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id71543b5f469a205da6aca3dca7010188fc08c60 Reviewed-on: https://chromium-review.googlesource.com/c/1393357Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/4618b86e9e4b..392ae31831b7 git log 4618b86e9e4b..392ae31831b7 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 johnkslang@users.noreply.github.com Merge pull request #87 from rtbo/dlang Created with: gclient setdep -r src/third_party/spirv-headers/src@392ae31831b7 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia712ff4d3bccbe1bfec57a7c68dce03e7b7ced7e Reviewed-on: https://chromium-review.googlesource.com/c/1393926Reviewed-by:
-
Dan Beam authored
This CL was generated with: $ eslint --fix ui/webui $ git cl format --js Note: there are some annoying edge cases that mess up formatting. Specifically: if (blah) // trailing comment <do something> is transformed by eslint --fix into: if (blah) // trailing comment { <do something> } and all other types of things start to get funky. R=aee@chromium.org BUG=916782 NOPRESUBMIT=true # for __lookupGetter__ in cr.js Change-Id: I2698d8c17ee06dac0688aa55d783f7978f587663 Reviewed-on: https://chromium-review.googlesource.com/c/1393626 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#619553}
-
khmel@chromium.org authored
We are 2+ years using shelf pins supported by sync. Now we can drop import from prefs code. As a side effect this fixes several DCHECKs. This also makes pin positions for default apps and apps, pinned by policy deterministic and not-dependent from installation order. TEST=Locally + unit_tests. Logic of unit tests is not changed. BUG=918203 BUG=907221 Change-Id: I11d1cd7f1f0192719b48adfd3fa9e56c9dc1429b Reviewed-on: https://chromium-review.googlesource.com/c/1392280 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#619552}
-
Peter Kotwicz authored
This CL changes the names of methods which search for a WebAPK which matches a given URL to make it clearer what the return value is if there are several matching WebAPKs. Changed method names in WebApkValidator: queryWebApkPackage() -> queryFirstWebApkPackage() queryWebApkResolveInfo() -> queryFirstWebApkResolveInfo() findWebApkPackage() -> findFirstWebApkPackage() findWebApkResolveInfo() -> findFirstWebApkResolveInfo() BUG=None Change-Id: I2a1bb3042f93fb6f465cd069f672bfca57acb7f9 Reviewed-on: https://chromium-review.googlesource.com/c/1390320 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619551}
-
Daniel Rubery authored
The crash in http://crbug/915037 appears to have been fixed, so this CHECK is ready to be removed. Bug: 915037 Change-Id: I1b09c308287e3ef6d411b60378f08f334c8396e3 Reviewed-on: https://chromium-review.googlesource.com/c/1393884 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619550}
-
