- 07 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3b08f35fd150..3e8fae719358 2020-08-07 brianosman@google.com Revert "Add inline threshold to SkSL::Program::Settings" 2020-08-07 johnstiles@google.com Enable ClangTidy check readability-const-return-type. 2020-08-07 johnstiles@google.com Enable ClangTidy check readability-static-accessed-through-instance. 2020-08-07 johnstiles@google.com Fix bug in SkMipmapCache::AddAndRef factory selection. 2020-08-07 brianosman@google.com Add support for children to runtime color filters 2020-08-07 fmalita@chromium.org [skottie] Add animation in/out point getters 2020-08-07 brianosman@google.com Add inline threshold to SkSL::Program::Settings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I9b4d24b880ad32ce43e0a72575db074f6fd76e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796054}
-
phillis authored
Move OS updates from being embedded in WebAppInstallTask and observer pattern to OsIntegrationManager and remove AppShortcutManager from WebAppInstallTask and InstallManager. This also removes ShortcutManager and FileHandlerManager from inheriting AppRegistrarObserver and get rid of unneeded TestAppShortcutManager. Bug: 1098027 Change-Id: I7ecbaa2a68669435d4a8a05b7d02c8b6ef67fc09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331072 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#796053}
-
Brian Sheedy authored
Prepares RenderTestRule for the upcoming test name change to not include OS or device model in the test name reported to Skia Gold. This is done by creating a copy of the compareForResult method that does not add the extra information and calling it at the end of compareForResult. These extra comparisons have the ignore=1 field in their JSON, which means that they won't cause Gold to comment on CLs if they fail. This is so that any existing flakiness in the tests can work through the system with the new names without affecting anyone. Once everything is ready, this new implementation can just replace the existing compareForResult (with the ignore field removed and some renaming performed). Bug: 1077274 Change-Id: I714999a382b2f2f9a7e4e5abe34d46a817c8882a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337101Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796052}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fe4688edfa48..4c2f9c90f425 2020-08-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2f197110..61491ae4 (795842:795944) 2020-08-07 sprang@webrtc.org Revert "Makes aborting delayed probes default enabled." 2020-08-07 eshr@google.com Add ilnik to OWNERS of video/adaptation 2020-08-07 nisse@webrtc.org Delete unused argument |require_key_frame| If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I68aed292d930e7857d5e20e829e39d493a47b922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343375Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Idddd721b170edfddc3b7a43f39825583d4e4b707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343372Reviewed-by:
-
shivanigithub authored
Change-Id: I2e64bf17aafd6aeeaaafbb54d30f246998fcf4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324506Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#796049}
-
Tommy Li authored
Add a new value to OmniboxFocusType called DELETED_PERMANENT_TEXT, which corresponds to the Ctrl+L, and then Backspace case. This CL also breaks OmniboxFocusType out of template_url.h, into its own header file. This is because we plan to use OmniboxFocusType within AutocompleteInput in the next CL, to replace the from_omnibox_focus() boolean with this multi-valued enum. Bug: 1106096 Change-Id: I2ef25083845d272fd934adafa66624de85d84cb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341399Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796048}
-
Xinghui Lu authored
Per UX guidance, the highlighted area should match the tap target area. Mocks: go/esb-clank-dd-highlight screenshot: http://screen/OkDyUpuFG3Q RTL screenshot: http://screen/2U98n12nfaw Bug: 1105998 Change-Id: I3bac076c70596f090f76800ca8b82f80a0a37dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292710 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
-
Sammie Quon authored
The overview bounds calculations today consists of determining the bounds in OverviewGrid, then adding a margin (for the highlight border) and to eat events near the edge), then removing the margin for calculations down the line. This patch simplifies some of that logic, allowing us to remove a workaround in WmHighlightItemBorder. Some calculations are still left behind, but its a lot fewer and better commented. This does affect behavior in one case - for extreme window cases (in this example super wide windows), the ratio between the width and height is now 2:1. Previously, the ratio between the width + margin and height + margin was 2:1. I think this is the expected behavior we want. Test: existing tests Bug: 1111961 Change-Id: I564a63cdf5f9420ef364cd6473acaccba3c6050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335794 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#796046}
-
Sammie Quon authored
Existing screenshot accelerators now enter capture mode. Test: manual, no screenshots taken with capture mode enabled Change-Id: Iaa80f4f16b906907c8f574627c4ce4217469a039 Fixed: 1113848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341831Reviewed-by:
-
Avi Drissman authored
Do not try to derive one weight of font from another. Use the API to directly generate them. PlatformFontMacTest.FontWeightAPIConsistency tested that our understanding of shifting weights up and down was correct. The code no longer shifts weights up and down as that is unreliable and version-specific, so there is no need to test weight shifting and it is removed. This also fixes Big Sur issues. Bug: 1101426 Change-Id: I2165c3550ad295b3ee7742f3289874ed2bb89c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340262 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796044}
-
Robert Sesek authored
Bug: 1114242, 1113952 Change-Id: Ie4ac3587177024f3c14bdca10515d5291063e1c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342255Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#796043}
-
Xida Chen authored
This CL fixes a problem when pinch zoom is laggy. The root cause of this is due to a legacy IPC channel that is not removed yet in the InputRouterImpl. More specifically, in InputRouterImpl, we now have: 1. OnSetCompositorTouchAction, which sets the allowed touch action computed from CC. This is the most restricted touch action which can be used to process gesture event right away. 2. SetTouchActionFromMain: this is the touch action computed by the Blink main thread, and that's the correct one (more correct than the compositor computed one), and we should use this touch action to process touch events. 3. OnSetTouchAction: this is the legacy one, it was there before SetTouchActionFromMain was introduced. This should be removed. The problem is that we got SetTouchActionFromMain to be Auto, which means any gesture event is allowed. But then OnSetTouchAction somehow set the touch action to be none, which means no gesture event can be allowed, and that prevents pinch zoom. Bug: 1059125, 1030234 Change-Id: I4bb66ad52f6a1353f8383d6685cb293b41d4e08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304161 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#796042}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fb03de538548..3a3d419df752 2020-08-07 courtneygo@google.com Reference count context to fix ASAN issues If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I6814164726522aaa5c833b9beb08eda14931c693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343371Reviewed-by:
-
Michael Thiessen authored
Chrome does not allow sites to navigate to content URIs, but the Google Search app parses and re-sends URIs, including content URIs, sent to it. This allows intents sent to GSA to bypass this content URI restriction. In order to prevent this bypass, we can simply remove the BROWSABLE category from our intent filters that handle content URIs, as we don't need to handle content URIs coming from other browsers. This change also adds tests for our Intent Filters, which, as far as I can tell, were untested before this change. I also fixed a few edge cases with the intent filters I modified as revealed by the tests. Note that for some intent filters I removed the content scheme altogether. In these cases the filter wasn't useful because a file extension was specified, making it impossible for the content scheme to be matched. I also suppressed some AppLinkUrlErrors: "Error: Activity supporting ACTION_VIEW is not set as BROWSABLE". This isn't an error. I don't know why lint flags it other than to make sure you know what you're doing and don't accidentally prevent browsers from launching your View intent Activity. Bug: 1092453 Change-Id: I167d2e41c0d9c75c0b80a5a1778817b42016e21b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321522 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#796040}
-
Egor Pasko authored
When run_web_tests.py --driver-name=... is used, print the driver name on error instead of the default driver name. Bug: None Change-Id: I5577fe5e774f6fd9959737d3e2792c20e5fc9359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341649Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#796039}
-
Mason Freed authored
Bug: 1104846 Change-Id: Id2a9c609a8595576787e4fd5e0f7de3e250506fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342141 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#796038}
-
Matthew Mourgos authored
The color for the shelf notification badges is calculated by getting a light vibrant color from the shelf app icon image. If no color can be calculated then white is used as the default notification color. Bug: 1080827 Change-Id: I2b858b7c15f1a54191afe063716c64a9fa58b925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241291 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796037}
-
Ioana Pandele authored
The check manager will now package the compromised credentials in a format that is useful to the Java side and send them over to the bridge. Bug: 1102025 Change-Id: I86d6dc86c379a4dc67c618cb048a2eff8bbe5af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339967 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#796036}
-
Victor Vasiliev authored
This is a primarily no-op change to aid adding support for NetLog into QuicTransportClient. Bug: 1114027 Change-Id: I06c449c3cc977789a1d28c5320905ca4ffd2be3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342483Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#796035}
-
Olivier Yiptong authored
Adds FONT_ACCESS content settings and permission enum values. This gates the experimental navigator.fonts.query() enumeration API. This cl also wires up the permission prompt to the API implementation. In doing so, direct worker support for the API has been removed. Should developers have the need to enumerate from a worker, we'll reconsider the shape of the API so that the permission prompt is explicit, perhaps via the Permission Request API or otherwise. Bug: 1112552 Change-Id: Ie0ec477e4ae67b93d35e1008f76b84be312fcc6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335980Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#796034}
-
Natalie Chouinard authored
Copy downstream XML to preload Google Sans fonts from GMS Core to upstream. This will be followed by CLs to cleanup downstream preloading (crrev.com/i/3202583) and update downstream font references (crrev.com/i/3202445). The only change made in duplicating these files was renaming font/accent_font.xml and font/accent_font_medium.xml to font/google_sans.xml and font/google_sans_medium.xml, respectively. At the time of this CL landing, there are not yet any style resources referencing these new font resources. The only functional change in this CL is that public Clank builds will now also preload Google Sans, which is by design to support https://crbug.com/1110973. Bug: 1112002 Change-Id: I242e28d1ff57f41d17d08499e9efb236268e11de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339612Reviewed-by:
-
Michael Thiessen authored
The non-androidx version of UiThreadTestRule has surprising semantics, like causing the @Before and @After methods to run on the UI thread, even when not annotated. Almost none of the tests that use UiThreadTestRule are aware of this, and do things like poll the UI thread (causing flaky deadlocks), or redundantly post tasks to the UI thread. This change replicates what the androidx junit4 test runner does, processing the @UiThreadTest annotation when running test methods to run only the test method on the UI thread without causing other rules or @Before/@After to run on the UI thread as well. Bug: 1111893 Change-Id: Ib0a067e24fec0fd1a2a5b1558d30e5f85e5f37a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332301 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796032}
-
Jan Wilken Dörrie authored
This change adds implementations of the algorithms in [alg.merge] to //base/ranges/util. Bug: 1071094 Change-Id: I7576ddd3c84738437959317b881c4883339359b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339975 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796031}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0c0349252934..a4cba6578f09 2020-08-07 treehugger-gerrit@google.com Merge "Importing flow events from protobuf to flow table" 2020-08-07 treehugger-gerrit@google.com Merge "Perfetto: parse GpuMemTotalEvent in trace processor" 2020-08-07 treehugger-gerrit@google.com Merge "Minor test cleanup, use protozero::HeapBuffered<Msg>" 2020-08-07 hjd@google.com Merge "ui: Remove thumbnail mode from heap profiles" 2020-08-07 hjd@google.com Merge "ui: Add instant event rendering" 2020-08-07 treehugger-gerrit@google.com Merge "Make client_ext ABI more stable." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8ff8e2e3bd8f4fa4ebd2539193944c57b3188276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343147Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/56f14dabfe99..0c0349252934 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I51a5b3bf19db94c3016efe14361aa7c1cfa8655c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343311Reviewed-by:
-
Tarun Bansal authored
Change-Id: Ie5273ded866519340ee6c3f8665b636d6e8ef7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342118 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#796028}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e69d5b2de943..56f14dabfe99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I28e6d75b8d7d2a075d3a0b8c7a7c8d30c82eb3d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343307Reviewed-by:
-
chrome://flagsCollin Baker authored
This also updates the expiration of WebUITabStrip which I forgot to extend. Bug: None Change-Id: Icba7fc5ce10bb967fe4145662ce6cbe08c96454a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341823 Commit-Queue: Collin Baker <collinbaker@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Auto-Submit: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#796026}
-
dpapad authored
Adding a simple usage of eventToPromise() to showcase that loading generated files works, as well as that JS type checking passes. Bug: 1101146 Change-Id: I3a4ad806b498f1fef1ab92db355d1d4e1af20f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338915Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#796025}
-
Lei Zhang authored
In the rare case where the renderer cannot send its data, it exits early from PrintFrameContent() and forgets to send the onafterprint event. Fix the code to always send the event when possible. Change-Id: I31cf4fec8f17fcd64742d22056c0c445b422c7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340356Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796024}
-
Dominic Mazzoni authored
Original patch: r795655 http://crrev.com/c/2340163 Revert: r795891 http://crrev.com/c/2339627 Fix is just to update the Android expectations. Original description: A file picker control (<input type=file>) is exposed as a button in the accessibility tree. Previously the filename chosen was only exposed in the accessible value, like with other input elements - but most screen readers were not reading the value, since it's not normal to read the value of a button. So users couldn't tell what file was chosen, or whether a file was chosen at all. Fix this by making the accessible name include both the filename (as already exposed in the value) and the text of the "Choose File" button. Add a test to confirm this is working correctly when a file is selected. Bug: 903655, 1114139 Tbr: aleventhal@chromium.org Change-Id: I77185cb5a71e6a1ae821f8a9ea9e205596cff109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343308Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796023}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e69d5b2de943..56f14dabfe99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I53a3dfe511f28659a3600b6a6715264b2b5aee22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342137Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fb4355fa6266..ce00f903c268 2020-08-07 patrick.brosset@microsoft.com Grid: Always place grid area labels in the top/left corner of the area If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1100384 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5f7ba7e1ad32ecc98a37950761cc4129d18334f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343369Reviewed-by:
-
Andrew Grieve authored
And moved helper function into gn_helpers.py It was only ever in .properties format so that it could be easily parsed by bash, but we no longer need that. Also fixes default_android_sdk_version to be a string. -next builds need it to be a string. Bug: None Change-Id: I99541f18510de93dae4c0d68b734638564f74ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340673 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#796020}
-
John Delaney authored
What: Add relevant config line for 3p origin trials Why: The Conversion Measurement API may be used by third parties to measure conversions between different first parties. Allowing them to opt-in makes the trial integration much easier. Bug: 1113879 Change-Id: I76df331041d0a3519c0805c7d8a9239556fcd492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340553Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796019}
-
yjliu authored
This was caused by frame throttling which continued to apply to the snapped window in splitview after the window was moved out of overview. Bug: 1112835 Change-Id: I80f09e27cf2f29e67f8dfa8d8baa2ae3fabe1349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342130 Commit-Queue: Jun Liu <yjliu@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#796018}
-
Ilia Samsonov authored
This CL removes the blink web tests suite from Mac10.10 and Mac10.11 ci builders. Bug: 1107003 Change-Id: If124a774b663ccb60cf39a7aa44b624c37341274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343306Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#796017}
-
Rakina Zata Amni authored
The test depends on the fact that unload handlers will run before the new page renders on same-site navigations, which isn't supported for same-site cross-RFH navigations currently. Bug: 977562, 1110744 Change-Id: If191895ec13f9699b478737fa16a7175a9aa3aac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341232Reviewed-by:
-
Dan Harrington authored
To keep scroll tracking in sync with v1, I wanted to re-use v1's ScrollTracker. I moved ScrollTracker to the shared package, and refactored it so that it uses normal chromium deps. This does change behavior very slightly for simplicity -- the new implementation will sometimes collate scroll events that happen between 200ms and 400ms apart. Events between 0 and 200ms are always collated, as before. Finally, the new ScrollTracker is used to call FeedStreamSurface's native scroll reporting functions. Bug: 1044139 Change-Id: I8bbfdf6cc8f8d336df1b6d97f39a5e9f0bf5afe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340168 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796015}
-
