- 21 Nov, 2018 40 commits
-
-
Antonio Gomes authored
CL converts ArcAuthContext away from PO2TS, as part of the IdentityManager servicification effort (//services/identity). No functionality change is expected. Note that there is still one reference to PO2TS left, that is used to construct UbertokenFetcher. It will be removed on a follow up pass. CL also takes the opportunity to migrate ArcBackgroundAuthCodeFetcher away from OAuth2TokenService::Consumer, since it is tied to ArcAuthContext. BUG=905243 TEST=Run on test device. TEST=Run browser_tests --gtest_filter=Arc* TEST=Run unit_tests --gtest_filter=Arc* Change-Id: I1a74df3b79a7753e96dc7993d636692efa18d1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1345130 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610189}
-
Steven Holte authored
Update variations_seed proto and metrics protos, and send seed versions to UMA, so it's available for analysis. Change-Id: Id2954646c6c000af8accde3e43f1eedc9e5c1c1f Reviewed-on: https://chromium-review.googlesource.com/c/1339242Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#610188}
-
Majid Valipour authored
Previously scroll source was resolved anytime it was accessed. However this is problematic in two ways: - The Document.scrollingElement can change so we could resolve to a different node if that happens. However Attach/Detach process expect the resolved node to be the same and violating this invariant can cause unexpected behavior. - Resolution process can trigger layout which may not be allowed during detachment (see issue 890143) This patch changes this behavior so that the scroll source is only resolved at ScrollTimeline construction and the resolved node is used for the lifetime of scroll timeline. Bug: 890143 Change-Id: I8a745385e22e2c0718a5f9cade763f5eb2174c83 Reviewed-on: https://chromium-review.googlesource.com/c/1342677Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610187}
-
Erik Luo authored
Motivated by the desire to make Console links keyboard navigable, this CL removes the BrowserConsole module and moves logic back into ConsoleViewMessage. BrowserConsole did not explicitly depend on BrowserSDK. Bug: 865674 Change-Id: Ibb004c52699b1d504b32accdfa4ee19adc907633 Reviewed-on: https://chromium-review.googlesource.com/c/1338329Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#610186}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3adb7977dae0..fe39a6f342f6 git log 3adb7977dae0..fe39a6f342f6 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 zoddicus@users.noreply.github.com Add tests coverage for OpTypeVector column count validation (#2087) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fe39a6f342f6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8d21c4bd9389e3b8fa4af21c3097290f6bcba2bc Reviewed-on: https://chromium-review.googlesource.com/c/1346889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610185}
-
Rebekah Potter authored
This reverts commit d12f01a6. Reason for revert: Causes crbug.com/907378, and the Blink change that caused that bug is expected to be reverted. Original change's description: > Fix Print Preview sidebar outline > > The scroller is now focusable due to Blink changes at r608013. > Remove the outline and take it out of the tab order. > > Bug: 905604 > Change-Id: Ib8154c691e1240b27118288950c8efdf46c803b6 > Reviewed-on: https://chromium-review.googlesource.com/c/1343285 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609495} TBR=dpapad@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905604 Change-Id: Iea4a67f80284091c2acf0fee24215a7f5b174a03 Reviewed-on: https://chromium-review.googlesource.com/c/1344837Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610184}
-
Kyle Milka authored
Add flag for showing search suggestions on the local NTP. Add flag for showing promos on the local NTP. Move kUseGoogleLocalNtp and kDoodlesOnLocalNtp into ntp_features. Update flag-metadata for ntp flags. Bug: 904565, 906278 Change-Id: I465c1f3c42092f491112439260d9fe8546e038a7 Reviewed-on: https://chromium-review.googlesource.com/c/1338233Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#610183}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5825fead. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I99637ffece142e86ae23e98ccb5ae132489e2c43 Reviewed-on: https://chromium-review.googlesource.com/c/1347091 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610182}
-
Mikel Astiz authored
This will allow tests to introduce doubles in future patches. Bug: 895455 Change-Id: I33b99a8a90f00ab47678a852e4521e90deee1390 Reviewed-on: https://chromium-review.googlesource.com/c/1346453Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610181}
-
Mohamed Amir Yosef authored
Bug: 882887 Change-Id: Id2b3c2c6d80b30552fd94face69b32223f455c68 Reviewed-on: https://chromium-review.googlesource.com/c/1296543 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#610180}
-
Geoff Lang authored
The context may have been destroyed because it was lost, recreate it for the next iteration of the fuzzer. BUG=907303 BUG=907350 Change-Id: Ie2acb7d8da68be7f96427766c697624e0d54bd7a Reviewed-on: https://chromium-review.googlesource.com/c/1346730 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610179}
-
Nico Weber authored
Add debug logging to debug why https://chromium-review.googlesource.com/c/1346670 has no effect on the bot. TBR=hans@chromium.org Bug: 899438 Change-Id: Ibec766f0ccf5554556c4c578625469d20504fff9 Reviewed-on: https://chromium-review.googlesource.com/c/1347211Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610178}
-
Nico Weber authored
Revert "Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234"" This reverts commit 1ffe990d. Reason for revert: roll-dep is still broken with this (https://bugs.chromium.org/p/chromium/issues/detail?id=906114#c19) Original change's description: > Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234" > > This is a reland of c5612605 > > Original change's description: > > Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234 > > > > Bug: 875037 > > Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3 > > Reviewed-on: https://chromium-review.googlesource.com/c/1339339 > > Reviewed-by: Hans Wennborg <hans@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608783} > > TBR=hans > > Bug: 875037 > Change-Id: Iac24d9ec462cd4d5720d78a52b7f867be3ab2ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/1344198 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609974} TBR=thakis@chromium.org,hans@chromium.org,martiniss@chromium.org,ehmaldonado@chromium.org Change-Id: I1b2327216797da231e11427a29edece425cd35bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875037 Reviewed-on: https://chromium-review.googlesource.com/c/1347333Reviewed-by:
-
Yuchen Liu authored
Record whether the license is released or not in persistent storage. Add a new field "key_type" to persistent storage for each session. If the license is installed to the device successfully, we update the field with KEY_TYPE_OFFLINE. If the license is released, we should update the key type to KEY_TYPE_RELEASE to reflect this change. In case the JS doesn't provide any response from server and calls "load" again, we can check the key type to avoid restore released keys, which may lead to an exception. Bug: 883895 Test: link in the bug Change-Id: I4672bd0d640b2fd9faa8c6feae45894bd1aee062 Reviewed-on: https://chromium-review.googlesource.com/c/1327171 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#610176}
-
Mohamed Amir Yosef authored
This CL adds the ability to change a subscription from lazy to unlazy. Bug: 882887 Change-Id: I0dc68442feb2ac460b82896ee424c806f6613041 Reviewed-on: https://chromium-review.googlesource.com/c/1296603 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Ned Nguyen authored
This updates wpt_expectations_updater to merge specifiers of same platform type to a simpler specifier when possible, but still keep separate expectation lines for different specifiers. This is needed for later CLs which will update Layout test expectation formats to no longer have mutual exclusive specifiers on the same expectation line (CL https://chromium-review.googlesource.com/c/chromium/src/+/1336439) Bug: 807751 Change-Id: Icd47c6d5d3f35a789ed266ee20fbb60dca382ac3 Reviewed-on: https://chromium-review.googlesource.com/c/1336912 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#610174}
-
lgcheng authored
1. Fix text size overflow issue for OOBE opt-in session. 2. Fix learn more text style inconstancy. TBR=xiyuan@chromium.org Bug: 907021 Test: Manual Change-Id: I6bd7ea9036a9bb89a139e02a2c1c15b33d3a1f60 Reviewed-on: https://chromium-review.googlesource.com/c/1345429 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
-
Jan Krcal authored
This CL introduces a per-data-type metric for reporting configuration duration for in-memory (ephemeral) data-types. This is important for monitoring health of the end-to-end product. Bug: 894028 Change-Id: I3ee3f9f11d31b1eb49e5722eb12391a2dd05bb36 Reviewed-on: https://chromium-review.googlesource.com/c/1343085 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610172}
-
Denis Kuznetsov authored
This flow is using attestation-based flow, but provides extra EnrollmentToken along with Register request. TBR: alemate@chromium.org Bug: 854101 Change-Id: I9a0710dcffc7a2f68fe43097a9e0d321769ddf35 Reviewed-on: https://chromium-review.googlesource.com/c/1327211 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610171}
-
Esmael El-Moslimany authored
When a div has its cursor style set to pointer, it is highlighted when clicked. This can be replicated on desktop using the dev tools device toolbar. When expand button does not have a label, the expand button is highlighted. The actionable attribute is used set the cursor style to pointer. The label div has has 0 dimensions when no label is slotted. Moving the actionable attribute down to the label div works for both when a label is present and missing. Bug: 907057 Change-Id: I23a0950b789c842739997554a3232c1805b3089e Reviewed-on: https://chromium-review.googlesource.com/c/1344819Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610170}
-
Becca Hughes authored
Add support for seeking to MediaController and the underlying media session. Consolidates the SeekForward/SeekBackward methods into a single Seek method. BUG=893296 Change-Id: I6e76406e2ec3d8afe3a31ae8acfdaf1dcbf667d7 Reviewed-on: https://chromium-review.googlesource.com/c/1306297Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610169}
-
Brad Hall authored
Bug: 878527 Change-Id: I2e527d39337232a657c34aa51c021d82b5f8a02d Reviewed-on: https://chromium-review.googlesource.com/c/1347054Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brad Hall <bradhall@google.com> Cr-Commit-Position: refs/heads/master@{#610168}
-
Aiden Benner authored
Can't use @JniStaticNatives in comments because it's not a valid javadoc tag. Use {@link JniStaticNatives} instead. Also renames instances of JNINatives -> JniStaticNatives in comments. Bug: 898261 Change-Id: I62d0dda735559af92473052f4856466308cd14a4 Reviewed-on: https://chromium-review.googlesource.com/c/1345231 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610167}
-
Allen Bauer authored
Removed IDS_CRITICAL_NOTIFICATION_RESTART; use IDS_CANCEL instead. Reworded IDS_CRITICAL_NOTIFICATION_TEXT content per referenced bug. TBR=cpu@chromium.org Bug: 763227 Change-Id: Ie8bf0157da2a62f0e1d32807b9b5ea022d02bd49 Reviewed-on: https://chromium-review.googlesource.com/c/938186Reviewed-by:
-
Kelvin Jiang authored
Add a loading state to activity log so we clear the activity log when we switch to a new extension. This ensures that the user does not see any previous data when new activity log data is being loaded. It also gives users a bit more feedback on progress loading the activity log. Bug: 832354 Change-Id: I30d5756fc375979d0a6f183af1e2e1bf25fe1073 Reviewed-on: https://chromium-review.googlesource.com/c/1345409 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610165}
-
Scott Violet authored
Ash related services, such as shortcut-viewer, create various objects that read command line flags (such as ui::Compositor). This makes such services copy the command line flags from chrome. Long term we shold move to a whitelist, but shorterm not copying all flags is causing display problems for some devices. BUG=906954,905569 TEST=none Change-Id: I408798f0c0a6145b84a926f464a6d76b3a116bb9 Reviewed-on: https://chromium-review.googlesource.com/c/1346690Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#610164}
-
Christopher Grant authored
When bundles start using bundle-specific native libraries, the unwind asset name will need to change accordingly. This is easier to do if the asset name is specified alongside the native library, which currently isn't always the case. Monochrome specifies its shared library in the public repo, but names the unwind asset in the internal repo. That means there'll be a build break if the library changes names. Note that non-Monochrome doesn't have this problem, because its public and internal configurations both specify the library and asset names together. These templates also don't have the luxury of specifying such properties in a root template, because they're reused by test APKs. We can clean this up with the following sequence: 1. Add the "monochrome" unwind asset specifier in the public repo. This will duplicate the value currently set in the internal repo. 2. Remove the internal repo variable assignment. 3. Land the bundle-specific libraries with their new names. BUG=874584 Change-Id: I7f4db40c0496a7f17e766afb1ba7e2b290054551 Reviewed-on: https://chromium-review.googlesource.com/c/1346809Reviewed-by:
-
liberato@chromium.org authored
Also adds a typemap for TrainingExample. Bug: 897463 Change-Id: I66d47d01e56e0a8f250783225662f258646e4cfa Reviewed-on: https://chromium-review.googlesource.com/c/1338223 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#610162}
-
Benoît Lizé authored
We don't need the feature anymore, especially since this will be available before native is loaded. In this case the feature flag would be at best misleading (because its setting would not be respected), and at worst cause crashes (calling a native method before native is loaded). Bug: 901835 Change-Id: I5e07931674ac1344e3ff3eff805c6b9d15e159d0 Reviewed-on: https://chromium-review.googlesource.com/c/1341833Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610161}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0e4dfcbcf4fd..8da7b350cf93 git log 0e4dfcbcf4fd..8da7b350cf93 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 alessiob@webrtc.org AGC2 adaptive digital false by default 2018-11-21 jonasolsson@webrtc.org Add ios bindings for PeerConnectionState. 2018-11-21 srte@webrtc.org Don't restart streams in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@8da7b350cf93 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib4c1f6d347b02c39cf6ddfef6395c2b570bfab89 Reviewed-on: https://chromium-review.googlesource.com/c/1346929Reviewed-by:
-
Etienne Pierre-Doray authored
Turn may_block_threshold and blocked_workers_poll_period into finch parameters under the experiment kMayBlockAdjustTasksTiming. Bug: 874080 Change-Id: I0104b68a96b08e9bf318258e75869555ab39e54b Reviewed-on: https://chromium-review.googlesource.com/c/1337276Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#610159}
-
Erik Luo authored
Bug: 700519 Change-Id: I85553324c653f7397ed538581dc62ac5260188fe Reviewed-on: https://chromium-review.googlesource.com/c/1329900 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
Peter Kasting authored
These pass on Windows. Bug: 320050, 327287, 406574, 427184, 624513, 701241, 865527 Change-Id: I51db36ebd63ca17b60eff0bf999ed3aae9ddd958 Reviewed-on: https://chromium-review.googlesource.com/c/1338955 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 907402, 902685 Change-Id: Ifa530668be9f322a2ae5d92692298c20f98da828 Reviewed-on: https://chromium-review.googlesource.com/c/1347089Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#610156}
-
Jun Cai authored
https://chromium-review.googlesource.com/c/chromium/src/+/1318750 The above CL changed the layout test expected file for the following two tests: http/tests/inspector-protocol/network/raw-headers-for-protected-document.js http/tests/inspector-protocol/network/security-info-on-response.js and these two tests fail in the Mojo Linux and Mojo Windows trybots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux?numbuilds=200 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Windows?numbuilds=200 This CL adds an expectation of failure for these two tests to: //third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService Bug: 898306 Change-Id: I63fb64fe5531c55dbcb06e9642aee22411ca5342 Reviewed-on: https://chromium-review.googlesource.com/c/1345432 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#610155}
-
Avi Drissman authored
Their last listeners were removed in r593728 and their last broadcasters were removed in r598355. BUG=411569 Change-Id: I1471d4984a2e0439d29daf538972b317940af224 Reviewed-on: https://chromium-review.googlesource.com/c/1346835Reviewed-by:
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: p*/ - s*/ Most of this patch is mechanical rebaseline, except that some LayoutNG-specific baselines become redundant and are removed. For some svg tests, we see new text lines in their text dumps. This is because legacy TextIterator doesn't enter <svg> elements, while innerText does so and dumps text from <foreignObject>. Bug: 887148 Change-Id: Ieef2419ab4deeeb64fe47cc0af49c30c6ca6887a Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1335844Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#610153}
-
Mikel Astiz authored
Historically, sync integration tests were incompatible with testing an actual browser restarts, leading to (best case) weird workarounds or (more often) lack of test coverage for very basic functionality (e.g. loading of persisted data). Browser tests do support a mechanism for this, which involves prefixing test names with PRE_, designed to reuse the very same profile path in multiple tests and hence carry over state. The only reason why this didn't work for sync integration tests is that we created random directories on every test run: instead, this patch makes the profile path deterministic. In this patch, a couple of tests are migrated to the new scheme, as a proof-of-concept. Bug: 856696 Change-Id: I6bf33bcb78d834984ff5230f7119cb79eb8bab55 Reviewed-on: https://chromium-review.googlesource.com/c/1341996 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fd17a12ec7ac..d69ae20edf94 git log fd17a12ec7ac..d69ae20edf94 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 perezju@chromium.org [soundwave] Add timeseries2 API Created with: gclient setdep -r src/third_party/catapult@d69ae20edf94 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900218 TBR=sullivan@chromium.org Change-Id: I15708dc6e61810aa55530c6e1713f11350b2f545 Reviewed-on: https://chromium-review.googlesource.com/c/1347071Reviewed-by:
-
Alexandr Ilin authored
This CL updates the expiry from M72 to M73 for the following histograms: - CustomTabs.ResourcePrefetch.Duration.Failure - CustomTabs.ResourcePrefetch.Duration.Success - CustomTabs.ResourcePrefetch.FinalStatus The experiment these histograms were added for isn't complete yet. Bug: 899952 Change-Id: I9963e520c8ed966525b9e172a2acbe0e568da673 Reviewed-on: https://chromium-review.googlesource.com/c/1343006Reviewed-by:
-
