- 10 Nov, 2020 40 commits
-
-
Julie Jeongeun Kim authored
This CL removes blink::mojom::ResourceType from InspectHistograms() which is a helper method for CrossSiteDocumentBlockingTest as it's unused and blink::mojom::ResourceType is deprecated[1]. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I8679d716a3de44c2a8fe78a5ef5b330c073a488c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525383Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#825598}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/8jzvjjrzhQLK8JH Bug: 889763 Change-Id: I38bf77914dff548997b2a7876383dec7c85db4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522795Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825597}
-
Curt Clemens authored
Adds error divs and styling to the send confirmation page, error strings, and displays them when the corresponding transfer statuses are received for the following error types: - Rejected share - Timeout while waiting for accept - Unsupported file type Bug: 1123934 Change-Id: I7d07ab29814bb21ba06a10e20e072d2ee877d559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522004 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#825596}
-
Kenneth Russell authored
A recent change, still being tracked down, has made this test flaky on macOS and ChromeOS. Bug: 1146687 Change-Id: If22497aeefa8fa582124dce83c1e8fcf53bde479 No-Try: True Tbr: jdarpinian@chromium.org Tbr: schenney@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528295 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#825595}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=sky@chromium.org Change-Id: I1fad30d867891377a5575027c45eb18d466c5d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526923 Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#825594}
-
Mark Pearson authored
This reverts commit 202e93e8 and the ones that come after it. Reason for revert: immediately after this landed (not the build this landed), the one after it, the Windows deterministic builder started failing consistently during the compare_build_artifacts step. https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic Step with first failure: https://ci.chromium.org/p/chromium/builders/ci/Windows%20deterministic/17458 Failure: swiftshader\libEGL.dll : None swiftshader\libEGL.dll.pdb : None swiftshader\libGLESv2.dll : DIFFERENT (unexpected): 19159 out of 2435584 bytes are different (0.79%) ... swiftshader\libGLESv2.dll.pdb : DIFFERENT (unexpected): 1227 out of 17125376 bytes are different (0.01%) and in the summary section: Equals: 4495 Expected diffs: 2 Unexpected diffs: 2 Unexpected files with diffs: swiftshader\libGLESv2.dll swiftshader\libGLESv2.dll.pdb Original change's description: > Roll Skia from ee0ce9858cbc to cffe7e631c4e (3 revisions) > > https://skia.googlesource.com/skia.git/+log/ee0ce9858cbc..cffe7e631c4e > > 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a4f272b3 to 083976a7 (536 revisions) > 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions) > 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3dfaeeb00271 to d4439824c554 (28 revisions) > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/skia-autoroll > Please CC jlavrova@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Cq-Do-Not-Cancel-Tryjobs: true > Bug: None > Tbr: jlavrova@google.com > Test: Test: Test: Capture Clash of ClansTest: Test: angle_end2end_tests.exeTest: Test: angle_perftests --gtest_filter="*clash_of_clans*" > Change-Id: I9fa84e51de5c3fd8f7464fef222631d3de74dc48 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2524758 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#825267} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,jlavrova@google.com Change-Id: Idb300b9c17c2405a679c46b5555836a460b3357f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527777Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#825593}
-
Sergey Ulanov authored
Previously FuchsiaVideoDecoder was setting min_buffer_count_for_camping to reserve output buffers. Updated it to use min_buffer_count_for_shared_slack instead. Also removed dependency on StreamBufferConstraints.packet_count_for_client_max, since it's being deprecated. Bug: fuchsia:61424, fuchsia:55146 Change-Id: Ice65f44e4f53117a50ceb3c0bb0f82e9326c9957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518720 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825592}
-
Nancy Wang authored
The 'FullRestore' flag is added in ash considering the window manamement might use it as well, and if it is added in the chrome/browser directory then the window manamement in ash can't include the file in the chrome/browser directory. BUG=1146900 Change-Id: Ib61186739832048e52ce4c87dd9e40b996cddc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525461 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825591}
-
Sven Zheng authored
For some trunk builders, they set env var CHROMIUM_TEST_LAUNCHER_BOT_MODE. For unit test, we need to unset the var to test some scenario. https://source.chromium.org/chromium/chromium/src/+/master:ui/base/test/skia_gold_pixel_diff.cc;l=153;drc=07e4c76dd0f6b37146a1c35e4a96fae53aff7371 Bug: 1146399 Change-Id: Ifb71831060a4bd779ef48e83ca8d66741e5e57e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523555Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825590}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/8jZbxyJfqwvFAuq Bug: 889763 Change-Id: Ifeaf20f918c80ba7dbed68c25d4982b9b1a47410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521879Reviewed-by:
-
John Palmer authored
Change-Id: I1bedf8383e3cd46d5e37d8a5778e47a060521f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518526 Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#825588}
-
Joel Hockey authored
While implementing file drag and drop, I have discovered that net::FilePathToFileURL does not correctly handle paths which end with a space char. GURL does some modifications to the path in its constructor so we must percent-encode control chars before calling it to avoid corruption. Bug: 1144138 Change-Id: Ie8e601edbc42033e33389ff4bd48046d16571ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522735 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#825587}
-
Jesse Schettler authored
When a scanner only supports one source, the selected source is not being set. Fix the function that sets the selected source to account for this case. Bug: 1059779 Change-Id: I1ee927506bf4c2b0f6be412db39c7f6cdca670d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527774Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#825586}
-
Tom Anderson authored
The default GTK error handler exits the process, which we don't want. We used to reset the error handler at some point after GTK initialization, but this became lost after r815319. Also refactor the XlibLoader instance to be global so it doesn't have to be created multiple times for each connection. R=sky Bug: 1145929 Change-Id: I73a3f27551534c2262bd8994d33e30fc2a0a4e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527743 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/26e2a89598d6..32b14552d662 2020-11-09 wl@gnu.org * src/type42/t42parse.c (t42_parse_sfnts): More tracing messages. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC thestig@google.com,bungeman@google.com,drott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: thestig@google.com,bungeman@google.com,drott@google.com Change-Id: Ia093dde5916f38386b323910bb6f1288e79aa324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#825584}
-
Christopher Lam authored
This CL disabled the Python 3 version of the GRIT presubmit as it causes bots to hang when running test_suite_all.py. Bug: 1145395 Change-Id: I90426733f40496a97a029d79e83cb0a91945bb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518306 Auto-Submit: calamity <calamity@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#825583}
-
Alexander Bolodurin authored
It was dropped in https://crrev.com/c/2464518 which may result in all errors being reported as base::File::FILE_ERROR_NOT_FOUND. Bug: 1049966 Change-Id: I78e1ac5bf664c49ecebf130d23737f8dad3721a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505341 Commit-Queue: Alexander Bolodurin <alexbn@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#825582}
-
Liquan (Max) Gu authored
Before the CL, PaymentRequestUi takes waitForUpdatedDetails from CPRService by PaymentUiService.Delegate.waitForUpdatedDetails(). Using a delegate is not as simplified as a method parameter. After the CL, PaymentRequestUi takes the value by method parameters. Change-Id: Icb61a32c6df6d6f2b01d6f6669483cd4b2111b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527543 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#825581}
-
Sigurdur Asgeirsson authored
It's replaced by base::ScopedObservation for observing a single source, or base::ScopedMultiSourceObservation for observing multiple sources. Bug: 1145565 Change-Id: Iadc2e3efee7860e1b17b86b077d4c6a2566b6a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527541 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Yuke Liao authored
This CL cleans up checkout_presubmit_ash_chrome DEPS hook because all CI/CQ builders have been switched to build ash-chrome from ToT. Bug: 1129223 Change-Id: I9de1f832ae29d3fe7eea85d67cd822b8c999c767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518080 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#825579}
-
Christopher Cameron authored
This flag gates whether or not we specify kCGLPFAAllowOfflineRenderers, and whether or not we call CGLSetVirtualScreen to manually migrate our compositing/raster contexts on GPU switch. ARM DTKs only have the single integrated AGX GPU, and do not recognize external GPUs, so this is necessarily untested. Indications are that it would be a good idea to add this to our initial ARM shipping build. Note that this would enable the flag even on single-GPU systems, because we haven't been able to test multi-GPU detection code on multi-GPU ARM machines (and so this could end up being unused if that code failed to detect the multi-GPU configuration). Bug: 1131312 Change-Id: I38404a8fc380d9f7542f0aaf93f969893815fac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522431Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#825578}
-
zhiyuancai authored
This CL corrects the message card close button color in incognito mode under dark theme. Bug: 1145869 Change-Id: I4803b7d9c078b7c16f4e6b39aca7be99228e0f09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527342Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#825577}
-
Michael Lippautz authored
Avoid using blink::* types in WTF where easily possible. Bug: chromium:1056170 Change-Id: I78da26f10a3e1f0b049aff00f5ab064273fe9ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527422 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#825576}
-
Tomasz Wiszkowski authored
This change ensures that certain specialized suggestion types are not used to backfill the suggestions list when the AutcompleteController did not get the chance to complete collecting results. These suggestions are particularly important to be removed, because: 1. these are zero-prefix suggestions and should not be shown when the user is typing and 2. these suggestions are expensive to create, causing a noticeable slowdown of the user interface. Bug: 1145722 Change-Id: I6e5024cde7d2033f942af6e07db24b62d98e0bba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522631Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#825575}
-
Anupam Snigdha authored
Added helper functions that check whether a given node has list or list items tags. This is used in editing commands for list related operations. Bug: 942133 Change-Id: I950a0c8a5e0b87eeed091d68cebab921ddc55d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527961 Auto-Submit: Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825574}
-
Tom Anderson authored
This CL removes the link-time dependency for Xlib, at least for //ui/gfx/x. There are still some lingering components (eg. Angle) that link against Xlib, which I'm going to investigate separately. R=sky Bug: 1066670 Change-Id: I699a29f28077d51c98f2c021944c10aca9ff5b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508226 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5de0b38dd133..823b1537f71e 2020-11-09 kjlubick@google.com [canvaskit] Add config key and manual mode to unit test harness. 2020-11-09 mtklein@google.com align SkAlignedSTStorage<N,T> to T 2020-11-09 jvanverth@google.com Update code-signing script to have better error messages. 2020-11-09 mtklein@google.com re-enable tests on GCC (and Clang o_O) 2020-11-09 johnstiles@google.com Add unit test for fuzzer-detected error with in vars. 2020-11-09 mtklein@google.com init SkSTArray storage before passing to SkTArray If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Change-Id: I643834add167c7c09c57b6e7d1e8a6237e1253e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527786Reviewed-by:
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=boliu@chromium.org Change-Id: I788f679615f4890fc58eb0411f6e8209daa46d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525766 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825571}
-
Kevin McNee authored
Several of the functions here are never called. Several others are only called from WebView::ApplyWebPreferences which is within blink so it can simply call the RuntimeEnabledFeatures functions directly. We also correct links in related documentation. Bug: None Change-Id: I2317f0c5ce328db14cb1e1e2c2ccf3d45bb13c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522002Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#825570}
-
Sajjad Mirza authored
This assignment was overridden immediately afterward, and is duplicated later, so it's safe to delete here. Change-Id: I5b5f607de57909f097d6eb5df629cd954f619a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523523 Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825569}
-
Chan Li authored
This reverts commit 11931d6d. Reason for revert: ResultDB bq_export is back to normal Original change's description: > Temporarily disable test results export to GPU-specific bq tables > > TBR=nodir,bsheedy,vadimsh,gbeaty > > Bug: 1145735 > Change-Id: Ia6793aa3c3198ab0b425ec9048c15490f353c32a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519879 > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824189} TBR=vadimsh@chromium.org,nodir@chromium.org,robertocn@chromium.org,bsheedy@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145735 Change-Id: I841fbb611971416fb434e0e96aec4e378a0a1b52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527735Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825568}
-
Erik Chen authored
There is no system tray on ChromeOS so it does not make sense to create status icons. Bug: 1128963 Change-Id: I1a14371bd5a9d8c5e70ea72179308681917a1fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528126 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Fredrik Söderqvist authored
Since SVGImage::PopulatePaintRecordForCurrentFrameForContainer() is downstream of both of the PaintImageForCurrentFrame() implementations, just let it set the completion state and don't expose this state publicly on SVGImage. Change-Id: Icb3a4a1aa263a04098cb6358f5d7bbb9923e37a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526427 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Chan Li authored
This reverts commit 5083892c. Reason for revert: ResultDB bq_export is back to normal Original change's description: > Temporarily disable test results export to GPU-try bq tables > > TBR=nodir,bsheedy,vadimsh,gbeaty > > Bug: 1145735 > Change-Id: Id7921fbacb0fedfd3500fd86953173fa63eb80b5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518699 > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824198} TBR=vadimsh@chromium.org,nodir@chromium.org,robertocn@chromium.org,bsheedy@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145735 Change-Id: Ib023d524b4673ed3eecb8ca8b38ed450f18f031b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528570Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#825565}
-
Clark DuVall authored
This change implements multi-level splits by first merging all the second level DFMs into the parent module, then splitting them out using DexSplitter. This is simpler than trying to use TraceReferences, and seems to work better for now (minus some workarounds needed for DexSplitter problems, see crbug.com/1145287 for more details). I want to try enabling this in canary to see if we have any issues. This is behind another gn flag so it can be easily turned off if necessary. We currently don't support using @CalledByNative methods in isolated splits since it will require some work on the JNI side, so the vr module is left merged in the chrome module. This change also moves all the R.java classes into the base module to match the resources, these are the changes in write_build_config.py. Bug: 1145287 Change-Id: I4b530b0ee470c72712f203df55fba0e2b67718a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518184Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#825564}
-
Bill Budge authored
- Removes Flash plugin metadata, to help plugin tests pass. Bug: chromium:977738 Change-Id: I6e131c9afe92793c3f449d7702088ab8198bdbe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523556Reviewed-by:
-
Michael Hansen authored
This disables the contact visibility card radio buttons until contacts are successfully downloaded. Screenshot: https://screenshot.googleplex.com/C8KWKrp7AivjbQx.png Bug: b:168841167 Change-Id: I62f44111bb5f1a55c035576e0d5cfc14869ab2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523443Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5226a88fe0de..59992a0fea40 2020-11-09 jalyn@microsoft.com Settings: Fix keyboard navigation of shortcuts list If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:174309 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I62e49cbba67b936a1808ecdcfbe2b9ed710fa2d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527785Reviewed-by:
-
Xing Liu authored
Add accessibility strings for bookmark bottom sheet. Bug: 1133496 Change-Id: If5b4ef63e27fc0f0439cfd19b09e022adc85517a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523731Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825560}
-
Domenic Denicola authored
* Flips the pass condition for worker interaction. A module worker does not impact the import map of the outer page, since its constructor takes a URL, not a specifier that needs resolution. * Removes leftover built-in module support and @std references. * Removes .tentative filename suffixes. * Renames "common" to "data-driven". * Renames parsing.tentative.https.html to parsing-internal.https.html so that all internal tests to have -internal in the name. We should move them out of WPT (or convert them to not require internals), eventually, but for now making the difference clear is good. * Moves "core" tests up to the top level. * Removes references to future fetch-based import maps and Chromium implementation limitations. * Adds OWNERS and META.yml Bug: 1026809 Change-Id: I1807468a813ebee416cd8e05a272dbae6ea157bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491616Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#825559}
-
