- 10 May, 2018 40 commits
-
-
Theresa authored
BUG=833873 Change-Id: I3f00d9258e7b2167c0cadaa41fed2506409b9496 Reviewed-on: https://chromium-review.googlesource.com/1053794Reviewed-by:
Nicolas Zea <zea@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#557631}
-
mrefaat authored
It's more appropriate as the tabhelper handle urls not links. Bug: 841615 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7f852766712545574a1d07eeaa21e871f064a97a Reviewed-on: https://chromium-review.googlesource.com/1053359 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#557630}
-
Matt Menke authored
Bug: 837776 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5adf6cbed89f755e7e25c3efdf326aab1c472d67 Reviewed-on: https://chromium-review.googlesource.com/1045365Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557629}
-
Abhishek Arya authored
- Add test_suite.txt here to make it easily configurable. - Move styles in static dir. R=mmoroz@chromium.org,liaoyuke@chromium.org Change-Id: I8284b6f0ea225e8d0e937686fbc3f6b369b5e2b7 Reviewed-on: https://chromium-review.googlesource.com/1054386Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557628}
-
Pavol Marko authored
Add support for the forced initial enrollment check in AutoEnrollmentClient. This check uses a different identifier set, 8 byte hashes and a different message for the state download. The differences are abstracted by using two virtual classes with different implementations for FRE/initial enrollment checks: DeviceIdentifierProvider specifies the identifier set and hashes, and StateDownloadMessageProcessor understands fills state download requests and parses state download responses. Bug: 839353 Test: unit_tests --gtest_filter=*AutoEnrollmentClientTest* Change-Id: I83d041f568d84c42b9b8cf00a1e44955f9d5abe3 Reviewed-on: https://chromium-review.googlesource.com/1049929 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#557627}
-
Matthew Jones authored
Overtriggering of the peek-to-half event would cause the scrim to disappear when the device was rotated. This patch checks that the sheet state is <= hidden (as opposed to just <) when blocking the event's trigger. As an added precaution, the listener that sets the scrim alpha has an added check for whether the sheet is open. Bug: 840265 Change-Id: Ic3e0731be3525959898159e0610b3c49b9a04fa4 Reviewed-on: https://chromium-review.googlesource.com/1054210Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#557626}
-
John Rummell authored
Now that AesDecryptor supports 'cbcs' decryption, update the Clear Key CDM to do the same. BUG=658026,835009 TEST=modified browser_test passes Change-Id: Ie138d4b638d5d6493cb89368171adae5660486da Reviewed-on: https://chromium-review.googlesource.com/1053172Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#557625}
-
David Benjamin authored
CertDatabase is just a giant singleton observer list at this point, except for the Mac code which internally registers some notifier. Since URLRequestContext no longer assumes the platform verifier at this point, the Right Way to do this would probably be for CertVerifier to have an observer and, separately, for there to be an external way to tell a URLRequestContext to drop all client certificate identities. But, to start with, trim a bunch of unnecessarily duplicated code. Change-Id: I11b15b10a0eb4da0f528581da1c57dad9ebbc30d Reviewed-on: https://chromium-review.googlesource.com/619929 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557624}
-
Michael Thiessen authored
Bug: 841850 Change-Id: I0249210c8fe387a3732715be2650ce9aea5af800 Reviewed-on: https://chromium-review.googlesource.com/1054211Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#557623}
-
Mark Pearson authored
This enables the flag by default on Android. Bug: 787940 Change-Id: I550d6d22d629c0bcb62dacefaf32b5d8b24ced57 Reviewed-on: https://chromium-review.googlesource.com/1054170Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557622}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib317cffef2c44e2fa29cca1f8a62664e4c90b7c8 Reviewed-on: https://chromium-review.googlesource.com/1054260Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557621}
-
Xi Han authored
This CL is a precursor CL for https://crrev.com/c/969098. It simply contains a file renaming to keep log history: 1. content_main_runner.cc rename to content_main_runner_impl.cc 2. browser_main_runner.cc rename to browser_main_runner_impl.cc It allows to introduce content_main_runner_impl.h and browser_main_runner_impl.h which contain new methods without changing their interface in /content/public. Bug: 740677 Change-Id: I4e42bb594d65888b4358ac843b13837be26a5b7e Reviewed-on: https://chromium-review.googlesource.com/1042456 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#557620}
-
Reza.Zakerinasab authored
This change adds color management to ImageBitmapRenderingContext. Bug: 782383, 785389, 796226 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I653bc2e5d3a32f5211bd09c80ee35b6f4df6ad92 Reviewed-on: https://chromium-review.googlesource.com/973801Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#557619}
-
Daniel Murphy authored
Bug: 840949 Change-Id: Ied53a2d1cccb0a0c474d8b9cfb76bad1a8d83987 Reviewed-on: https://chromium-review.googlesource.com/1050581 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#557618}
-
Changwan Ryu authored
This reverts commit e9c5bc10. Reason for revert: caused crbug.com/841489 Original change's description: > Don't show text selection popup menu if current selected text is cleared. > > If text selection clear action is just after selecting all text action in editable input box, > then the state of text selection in renderer is not correct, which causes the selection popup > menu will be incorrectly shown. > Fix this issue by checking selection state before popup text selection menu. > > Bug: 817712 > > Change-Id: I4dcda47d5f0fe5f20febc2e1def30574c6060724 > Reviewed-on: https://chromium-review.googlesource.com/940290 > Commit-Queue: Antoine Labour <piman@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Pedro Amaral <amaralp@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555099} TBR=boliu@chromium.org,haraken@chromium.org,changwan@chromium.org,piman@chromium.org,amaralp@chromium.org,zuojinglong@xiaomi.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 817712 Change-Id: I97f01cd58f23939066a2179a819d20534a60123f Reviewed-on: https://chromium-review.googlesource.com/1054112Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557617}
-
Dave Schuyler authored
This Cl removes the text_height parameter from the match cell ctor as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1048865 It further removes other unnecessary passing of text_height or font_list parameters. Bug: None Change-Id: Ifd6eaf9b113d09ff2e18b7e780ad50887e78e850 Reviewed-on: https://chromium-review.googlesource.com/1050869Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#557616}
-
Marijn Kruisselbrink authored
This is a reland of 6a1c56b9 Original change's description: > Get rid of FrameMsg_PostMessage_Params.is_data_raw_string. > > Instead use the helper method we already have to just convert a raw > string to a serialized string value encoded byte array on the browser > side. This gets rid of some special casing and possible confusion in > this codepath. > > Does requre moving string_message_codec to some non-android specific > location (even though this code is only really used on android), and for > that blink/common seemed like a sensible place. > > Bug: none > Change-Id: I4ebc70cb68a1c12ad57d3949a1ac606392f7c908 > Reviewed-on: https://chromium-review.googlesource.com/1053169 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557363} Tbr: kinuko@chromium.org Bug: none Change-Id: I75fafccb7c4c49c1729a3a6709e51874ba82da78 Reviewed-on: https://chromium-review.googlesource.com/1053068Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#557615}
-
Ian Kilpatrick authored
There should be no behaviour change in this patch. This introduces the "line layout opportunity concept" which has: - A line size. - A float line size. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib8667a7c0909116da8e89cb2e20d9df66a2c401d Reviewed-on: https://chromium-review.googlesource.com/1035617Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#557614}
-
John Chen authored
This is a reland of 3edba584 Original change's description: > [ChromeDriver] Use Browser.close to quit > > Currently, ChromeDriver closes desktop Chrome by simply killing the > top-level Chrome process. This isn't graceful, and causes problems > in some scenarios. This commit sends a Browser.close command to close > the browser gracefully. > > Bug: chromedriver:2311 > Change-Id: Idec9338b094f0aab89022b8453dd2a98268ad1e7 > Reviewed-on: https://chromium-review.googlesource.com/1037585 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556689} TBR=kereliuk@chromium.org Bug: chromedriver:2311 Change-Id: I302e064532fdadb1b6e40d53fbfe3cf72601a731 Reviewed-on: https://chromium-review.googlesource.com/1054117Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557613}
-
Bailey Berro authored
This change makes the D-Bus timeout for the CopyEntry method infinite since currently each CopyEntry call can take an undefined amount of time on the SmbProvider daemon side. BUG=chromium:757625 TEST=none Change-Id: I6da15c49a80062fa05f8c622e3ea3c402f69d8f2 Reviewed-on: https://chromium-review.googlesource.com/1054200Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#557612}
-
Sebastien Marchand authored
This is an initial implementation that currently requires that all tests run on a thread allowed to do IO operations. A follow-up CL will focus on moving all the blocking operations to a separate thread. BUG=773382 Change-Id: Iea5ee2ede75f4fff168f6546b515018f0fd2a0ca Reviewed-on: https://chromium-review.googlesource.com/1005444 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#557611}
-
Matt Menke authored
They aren't in histograms.xml, and that has been the case for multiple years, so they're presumably safe to remove. Bug: 643569 Change-Id: I262be8f7b4c97a6e85b1f58ddb54fe56dd67772b Reviewed-on: https://chromium-review.googlesource.com/1053872Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557610}
-
Sergey Ulanov authored
layout_test_proxy is no longer needed for layout tests because we can use SSH. Bug: 778467 Change-Id: I802ee687a9dab6448fc902a074553dbeb5bbafee Reviewed-on: https://chromium-review.googlesource.com/1053394 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#557609}
-
Michael Thiessen authored
This helps prevent us from getting into a state where we have a 2D popup window open but VR mode is on. Bug: 841814 Change-Id: I280954eb575cf489e10b9307d50e9a862b2b236c Reviewed-on: https://chromium-review.googlesource.com/1054209 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#557608}
-
Ian Kilpatrick authored
There should be no behaviour change. This is done so we can modify the LineSegment in LayoutNG to be in the correct coordinate system. Bug: 635619 Change-Id: I4be2b099fc0731e0927b8a548a960ff00d9ddf9c Reviewed-on: https://chromium-review.googlesource.com/1050487 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557607}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bc30f712. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17252 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: worker-dev@chromium.org: external/wpt/workers TBR=markdittmer No-Export: true Change-Id: I66a359aed4db305a829c8bf2fd1b63dda9e4009f Reviewed-on: https://chromium-review.googlesource.com/1053954 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557606}
-
Evan Stade authored
Bug: 839955 Change-Id: Ib8897bc667a0896f3f6cf607005738c6fbfc920d Reviewed-on: https://chromium-review.googlesource.com/1048975 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#557605}
-
Emircan Uysaler authored
CanvasCaptureHandler is owned by blink whereas VideoCapturerSource is owned by VideoTrack. Since they can be destructed at different times, we should check WeakPtr<CanvasCaptureHandler> before use. Bug: 840926 Change-Id: Ia3570bcce8954a406ce95b0aee4f00a377825d30 Reviewed-on: https://chromium-review.googlesource.com/1053125 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#557604}
-
dpapad authored
The element is no longer used. All usages have been migrated to cr-toggle. Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia02580497b901732defdbc7e75fc4eaedf2b0413 Reviewed-on: https://chromium-review.googlesource.com/1053416Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#557603}
-
Emily Hanley authored
Change-Id: I349768cec84b3545ca35f8836fdbd83fda6c2bc2 Reviewed-on: https://chromium-review.googlesource.com/1054193Reviewed-by:
Simon Hatch <simonhatch@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#557602}
-
Allen Bauer authored
Material Refresh - Now fades in/out the tab separator and the close button in conjunction with the glow hover effect. Bug: 822061 Change-Id: Ic4c339c54a61d7f00ff8eedc1ae20c6176440aec Reviewed-on: https://chromium-review.googlesource.com/1052382 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#557601}
-
https://pdfium.googlesource.com/pdfium.git/+log/35557c3ce83c..95061379c945 $ git log 35557c3ce..95061379c --date=short --no-merges --format='%ad %ae %s' 2018-05-10 rharrison Do not build BMP when codec is disabled Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I19cd1fa0a5bcc56e1eebc140005399d8585d155c Reviewed-on: https://chromium-review.googlesource.com/1054090 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557600}
-
Sergey Ulanov authored
This reverts commit 8b972f42. Reason for revert: Incompatible with the latest fidlgen Original change's description: > [Fuchsia] Update namespace in generated FIDL files. > > Currently fidlgen uses the namespace that's specified in the .fidl file. > As result the generated code may collide with other code in > chromium. This CL implements a temporary workaround for this problem: > generated code is updated to use a namespaces nested in fuchsia:: > namespace. The script won't be necessary after FIDL-160 is resolved. > > Bug: 831384 > Change-Id: I3648f89f44a8e0148b1cc6b58d6f3a8de82a684e > Reviewed-on: https://chromium-review.googlesource.com/1045257 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556882} TBR=dcheng@chromium.org,kmarshall@chromium.org,mmenke@chromium.org,sergeyu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831384 Change-Id: Icde5c76db4abd1730e525bbd4f44bb8553caa409 Reviewed-on: https://chromium-review.googlesource.com/1054111Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557599}
-
Daniel Murphy authored
This reverts commit f57e1c35. Reason for revert: There are ash and mash_ash failures, reverting because it's ash-related. See crbug.com/841889 Original change's description: > cros - Update appearance of resolution change notification. > > This removes the last raster asset in ash_resources.grd, so remove that > file and the associated build target. > > Bug: 840509,505953 > Change-Id: I43ec69b5b8b9fc34aa71a1b65f204447e73b133c > Reviewed-on: https://chromium-review.googlesource.com/1050523 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557292} TBR=jamescook@chromium.org,sky@chromium.org,estade@chromium.org Change-Id: I4b0ce3e1d01b5b8e390216b379f4158380f542b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 840509, 505953, 841889 Reviewed-on: https://chromium-review.googlesource.com/1054118Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#557598}
-
Guido Urdaneta authored
This ensures that the main thread as a CFRunLoop, which is required by audio APIs on Mac. Bug: 841845 Change-Id: I10be74d77c1585014a63896099eb2b4acb5b345b Reviewed-on: https://chromium-review.googlesource.com/1054227 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#557597}
-
Evan Stade authored
Bug: 841768 Change-Id: I7b2d23223f270c129a6c38510ba51cb0eca5f287 Reviewed-on: https://chromium-review.googlesource.com/1054212Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#557596}
-
sczs authored
- Makes some small changes in order to make BookmarkEditVC and BookmarkFolderEditorVC navigation toolbars appeareance more similar to the ElevatedToolbar they were using before. Screenshots: Old: https://drive.google.com/open?id=1uagROckekOJXPjwxu6HdhGfXUEoZtZ7v New: https://drive.google.com/open?id=1btpW_JxZ-Kad0U0fgPtGuYrD03FceXQq Bug: 839435 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifbfc7ca44dad96bad6d6fc55788ecb1c670580a3 Reviewed-on: https://chromium-review.googlesource.com/1053390 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#557595}
-
spqchan authored
Bug: 829298 Change-Id: I24c6fb3fde3ad30f00801e096cd034e16642ce35 Reviewed-on: https://chromium-review.googlesource.com/1048625Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557594}
-
Paul Miller authored
This is for testing purposes and will be removed after launching variations in WebView: https://crbug.com/841623. Skipping presubmit for LOG(INFO). BUG=678288 NOPRESUBMIT=true Change-Id: Ia100eb88a20b3155ef8d280e598644b3684990a0 Reviewed-on: https://chromium-review.googlesource.com/1053375Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557593}
-
Michael Thiessen authored
When exiting VR on chrome://crash (sad tab), the renderer doesn't send any control offset updates, and resetting the overrides to the control offsets for VR restores the hidden control values, so we need to tell the controls to show explicitly. Also fixes initialization when opening a new tab while in VR... Bug: 837807 Change-Id: I14df5479156dc6ac981f845529f8c13aadbd15ac Reviewed-on: https://chromium-review.googlesource.com/1052892Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#557592}
-