- 20 Apr, 2018 40 commits
-
-
Sylvain Defresne authored
There were at least three different CallbackCounter classes in the code base. Most of them counting the number of time a callback has been invoked (and used only for tests) and one invoking a OnceClosure after calls to DecrementCounter matched earlier calls to IncrementCounter. Since the class in base/ios/callback_counter.h had only a single use, inline the code into the callsite and remove the class that is confusing (the name does not really correspond to the behaviour of the class and neither to the other classes with the same name). Other implementations are in: - components/sync/test/callback_counter.h - net/cookies/cookie_store_test_helpers.h Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I822243085afde29e640c72fd3e9790240a965987 Reviewed-on: https://chromium-review.googlesource.com/1020235 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552257}
-
https://skia.googlesource.com/skia.git/+log/1804b3528c53..665c4b78eb59 $ git log 1804b3528..665c4b78e --date=short --no-merges --format='%ad %ae %s' 2018-04-20 angle-skia-autoroll Roll third_party/externals/angle2/ e24032a2c..b0f917fa6 (3 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: Iac832eeb29b9bf3b3d68fe69001d0fa2184ea4bf Reviewed-on: https://chromium-review.googlesource.com/1020722 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552256}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/55fae2ff6860..328ec4e1303a $ git log 55fae2ff6..328ec4e13 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 achuith cros_chrome_sdk: Don't retry if gsutil cat fails. Created with: roll-dep src/third_party/chromite BUG=chromium:832406 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2bf9a4c977f810bccdd92fb963031211d8b5c25c Reviewed-on: https://chromium-review.googlesource.com/1019921Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552255}
-
Ricky Liang authored
Some straightforward clean-up to replace the deprecated base::Bind() API with base::BindOnce(). BUG=chromium:832772 TEST=unit tests TEST=Make sure camera works on Soraka. Change-Id: Id19a0b4ca14d8fb794a2c0e24e61747060730b66 Reviewed-on: https://chromium-review.googlesource.com/1019263Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552254}
-
Kenneth Russell authored
We should add a better way to define mixins like these, but for the time being, add exceptions to trigger these jobs on physical hardware. Bug: 830659, 835072 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_asan_rel_ng;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Change-Id: I30c377d28e6c2ea1202d0d64f86de9665c0266ad Reviewed-on: https://chromium-review.googlesource.com/1013127 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#552253}
-
Brandon Jones authored
Bug: 833196 Change-Id: Idd47df99dc9e98b627ba1e6aead0b9a7c5e6f631 Reviewed-on: https://chromium-review.googlesource.com/1014626Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552252}
-
Zhenyao Mo authored
BUG=828462 TEST=manual in about:gpu R=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1a23827e504b2378762a59c46e23e730e9b2284e Reviewed-on: https://chromium-review.googlesource.com/1017300Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#552251}
-
Devlin Cronin authored
The ExtensionFunction::GetAssociatedWebContents() method is unpredictable and can return surprising values in certain circumstances. It is deprecated and should be removed to ensure that callers are using the WebContents they expect. Update the USB API to use GetSenderWebContents() instead. Bug: 461394 Change-Id: I284a4efc98d878fff0ad48714177467004510d6b Reviewed-on: https://chromium-review.googlesource.com/1018532Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552250}
-
Fumitoshi Ukai authored
Chromium is no longer built with msvc, so there's no need to keep the CrWinClexeGomaGCEStaging bot. Bug: 834662 Change-Id: Idfec2209033b7d7bab8cfaa572a5e8088b9c9e52 Reviewed-on: https://chromium-review.googlesource.com/1018687Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#552249}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I22c494c83012b3157319eb2d0b0aaf4f62917b56 Reviewed-on: https://chromium-review.googlesource.com/1020321Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#552248}
-
Sylvain Defresne authored
As the callback will only be invoked once, convert it from a base::Callback to a base::OnceCallback. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I956e33b9877b0971ebbe92bbf1dbdf001145056b Reviewed-on: https://chromium-review.googlesource.com/1020520Reviewed-by:
-
Wei Guan authored
BUG=chromium:833595 Change-Id: Ifed53adb6baef9e34c50cf09b71703d018f1617b Reviewed-on: https://chromium-review.googlesource.com/1015506Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wei Guan <weigua@chromium.org> Cr-Commit-Position: refs/heads/master@{#552246}
-
Peter Kasting authored
This is recommended team practice now, and will help with a unittest that wants to call InfoBarView::Layout(). No functional changes. BUG=834728 TEST=none TBR=estade Change-Id: Id8745264363e62e8becb5f9b8aa6071d6e6234bd Reviewed-on: https://chromium-review.googlesource.com/1019364Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#552245}
-
Wenzhao Zang authored
We need this because: 1) Mustash requires all //ash dependency except //ash/public to be removed from //chrome. 2) Currently saving and retrieving online wallpapers are handled separately in //chrome and //ash, and it has duplicate logic in the path calculation. 3) Currently wallpaper_private_api.cc is responsible for saving online wallpapers, so it defeats the goal of making wallpaper paths internal to //ash. Also fixed a bug: on Linux build, online wallpaper is lost at login screen. Bug: 827062 Change-Id: I0d3ea5daf537db6e189c7a8b2ede469521e9dcbf Reviewed-on: https://chromium-review.googlesource.com/1013211Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552244}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5c62ed59d2a3..067ef5d8941a $ git log 5c62ed59d..067ef5d89 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 ehmaldonado Add support for checking that OWNERS files are correctly formatted. 2018-04-19 tandrii [auth] cleanup old code.google.com oauth scope usage. 2018-04-19 tandrii [auth] cache LUCI_CONTEXT local_auth parameters. 2018-04-19 tandrii [gerrit_util] learn about and use LUCI_CONTEXT when available. Created with: roll-dep src/third_party/depot_tools BUG=chromium:789773,chromium:834536,chromium:834536 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I8680161b25310e23648fe1034c1afa0268116326 Reviewed-on: https://chromium-review.googlesource.com/1019731 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552243}
-
Xiaocheng Hu authored
Originally, cold mode checker was designed for full document checking, which must be requested on document startup. With crrev.com/c/1014472, cold mode checker only checks the currently focused element, so there is no need to request it on startup. Hence, this patch removes it. Note: this patch also stops the memory leak seen in crbug.com/834199. The root cause of the leak is still unclear. Bug: 716642 Change-Id: Ide93fa3ce8050b77b08079145c8cd81c2571974f Reviewed-on: https://chromium-review.googlesource.com/1020156Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552242}
-
Gabriel Charette authored
Follow-up to https://crbug.com/827615#c17 R=fdoray@chromium.org, wez@chromium.org Bug: 827615 Change-Id: I873b3eadd6be973b4e0d7b962d7cd720a663198e Reviewed-on: https://chromium-review.googlesource.com/1020372 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#552241}
-
https://skia.googlesource.com/skia.git/+log/b3a6959408e1..1804b3528c53 $ git log b3a695940..1804b3528 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 csmartdalton ccpr: Don't preempt the convex path renderer 2018-04-19 benjaminwagner Add more angle_gl_* configs for NVIDIA. 2018-04-19 jvanverth Remove ambient clamp hack for analytic shadows. 2018-04-19 brianosman Remove duplicate predefined configs Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I3d877b212203de9c14d4c98067dc90ee5c7abdff Reviewed-on: https://chromium-review.googlesource.com/1020442Reviewed-by:
-
Oksana Zhuravlova authored
Bug: 799482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I2ff7cf5de96d7a9cb479202edc362a7f06248e8e Reviewed-on: https://chromium-review.googlesource.com/1017865Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#552239}
-
https://chromium.googlesource.com/angle/angle.git/+log/025aafdfc4af..b0f917fa6347 $ git log 025aafdfc..b0f917fa6 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 geofflang Fix being unable to request some extensions implemented in the GL layer. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I5c1cf05aedc7b94e9c7b580c2fb8fe66f019c44c Reviewed-on: https://chromium-review.googlesource.com/1020453Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552238}
-
Lei Zhang authored
This follows a similar strategy as the CLs for https://crbug.com/753216. BUG=764260 Change-Id: I52523799a8e1f749cd2f7acefe5a287c6144cb57 Reviewed-on: https://chromium-review.googlesource.com/1015891 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#552237}
-
Yuki Awano authored
- Remove observer in OnConnectionClosed instead of Shutdown. Shutdown is called in different life cycle. OnConnectionReady can be called more than once for a single Shutdown call. It can cause helper bridge to register observer more than once. Bug: 833731 Test: None Change-Id: I7057f8d11364687f0d7f9fb5d3b5d213a18e18db Reviewed-on: https://chromium-review.googlesource.com/1018781Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#552236}
-
Edward Lesmes authored
ANGLE and WebRTC now use Skia's autoroller, so these scripts shouldn't be needed anymore. R=geofflang@chromium.org, phoglund@chromium.org Bug: 585360 Change-Id: Ic478e3775593baa433dc91688a04d9b6dca5acf5 Reviewed-on: https://chromium-review.googlesource.com/1016139Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
-
Kenneth Russell authored
This was lost in the recent DrawingBuffer refactoring adding clearBuffer support, leading to performance losses on lower-end GPUs. Bug: 834500 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic81ac215183419145e7e9a67552e760cd3854764 Reviewed-on: https://chromium-review.googlesource.com/1020527Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552234}
-
Matt Falkenhagen authored
The entire directory is all non-upstreamable tests now, so we don't need "chromium" anymore. We had some file names prefixed with "chromium." and subdirectories called "chromium". This was making some relative paths complicated and and was confusing when some files had the prefix and some didn't. Bug: 688116 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I873cee47baa0338f57af8c6d4b90caac7fdd3c04 Reviewed-on: https://chromium-review.googlesource.com/1020480 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#552233}
-
danakj authored
For unit tests, replace it with an ImportResource() of some arbitrary TransferableResource. For pixel tests, use viz::bitmap_allocation to allocate a bitmap, and SkBitmap::readPixels to populate the SharedMemory for the resource. Then register the SharedBitmapId with the display compositor via the SharedBitmapManager directly, and ImportResource() to make a ResourceId pointing to the SharedBitmapId for use in DrawQuads. R=piman@chromium.org Bug: 730660, 738190 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I143996712ee6477634d728a767f9095b5be8d74c Reviewed-on: https://chromium-review.googlesource.com/1020226 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 706325 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7166b4d3c2277d201bb29c305136cf4ed98a95d2 Reviewed-on: https://chromium-review.googlesource.com/1020522Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#552231}
-
Noel Gordon authored
Bug: 833834 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I12a7179f546bc3e7a6c3c12ae436e87a56adc870 Reviewed-on: https://chromium-review.googlesource.com/1019261 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#552230}
-
Kurt Horimoto authored
This can be useful for localized translations of these labels, which may need to span multiple lines. Bug: 805100 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4a4a8b98cb8b7f56f5b7b19dbe8478bf50f4fbf2 Reviewed-on: https://chromium-review.googlesource.com/1018168 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552229}
-
Dmitry Gozman authored
Original patch exposed an issue in layout test controller, which was fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1015221. > Onion-soupify blink leak detector > > - Expose LeakDetector interface in render process, remove unneeded plumbing. > - Switch from IPCs to Mojo in layout test runner. > - Move implementation to controller. > - Migrate inspector usage to browser. > - Merged two methods of LeakDetector into a single one. > - Fixed leaks in existing tests. > > Needs a followup to not register fetchers in leak detector, > but instead have a collection in ResourceFetcher. > > Reviewed-on: https://chromium-review.googlesource.com/999170 > Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> > Reviewed-by: Yuzu Saijo <yuzus@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551012} TBR=kolos,yuzus,dcheng,haraken NOPRESUBMIT=true Bug: 833609 Change-Id: I6723ffc4aa6a88e6d6d88cc3850410dcd42aa51c Reviewed-on: https://chromium-review.googlesource.com/1016021 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552228}
-
Joel Hockey authored
Console shows which test is running, and test status PASS/FAIL and time that each test takes, as well as overall status and time for all tests. This information makes it easier to determine which test fails when there are multiple tests running and one of them times out. Currently webui_resource_test.js is used for FilesApp unit tests and in the FileManagerUITest browser test. Bug: 813477 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie42d5dcdf678371e1a3692f1764f2d18533da3f2 Reviewed-on: https://chromium-review.googlesource.com/1007114Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#552227}
-
Dominick Ng authored
This will be relanded to target M68. BUG=782120,811578 Change-Id: I2f67f27e8aacc76c32efb3e3773e2482033b19fb Reviewed-on: https://chromium-review.googlesource.com/1020560Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#552226}
-
Sunny Sachanandani authored
Video swap chain size is zero when scaled overlays are supported, and contents rect is zero. The earlier fix missed this case. This CL moves the calculation of swap chain size to DCLayerTree so that we can skip swap chain creation and other steps which depend on swap chain size. A follow-up CL will remove the CHECKs and replace them with UMA where it makes sense. Bug: 792806 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3de017da44913c9522a0b98c91324efab8148ee6 Reviewed-on: https://chromium-review.googlesource.com/1018499Reviewed-by:
-
Joe Downing authored
This change integrates the FullscreenControlPopup with the KeyboardLock feature (via the ExclusiveAccessManager). The KeyboardLockController continues to own which WebContents is granted keyboard lock and the initial display of the exclusive access message, but now the FullscreenControlHost is responsible for showing the UI popup. I decided to go this route as the logic for mouse/touch exists in the FullscreenControlHost (via the events it is fed) and the alternative involved punching a hole through several interfaces to expose the popup to the KeyboardLockController. BUG=680809 Change-Id: I152003587cc872b9e2f52883f0698fa26c5dea12 Reviewed-on: https://chromium-review.googlesource.com/1014633Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#552224}
-
enne authored
This reverts commit b3fdac1b. Reason for revert: no longer needed Causes breakages in https://chromium-review.googlesource.com/c/chromium/src/+/1018402 Will roll Skia patch first and then reland this. Original change's description: > skia: Add workaround header define > > Chromium-side changes for: > https://skia-review.googlesource.com/c/skia/+/120608 > > Bug: 829614 > Change-Id: I59dc05ae1d66622ce3c771311ec3e1b64023b66f > Reviewed-on: https://chromium-review.googlesource.com/1008924 > Reviewed-by: Brian Salomon <bsalomon@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551370} TBR=bsalomon@chromium.org,enne@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 829614 Change-Id: I7512e16d2023c51407c2d3bc8b2969dc067d5f91 Reviewed-on: https://chromium-review.googlesource.com/1019730Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552223}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: I06b60671dfc32f88de8a7503b4add18ba54cb0e4 Reviewed-on: https://chromium-review.googlesource.com/1020379Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#552222}
-
Gabriel Charette authored
And use the new argument-less constructor to avoid being redundant. R=altimin@chromium.org TBR=thestig@chromium.org Bug: 781352, 825327 Change-Id: I57a0bd50934f402ec24409fa4b315bafec83bd7f Reviewed-on: https://chromium-review.googlesource.com/1020288 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#552221}
-
https://pdfium.googlesource.com/pdfium.git/+log/9914d4dc1e7a..901f34332823 $ git log 9914d4dc1..901f34332 --date=short --no-merges --format='%ad %ae %s' 2018-04-19 hnakashima Caret moves after clicked char if closer to its right rect boundary. 2018-04-19 hnakashima Fix duplicated text in each line in XFA widgets. 2018-04-19 hnakashima Fix caret moving to start of edit on click after the text. 2018-04-19 thestig Add public APIs for undo / redo in forms. 2018-04-19 thestig Change SHADING_STEPS from a #define to a constant. 2018-04-19 hnakashima Fix caret not moving to click target in XFA edit. Created with: roll-dep src/third_party/pdfium BUG=chromium:832293,chromium:832909,chromium:832293,chromium:764260,chromium:832293 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0c49fb5b7d6ee39f132bf4c8e2daf7a9740e5c39 Reviewed-on: https://chromium-review.googlesource.com/1019973 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552220}
-
Christopher Grant authored
BUG=833439 R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I483b430931a7719d8db91ac1b45b080de9d4480b Reviewed-on: https://chromium-review.googlesource.com/1020151Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#552219}
-
Joel Einbinder authored
This patch merges some variables together which were seperate inf JavaScriptSourceFrame, takes @unrestricted off of the plugins, and renames JavaScriptSourceFrame to DebuggerPlugin where appropriate in tests. Bug: 778043 Change-Id: If1d86f46afff1bf0af328090a15a5a1bc92726d7 Reviewed-on: https://chromium-review.googlesource.com/1015650Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#552218}
-
