- 07 Apr, 2020 40 commits
-
-
Armando Miraglia authored
Fixed: 1055409, 1055408 Change-Id: I40eb1d7c0448e63da134f0cf4a09c841388b34da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118051Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#757025}
-
Dominik Röttsches authored
Add WPT test for ensuring shaping of system font Tibetan when common ligatures are disabled. https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/014e038b2c2f..0d5695983e8b $ git log 014e038b2..0d5695983 --date=short --no-merges --format='%ad %ae %s' 2020-04-05 qxliu [subset] fixes dangling object_t issue in FeatureVariationRecord Fixes https://crbug.com/oss-fuzz/21560 revert () does not clean up useless object_t. Adjust the order of subsetting substitutions and conditions to avoid dangling object_t. 2020-04-05 ebrahim [subset] Fail ClassDefFormat1 serialization if no space available 2020-04-02 qxliu fix issues in ClassDefFormat1 serialize: glyph ids in Iterator may be non-consecutive, so the number in classValue might be larger than length of the Iterator 2020-04-03 ebrahim [tests/macos] Adopt added Apple Chancery tests with older macos versions 2020-04-03 ebrahim [aat] minor spacing 2020-04-03 ebrahim [aat] add the bug link, minor 2020-04-03 jfkthame Add a test for #2307. 2020-04-03 jfkthame Special-case 'smcp' when checking for exposed AAT features. 2020-04-03 jfkthame Add tests for #2305. 2020-04-03 jfkthame Fix sense of comparsion in hb_aat_map_builder_t::feature_info_t. 2020-03-30 jfkthame Set sequence number when adding feature to aat map builder, to support stable sort. 2020-04-03 ebrahim [ci] Update macOS 10.15's version 2020-04-03 ebrahim [aat] minor over previous feat related changes 2020-04-02 jfkthame Add a couple testcases for issue 2285. 2020-04-02 jfkthame [AAT] Don't map OT tags to AAT feature types that are not exposed. 2020-04-01 qxliu typo fix 2020-04-01 ariza minor; fixes #2292 Created with: roll-dep src/third_party/harfbuzz-ng/src Bug: 1036390 Change-Id: Icffdaf7aec234fcd50420a4f9f6eac5cbdd07836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134234 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757024}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/91aecef3b39e..177d32254ec8 git log 91aecef3b39e..177d32254ec8 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 ddrone@google.com Merge "Support process association for global tracks" Created with: gclient setdep -r src/third_party/perfetto@177d32254ec8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id6154a407fadb92fc1727b032f9a772f731fe33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139387Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757023}
-
Kevin Ellis authored
Bug: 933761 Change-Id: I78faca1d6f63e28749d91ad837a04a6fc31f0c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135543Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#757022}
-
Mathias Carlen authored
Before this patch, the observer/listener for navigation state changes were implemented using a std::vector. This would lead to null pointer dereferencing when adding and removing listeners while handling an event due to std::vector::erase reordering elements (pointers). This patch uses a checked observer and ObserverList instead to properly handling adding and removing observers/listeners. This bug was uncovered while working on the bug linked in this patch. R=arbesser@google.com Bug: b/152724265 Change-Id: Ia59bfca5bec5ce326394668eb7d8d62004fc16fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139691 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#757021}
-
Jérôme Lebel authored
This patch implements the advanced settings sign-in for the first run sign-in. SigninCoordinatorCompletionCallback is updated from: typedef void (^SigninCoordinatorCompletionCallback)( SigninCoordinatorResult signinResult, ChromeIdentity* identity); to: using SigninCoordinatorCompletionCallback = void (^)(SigninCoordinatorResult result, SigninCompletionInfo* info); The |SigninCompletionInfo| is a class that owns 2 values: + |identity| + |signinCompletionAction| SigninCompletionAction is an enum 2 values: + SigninCompletionActionNone + SigninCompletionActionNeedsAdvancedSettingsSignin The seconde value is only used for the first run sign-in since it can't open the advanced settings sign-in as long as the first run is not finished. Bug: 971989 Change-Id: Id9041def2bf872c0c10b7d21d7bcfe42eff7960e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130852 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#757020}
-
sauski authored
To ensure that the two related preferences, cookie_controls_mode and block_third_party_cookies remain in a consistent state, this CL updates the existing block_third_party_cookies toggle located in settings to update both preferences. Bug: 1068144 Change-Id: Ia64cb37c766a3143c6ac986efc67e87283852a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134261Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#757019}
-
Swapnil authored
When update manifest is fetched from the server, we receive an update check status from the server. We want to gather statistics about the status by using UMA statistics to investigate into this and improve installation reliability for the force installed extensions. Following histogram is added: Extensions.ForceInstalledFailureUpdateCheckStatus Bug: 1064202 Change-Id: Ie489e9b4b20888876869c42ca476fa3c6647b4d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116438Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#757018}
-
sreejakshetty@chromium.org authored
Currently, renderer-initiated same-document navigation using NavigateToURLFromRenderer results in runloop timeout as TestFrameNavigationObserver::DidStartNavigation is excluded for SameDocumentNavigations. This CL proposes a fix to this scenario. Bug: 1065868 Change-Id: I9d2e7c619f3fce756d3b3f6d2196aa86820208d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127028 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#757017}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I6d13ced16e45f608f044d783529003c700ab3ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131807 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#757016}
-
Nathan Zabriskie authored
This CL disables ContextGL() on the shared main thread context which will now log an error and return nullptr. This is being done to enable OOP Rasterization for Canvas2D which requires RasterInterface in place of GLInterface. New APIs should be added to RasterInterface as GLInterface will be deprecated on the shared main thread context after this CL. Bug: 1018898 Change-Id: Ic36e15b4558cbe70ea213ebf7d5c0f1751b40b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134916Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#757015}
-
Jacobo Aragunde Pérez authored
Add two tests for the focus dialog and rotate pane focus accelerators. We create a "restore pages" bubble and then simulate the corresponding key press events, finally we check if the bubble is focused. Bug: 1042010 Change-Id: Ie8f44615c63386d62fbf5d32d6ff9b55c6704b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095066 Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#757014}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/461f9ab12106..d14735b25df3 git log 461f9ab12106..d14735b25df3 --date=short --first-parent --format='%ad %ae %s' 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 0e78ffd1dcfc..b4b0f994204e (1 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src e95fbfb1f509..4af38c49bfee (1 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src dbd073615280..004b2914bfe3 (5 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b8d47928094f..bdb6807825ac (4 commits) 2020-04-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 698d82e38b39..1fbefe048387 (2 commits) Created with: gclient setdep -r src/third_party/angle@d14735b25df3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I5e92d94c92305582957addc825eddcf17d02dfec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139381Reviewed-by:
-
Colin Blundell authored
We had initially thought that it would make sense to fork //chrome's TabRedirectHandler.java for usage in //weblayer. However, on investigation its //chrome dependencies are essentially layered on top of its core logic, the latter of which can be shared directly with WebLayer. This CL thus prepares TabRedirectHandler for componentization by moving its association with Tab to a RedirectHandlerTabHelper thin wrapper object. Future CLs will componentize TabRedirectHandler as RedirectHandlerImpl and then merge it back into the RedirectHandler interface (eliminating the latter as an interface). A side benefit of this change is that it removes the remaining //chrome dependencies from ExternalNavigationHandlerTest.java, as this test now explicitly passes in the values for the flows that it wants to test to TabRedirectHandler#updateIntent() rather than needing to configure the latter's behavior via mutating //chrome-level state. Finally, as part of this change various CustomTab-related unittests now need to mock out an access to ChromeFeatureList. This is because with this refactoring that access now happens before an early return in TabRedirectHandler#updateIntent(), whereas before the access was after that early return. Bug: 1031465 Change-Id: Idabfe225fb77cf3bfe454d7ff1d63c9e801b8fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127090 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#757012}
-
Wez authored
WebContentRunner used to exit() if its Context terminated unexpectedly. This was removed when support was added for a single Runner service to run WebComponents in their own isolated Contexts. Launch of the Context requires move()ing the contents of the CreateContextParams, resulting in some of its fields (in particular the service-directory) still being set, but to nulled values. Failure of the default Context would therefore leave the WebContentRunner active but unable to launch any new non-isolated WebComponents. This affected both the Cast and web Runners. WebContentRunner & CastRunner are fixed to consume a callback which they can Run() to get a fresh fuchsia.web.CreateContextParams table from the caller. Bug: 1066826, b/152696080 Change-Id: I3610765751c402cd0c3d2acca13c3f0e164f85d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134231 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#757011}
-
sandromaggi authored
This tests what happens when clicking the "switch tabs" button without actually opening a new tab and then going back to the original tab (by clicking the back button). Bug: b/152967053 Bug: b/152951618 Change-Id: I7514d344f4cdb16b5f1c8033bd34c52799f66c3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138414 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/50b248c3..6ae4715e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I07c0e536ecbaa8aafd3b66e70b33b3eda1bd4c60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139731Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757009}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I77236487532a3776cd2a389d7e15a261f6489b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137194 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#757008}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9e918ea3. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 7e979350 "Handle k-rate AudioParam inputs for PannerNode" b32714e6 "Reland: [shapedetection] Upstream TextDetection tests to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I281f99b01d55385edec7551f74af0285e4e3c09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139671Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757007}
-
sreejakshetty@chromium.org authored
RenderFrameHostImplBrowserTest::CheckIsCurrentBeforeAndAfterUnload results in flakiness in network_service_out_of_process_content_browsertests. Bots: android-pie-x86-fyi-rel Instead of using a sub-frame long timeout disable the timer. Bug: 1065184 Change-Id: I476071c767e97893e59918983d1c22f69a7fe796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132199Reviewed-by:
-
Finnur Thorarinsson authored
Bug: 1063394, 656015 Change-Id: I17839cda34845181823b4f594150fe6a18caf0cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137395 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#757005}
-
Rayan Kanso authored
Tested by running chrome_apk and chrome_public_apk Bug: 1045009, 911900 Change-Id: Ib6803cfc0668967efdaac147e4d3c3269634c6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126929Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#757004}
-
Robbie Gibson authored
Before, the OTR prefs were stored in chrome_browser_state_impl, so even after destroying the OTR state (when closing the last tab), a new OTR state would use the same prefs. Thus, the prefs would only reset after a cold start of the app. After, each new OTR browser state creates a new prefs (based off of the existing CBS prefs). The net affect of this is that incognito prefs are reset every time the OTR state is destroyed instead of only every cold start. Bug: 1067412 Change-Id: I0a11f2d83bf7cf1d939bacbafa15b96cb63ee5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135754Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#757003}
-
arthursonzogni authored
On 2019-09-27, lfg@ added support for parsing CSP for navigation response provided by the ServiceWorker. See https://chromium-review.googlesource.com/c/chromium/src/+/1819631 This patch is an alternative version of: https://chromium-review.googlesource.com/c/chromium/src/+/2126933 What is not kept: 0) Automatically convert blink/non-blink typed using mojo. As a result all the ConvertToBlink functions remained. What is kept: 1) Move the part from the ServiceWorker about parsing CSP toward the blink http_parser. 2) Use the HttpResponseHeader instead of the HTTP field values. This will help with ParsedHeader in the following patch: https://chromium-review.googlesource.com/c/chromium/src/+/2122647/11 Bug: 1063832 Change-Id: I7721e846f0fd14b6a8517d25b4e9cd39d0c77061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134246 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757002}
-
Hans Wennborg authored
This is in preparation for moving these macros out of logging.h Bug: 1031540 Change-Id: I29aa4ce07dcb7b165b72a6fa4b8dda4f8371e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139152 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#757001}
-
Dominik Röttsches authored
Bug: 1063867 Tbr: kojii Change-Id: I7cc1a1e075078c6e2d82b45321463056ae217759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139711Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#757000}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e95fbfb1f509..4af38c49bfee git log e95fbfb1f509..4af38c49bfee --date=short --first-parent --format='%ad %ae %s' 2020-04-06 afdx@google.com spirv-fuzz: Improve support for compute shaders in donation (#3277) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@4af38c49bfee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ia7afaf8b1f59bed26226e5ab87a81dcbda61174a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139353Reviewed-by:
-
Simon Zünd authored
This CL prevents Debug.evaluateOnCallFrame to interrupt V8 execution. This is necessary as V8 is not able to handle nested Debug.evaluateOnCallFrame messages in a safe and correct manner. Bug: chromium:1062448 Change-Id: I59f62c3c16a3052fe09043e06ced6b59c8364fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139391 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#756998}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/bdb6807825ac..b4a27407e2be git log bdb6807825ac..b4a27407e2be --date=short --first-parent --format='%ad %ae %s' 2020-04-07 bclayton@google.com Coverage: Improve uncovered visualizations Created with: gclient setdep -r src/third_party/swiftshader@b4a27407e2be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I0e9786a27a931cb38c21cb85593cbd5715013348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139252Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ibfc14dbbc3cab9a131352d9c724483f53c47a16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139379Reviewed-by:
-
Alice Wang authored
This CL adds the param eligible_for_consistency in X-Chrome-Connected header and sends true to Gaia when user is signed out. It also parses the param show_consistency_promo from the response of Gaia. Bug: 1063362 Change-Id: Ia6329304db8928a5e309fa7f2424f66a55a04751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132252 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756995}
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is depreciated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates OfflinePage classes. Note: This change is only code clean-up, does not change any behaviour. Bug: 1041781, 1067314 Change-Id: I73fa1791aa8c862ee0c9833eeb13db1c92ac411d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126989 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#756994}
-
Wei-Yin Chen (陳威尹) authored
Bug: 1065314 Change-Id: Ib716159c67e84ac6e09511c45dc42cedc45d23dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123991 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#756993}
-
Dominic Battre authored
This adds more log data to understand why the charset converter fails on some Chrome OS bots. R=mkwst@chromium.org Bug: 1068489 Change-Id: I4abca82cdffdd60ffd7c15f186c79768c2a1c8c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139651 Auto-Submit: Dominic Battré <battre@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#756992}
-
Wez authored
This test made assumptions regarding the timely processing of network- change notifications, resulting in flakiness. Fix the test to explicitly wait on each expected OnNetworkChanged() notification before continuing. Bug: 1064673, b/142796913 Change-Id: I9da235476415274ebcd254d8f6d08a62176b31c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124669 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756991}
-
Koji Ishii authored
This member needs to be set in |LayoutBox::AddLayoutResult|, after |NGFragmentItems| was built and set to the cached list. Since this member is used as a cached index, allow changing by marking it as |mutable|. This change is needed to properly mark |NGFragmentItem| as |const|. This patch has no behavior changes. Bug: 982194 Change-Id: I83131b744cd73994b861be9eb374e5e5e47fd5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138998Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756990}
-
chromium-autoroll authored
fuchsia/third_party/aemu/linux-amd64/+log/lSCFQ.....PanIU... Created with: gclient setdep -r src/third_party/aemu-linux-x64@PanIU... If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: chonggu@google.com Change-Id: Ie5c8ea92d8145654e845ae9d9b93b80783c10ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139351Reviewed-by:
-
Rainhard Findling authored
* Rename metrics to appropriate naming scheme. * For safety check start, record both action and hist on JS side to have metrics for all user actions in one place. Bug: 1015841 Change-Id: I2160be6721bad09d6f7c2978e1a459b8916615ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132140Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#756988}
-
David Jean authored
Bug: 1052143 Change-Id: I1838e127921240e6052c4f2370ea4e0e46ae3d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137389 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#756987}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/275e665173c6..852ebea2d55d git log 275e665173c6..852ebea2d55d --date=short --first-parent --format='%ad %ae %s' 2020-04-07 csmartdalton@google.com Reland "Reland "Reland "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding"""" 2020-04-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@852ebea2d55d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I5a46266b0c5075299b8b2ead185e0cde6997b10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139251Reviewed-by:
-
