- 26 Jun, 2020 40 commits
-
-
Avi Drissman authored
Switch to more inclusive terminology in browsing_data. In fact, the way the terminology was used was confusing, as it was backward from the usual use. Therefore switch to "delete" or "preserve" as those are consistent no matter what perspective the deletion is considered from. Bug: 1097355 Change-Id: If4f45c5f816b091611cfe32780aa330ff98a0d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265403 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#783013}
-
Andrew Grieve authored
There is an upcoming migration that will move component information OWNERS -> METADATA.chromium See: https://chromium-review.googlesource.com/c/chromium/src/+/2248340 For the interim, support both. Bug: None Change-Id: Icb03b8b7b69a509f760c3b15a69f2d16eec3801d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269698 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#783012}
-
Andrew Grieve authored
E.g. I use out-gn/, and for me this change makes licenses.py run in 1.5 seconds rather than 3 seconds. Our .gitignore ignores all top-level out* directories, so this script should do the same. Bug: None Change-Id: I78cd1fea4c23d4990d52d2d521a41fe2267a2be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269317Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#783011}
-
Dave Tapuska authored
This moves the WidgetInputHandlerImpl/Manager and FrameWidgetInputHandlerImpl classes. Some additional APIs are added for the synchronous compositor where the frame sink still lives on the content side. BUG=1073560 Change-Id: Iff2a436f83c890be36362fd4139ab0349b01ff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250943 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#783010}
-
Scott Violet authored
This helps ensure positioned objects are laid out in tree order. BUG=1098840 Change-Id: I33b4290101e1c6e684a29330268e3f2f052fb7a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264951Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#783009}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/bf571219978d..a14393ff9a04 2020-06-26 bmeurer@chromium.org [sdk] Propagate protocol errors from `Debugger.getScriptSource`. 2020-06-26 sigurds@chromium.org [browser_sdk] Refactor main frame navigated event listening 2020-06-26 alexrudenko@chromium.org Fix alignment for the inspector overlay header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069378,chromium:1099680 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icccf90a43278939c57c9bcba475f525dcf9519af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270523Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783008}
-
Lan Wei authored
After we finish the scroll unification, the scrolls happens mainly on the compositor thread, and the scroll code in the main thread will be removed. eventSender sends the scroll events to main thread, so it would not work after the scroll unification. This CL we should replace eventSender.mouseScrollBy with wheelTick which uses gpuBenchmarking.smoothScrollByXY in forms/resources/common-wheel-event.js. TBR=ellyjones@chromium.org,avi@chromium.org,sky@chromium.org,bokan@chromium.org,lanwei@chromium.org Bug: 1047176 Change-Id: Ib45dce450fe395d53a443612033305bccef6b19d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268227Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#783007}
-
Lindsay Pasricha authored
This reverts commit cf4e7dcb. Reason for revert: AddAccountSigninManagerTests are failing again Original change's description: > [iOS] Fix broken tests due to missing completion in fake ViewController. > > AddAccountSigninManagerTests were failing due to a missing run > completion. Remove intermediary method that causes this failure. > > Bug: 1078815 > Change-Id: I1766e593927cd40be318cf66bb67d11f5ed47006 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264057 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Jérôme Lebel <jlebel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782928} TBR=jlebel@chromium.org,fernandex@chromium.org Change-Id: I13a4ea3529c35567c607eeb77ce9e9c690ac8cbe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1078815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269879 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#783006}
-
Benjamin Smith authored
R=tmrts@chromium.org, ulan@chromium.org Compose is a critical user journey for Gmail. Open compose mole. Bug: 1044682 Change-Id: I2522512bb19fd616cb1c8809e3c09c4ea7f87ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247339 Commit-Queue: Benjamin Smith <codesmith@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#783005}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0cf906bce58a..abe3c443ff9a 2020-06-26 khokhlov@google.com [Telemetry] Sideload Perfetto binaries in Perfetto tracing agent If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:839067 Tbr: sadrul@google.com Change-Id: I049084b200605876faf9cb3d35be8d1f1f90fc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270520Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783004}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e684c6daef6b..e6c33eabe079 2020-06-26 michaelludwig@google.com Don't erase child optimization flags 2020-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6d759c2e to 86c15223 (594 revisions) 2020-06-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6ef0387d581d to c81da1c809fe (11 revisions) 2020-06-26 egdaniel@google.com Add default flush calls to gpu backend. 2020-06-25 michaelludwig@google.com androidFramework_replaceClip proposal 2020-06-25 michaelludwig@google.com Revert "clean up after big refactor of SkColorFilter --> ...Base" 2020-06-25 fmalita@chromium.org [skrive] Add dm source 2020-06-25 johnstiles@google.com Update SkComposeColorFilter to support an input FP. 2020-06-25 jvanverth@google.com Implement Direct3D semaphores 2020-06-25 adlai@google.com Remove outdated comment 2020-06-25 brianosman@google.com Cleanup of GrSkSLFP 2020-06-25 bsalomon@google.com Make GrBicubicEffect also support centripetal Catmull-Rom kernel. 2020-06-25 johnstiles@google.com Add support for passing an inputFP to SkColorFilter objects. 2020-06-25 borenet@google.com bin/try: automatically set 'git cl issue' when not found 2020-06-25 reed@google.com clean up after big refactor of SkColorFilter --> ...Base 2020-06-25 adlai@google.com Have the drawing manager ref & unref DDLs on playback 2020-06-25 fmalita@chromium.org [skrive] Initial render plumbing 2020-06-25 robertphillips@google.com Add GM::gpuTeardown entry point 2020-06-25 robertphillips@google.com Add GM::onceBeforeDraw method that encapsulates calling onOnceBeforeDraw 2020-06-25 bungeman@google.com Cleanup for TextLine::getGlyphPositionAtCoordinate. 2020-06-25 bsalomon@google.com Fix nearest neighbor sampling of YUV[A] images 2020-06-25 brianosman@google.com Move SkSLSampleMatrix to include/private 2020-06-25 herb@google.com add mutex to GrTextBlobCache 2020-06-25 michaelludwig@google.com Update how sample(matrix) calls are invoked in SkSL 2020-06-25 adlai@google.com Reland "Ignore calls to freeGpuResources on abandoned contexts" 2020-06-25 michaelludwig@google.com Update complex clip GMs to only use supported clip ops 2020-06-25 brianosman@google.com Initialize SkVertices::Sizes::fTotal 2020-06-25 csmartdalton@google.com Don't write instance locations for unused resolve levels 2020-06-25 csmartdalton@google.com Remove GrMiddleOutCubicShader::kMaxResolveLevel 2020-06-25 herb@google.com Reland "simplify freeAll" 2020-06-25 adlai@google.com Add an sk_sp API for DDLs with a macro for staging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087084,chromium:1097750 Tbr: lovisolo@google.com Test: Test: Test: Capture and replay sample of gfxbench Change-Id: I811e460a44bb93ca1056dd84e9f9a35b403fd356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#783003}
-
Mark Cogan authored
In order for the unit test suites to run with the iOS 13 Scene APIs: - Create a test-specific scene delegate (similar to the test-specific app delegate). For now, this is a no-op delegate. - Update the plist for unittests using the scene APIs to use this as the scene delegate. - Early return from one test that uses a code path that expects SceneState objects to be created. Bug: 1084483 Change-Id: Ibd0efbc72b55818647076481b361b3252e847520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241652Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#783002}
-
Nohemi Fernandez authored
This reverts commit 11f8ce83. Reason for revert: Landed the fix to SigninCoordinator EarlGrey tests in patch 2264057. Original change's description: > Revert "[iOS] Remove unused ChromeIdentityInteractionManager APIs." > > This reverts commit 053f6124. > > Reason for revert: > AddAccountSigninManagerTest fail on iOS 12: > https://ci.chromium.org/p/chrome/builders/ci/iphone-device/9356 Bug: 1078815 Change-Id: Iba786bb1caa7dbbb1b8aa3c4d2feeb5e24674922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270085 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#783001}
-
James Howard authored
Unaccelerated pointer movement fields in CGEvent are publicly declared in the macOS 10.15.1 SDK. Any local mouse move NSEvent/CGEvent on a compatible macOS has the unaccelerated movement data, so simply choose which fields to query when constructing a WebMouseEvent based on a flag. R=jameshollyer@chromium.org Bug: 998688 Change-Id: I45a9fdb5c0cd1ef2dff3edf31d9dfa116d13b703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238504 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#783000}
-
Steven Bingler authored
Call into EnterpriseInfo info to check if the device or profile is owned. The check may be performed asynchronously and could take some time. While this check is in progress we'll assume a "not owned" state which will allow for any existing dns-over-https preferences to be honored. Testing: Hand tested by installing a device ownership app onto an emulator and checking Net.DNS.DnsConfig.SecureDnsMode to see if the value is as expected. Bug: 1085168 Change-Id: I82690a4c1ff3380fbc3599c71a9fc1fd8a37571c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239530Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#782999}
-
Steven Bingler authored
The current location of UmaSessionStats gets called once per browser session, this means that the metrics could be recorded multiple times between process restarts. Move the call to a location that is only called once per process start. Because the frequency of the metrics call changes as part of this work create a new versioned histogram. Bug: 1085168 Change-Id: Iac9614e6c3b16031327102d9a5d548d282257713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252280 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#782998}
-
Steven Bingler authored
Create a native class that other classes can use to query ownership state of the Android device from the Java side EnterpriseInfo. This class provides a function that accepts a callback. When this function is called the callback is stored in a list and a request to the Java side is made. If any more requests are received they are stored in the list while we wait on the response from the Java side. Once the Java side response is received all callbacks stored in the list are run. Bug: 1085168 Change-Id: I49429d13f9a407e3650fe265d4e010e7e169ee68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268657 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#782997}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593151085-cd414c91e242db50072f832cc2413fee8d11ae76.profdata to chrome-win64-master-1593172332-916071453aae1545518df43885df715cf33cbe36.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie8b01a2a513446eac80b956b32710165d0fe8c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782996}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c403081641a8..d43c3788d782 2020-06-26 nisse@webrtc.org Delete old TODO item If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic382a610e9dae371af4f3fcaf892a18a9722e597 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782995}
-
Michael Crouse authored
This change adds a keyed service so that LiteVideos can be enabled based on the decision provided by the LiteVideDecider for appropriate navigations. This change also adds a web contents observer to query the decided, via the keyed service, for each navigation, main and subframes, for LiteVideoHints to inform throttling media requests. A future change will pass any hints for allowed navigations to the LiteVideo render agent needed for throttling media requests. Bug: 1095683,1095684 Change-Id: Ifbe1df5917938a7562e1883da399bb389471d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255130Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#782994}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1df00953. With Chromium commits locally applied on WPT: d7b4fa22 "[css-pseudo] Fix DCHECK failure with ::marker and text-combine-upright" 4778c353 "Origin isolation: implement window.originIsolationRestricted" 3398d444 "[COOP] moving reporting tests to reporting/" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure iclelland@chromium.org: external/wpt/feature-policy jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I19946c67e02fb6c6efa6c46974622a178bc27110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269801Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782993}
-
Nick Diego Yamane authored
This is required to be able to transfer WaylandWindow's surface ownership over to WindowDragController in case it gets destroyed in the middle of a window/tab dragging DnD session. Refer to [1] and [2] for more details. Bug: 896640 [1] https://chromium-review.googlesource.com/c/chromium/src/+/2267637 [2] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing R=msisov@igalia.com Change-Id: I69360ab208e8754625b5fcd37614530589f0d5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267618 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#782992}
-
Marc Treib authored
As requested on crrev.com/c/2263815. This constant is used to indicate that the user accepted a password manager bubble by clicking on "Save", "Update", or a similar button. So this rename makes it a bit more accurate. No behavior changes. Bug: none Change-Id: I3fccfcf4d7d3169637cd28dbd0d25e4517c35b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270219Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#782991}
-
Mehran Mahmoudi authored
This limits the number of times paint preview is displayed on tab restoration to only 1 tab. This means that this will only happen for the tab that is dispalyed right after Chrome startup. Bug: 1064011 Change-Id: I4a95eaeccb63f62b38dd36521fa79eff952b09d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264507Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782990}
-
Colin Blundell authored
//chrome's InfoBarCompactLayout.java has been componentized and //weblayer can now use it directly rather than a custom fork. This CL makes that change. The only differences in the //weblayer version were the following: - It had brought in the createCloseButton() implementation from //chrome's InfoBarLayout.java as InfoBarLayout.java wasn't brought into //weblayer for the initial implementation. The componentized InfoBarCompactLayout.java calls the now-componentized InfoBarLayout.java directly. The implementations are identical. - It forked a string resource; this CL undoes that forking. Again, the values of the resource were identical. There is no functional change. Bug: 1099169 Change-Id: Idefdf0c0726f79512f10cc82ddc93ffd453f7dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265994Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#782989}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/55be03a1e001..4b744d80038c 2020-06-26 fmayer@google.com Merge "Allow heapprofd_initialize to tear down existing client." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7e86d92228cce12088ef0f9cc51bd1073bf252bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270519Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782988}
-
Sorin Jianu authored
After this change, the RequestSender is choosing between x-cup-server-proof and etag value, and gives priority to the x-cup-server-proof value if it is non-empty. The values for both headers is read by the network stacks, and made them available to the RequestSender, which implements the validation mechanism in one place. It's impractical to unit test this code, since the RequestSender hardcodes the production public key and it can only transact CUP with a production backend. Bug: 606958 Change-Id: I5b0f2e9f2ba1e75ca4fd4c4becde848846541bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266918Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782987}
-
Samuel Huang authored
Previously, running SuperSize-archive on .apk files without native code (.so files) would lead to failure. The workaround was to specify the --java-only flag, but this was non-ideal. This CL fixes the above, so SuperSize can archive .apk files normally without the flag. This change is also propagated to Trichrome .ssargs generation (for WebView in particular). Bug: 1040645 Change-Id: I19f5fe1f03ea74f789fd8fd12a072fe073df4021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269878Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#782986}
-
Philip Rogers authored
This patch replaces "Lenna" images with images of Grace Hopper. Bug: 1099702 Change-Id: I32cf958bd2b6fbef5388da24de846a90ac0af9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270110 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782985}
-
Nohemi Fernandez authored
Clean up signin_interaction/ directory, which was part of the old sign-in architecture. Bug: 971989 Change-Id: I099c0247d69861c6836672840dc5ddb66bad4299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270201 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#782984}
-
Mihai Sardarescu authored
We are preparing to enable by default the feature kUseNSURLSessionForGaiaSigninRequests. This CL enables the tests of the bridge that were deemed flaky. Fixed: 1065349 Change-Id: I5408f4ed70463503fd00cf06cc6e6f649cdfa00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247771 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782983}
-
Sylvain Defresne authored
The variable is now configured from BUILD.gn so should not be overridden when adding configuration/platforms to the Xcode project. Bug: 1094890 Change-Id: I06cef502ebcc3f19b68b91c54e2588b38f411524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270068 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782982}
-
Rouslan Solomakhin authored
Before this patch, Web Payment would enable Trusted Web Activity (TWA) features only in production TWAs. This patch adds a test controller method to set the TWA package name. After this patch, the cross-platform tests for Web Payment can simulate being in a Trusted Web Activity be calling test_controller()->SetTwaPackageName("com.example.app"). Bug: 1061503 Change-Id: I5abb67c0a0ca514b8ed739ecd5cf85fdc05ef27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270338Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782981}
-
Morten Stenshorne authored
If there's no class C breakpoint (i.e. non-zero gap) between the outer block-end edge of the last child and the inner block-end edge of its container, we really don't want to break there. We also don't want to break *inside* the block-end border/padding area. Only allow breaking here if there are no real preceding breakpoints. Bug: 829028 Change-Id: If922143923446060702eec5cfb8f7b2fbed06a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264296 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#782980}
-
Benoit Lize authored
This reverts commit 08f75150. Reason for revert: Fixed accounting on POSIX. Original change's description: > base/allocator: Report the size of mapped PageAllocator space when crashing. > > PartitionAllocator can occupy a lot of address space, as freed pages for > normal buckets are never unmapped, and these are not shared across > buckets. This is a known issue, tracked in the linked bug. > > However the reporting currently in place only looks at a single > partition when reporting that an OOM is likely due to too many mapped > pages. It does not look at all PageAllocator allocations. This commit > adds a crash key reporting the total amount of mapped PageAllocator > pages to crash reports, to allow distinguishing between "true" OOM and > address space exhaustion. > > For instance, on Windows 32, an address space exhaustion crash would > happen with a reasonable committed set, remaining system commit limit, > and a large amount of mapped pages. All these data points are available > in crash reports, except for the last one, which this commit adds. > > Bug: 421387 > Change-Id: If3eac64489b61297cb5da6da328cfc70fecc4c8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264438 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Benoit L <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782459} Bug: 421387 Change-Id: Ib6e377d978f3a9905224e3d0fa9944b741d4a4b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270318Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#782979}
-
Philip Rogers authored
Change-Id: I804e2b4aceffb94c551e7829da35254cdcf9fceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270108Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782978}
-
Richard Knoll authored
Updates the VectorIterator interface to be compatible with the clarified IIterator API. The return value should be S_OK if we just moved past the last item, and E_BOUNDS if the iterator was already past the end before. See updated docs: https://docs.microsoft.com/en-us/previous-versions/br205830(v=vs.85) Bug: None Change-Id: Ifac585ca1dcfbf967afc801a64c97fa17ee2ef79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124831Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#782977}
-
Adam Rice authored
Serialising and deserialising exceptions is now supported directly, so transferable streams do not have to work around the lack of support. Remove the workarounds. Change the semantics so that failures to serialise are not hidden by implicit conversion to undefined. Instead the cancel() or abort() method will return a rejection, and the stream will be errored. Update the http/streams/transferable/reason.html web test to reflect the new semantics. BUG=894838 Change-Id: I44c5bd968b4544df2706269900ca8461eabfa00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257655Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#782976}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b60d96652beb..4b4651dbc255 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC droger@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: droger@google.com Change-Id: I90716949ed12ea5fafa0b96ec68e3e2a60f7f957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270432Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782975}
-
Andrew Grieve authored
This is step #1 to merging chrome_public_apk and chrome_public_modern_apk. Bug: 1097998 Change-Id: I8546aa16eecdbd45c40413cd89e98516932cd033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259574 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#782974}
-