GitLab

These targets no longer directly depend on OpenGL symbols. These
days, the dependency on ANGLE (and SwiftShader) is achieved via a
data dependency from //ui/gl:gl.

This change is necessary in order to prevent the ANGLE libraries from
being loaded into a process as a result of a hard link-time dependency,
resulting in failures in the SwiftShader library. Normally, the lack of
a direct dependency on any of the symbols defined by ANGLE prevents a
link-time dependency from being created. But when ubsan is enabled,
it causes additional runtime library symbols to be exported from
each DLL. If one of those symbols is used in the main executable as a
result of ubsan instrumentation, it can create a link-time dependency
on an arbitrarily chosen (as a result of link order) DLL, which could
happen to be one of the ANGLE libraries. This will cause the following
to happen:

- The program loads SwiftShader libEGL.dll using the code in
  ui/gl/init/gl_initializer_win.cc.
- SwiftShader libEGL.dll tries to find SwiftShader libGLESv2.dll by
  calling GetModuleHandleEx [1], but it ends up finding ANGLE
  libGLESv2.dll because it was loaded first.
- SwiftShader tries to find the symbol libGLESv2_swiftshader in that
  DLL [2], but fails because the symbol is not exported from ANGLE
  libGLESv2.dll.
- All subsequent OpenGL calls fail.

[1] https://cs.chromium.org/chromium/src/third_party/swiftshader/src/Common/SharedLibrary.hpp?l=74
[2] https://cs.chromium.org/chromium/src/third_party/swiftshader/src/OpenGL/libGLESv2/libGLESv2.hpp?l=313

Bug: 507755
Change-Id: I67b75bb6eba062e82744268a551e2744afb6cbb8
Reviewed-on: https://chromium-review.googlesource.com/826544Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524228}

Use of gconf has been removed, and we depend on gsettings (in libgio)
instead of dconf directly.

Bug: 768027
Change-Id: Iec222f01577d3ffe10ee4a31345030d765eaefb4
Reviewed-on: https://chromium-review.googlesource.com/827921Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524227}

When use_static_angle is set

BUG=726002

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4d716a48002f03af29a0280cd9207460e470143d
Reviewed-on: https://chromium-review.googlesource.com/822952Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524226}

In preparation for the newer capture impl, content::CursorRenderer and
content::WindowActivityTracker have been merged into a single
CursorRenderer class that monitors platform views for mouse activity.
The client interface for CursorRenderer has been simplified, with added
support for: a) Changing the view being monitored without having to re-
instantiate a new CursorRenderer; b) Rendering the mouse cursor on the
VideoFrame from any thread (to avoid unnecessary hops to the UI thread);
and c) A callback to notify when the mouse cursor in the video needs to
be updated.

As a result of this refactoring, a few minor behavioral bugs were fixed.
Now, for tab capture, the mouse cursor should hide after 2 seconds of no
movement; as was intended.

TBR=nick@chromium.org

Bug: 754872
Change-Id: Iaab12fbd397d9034d9044e39c19a45f0cc88e9cf
Reviewed-on: https://chromium-review.googlesource.com/818730
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524225}

The motivation for this change is a difference in behavior between
macOS and other platforms.

  On non-macOS platforms, once the output surface has been created,
  calling SwapBuffers on the output surface will cause content to appear
  in the window created in the browser process.

  On macOS, SwapBuffers generates parameters that then must be sent back
  to the browser process (more generally, wherever the NSWindow lives),
  in order for the content to be displayed on-screen.

  These parameters are stored in the CALayerParams structure. They are
  consumed by the ui::CALayerFrameSink interface (which, given a
  gfx::AcceleratedWidget and CALayerParams, will show the described
  content in the specified gfx::AcceleratedWidget).

Prior to this change, content::GpuOutputSurfaceMac would reach directly
over to ui::CALayerFrameSink. This doesn't work in viz, because the viz
equivalent (viz::GLOutputSurfaceMac) lives in the GPU process.

This change plumbs these CALayerParams back to the browser process, via
a new priviledged DisplayPrivateClient interface.

Note that creating a new DisplayPrivateClient interface is chosen over
repurposing the existing CompositorFrameSinkClient interface because
CompositorFrameSinkClient is not specific to an output display. The
feedback from the new DisplayPrivateClient will also be used in MacViews
in the future to ensure that NSWindows are not placed on-screen until
they have content available.

A stub DisplayPrivateClient is used by ui::ws::VisHostProxy, which will
need to be fleshed out for mus on macOS.

The DisplayPrivateClient for DirectLayerTreeFrameSink is left as nullptr
on Android (and other locations) for now. This interface should be made
non-optional in the future.

R=sadrul,tsepez,fsamuel
TBR=avi (content/)

Bug: 772576
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id5e873cf18ef17e86dc26fd61e17705e94274015
Reviewed-on: https://chromium-review.googlesource.com/820630
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524224}

Currently, CBOR maps only permit keys to be UTF-8 strings. Add support
for unsigned integer keys. Support for negative integer type keys will
be integrated as CL 777807 is lands.

Bug: 786218
Change-Id: Id28864a9c62d0b0d93e71a663b6e8b2b84b2de95
Reviewed-on: https://chromium-review.googlesource.com/781207
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524223}

RenderTextHarfbuzz has always (since r272260) categorised some
unicode blocks as "unusual". Characters from another block will
never appear in a run with characters from an unusual block.

But variation selectors always apply to the preceding glyph. Allow them
to merge with an unusual block.

Bug: 786840, 775404
Change-Id: Id562836b79bbc494e6f44e8492f8b36b704a2838
Reviewed-on: https://chromium-review.googlesource.com/813459Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524222}

This reverts commit f8625da2.

Reason for revert: This change breaks EGTests for iOS Simulator and Device, see:

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.mac%2Fios-simulator-full-configs%2F1434%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_web_egtests__iPhone_6s_Plus_iOS_10.0_%2F0%2Fstdout

Original change's description:
> Unescape fragment for display in Omnibox
> 
> A change in Chrome 63 causes Chrome to urlencode the fragment component
> of URLs. The Chrome omnibox should decode the fragment component as it
> does for other URL components and matching Firefox.
> 
> Bug: 789163
> Change-Id: If82d72445d904495c8d3e4129ab63be141745328
> Reviewed-on: https://chromium-review.googlesource.com/822819
> Commit-Queue: Eric Lawrence <elawrence@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524123}

TBR=pkasting@chromium.org,elawrence@chromium.org

Change-Id: I9572e8a5d66381478c1faca0f78a66b878a4b059
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789163
Reviewed-on: https://chromium-review.googlesource.com/828080Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524221}

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I973012bf731d22eb1059c12d9614db70a86f94c6
Reviewed-on: https://chromium-review.googlesource.com/827610
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524220}

Bug: none
Change-Id: I22c12174321b8471e54bfb65c9062fe367671471
Reviewed-on: https://chromium-review.googlesource.com/827628Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524219}

https://chromium.googlesource.com/catapult.git/+log/6ee03a73439b..928fcfa65b78

$ git log 6ee03a734..928fcfa65 --date=short --no-merges --format='%ad %ae %s'
2017-12-14 dtu [pinpoint] Increase Gitiles service timeout from 30 to 60.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If06fea910fca86ae9b1e88750bff0ffb880b8893
Reviewed-on: https://chromium-review.googlesource.com/827597
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524218}

https://skia.googlesource.com/skia.git/+log/77dd6c28d090..f53e6c912dd4

$ git log 77dd6c28d..f53e6c912 --date=short --no-merges --format='%ad %ae %s'
2017-12-14 benjaminwagner Temporarily specify machine_type for Win GCE bots.
2017-12-14 djsollen Suppress warnings of unused variables.
2017-12-14 angle-deps-roller Roll skia/third_party/externals/angle2/ 9d4d7f06f..f15f9cec3 (1 commit)
2017-12-13 mtklein make SkColorSpace_New real
2017-12-14 jvanverth Send TextBlobCache purge messages only to owning cache.
2017-12-13 pirama Turn on PGO for skia_nanobench, skia_dm
2017-12-13 benjaminwagner Enable Goma fallback by default.
2017-12-13 benjaminwagner Switch Goma test jobs to ANGLE/Vulkan.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Idb48dd603d0ddb5bfd6129ed674b5d1a6a59811d
Reviewed-on: https://chromium-review.googlesource.com/827585Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524217}

After moving to GPU discardable, we saw a number of cases where
reported memory from the GPU image decode cache spiked. This was
due to the controller reporting images which had already been deleted
by the underlying discardable system.

This patch gives a way for the GPU image decode cache to query
whether a given discardable texture has been deleted, and log 0
in these cases (matching software discardable behavior).

Bug: 776713
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8c189074ccc488530cdcfcddbdc4ab664684b53e
Reviewed-on: https://chromium-review.googlesource.com/822461
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524216}

Making an element fullscreen wraps it with a LayoutFullScreen, unless it
is the <html> element in which case Fullscreen::FullscreenElementChanged
specifically avoids wrapping it.

This patch updates the layout tree construction code to match the logic
used when entering fullscreen mode.  This ensures that toggling display:
none on a fullscreen <html> element doesn't inadvertently create a
LayoutFullScreen where we didn't have one before.

Bug: 676432
Change-Id: I847b49fe8efa3af2ae0e02c4879fe6dc89a6a146
Reviewed-on: https://chromium-review.googlesource.com/826468
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524215}

The |delegate_| might be gone when the unmask response comes (we have
seen crashes). Guard it.

Bug: None
Change-Id: I4d656c0379c76383b616d564cf2d1dc024cffaf7
Reviewed-on: https://chromium-review.googlesource.com/827032
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524214}

Add histograms to the downloads home UI to track impact:
- Actions taken on specific list items.
- Actions taken on the home menu.
- Number of items selected when taking actions on the home menu.

BUG=777630

Change-Id: I1f81bcb18b4f814cf4c76b96aa1b736766c257a8
Reviewed-on: https://chromium-review.googlesource.com/821312Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524213}

There are crash reports.

Bug: 769382
Change-Id: I4e406945605fa65193962048ad7e8961e8aa75c8
Reviewed-on: https://chromium-review.googlesource.com/826488Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524212}

https://pdfium.googlesource.com/pdfium.git/+log/fe9d640ea90c..df4f30eaaa46

$ git log fe9d640ea..df4f30eaa --date=short --no-merges --format='%ad %ae %s'
2017-12-14 dsinclair Add types to the CXFA_Node::Get*{Child|Sibling}* methods
2017-12-14 dsinclair Change CXFA_Node::GetChild to return proper types
2017-12-14 rharrison Reduce XFA image fuzzer size limit to 64MB
2017-12-14 dsinclair Fold CXFA_ScriptData into CXFA_Script
2017-12-14 dsinclair Fold CXFA_SubmitData into CXFA_Submit
2017-12-14 dsinclair Fold CXFA_TextData into CXFA_Text
2017-12-14 dsinclair Fold CXFA_ValueData into CXFA_Value
2017-12-14 dsinclair Fold CXFA_ValidateData into CXFA_Validate

Created with:
  roll-dep src/third_party/pdfiumBUG=794351


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I5d6fcd65e6263a4523da381a114de118e0e1b2c3
Reviewed-on: https://chromium-review.googlesource.com/827787
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524211}

This reverts commit f174f4de.

Reason for revert: Breaks apk_merger.py (see bug)

Original change's description:
> Reland "Use Aapt2 for final apk resource packaging"
> 
> This reverts commit db213ff6.
> 
> Reason for reland: Downstream issue fixed. No changes here.
> 
> This CL makes aapt2 perform the final resource processing and packaging for an
> apk as well as outputting proguard files.
> 
> TBR=agrieve
> 
> Bug: 782316
> Change-Id: I1b35f49f2e4b4d503cc7ae07dabc18d9014abea5
> Reviewed-on: https://chromium-review.googlesource.com/817377
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: agrieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523456}

TBR=tedchoc@chromium.org,agrieve@chromium.org,ctzsm@chromium.org,mheikal@chromium.org

Bug: 782316
Change-Id: Idd57f012b1bc32330c9659e9d63fba5eec27615d
Reviewed-on: https://chromium-review.googlesource.com/827900Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524210}

If the slide-down top-chrome is available in fullscreen mode then we
don't need to show the fullscreen exit UI since the user can use the
top-chrome to exit fullscreen.

Bug: 758456
Change-Id: I1298279ca97e5fea00629e888e6a56ade23bc67f
Reviewed-on: https://chromium-review.googlesource.com/827608Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524209}

The move allows returning
ContentBrowserClient::GetOriginsRequiringDedicatedProcess from
SiteIsolationPolicy::GetIsolatedOrigins.

No expected behavior change.

This is a "reland" of r521893 (which got reverted in r521907).

Bug: 792162
Change-Id: I87cd203a12f1f5784dd9aa2745064a2b96532336
Tbr: alexmos@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/827537Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524208}

Partial revert of commit 8f1e606d,
which introduced a crash in ash when opening the keyboard shortcuts
viewer from the keyboard settings webui. The code that caused the crash
was reverted separately to make it easier to backport.

More generally, any mojo interface Foo in ash that has both a persistent
client (a SetClient() method) and other methods (a DoBar() method)
might end up with multiple bindings:
* The persistent binding from FooClient in chrome
* A temporary binding from other code in chrome that happens to
request the Foo interface and call DoBar

I've reverted most of the places I changed, since new code might add
calls to DoBar() methods outside of FooClient, and in general I think
we should support that use case. (Otherwise we have to route all
calls in chrome through FooClient::Get()->DoBar() wrapper methods,
which isn't desirable in general.)

Bug: 794581
Test: ash_unittests, chrome unit_tests and browser_tests, manually open keyboard shortcut overlay from webui settings > keyboard section
Change-Id: I3d974b459f60f7a720d7d345862af8197ddb37df
Reviewed-on: https://chromium-review.googlesource.com/825959
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524207}

Update Hosting Side nav contained updates related to hosting released in 2014.
This documentation outlines the updated standard and re-organizes the sidebar.

Bug: 
Change-Id: I0496ca0a4fb2c56fdfda8ba31dbf869851713ed1
Reviewed-on: https://chromium-review.googlesource.com/722062
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524206}

BUG=794769

Change-Id: I43530b4b5ec76ab60ede516e8f736e85956270f4
Reviewed-on: https://chromium-review.googlesource.com/826567Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524205}

This change refactors the existing CanvasResource_Skia to make it
store a StaticBitmapImage instead of an SkImage intenally. This
simplifies the gpu mailbox management code by re-using the
functionality provided by StaticBitmapImage. It also bring the code
closer to unifying OffscreenCanvasResourceProvider with
CanvasResourceProvider

BUG=788439,776801
TBR=bajones@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia57a68e1a61763daa158403e258b89b56a82a6f7
Reviewed-on: https://chromium-review.googlesource.com/820251
Commit-Queue: Justin Novosad <junov@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524204}

pingback will also have this information

Bug: 793373
Change-Id: I0c999c35b5e968f6b2e19696a08a722b3399d0d9
Reviewed-on: https://chromium-review.googlesource.com/823176Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524203}

This removes its use of the ClientSharedBitmapManager in the renderer
process, freeing up one use toward removing it. This also means the
Display in the SynchronousLayerTreeFrameSink will not allocate shared
memory for RenderPass resources, as the ServerSharedBitmapManager will
use normal memory allocations.

R=boliu@chromium.org

Bug: 730660
Change-Id: Ibb05a8f1787a221351232907704412c5b682e85f
Reviewed-on: https://chromium-review.googlesource.com/826182Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524202}

Bug affects java targets with no deps.

Change-Id: I3b85d3a1affcdf9996743d9ff6bf304753af992c
Reviewed-on: https://chromium-review.googlesource.com/827726Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524201}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e8d8348b857..6e5d5a6a7c91

$ git log 2e8d8348b..6e5d5a6a7 --date=short --no-merges --format='%ad %ae %s'
2017-12-14 jchinlee Kick recipes and add trigger_build file.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: Iadf9305c055701831235f15f2d593be22ff82907
Reviewed-on: https://chromium-review.googlesource.com/827533Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524200}

Threaded versions of the tools make processing code coverage data and generating
code coverage reports an order of magnitude faster. See the experiments data
in https://bugs.chromium.org/p/chromium/issues/detail?id=759794#c34.

Bug: 759794
Change-Id: Ia5776de8d250d2e4bb23de79dd921e22e78a3095
Reviewed-on: https://chromium-review.googlesource.com/825985Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524199}

Fold some small methods that are only called once into their callers.

Change-Id: Ib3e9563113292dc381e0393da09eb6c8f1935088
Reviewed-on: https://chromium-review.googlesource.com/827587Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524198}

BUG=648548
NOTRY=true

Change-Id: If61eef633f510b192dd7587acec5b97709e60f50
Reviewed-on: https://chromium-review.googlesource.com/826127Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524197}

Remove hard-coded benchmark options from story_expection_validator.
Instead, automatically generate default values for these options based
on the parser options provided in the benchmark (i.e., behave as if
the benchmark had been run without providing any additional options).

Change-Id: Id9a49bf7b928c428cd50012866443ed7096a856b
Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>
Reviewed-on: https://chromium-review.googlesource.com/823848Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524196}

fake_platform_sensor_and_provider.h also contains a
MockPlatformSensorClient class, which collides in jumbo
builds.

BUG=794692

Change-Id: Ib3769a25bb0927766757ba5b37ec99fc4f15768f
Reviewed-on: https://chromium-review.googlesource.com/827766Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#524195}

This tracks per host data savings for offline previews as well as
cleaning up the code somewhat.

Bug: 794642
Change-Id: I2660beeee2c6ef8f7939eff4861b78203dab63d6
Reviewed-on: https://chromium-review.googlesource.com/825362
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524194}

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I27c2689ebf8b4c5027cb272cf8359f68a6e2918a
Reviewed-on: https://chromium-review.googlesource.com/822234
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524193}

Disable flaky smoothness.tough_texture_cases story on Android One

TBR=vmiura@chromium.org, nednguyen@google.com

Bug: 795060
Change-Id: I9dbaa1e3563b60ad95f20f4ee18935637ee09925
Reviewed-on: https://chromium-review.googlesource.com/827530Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524192}

This is a reland of 5fc3b9d0
Original change's description:
> [DevTools] Implement waitForDebugger for OOPIFs
>
> Using NavigationThrottle for this. Since during throttling
> the navigation has not committed yet, we have to create
> agent host for soon-to-be-committed frame in advance.
>
> Bug: 750901
> Change-Id: I88dbd982481b88eeec36209b6bf3ad7f74863200
> Reviewed-on: https://chromium-review.googlesource.com/818076
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#523835}

TBR=pfeldman

Bug: 750901
Change-Id: I96e6c083aa0de96799fbd4a529ae97019738ed87
Reviewed-on: https://chromium-review.googlesource.com/826318Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524191}

1. Stopped using the value attribute to hold the inner text of spin buttons and other range controls because this could result in showing the inner text as the control's value which, depending on the control's author, could be totally meaningless. For spin buttons, now the value attribute only holds the contents of aria-valuetext if present.
2. Took the opportunity to write some more tests and clean up some of our Blink code.
R=dmazzoni@chromium.org, aleventhal@chromium.org

Also: 
Bug: 792056
Change-Id: Ib4eb98c2c1a351f40e2ac144b1967142040f0675
Tested: manually with dropdowns on kayak.com, browser tests, sample HTML snippet of an ARIA spin button
Reviewed-on: https://chromium-review.googlesource.com/823136
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524190}

Add a test for German time format (12hr with AM/PM marker).

It has 3 changes:

 https://chromium.googlesource.com/chromium/deps/icu.git/+log/e3b480d..94d819f

 2017-12-13 jshin@chromium.org Update German AM/PM marker to the previous value
 2017-12-13 jshin@chromium.org Cherry-pick an upstream fix for UTF8 to UTF8 conversion
 2017-12-12 jshin@chromium.org Cherry-pick an upstream fix for Calendar class

Bug: 794737,794390,792537
Test: base_unittests --gtest_filter=TimeFormat*.*TimeOfDayDE
Test: crbug.com/794737#c2
Change-Id: Ifa6d31624cbd9d4edc1b776e34527d8e842f7290
Reviewed-on: https://chromium-review.googlesource.com/826363
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524189}