- 11 Mar, 2020 40 commits
-
-
Eriko Kurimoto authored
This CL removes mixed-content wpts for cross-origin workers. Cross-origin workers are not allowed regardless of its security policy, so there is no need to test it. The auto-generator was unintentionally changed to be able to delete cross-origin workers wpts in the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2049953 but, the previous CL didn't appropriately delete these tests. This CL actually deletes such tests. (generator.py is not changed.) It is discussed here: https://chromium-review.googlesource.com/c/chromium/src/+/2077319/8/third_party/blink/web_tests/external/wpt/mixed-content/gen/top.meta/opt-in/sharedworker-module/cross-http.no-redirect.https.html#b1 Bug: 906850 Change-Id: I50570a1d41437e7212655252c2f3eae4042dce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097682 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#749081}
-
Xiaocheng Hu authored
This patch ensures that an 'optional' web font never causes relayout: - When document rendering starts, any 'optional' web font that hasn't been loaded enters the failure period directly. - When an @font-face rule is added, if document rendering has started and the font is not available from memory cache, then it enters the failure period directly. In this way, any element attempting to use such 'optional' fonts will always use a font that's further down in the 'font-family' list during the document's lifetime. Bug: 1040632 Change-Id: Idde675a8dddadf15d22c13b95db649410fd9cd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057502Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749080}
-
Eugene But authored
The test is likely crashing because of out of bounds exception. Using ASSERT_EQ instead of EXPECT_EQ should stop the test before accessing invalid index. This CL does not fix the failing test, it just replaces crash with a graceful failure. Bug: 1060251 Change-Id: I214a4aae84274f5c191ad665c906743cc3f856d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094709 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#749079}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fd848c18..576a8e97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idcec69857e2dc97746f15056058f5feca3418dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097080Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749078}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/715c8c459f00..af976e22c803 git log 715c8c459f00..af976e22c803 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-03-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@af976e22c803 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ied4f9144124e054e5ab8229452171deab417fc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749077}
-
Tomasz Moniuszko authored
BUG=1060156 TEST=events_unittests --gtest_filter=XEventTranslationTest.* Change-Id: I8e26af89d45edb24027a2d53c7b25cbe824bf0b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096640Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Cr-Commit-Position: refs/heads/master@{#749076}
-
Donna Wu authored
Remove the TODO as the union type has been supported in the bindings generator. BUG=520391 Change-Id: I709726c9378b739944eebf26ff9b1ccb0b8cd823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093397Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#749075}
-
Joel Hockey authored
Terminal app should only have 1 instance of the settings page open. For now, we will assume that all system web apps will have only 1 instance of a popup, we can make this configurable per app if needed. Bug: 1056983 Change-Id: Ib6414fc0e313beaddccc19f0bb23cedf6ccb4faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094911 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#749074}
-
Luciano Pacheco authored
Change from click event to focusout event so it works for keyboard TAB key too. The fix is the following: 1. Listen to 'focusout' event within the whole search box. 2. Use requestAnimantionFrame() to give a chance to clicking on buttons on the left of the search box to receive the click event before the collapse. 3. Only collpase if the focus moved out of the whole search box. This also fixes issue:1058547. Test: browser_tests --gtest_filter="*searchHidingTextEntryField*" Bug: 1059016, 1058547 Change-Id: I4ad6441d1400e7de629bc6619a3eb69c88b29d50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097775 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#749073}
-
Yutaka Hirano authored
We introduced the virtual test suite to avoid accidental feature shipping, but the test suite is also a source of confusion (e.g., [1], [2]). As we are going to ship the feature soon, I think it's good to remove the test suite now. 1: https://chromium-review.googlesource.com/c/chromium/src/+/2076223/11/third_party/blink/web_tests/virtual/stable/external/wpt/html/cross-origin-embedder-policy/reporting.https-expected.txt#2 2: https://chromium-review.googlesource.com/c/chromium/src/+/2091326/7/third_party/blink/web_tests/virtual/stable/external/wpt/html/cross-origin-embedder-policy/reporting.https-expected.txt#4 Bug: 887967 Change-Id: I37bc19d441216c6af5b1003d0dff63c3181cfa27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096403 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#749072}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/552ddbf3bfe0..96c9784d1a3d git log 552ddbf3bfe0..96c9784d1a3d --date=short --first-parent --format='%ad %ae %s' 2020-03-11 tandrii@google.com Fix OWNERS: full regexps not allowed, it's matched by fnmatch. 2020-03-11 ehmaldonado@google.com subprocess2: Fix CalledProcessError str() method on Python 3. Created with: gclient setdep -r src/third_party/depot_tools@96c9784d1a3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060018,chromium:1060409 Tbr: agable@chromium.org Change-Id: Icc5cd4c8d5c6bb517ef7af78ccf4b173815afb2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097717Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/dbb56a1d4859..e2176c91b23c git log dbb56a1d4859..e2176c91b23c --date=short --first-parent --format='%ad %ae %s' 2020-03-11 johnkslang@users.noreply.github.com Merge pull request #2110 from jeffbolznv/escapeseq Created with: gclient setdep -r src/third_party/glslang/src@e2176c91b23c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: I0535e53ac300e459f9539e6fcf9a43aaf2409e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097719Reviewed-by:
-
Kei Nakashima authored
In this CL, VectorBackedLinkedList is imported to NewLinkedHashSet. Also it removed old code that we can replace by VectorBackedLinkedList. Updated constructor/destructor/assignment operator. Change-Id: Ie0dcfe8751b09bc2547bd206d2d2c38655d406a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094494 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#749069}
-
Dominic Mazzoni authored
Just like in HTML, some nodes in a PDF structure tree need not only the tag name, but also some attributes. This change adds some of the most generally useful: alt text for images, language codes for any element, and various table-related attributes. Bug: 1039816 Change-Id: Ib9c8a768f594bdd61cf5848befa09af290dafdc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090621Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#749068}
-
Simon Que authored
These are the remaining iOS builders in Chromium. They are expected to have under 150 QPS at peak: https://docs.google.com/spreadsheets/d/1-XKh-CqSoUcXEqCETVywjmIo1C18P0qEBDCY50ozBb0/edit#gid=555424423 Schedule of migration: https://docs.google.com/spreadsheets/d/1TZhpasm6iceYm7zqkyEtZ1wn9ZcpREfH4LV4cusICJA/edit#gid=0 Bug: 950413 Change-Id: Id11829b5b9b04e2096ddd2d464b63532b69201f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084035 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#749067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/08d2ab0bcd7e..af79e7a37126 Created with: gclient setdep -r src-internal@af79e7a37126 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1057083 Tbr: jbudorick@google.com Change-Id: I13eec8c400d55ccdb3355da5cae7333841a99387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094629Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749066}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2fe5ee2b3a1..6bc4a7405acc git log c2fe5ee2b3a1..6bc4a7405acc --date=short --first-parent --format='%ad %ae %s' 2020-03-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8be72df60462..16ae92a4ee52 (1 commits) Created with: gclient setdep -r src/third_party/skia@6bc4a7405acc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: I56bcafb8560d4c36b9294b1c34d96ead54d3263a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094634Reviewed-by:
-
Chris Hall authored
- specifying types of constants. - clarifying comment references to functions and variables. - adding `using` aliases to shorten long library type names. - adding explicit type for value returned from library. These changes came out of suggestions from thestig@ on crrev.com/c/1949807 R=thestig, akihiroota, dmazzoni Change-Id: I25fc99843c27f7a41403f15e3e82d688fd5b44fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096417 Commit-Queue: Chris Hall <chrishall@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749064}
-
Eric Willigers authored
We no longer use Extensions APIs to configure the web app to open in a window. Bug: 1054116 Change-Id: I0f05d939d3109eef7bf5de25ae452c52f3361b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096422 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749063}
-
Hirokazu Honda authored
This reverts commit d47ac572. Reason for revert: Cause gpu hang on octopus (b/150964098) Original change's description: > media/gpu/vaapiVEA: Manage VASurfaceID by ScopedID > > VaapiVEA manages VA Surfaces with the ids. They need to be destroyed > by vaDestroySurface(). The ids are pooled for recycling. Some > ids has not returned to the pool, so that they are never > destroyed. This CL fixes the leakage by managing VASurfaceID > by ScopedID. > > Bug: b:143957628 > Test: video.EncodeAccel.* > Test: Open & Record & Close CCA multiple times > Change-Id: I86743fe80973fc3e850d543e38dcfe2764b2a710 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060388 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745351} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,wtlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:143957628, b:150964098 Change-Id: I1bddc70915287d93e1e38ed8a2c8b79ad36f8bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097779Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749062}
-
Koji Ishii authored
This patch rebaselines the last two remaining failures in paint/invalidation. These two tests invalidates more than |NGPaintFragment| does, but are equivalent to the legacy. TBR=wangxianzhu@chromium.org, yosin@chromium.org Bug: 982194 Change-Id: I016043e2c1440319fee9cfaa4011e2014e6e4981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096405Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749061}
-
Noel Gordon authored
Class is cool but attributes are too: when they are concise as here so reader does not have to read so much, and fewer bytes on the wire. Bug: 1035691 Change-Id: I77ed2fdc0e51526719a57f4fc1b168a986320ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097680Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
These macros are used when implementing GObject interfaces to help mitigate accidental misuse of the API. We were using them, but not consistently in the AuraLinux accessibility implementation. This change makes their use more consistent. The original author of this CL is Martin Robinson<mrobinson@igalia.com> Bug: 1032019 Change-Id: I75ee57eea79ab11202924f9b04bd1def78dd5fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096167 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#749059}
-
nancy authored
https://ci.chromium.org/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan/29774 TBR=sky@chromium.org TBR=agawronska@chromium.org BUG=1060430 Change-Id: I0608315ef2b4d8991e6deacd8282a88efc7b4e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096333Reviewed-by:
-
Yoichi Osato authored
This CL fixes the redirect bug that crrev.com/c/2059889 introduced. It removed body copy at redirect in renderer but when OOB-CORS is disabled, we still need body. third_party\blink\web_tests> $ python.exe ..\tools\run_web_tests.py --additional-driver-flag=--disable-features=OutOfBlinkCors external/wpt/xhr/event-upload-progress-crossorigin.any.html .. Fixed: 1059776 Test: Change-Id: I9516719c1e18d8cedcf4e621d8ab3e0157d10844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096161Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#749057}
-
Kent Tamura authored
This improves code readability. This CL has no behavior changes. Bug: 1052232 Change-Id: Ib4b1ed17cc84ac5a29af15003527bed66e5273a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096329Reviewed-by:
-
Fergus Dall authored
Bug: 1024693 Change-Id: I6b6db68ae72ed7eca908706e922092a553e57192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089181Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#749055}
-
John Palmer authored
Bug: 1060433 Change-Id: I8f3dfc2d7d9c56fc6373475a46da7b0cbfa029f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094914 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#749054}
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: Id4bf79d0d2c69566465d73c1cfc42cb47e62c858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096323Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#749053}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3fc1f900e63d4a1a760e7ab857ae38677e16e703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094633Reviewed-by:
-
Takashi Toyoshima authored
These tests inherit CrSettingsV3BrowserTest and override featureList getter. This results in ignoring the network::features::kOutOfBlinkCors enabed in the super class, and causes failing in BlinkCORS fyi bots. TBR=rbpotter@chromium.org Bug: 1026426 Change-Id: Ib194b6ca402af196d5f701cd3bd2cefd920ee6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097676Reviewed-by:
-
Ramin Halavati authored
The following preferences are removed from persistent preferences in incognito mode: - metrics::prefs::kInstallDate/kUnisntall* - metrics::prefs::kMetrics* - metrics::prefs::kStability* - metrics::prefs::k*CellDataUse After this change, if these preferences are written to an incognito profile, they would not be persisted in their regular profile. All of these preferences are already written to local state. Bug: 861722 Change-Id: Iad0df3d31462a8373432d38a591a131ea8e27679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095718 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#749050}
-
Yoshifumi Inoue authored
This patch changes |TextSuggestionController::HandlePotentialSuggestionTap()| not to use null settings from |LocalFrame| for avoiding crash. Note: This is an experimental patch, because we are not sure actual reason about |TextSuggestionController::HandlePotentialSuggestionTap()| is called for document without frame. Bug: 1054955 Change-Id: If852d2e4dcf4cda40303dfea581e79efc3921642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096160 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/430e4a09e0ca..ed678386b4ac git log 430e4a09e0ca..ed678386b4ac --date=short --first-parent --format='%ad %ae %s' 2020-03-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ad5dd080..9a91e044 (748920:749020) 2020-03-10 kron@webrtc.org Add RTC_EXPORT to webrtc::Clock 2020-03-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4fa1454b..ad5dd080 (748775:748920) Created with: gclient setdep -r src/third_party/webrtc@ed678386b4ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011581 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I077a473095a7acb3bd3687c33db7189cf1f078b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096711Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1003942d..fd848c18 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7662520313283cb0e42c967fba72e948f85523df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097636Reviewed-by:
-
Shimi Zhang authored
Found by Tricium in http://crrev/c/2097537 Bug: None Change-Id: I53fedefb2f763bfc57080588eb95c8d07a7ba973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097529 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749046}
-
Takumi Fujimoto authored
Record the following metrics for the native Cast MediaRouteProvider: MediaRouter.CastStreaming.Session.Launch MediaRouter.CastStreaming.Session.Length MediaRouter.CastStreaming.Start.Failure.Native MediaRouter.CastStreaming.Start.Success These metrics are already being recorded by the Cast MRP in the component extension (MediaRouter.CastStreaming.Start.Failure is recorded instead of MediaRouter.CastStreaming.Start.Failure.Native in the extension because their enums are different). Bug: 954565 Change-Id: I476fdf417ccf085d3d122dc10d8ff976c8f8450f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080703Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#749045}
-
Rob Schonberger authored
- Palm Detection when the touchscreen reports the max radius - Palm Detection when the touchscreeen reports a palm itself Both are experimental features and documented as such, and or on by default already, etc. Bug: 1060051 Change-Id: I130c466a03b9a295c1b2777589ffc8a3ea8a5be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094908 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#749044}
-
Jinsuk Kim authored
Permission UI requires a ModalDialogaManager from the associated WindowAndroid instance, which was not available on Preview Tab. This CL overrides |ActivityWindowAndroid.getModalDialogManager| passed to the ThinWebView object of Preview Tab so that the permission UI can be displayed. Verified on a local device that this fixes the reported crash, and shows the permission UI as expected. Bug: 1057951 Change-Id: Ic7745d40edbea466ab1fef2de176743c3fda675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094386Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#749043}
-
Jeevan Shikaram authored
UseLocalPrediction/LoadingPredictorBrowserTestWithOptimizationGuide. NavigationHasLocalPredictionNoOptimizationHint/0 is failing deterministically on linux-chromeos-rel. TBR=tbansal@chromium.org Bug: 1060426 Change-Id: I2c9b0b9781d1d51de8911f34aa7d1bb689416996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097618Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#749042}
-
