GitLab

Remove suppressions for false positives / intentional leaks in Blink code. They
have since been annotated with in-code annotations.

BUG=121729, 242672
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/292663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374838
R=kareng@google.com

Review URL: https://codereview.chromium.org/294113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271708 0039d316-1c4b-4281-b951-d872f2087c98

Hooks up the blink GN build to the main GN build. Android is currently disabled
(some dependencies are not complete yet).

R=eseidel@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/296513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374452
R=benchan@chromium.org, jennyz@chromium.org

Review URL: https://codereview.chromium.org/286923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271706 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271705 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174366:174386&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/298723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271704 0039d316-1c4b-4281-b951-d872f2087c98

This CL moves the New Window API and navigation to chrome.

This CL removes a lot of unnecessary content APIs for BrowserPlugin now that permissions no longer live in content.

Up next, in a separate CL will be a huge cleanup that removes all WebContentsDelegate code out of BrowserPluginGuest and into WebViewGuest. This should significantly reduce the size of the BrowserPlugin content API.

BUG=364141, 330264
TBR=kenrb@chromium.org for trivial browser_plugin_messages.h change.

Review URL: https://codereview.chromium.org/272573005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271703 0039d316-1c4b-4281-b951-d872f2087c98

internal server.

Merge internal change: 67534473

R=rch@chromium.org

Review URL: https://codereview.chromium.org/290893004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271702 0039d316-1c4b-4281-b951-d872f2087c98

BUG=162740
NOTRY=true

Review URL: https://codereview.chromium.org/290493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271701 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=Internal cleanup.

Review URL: https://codereview.chromium.org/288393005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271700 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/295893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None (cleanup only, does not change behavior)

Review URL: https://codereview.chromium.org/278013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271698 0039d316-1c4b-4281-b951-d872f2087c98

Breaks android builder due to PNG corruption from ASCII conversion (same error
as on try job).

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=58007

> Web MIDI: add permission infobar icon for Android
> 
> On Android, permission infobar appears for Web MIDI permission,
> but correct icon is not used. This change add a proper icon.
> 
> Submit with NOTRY=true since it contains binary files and the patch
> fails on try.
> 
> BUG=339767
> NOTRY=true
> 
> Review URL: https://codereview.chromium.org/292743004

TBR=toyoshim@chromium.org

Review URL: https://codereview.chromium.org/291213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271697 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/287063010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271692 0039d316-1c4b-4281-b951-d872f2087c98

Right now TSan doesn't support suppressions for any lock inversion stacks but the top one.

BUG=374135
TBR=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/295933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271691 0039d316-1c4b-4281-b951-d872f2087c98

We need SurfaceFactoryOzone initialized in the GPU process.

TBR=sadrul
NOTRY=true

Review URL: https://codereview.chromium.org/288033019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271689 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally typed "git svn dcommit" instead of "git cl dcommit", which used
my local commit message instead of the CL description. :(

> i

TBR=earthdok@chromium.org

Review URL: https://codereview.chromium.org/289353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271688 0039d316-1c4b-4281-b951-d872f2087c98

The gestures library links jsoncpp, which we link statically. Turn off
fatal-warnings while we sort this out.

BUG=351168
TEST=build --board link_freon
TBR=rjkroege

Review URL: https://codereview.chromium.org/292513003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370497
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/286933005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371845
TBR=rohitrao

Review URL: https://codereview.chromium.org/292513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271685 0039d316-1c4b-4281-b951-d872f2087c98

QtKit doesn't support 1080p, which I found out when I enabled our C920-
equipped mac bot. Therefore we will no longer try to test that.

Also temporarily disabling QVGA for qtkit since it incorrectly acquires
320x180 rather than 320x240.

BUG=375185
TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/295943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271684 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271683 0039d316-1c4b-4281-b951-d872f2087c98

Due to button refactoring patches, we now need to ask views for their
preferred sizes in const methods. Across the entire codebase, the
overwhelming majority of GetPreferredSize() implementations could be
const. There are only a few places where we can't, and they are usually
combining the sizing and layout code.

BookmarksBarView was simple enough to perform this separation. Most of
the other places were solved by adding "mutable" to value caches.

BUG=155363
R=jam@chromium.org, pkasting@chromium.org, scheib@chromium.org, sky@chromium.org, pkasting, sky
TBR=jam, scheib

Review URL: https://codereview.chromium.org/273223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271682 0039d316-1c4b-4281-b951-d872f2087c98

If we don't do this, then the standard frame appears with the blue one
provided by views, presenting two title bars with the same information,
which looks ugly.

BUG=374046
TEST=build views_examples_with_content_exe on Linux, run it. Observe.
The window displayed must have a unique frame, the blue one. See bug for
previous-after screenshots.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/291503006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375178
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/294943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373965
For fake_wifi_service.cc

R=armansito@chromium.org, pneubeck@chromium.org
TBR=mef@chromium.org

Review URL: https://codereview.chromium.org/285233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316551
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/290423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271678 0039d316-1c4b-4281-b951-d872f2087c98

On Android, permission infobar appears for Web MIDI permission,
but correct icon is not used. This change add a proper icon.

Submit with NOTRY=true since it contains binary files and the patch
fails on try.

BUG=339767
NOTRY=true

Review URL: https://codereview.chromium.org/292743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271677 0039d316-1c4b-4281-b951-d872f2087c98

Automove with some manual fixes.

BUG=374214

Review URL: https://codereview.chromium.org/294693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271676 0039d316-1c4b-4281-b951-d872f2087c98

Bookmarks is not a layered component, so there is no need for the two level deep
hierarchy, switch code from components/bookmarks/core/... to components/bookmarks/...

BUG=370434
TEST=components_unittests --gtest_filter=Bookmark*
R=blundell@chromium.org,sdefresne@chromium.org
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/284893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271675 0039d316-1c4b-4281-b951-d872f2087c98

This is required to do some experiments with low buffer size for input audio.

BUG=363958
TEST=manual test with audio-buffer-size flag

Review URL: https://codereview.chromium.org/285233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271673 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271671 0039d316-1c4b-4281-b951-d872f2087c98

Also check that we are root, as non rooted cannot control usb charging.

BUG=375178
R=tonyg@chromium.org

Review URL: https://codereview.chromium.org/292743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271670 0039d316-1c4b-4281-b951-d872f2087c98

The DesktopMediaPicker treats the contents of the DesktopMediaList as an
ordered list of sources. This change ensures the primary display is
always in the first position in the picker.

BUG=372444
TEST=Under ChromeOS connect/disconnect/reconnect secondary screen and
observe that the primary display is in the first position in the picker.

Review URL: https://codereview.chromium.org/283573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271669 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174310:174366&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/291163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375177

Review URL: https://codereview.chromium.org/292113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271667 0039d316-1c4b-4281-b951-d872f2087c98

getComputedStyle() in GWT only works for inline styles, not internal/external
stylesheets.  so add a test in browser instead.

BUG=367243
TBR=blundell

Review URL: https://codereview.chromium.org/278873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372381

Review URL: https://codereview.chromium.org/288913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271665 0039d316-1c4b-4281-b951-d872f2087c98

Remove ResourceMetadataStorage::PutCacheEntry, RemoveCacheEntry and GetCacheEntryIterator. (GetCacheEntry is kept for tests)
FileCache::ClearAll is only responsible to delete files.

BUG=275271
TEST=unit_tests

Review URL: https://codereview.chromium.org/296463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271664 0039d316-1c4b-4281-b951-d872f2087c98