- 06 Dec, 2017 40 commits
-
-
Alice Boxhall authored
Bug: 514674 Change-Id: I60aa5d38cb31b52f74a053f2dd35a5db675a2fea Reviewed-on: https://chromium-review.googlesource.com/627346 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522125}
-
Xiaohan Wang authored
This is not required now after https://chromium-review.googlesource.com/c/chromium/src/+/802274 BUG=788937 Change-Id: I9a17610a9185a3a73fe59b3c0d64a35a13f8d41a Reviewed-on: https://chromium-review.googlesource.com/809391Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#522124}
-
Morten Stenshorne authored
multicol-rule-style-foo were covering exactly the same thing that multicol-rule-foo did. Bug: 788337 Change-Id: I4102a21194a6f99e595930054655f7aaeace432e Reviewed-on: https://chromium-review.googlesource.com/811164Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522123}
-
Benjamin C. Wiley Sittler authored
Use mutable DataTransferItemList instead of eventSender, drag-n-drop, CGIs, or Unicode files on the host filesystem to exercise multipart form file upload filename encoding. Add separate non-upload tests for dragging Unicode-named files from the host filesystem onto <input type=file>. This also stops relying on script-triggered onchange for input type=file, it may be a bug - see crbug.com/792336 for discussion. Finally, this re-fixes the out-of-process IFRAME breakage reintroduced in https://crrev.com/521947 Technique from: https://github.com/whatwg/html/issues/2861#issuecomment-348888148 Bug: 661819 Bug: 786539 Change-Id: I7d6c9d03770759d1552a4456d869eb544cb652a0 Reviewed-on: https://chromium-review.googlesource.com/807465Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Cr-Commit-Position: refs/heads/master@{#522122}
-
Carlos IL authored
ssl_info now has a boolean is_fatal_cert_error flag. Flag gets populated in GetSSLInfo. Separate |should_ssl_errors_be_fatal| bool was removed from NavigationURLLoaderDelegate::OnRequestFailed and its overrides. Bug: 783262 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: If95f1ba06aeea177276cf10eac6b2a0484dfebbc Reviewed-on: https://chromium-review.googlesource.com/778042Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#522121}
-
Peter Wen authored
Use object_path and source_path from .o.whitelist files to find the right paths for each pak symbol. Refactor and generalize aliases/coalescing for all symbols. Bug: 723672 Change-Id: I8a0385241ffc60334bee981a98566e46954884d7 Reviewed-on: https://chromium-review.googlesource.com/807147 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#522120}
-
Elly Fong-Jones authored
This change: 1) Allows the text labels on checkboxes and radiobuttons to line-wrap instead of truncating; 2) Forces the content setting bubbles to the smallest width in Harmony mode. Bug: 787755 Change-Id: I7c823bc7e0c504935cbd210893001c1ff8c060ec Reviewed-on: https://chromium-review.googlesource.com/796452Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#522119}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/1946aaf15ca0..cad08c855e23 $ git log 1946aaf15..cad08c855 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 kjlubick Fix infra tests Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I4f9c8ebd4a3de8e1dde07e937d08a2ba9cea9db1 Reviewed-on: https://chromium-review.googlesource.com/810885Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522118}
-
Wez authored
Previously the tests would wait up to four times in the ExpectWorkerCapacityAfterDelay() helper function, which leads to them flaking sometimes under systems with heavy load, or systems running under slow emulation, such as QEMU. We now allow the test to wait indefinitely, provided that the capacity of the worker pool is stable, or increases. Bug: 792310 Change-Id: Ida8aa3abbb2d290771f74a7aae4ba7fe5c2176a0 Reviewed-on: https://chromium-review.googlesource.com/809710Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#522117}
-
Guido Urdaneta authored
This adds an implementation of the GetDefaultInputDeviceID() method for AudioManagerCras. Bug: 780492 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icbd00994c5b4d3008946b59eabadca7685aed9aa Reviewed-on: https://chromium-review.googlesource.com/810767Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#522116}
-
Gauthier Ambard authored
This CL makes sure the location bar has the border only during animations and when the it is contracted. Bug: 791460 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I12f1edcfe7e1c674b07826ed9e01c46c4cdee8e2 Reviewed-on: https://chromium-review.googlesource.com/809152Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#522115}
-
Lalit Maganti authored
Bug: 768373 Change-Id: I86bd1670ebcd82a5d61283d28eb757f0da57b58e Reviewed-on: https://chromium-review.googlesource.com/776880Reviewed-by:
Primiano Tucci <primiano@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#522114}
-
Chris Pickel authored
If it's NEW_WINDOW, turn the doodle into a SIMPLE doodle. Bug: 761998 Change-Id: Ida81f4dfaf920c42594b76d442403324d3f493ad Reviewed-on: https://chromium-review.googlesource.com/808972Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#522113}
-
Allen Bauer authored
Bug: 790555 Change-Id: Id64b81c88908adce55d47537ddd0744bfdefc857 Reviewed-on: https://chromium-review.googlesource.com/806256Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#522112}
-
Sebastien Marchand authored
Bug: 759092 Change-Id: I90b5ce6debcbd9f90e944f7c704d798f44a81998 Reviewed-on: https://chromium-review.googlesource.com/811144Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#522111}
-
John Abd-El-Malek authored
This is done by switching from net::URLRequestMockHTTPJob to using net::test_server::EmbeddedTestServer. Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8cf56477956ac64c70ba65221a1c248f39ff7944 Reviewed-on: https://chromium-review.googlesource.com/810205 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#522110}
-
Ethan Kuefner authored
This CL enables the aforementioned two benchmarks on our histogram FYI testing bot. We also remove smoothness.key_silk_cases since that's a mobile-only benchmark. Bug: 744736 Change-Id: I65c21d8769625a34b73d038c093c1b472eacd3ee Reviewed-on: https://chromium-review.googlesource.com/808667Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#522109}
-
Henrik Boström authored
Refactoring. Will do the same pattern for ReplaceTrack. Bug: 790007 Change-Id: Iadd661a839fed870fd423692ca553ec506413f8b Reviewed-on: https://chromium-review.googlesource.com/808284 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#522108}
-
Max Morin authored
In case the compressed data that is sent to the browser is larger than the allocated buffer, we shouldn't try to use the buffer. We should also be a bit careful with the bitstream_frames field, since it comes from an IPC call and thus isn't trustworthy. Bug: 792422 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1f6c02a4947b593375575da659573b1a93b93bd3 Reviewed-on: https://chromium-review.googlesource.com/810604Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#522107}
-
Chris Mumford authored
1. Returned more specific errors in OnHandleReady/TransferSomeBytes. 2. Described returned errors in header documentation. 3. Not mapping MOJO_RESULT_ALREADY_EXISTS as that will not be returned. Bug: none Change-Id: Icaa78bd347995c175cc50eb807d9a400d21e96e4 Reviewed-on: https://chromium-review.googlesource.com/809324Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#522106}
-
Łukasz Anforowicz authored
This reverts commit 39603d88. Reason for revert: This CL has caused renderer kills during CrOS login - see https://crbug.com/792500 Original change's description: > Reject IPC requests for isolated origin, sent by non-isolated renderer. > > The CL tweaks StoragePartitonInterceptor (in > isolated_origin_browsertest.cc) so that it can be configured to inject > different origins, depending on needs of individual tests. This tweak > is supported by changes in base/lazy_instance.h (adding of inequality > operator implemented on top of the already existing equality operator), > and in render_process_host_impl.cc/.h (to support creating a test-only > StoragePartitionService via a base::Callback, rather than via a function > pointer). > > Tweaks of StoragePartitonInterceptor allow forking of > IsolatedOriginTest.LocalStorageOriginEnforcement test into 2 separate > tests: > - LocalStorageOriginEnforcement_IsolatedAccessingNonIsolated > - LocalStorageOriginEnforcement_NonIsolatedAccessingIsolated > The second test is introduced by this CL and was failing before this CL. > > Tweaks of ChildProcessSecurityPolicyImpl::CanAccessDataForOrigin > disallow requests from non-isolated renderers (in which case > CheckOriginLock will return NO_LOCK) if the request is for > an isolated origin. This makes the new test pass. > > Bug: 509125, 764958 > Change-Id: Ibfff2c91cb2ac51966e1d89295f10592a3814c08 > Reviewed-on: https://chromium-review.googlesource.com/775060 > Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521838} TBR=thestig@chromium.org,alexmos@chromium.org,lukasza@chromium.org Change-Id: Id395a4be8f2127f2fbdc7e4f75e0fbd05272012f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 509125, 764958 Reviewed-on: https://chromium-review.googlesource.com/810986Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#522105}
-
Fredrik Söderquist authored
(last use probably removed by https://codereview.chromium.org/2750293003 and similar earlier CLs.) ShadowList: :Blend and BasicShape::Blend/CanBlend are no longer used Change-Id: I3d9690768f64fa8c602b55cb1a0bf8654100e04c Reviewed-on: https://chromium-review.googlesource.com/809012Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#522104}
-
Morten Stenshorne authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3ad8e07a5b15d0e0c1b8549d5c9397a9b0ca812f Reviewed-on: https://chromium-review.googlesource.com/809154Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522103}
-
Dmitry Gozman authored
This removes unneeded abstraction and plumbing and reduces dependencies from core/page to former Web classes which will be gone at some point. Bug: none Change-Id: Id637a60132687b26a438342cfc38cf86828307ee Reviewed-on: https://chromium-review.googlesource.com/772902Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522102}
-
Marc Treib authored
As of https://crrev.com/c/790511, this code isn't built on Android anymore. This also adds compile-time checks to many Instant headers to make sure they're not accidentally built on Android. Bug: 787830 Change-Id: I88026ce703158ac5b1580f02e621dea325a6fd64 Reviewed-on: https://chromium-review.googlesource.com/803280 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#522101}
-
Fady Samuel authored
If a view is shown then it should have a primary surface. Today, the primary surface may be lost due to frame eviction but we don't re-set it on showing a view and so it was possible to end up with an empty tab. Bug: 672962, 791342 Change-Id: I0ade2a58e9b78e82011e81af441a406b872b7710 Reviewed-on: https://chromium-review.googlesource.com/809935Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#522100}
-
Fabio Tirelo authored
Bug: Change-Id: I51c7f5c4b508b2846ba7af0feeee8085ca5e362c Reviewed-on: https://chromium-review.googlesource.com/810054Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#522099}
-
Becca Hughes authored
Move the UA resource counter into ImageResource itself. This means it will always line up with the corresponding Resource counter and there is no chance of a miscount. BUG=790979 Change-Id: Icbb514b151cf9b2800807e3a201db51bdd506076 Reviewed-on: https://chromium-review.googlesource.com/803347 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#522098}
-
deejay authored
According from ARIA 1.1 [1], default values for aria-valuenow were changed as below. - scrollbar, slider : half way between aria-valuemin and aria-valuemax - separator : 50 - spinbutton : 0 [1] https://www.w3.org/WAI/ARIA/wiki/ARIA_1.1_Changes BUG=768126 Change-Id: I670ea1a0c940665161598b0b3e81bcbe1583419a Reviewed-on: https://chromium-review.googlesource.com/652091 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522097}
-
Morten Stenshorne authored
I'm not sure what this test really provides. The name suggests that it has something to do with column rules, but there are no column rules defined. There is something that looks like rules, but they are in fact absolutely positioned boxes placed in the middle of the column gaps. Anyway, let's at least use the same offsets in the test and in the ref, instead of being slightly off. Bug: 788337 Change-Id: Ic6a07e7020d54e545413c1c7a68f5acdd52019a4 Reviewed-on: https://chromium-review.googlesource.com/810966Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#522096}
-
Jeremy Roman authored
Bug: 791121 Change-Id: Ief7110aae72a25201af687e03c82a88821fd7a2b Reviewed-on: https://chromium-review.googlesource.com/809906Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#522095}
-
Luna Lu authored
1. Vibrate features: Nav / safe browing team would like to collect URLs where vibrate is used when: a. from the top frame or iframe (ads); b. vibrate with user gestures. 2. Touch events: understanding reasons where scrolling is prevented without using touch-action. Features listed above all have shown <1% of page views from chromestatus.com and satisfy UKM privacy constraints. Bug: 706389, 123004 Change-Id: I3d2d48e1e7703d2cc4c05c35b7d4ba6d613d1ca7 Reviewed-on: https://chromium-review.googlesource.com/801754 Commit-Queue: Luna Lu <loonybear@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#522094}
-
Hui(Andy) Wu authored
Many web sites set autocomplete to wrong tel types. For example, they set it to tel but then expects a national number(Sephora.com). This change overrides all fields with autocomplete attribute set to tel/tel-* with server predictions, as long as server thinks it's a phone number field as well. Bug: 791569 Change-Id: If2c8bea2e0f7d1fed71f019d4756670e62e8ce1c Reviewed-on: https://chromium-review.googlesource.com/809092 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#522093}
-
liberato@chromium.org authored
This CL removes the WIP D3D11 VDA in favor of the D3D11 Mojo Video Decoder WIP. Bug: 775577 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie84276b35e274dff5e271be7ecad25e59ea4e7c3 Reviewed-on: https://chromium-review.googlesource.com/806237 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#522092}
-
Mohamad Ahmadi authored
These methods are repeated in AutofillDriverIOSBridge and invoked in AutofillDriverIOS. They're never invoked in AutofillClientIOS. Change-Id: I9f8f6401d7680b3cfcbe98f6d85748f1bea4e280 Reviewed-on: https://chromium-review.googlesource.com/809664Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#522091}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/f9af55641a6d..1946aaf15ca0 $ git log f9af55641..1946aaf15 --date=short --no-merges --format='%ad %ae %s' 2017-12-06 kjlubick Disable ThermalManager for Nexus5x Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I5d9cba8dc120bd45ba413943d8f8df03148a32f0 Reviewed-on: https://chromium-review.googlesource.com/810924Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#522090}
-
Mikel Astiz authored
The use of WaitForGetFavicon() is unnecessary and misleading because it introduces a nested runloop where many things can happen, including model changes that call BookmarksMatchVerifierChecker::IsExitConditionSatisfied() and hence make it reentrant. It is unnecessary because, starting with 55b3fe20, a loading favicon is guaranteed to ultimately notify a model change, which will trigger MultiClientStatusChangeChecker::OnStateChanged() and hence IsExitConditionSatisfied(). Bug: 783774 Change-Id: I02c7623e3bb173b25b9c715b7bdf9c646300e3ee Reviewed-on: https://chromium-review.googlesource.com/785091 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#522089}
-
Dave Tapuska authored
Repurpose spell checking code that was testing for the mojo channel to common code. Write a test that causes the showGuessPanel selector to be sent and verify the panel is requested to be shown. BUG=782836 Change-Id: I9d8ac59ac3bf96bbcd7e538f794eac71e0bc7553 Reviewed-on: https://chromium-review.googlesource.com/786260 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#522088}
-
stkhapugin@chromium.org authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/7f8fefabedf2..f1a87d73fc60 $ git log 7f8fefabe..247a3d8e5 --date=short --no-merges --format='%ad %ae %s' 2017-11-07 whame@users.noreply.github.com Fixes issue #826 by treating MinGW as "non-Windows" when determining colored output 2017-10-29 thielen@hs-worms.de remove markdown stars (bold) from code examples 2017-10-25 arkady.shapkin@gmail.com Enable CI for VS2017 2016-10-21 romain.geissler@gmail.com Remove gcc 6 misleading indentations. 2017-06-08 arkady.shapkin@gmail.com Fix gmock tests when std::unary_function unavailable 2017-05-03 arkady.shapkin@gmail.com Fix tests with VS2015 and VS2017 2017-05-03 arkady.shapkin@gmail.com Enable C++11 features for VS2015 and VS2017 2017-10-17 manojgupta@google.com googletest: Add GTEST_API_ attribute to ThreadLocal class. 2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://goo.gl/d5eV8o 2017-10-18 gennadiycivil@users.noreply.github.com Revert "Workaround for Travis issue https://github.com/travis-ci/travis-ci/is…" 2017-10-18 gennadiycivil@users.noreply.github.com Workaround for Travis issue https://github.com/travis-ci/travis-ci/issues/8552 2017-10-14 dariusz.ostolski@gmail.com #1282: Doc typo fix 2017-10-07 joe@robotgoblin.co.uk Updated README with information about C runtime dynamic/static linking issues in Windows 2017-09-27 jwakely@redhat.com Use gender-neutral pronouns in comments and docs 2017-09-21 gennadiycivil@users.noreply.github.com Revert "Allow macros inside of parametrized test names." 2017-09-19 stkhapugin@chromium.org Swap reinterpret_cast for static_cast 2017-09-16 benjamin.kircher@gmail.com Remove redundant declaration 2017-09-14 31530391+ly2048@users.noreply.github.com Add explicit `CMAKE_DEBUG_POSTFIX` option 2017-09-01 sokolov@google.com Make the failure messages from EXPECT_EQ and friends actually symmetric, 2017-09-08 31780593+yursha@users.noreply.github.com Fix ellipsis position in examples 2017-09-07 thielen@hs-worms.de use GTEST_ATTRIBUTE_UNUSED_ instead of dummy function 2017-09-07 gaspardpetit@gmail.com Removed flush scopes around GTEST_LOG(FATAL) and exit call since FATAL is expected to abort() 2017-09-05 thielen@hs-worms.de remove unused variables from travis environment 2017-09-05 thielen@hs-worms.de drop unused valgrind package from installation 2017-09-05 thielen@hs-worms.de reset ccache statistics at install 2017-09-05 thielen@hs-worms.de show ccache statistics in log 2017-09-05 thielen@hs-worms.de call clang via ccache on Linux 2017-09-05 stkhapugin@google.com add a cast 2017-09-05 thielen@hs-worms.de remove obsolete link_directories command 2017-09-04 thielen@hs-worms.de limit processors to use in Travis build to 4 2017-09-04 thielen@hs-worms.de install ccache on travis osx build slave 2017-09-04 thielen@hs-worms.de set MAKEFLAGS to use multiple processors on Travis CI 2017-09-02 thielen@hs-worms.de cache ccache 2017-08-30 thielen@hs-worms.de avoid warning about unused variable 2017-09-04 thielen@hs-worms.de avoid -Wshadow warning on GCC 2016-02-10 bauerb@chromium.org Add a non-parametrized test. 2016-02-04 bauerb@chromium.org Allow macros inside of parametrized test names. 2017-08-30 thielen@hs-worms.de treat all warnings as errors for GCC (-Werror) 2017-08-30 thielen@hs-worms.de switch one build to Release mode 2016-12-30 lebedev.ri@gmail.com CMake: use threads if allowed and found, not just if found. 2017-08-31 thielen@hs-worms.de change links from former code.google.com to current github repository 2017-08-31 thielen@hs-worms.de fix example's comment 2016-09-05 arkady.shapkin@gmail.com AppVeyor MinGW-w64 test build 2017-08-30 thielen@hs-worms.de create different python based tests for single and multi configuration build generators 2017-08-30 thielen@hs-worms.de Revert "ask cmake for per-configuration output subdir" 2017-08-30 thielen@hs-worms.de ask cmake for per-configuration output subdir 2017-08-30 thielen@hs-worms.de remove obsolete comment regarding python tests on linux 2017-08-30 thielen@hs-worms.de use upper-case build type 2017-08-30 thielen@hs-worms.de use build type set in .travis.yml 2017-08-29 thielen@hs-worms.de remove non-existing gmock_build_samples switch 2017-05-09 thielen@hs-worms.de remove unused TestCase import 2017-08-14 gaspard.petit@eidosmontreal.com Removed extra colon in error log 2017-08-14 gaspard.petit@eidosmontreal.com Use GTEST_LOG instead of printf 2017-07-02 chehsunliu@gmail.com Update googletest README.md 2017-02-13 olivier.clavel@gmail.com googlemock version must be changed as well 2017-02-13 olivier.clavel@gmail.com Wrong version reported (1.7.0 should be 1.8.0) 2016-10-08 adriyetichaves@gmail.com Fix WhenSorted() documentation example 2016-08-30 claus.stovgaard@gmail.com Moved the ignoring of *.pyc files to top level for also covering googlemock python scripts. 2016-05-22 tobbi.bugs@googlemail.com Performance fixes reported by cppcheck Created with: roll-dep ./src/third_party/googletest/src Bug: Change-Id: I72edf5c1ec21f34aab852f661fec6a58bedbd365 Reviewed-on: https://chromium-review.googlesource.com/681214 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#522087}
-
Egor Pasko authored
Update to the new way of getting the HTTP and HTTPS ports for the WebPageReplay server, which was introduced in: https://chromium-review.googlesource.com/c/catapult/+/796863 Bug: 792421 Change-Id: I62b8b18043aff03781fcfba2ac63eaf0e5921b28 Reviewed-on: https://chromium-review.googlesource.com/810967Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#522086}
-