- 19 Oct, 2017 40 commits
-
-
Peiyong Lin authored
This patch introduces mojo interface for each existing coordination unit, defines and implements the APIs for sending signals to coordination unit. This patch is part of the progress to make sure coordination unit in resource_coordinator/ strongly typed. See https://chromium-review.googlesource.com/c/chromium/src/+/719516 for a fully working prototype. BUG=775691 Change-Id: I2677920f07dafe3334a09a945e0d4e19266de319 Reviewed-on: https://chromium-review.googlesource.com/724186 Commit-Queue: lpy <lpy@chromium.org> Reviewed-by:
Zhen Wang <zhenw@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509997}
-
Yoshifumi Inoue authored
This patch makes |LayoutSelectionTest.TraverseLayoutObjectCrossingShadowBoundary| simpler for improving code health. Change-Id: Ic56df2cea300977358843e27f6838856548382cb Reviewed-on: https://chromium-review.googlesource.com/702077Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509996}
-
Koji Ishii authored
This patch changes LayoutNGPaintFragments to be enabled only for blocks with inline children. NGPaintFragment is generated only for where NGBlockFlowPainter should be used, and producing its descendants stops at the block layout boundary. BoxType() is re-worked to set from NGFragmentBuilder because kOldLayoutRoot is not computable from LayoutObject. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5d46167ddf53ffdde591035829ef0d4b8d3d79c5 Reviewed-on: https://chromium-review.googlesource.com/725008 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#509995}
-
Reilly Grant authored
This change removes the additional "context enabled" feature for the MojoJSTest bindings and instead simply modifies the base class for all WebUI browser tests to add a command line flag enabling these bindings. This enables the bindings in all renderers launched by such tests but that is okay. Bug: 775760 Change-Id: I36ec28aed07ff9bcf46228f9828e157c96222723 Reviewed-on: https://chromium-review.googlesource.com/727477Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#509994}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/eac03014e564..aa5c70636f61 $ git log eac03014e..aa5c70636 --date=short --no-merges --format='%ad %ae %s' 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ d0ef13a25..23e028432 (1 commit) Created with: roll-dep src/third_party/skia BUG=765919 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ide992249b98f15365bde945b35d0da5c595a721c Reviewed-on: https://chromium-review.googlesource.com/726824Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509993}
-
Wez authored
This reverts commit c2a865c7. Reason for revert: This causes some IPC and Mojo tests to start failing (see crbug.com/776242). Original change's description: > [fuchsia][mojo/edk] Clone FD if transfer fails > > When trying to send a platform handle represented as a file descriptor > cross-process on Fuchsia, we attempt to transfer the FD in-place which > is more efficient than the usual clone + send + close pattern. In some > cases the transfer operation fails, however, so we have to make a fresh > clone to transfer. > > Bug: 776163 > Change-Id: I6d25e19ee7fef194261f5d1e624a4d8de291d6b3 > Reviewed-on: https://chromium-review.googlesource.com/727121 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#509951} TBR=wez@chromium.org,jamesr@chromium.org Change-Id: Icd42bdf3e3d7438b486fd24d4aee5b7d25be32b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 776163, 776242 Reviewed-on: https://chromium-review.googlesource.com/727027Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#509992}
-
Lei Zhang authored
It does not need both a bool success value and an error base::Value. base: :Value can already represent a none type on its own. Change-Id: Ie329126ae026a2b489552efac2f5c56ba181055d Reviewed-on: https://chromium-review.googlesource.com/703864Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#509991}
-
Joel Einbinder authored
Puppeteer issue: https://github.com/GoogleChrome/puppeteer/issues/777 Bug: none Change-Id: Ib823af902263c7993978498174348fff28b47e1e Reviewed-on: https://chromium-review.googlesource.com/714280Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#509990}
-
Lei Zhang authored
The existing implementation took a raw base::Value* pointer and depended on a comment to explain ownership semantics. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79aeea59537056350bb87f37ca2f458b28f46484 Reviewed-on: https://chromium-review.googlesource.com/722352 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#509989}
-
Ella Ge authored
In this patch, we remove truncation in WebInputEvent builder. Use gfx::pointF in GetScreenLocation from ui::LocatedEvent to get fractional PositionInScreen. Add float coordinates conversions. Includes conversions in ui/ash part. (they are override functions of virtual function in screen_position_client.h) This CL doesn't expose the fractions to the web because of truncation in later stages in event pipeline. Bug: 456625 Change-Id: Ie1573cc8c059542f3fe07ce9c88b8c12c657ff96 Reviewed-on: https://chromium-review.googlesource.com/691338Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#509988}
-
Evan Stade authored
{Profile}NotifierGroup had one purpose, which was to separate notification settings from different profiles on Win-ash. ChromeOS doesn't mix notification settings from different profiles and only shows those from the active user, so they're not needed. MessageCenterSettingsController is only used by NotifierSettingsView, which now only compiles on ash/. Hence it can be ChromeOS only now (although it's still difficult to move to ash/). This class gets a lot simpler. Other random cleanups: - move more code into NotifierController - cut NotificationUiManager out of the settings provider initialization loop; instead set it directly on MessageCenter. Change-Id: Ib9a60e0eb3c167513eba555938369bad3f9d4634 Bug: 755413 Reviewed-on: https://chromium-review.googlesource.com/685986 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#509987}
-
Alexey Kozyatinskiy authored
R=lushnikov@chromium.org Bug: chromium:470899 Change-Id: If32e72208a2ccc6a0471a9e38e4f8a50b4eecfc0 Reviewed-on: https://chromium-review.googlesource.com/726386 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#509986}
-
Yuri Wiitala authored
Fixes a number of existing bugs when requesting scaling of a subset of the entire output (e.g., when the output rect does not have an origin of 0,0): 1) Corrected overscan calculations; 2) Math fixes, including proper accounting for vertical flipping; 3) Cleaned-up some confusing variable naming. Added a plethora of unit testing for use of: 1) the source texture re-positioning offset; and 2) output rects with non-0,0 origins. TODO: Currently, scaling using a source texture re-positioning offset having non-whole-numbered coordinates is broken. This is documented and guarded with DCHECKs for safety. There is not yet a use case for this, but the issues will be addressed in a later change. Bug: 775740 Change-Id: Iaa783a5e9efa37f16abbf2a4a8660cf843efb5c7 Reviewed-on: https://chromium-review.googlesource.com/724426Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#509985}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I5f737c0e1b218d68c4ec3d2b75e1770655844208 Reviewed-on: https://chromium-review.googlesource.com/727621Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#509984}
-
Benjamin Pastene authored
build-side change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/724164 Bug: 773872 Change-Id: Ie8bb990b3b6969cc245120bc8b3bdd0dac852c95 Reviewed-on: https://chromium-review.googlesource.com/724176Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#509983}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9614d686..b85708fb Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Icb78fe6b676cb28e0b978f3d6dc02e28ef023810 Reviewed-on: https://chromium-review.googlesource.com/727159Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#509982}
-
Scott Kirkwood authored
TBR: pkotwicz@chromium.org Bug: 776097 Change-Id: I99b137a8a1024c3f352a2ef3a8cd2c6dbb8e17c0 Reviewed-on: https://chromium-review.googlesource.com/727565Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#509981}
-
Jennifer Apacible authored
Add a custom WidgetDelegate for OverlayWindowViews. This is used to control more of the behaviour of OverlayWindow. This also adds a placeholder window title string. Non-trivial beheaviour will be added with more guidance from UX. Bug: 726621 Change-Id: I7d6eae901248f90d8cbebc9bc4bd6e52aa7f714d Reviewed-on: https://chromium-review.googlesource.com/722453 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#509980}
-
Qiang Xu authored
1-pager: go/tablet-mode-screenshot-hotkey changes: - add UMA recording user action of taking screenshot by power button screenshot accel. - add UMA recording the delay between power button pressed and volume down key pressed, which will help us determine the best delay time for users. Bug: 712072 Test: device test with chrome://histograms and chrome://user-actions Change-Id: Ibce1c238ada747ca0400dbad3429b1e74722390c Reviewed-on: https://chromium-review.googlesource.com/725220Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#509979}
-
Yoshifumi Inoue authored
This patch gets rid of redundant include directive of "ChromeClient.h" from "InputMethodController.cpp" for improving code health. Change-Id: I05e00762e14b1d665bcd7da81203335d900865e1 Reviewed-on: https://chromium-review.googlesource.com/725206Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#509978}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c4f93cab667b..eac03014e564 $ git log c4f93cab6..eac03014e --date=short --no-merges --format='%ad %ae %s' 2017-10-18 reed fix mapRect to always return the same as rectStaysRect 2017-10-10 kjlubick Update to go 1.9 2017-10-18 bungeman Compute inverse gamma table at compile time. 2017-10-18 bsalomon Fix dirty rect used when updating GrRenderTarget after clearing as draw in GrGLGpu. 2017-10-18 scroggo Move SkCodec::Origin into its own file 2017-10-18 brianosman Remove color space xform from GrTextureDomain & GrSimpleTextureEffect 2017-10-18 mtklein fix libc++/MSAN instructions 2017-10-18 halcanary SkPDF: TextSize > 0; 2017-10-17 liyuqian Update MSAN gn args to match our bots 2017-10-18 benjaminwagner Revert "Add an Option for orientation on JPEG encodes" 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ d042fba42..d0ef13a25 (1 commit) 2017-10-18 robertphillips Disable FullScreenClearWithLayers test on NexusPlayer Vulkan 2017-10-18 scroggo Add an Option for orientation on JPEG encodes 2017-10-18 csmartdalton Add a SampleApp flag to automate keystrokes on startup 2017-10-18 borenet bin/try: Add interactive mode 2017-10-18 herb Reland the combined 3 pass image blur with a fix to the bounds calculation 2017-10-17 mtklein Feed seed_shader() iota through a context pointer. 2017-10-18 caryclark convert mapHomogeneousPoints to SkPoint3 2017-10-17 mtklein rename (x,y) to (dx,dy) 2017-10-18 mtklein Revert "Remove some blur tests on google3 until the flag is removed." 2017-10-18 brianosman Convert more code to use color space xform FP 2017-10-18 brianosman Convert several effects to use color space xform FP Created with: roll-dep src/third_party/skia BUG=767343 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I9cfe20dcfe44e37ab9d36b4e928b2297c0902dc2 Reviewed-on: https://chromium-review.googlesource.com/727265Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#509977}
-
Wenzhao Zang authored
Bug: 775687 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I03f030f0e6210b907d5c890f7b8bbf7b1cce9e8e Reviewed-on: https://chromium-review.googlesource.com/724879Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509976}
-
Marti Wong authored
In iOS Bookmarks, Reading List and History, skip bottom toolbar button actions when context menu is showing. This is to prevent the bug that simultaneously tapping on toolbar button and table row triggers both actions. Bug: 773646 Change-Id: Iab6d3fe30642366443f88679e547a6dfa172adce Reviewed-on: https://chromium-review.googlesource.com/727480 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#509975}
-
Xiaocheng Hu authored
This patch moves LoadAhem() to PageTestBase for easier sharing of this function between editing and layout unit tests. Bug: 771800 Change-Id: I9fd2fa07cc78b42e37343243cbb52d9470b2c01c Reviewed-on: https://chromium-review.googlesource.com/727467 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509974}
-
Scott Kirkwood authored
Bug: 776097 TBR: pkotwicz@chromium.org Change-Id: I4cb7383afa071969e4225d6225faabbb52905554 Reviewed-on: https://chromium-review.googlesource.com/727367 Commit-Queue: Scott Kirkwood <scottkirkwood@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Piotr Swigon <piotrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#509973}
-
Wenzhao Zang authored
The page should use the border attribute of oobe-text-button for consistency. Bug: NONE Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3f64be76cc772f284b8d791cac6857bf9d9c7f6 Reviewed-on: https://chromium-review.googlesource.com/724428Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#509972}
-
Ehsan Karamad authored
It is possible to get consecutive calls to FocusedNodeChanged, i.e., repeatedly tapping into an <input>. This currently replaces the current |keyboard_observer_| in RWHVA with a new instance. However, there is a chance that during the call to OSKDisplayManager::DisplayVirtualKeyboard for the new |keyboard_observer_|, the OnScreenKeyboardDetector corresponding to the previous observer tries to detect the OSK and notify its (now deleted observers). This issue has caused crashes on Windows 8 and 10. The CL resolves the problem by properly removing |keyboard_observer_| as an OSKObserver before destroying and replacing it. Bug: 775973 Change-Id: I94dea4926a9d91cb7b4473d4c91b6574da66cbea Reviewed-on: https://chromium-review.googlesource.com/726376 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#509971}
-
Xiaocheng Hu authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I52e22bc5afe5bfe6a93338d127a3bbbe18415522 Reviewed-on: https://chromium-review.googlesource.com/726307 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#509970}
-
Tetsui Ohkubo authored
This CL makes style changes to ARC migration successful notification. - Add new material design icon to ARC migration successful notification. - Remove old icon on the right side. - Add title and adjust message string. This CL corresponds with https://crrev.com/c/666597 , which makes similar changes to ARC migration notification ("Install OS update"). TEST=manual BUG=775818 Change-Id: If483a86e932af3a8463bd282db3d325a9984c4a2 Reviewed-on: https://chromium-review.googlesource.com/725025Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#509969}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c4f93cab667b..eac03014e564 $ git log c4f93cab6..eac03014e --date=short --no-merges --format='%ad %ae %s' 2017-10-18 reed fix mapRect to always return the same as rectStaysRect 2017-10-10 kjlubick Update to go 1.9 2017-10-18 bungeman Compute inverse gamma table at compile time. 2017-10-18 bsalomon Fix dirty rect used when updating GrRenderTarget after clearing as draw in GrGLGpu. 2017-10-18 scroggo Move SkCodec::Origin into its own file 2017-10-18 brianosman Remove color space xform from GrTextureDomain & GrSimpleTextureEffect 2017-10-18 mtklein fix libc++/MSAN instructions 2017-10-18 halcanary SkPDF: TextSize > 0; 2017-10-17 liyuqian Update MSAN gn args to match our bots 2017-10-18 benjaminwagner Revert "Add an Option for orientation on JPEG encodes" 2017-10-18 angle-deps-roller Roll skia/third_party/externals/angle2/ d042fba42..d0ef13a25 (1 commit) 2017-10-18 robertphillips Disable FullScreenClearWithLayers test on NexusPlayer Vulkan 2017-10-18 scroggo Add an Option for orientation on JPEG encodes 2017-10-18 csmartdalton Add a SampleApp flag to automate keystrokes on startup 2017-10-18 borenet bin/try: Add interactive mode 2017-10-18 herb Reland the combined 3 pass image blur with a fix to the bounds calculation 2017-10-17 mtklein Feed seed_shader() iota through a context pointer. 2017-10-18 caryclark convert mapHomogeneousPoints to SkPoint3 2017-10-17 mtklein rename (x,y) to (dx,dy) 2017-10-18 mtklein Revert "Remove some blur tests on google3 until the flag is removed." 2017-10-18 brianosman Convert more code to use color space xform FP 2017-10-18 brianosman Convert several effects to use color space xform FP Created with: roll-dep src/third_party/skia BUG=767343 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I152654c52c98c295a5ac2499ca86fa61d3c1f258 Reviewed-on: https://chromium-review.googlesource.com/726960Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Brian Salomon <bsalomon@chromium.org> Cr-Commit-Position: refs/heads/master@{#509968}
-
Sergey Ulanov authored
Renamed and moved parts of the audio-only backend: alsa/MediaPipelineBackendAlsa -> MediaPipelineBackendAudio alsa/AudioDecoderAlsa -> AudioDecoderForMixer alsa/media_codec_support_cast_audio.cc -> media_codec_support_cast_audio.cc This will allow to reuse these classes on platforms that don't implement ALSA. TBR=dalecurtis@chromium.org Bug: 772488 Change-Id: I2bc557c1dd9359d2690dc984a75116af48685ebc Reviewed-on: https://chromium-review.googlesource.com/719459 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#509967}
-
Ben Cheng authored
BUG=chromium:775410 Change-Id: I1d7596cc21435dd77d5034bcdbba1469a0c5fe0d Reviewed-on: https://chromium-review.googlesource.com/724760Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Michael Hablich <hablich@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ben Cheng <bccheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#509966}
-
Lambros Lambrou authored
If the display is unchanging, the host will normally not send any frames to the client, which causes the client to think the video stream is broken. The client makes FIR or PLI requests every few seconds, resulting in unnecessary key-frames which wastes resources. This CL fixes this by sending empty frame deltas at a capped rate when the capturer returns empty frame updates. The capped rate is set to a rapid value, since testing indicates this also helps avoid laggy behavior (crbug.com/773549), possibly because of improved b/w estimation when more frames are sent. Bug: 773894,773549 Change-Id: I40da2167a86aad3d099eeb45de7c21685b6ad612 Reviewed-on: https://chromium-review.googlesource.com/724660 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#509965}
-
François Degros authored
Change-Id: Iae4b1a807c0984ea41dff9ffeaa45337dc8b9cdc Reviewed-on: https://chromium-review.googlesource.com/725099 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#509964}
-
Raymes Khoury authored
This ensures that the Feature Policy for the frame can be queried correctly. BUG=689802 Change-Id: I80f331f7466406473125dd235c0ffc949584215f Reviewed-on: https://chromium-review.googlesource.com/722541 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#509963}
-
Lei Zhang authored
To cover the most common use cases and avoid writing tons of ifdefs everywhere. Also simplify the ifdefs themselves. Change-Id: I24183eb020403e6b48dea00cd3c3f04c70287d4a Reviewed-on: https://chromium-review.googlesource.com/722441 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#509962}
-
sebsg authored
The first patch is a re-upload of https://chromium-review.googlesource.com/c/chromium/src/+/646754 The follow-up patches will add some modifcations on how we preview username and password suggestions. The suggestions will be in black text, and the password suggestions should be hidden behind dots. Bug: 753645 Change-Id: I1d28ea47f443fc40a1cddf2cdef6b1ec86c4491e Tbr: tkent@chromium.org Reviewed-on: https://chromium-review.googlesource.com/702056 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#509961}
-
Zijie He authored
According to SendSideBandwidthEstimation, https://cs.chromium.org/chromium/src/third_party/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc?rcl=033ea5f77140eef0c2defd4bd668de5dac9af3ea&l=392 the bitrate_bps won't be smaller than min_bitrate_configured_, i.e. the field set by x-google-min-bitrate. This behavior is wrong or at least not what we have expected in WebrtcTransport: when the bandwidth is fully used by video channel, returning x-google-min-bitrate as the bitrate from OnTargetBitrateChanged() is not expected. I have verified this change on my machine, and it partially resolves the laggy issue. Bug: chromium:769391 Change-Id: I2c87a78af63b508b5f8b25b77e171c92a10c7426 Reviewed-on: https://chromium-review.googlesource.com/726312 Commit-Queue: Zijie He <zijiehe@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#509960}
-
Mike Wasserman authored
The app list button test should start drags on the app list button. It was actually targetting the ShelfBezelEventHandler. Fix and enable the test, make other cleanup changes. Enable ShelfLayoutManager test fixtures that work as-is in mash. Move remaining ShelfLayoutManager test failures to filter file. Bug: 695686, 775177 Change-Id: I7638c6294bc8ce6e2c6b91d459d462a5b357db5d Reviewed-on: https://chromium-review.googlesource.com/723863Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#509959}
-
Kai Ninomiya authored
Specifically this bug was seen on Adreno 405 on Lollipop. It turns out that the older driver has a bug that's not covered by the fix in https://crrev.com/c/520883 . Since this is such an old device it's not worth it to find a workaround, instead we just re-disable multisampling and WebGL 2.0 which were enabled in that patch. Bug: 767913 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I661c974a617bec35eeb830fd1dffd28c0be5f7f2 Reviewed-on: https://chromium-review.googlesource.com/727182Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#509958}
-