- 31 May, 2019 40 commits
-
-
Robert Liao authored
The code reextracted the same data from IDR_* strings as was specified already in the input struct. BUG=642920 Change-Id: Ie140919a5c30a8f1671cf737cf61ee65aa0c7d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636678Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#665152}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/f99d7ad5c045..7919b877c3c1 git log f99d7ad5c045..7919b877c3c1 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 dsinclair@chromium.org Close opened file handles. (#2644) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@7919b877c3c1 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I051dce2ab76ae53125a033a0844e11f7092972f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638484Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665151}
-
dalyk authored
This change is a precursor to a follow-up change where secure and insecure cache lookups will occur separately. Secure lookups and insecure lookups are now separated into separate DnsTasks and cannot be combined in a result. This change also prevents SECURE mode from falling back to ProcTask. Bug: 878582 Change-Id: I7f5b1f5bcb1c205575c7c28bb066c55678fea466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529731 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#665150}
-
Henrique Grandinetti authored
This CL adds a method to the login data dispatcher that shows the parent access widget and uses it to only allow parents to change the clock when there is a child signed in or a child is a device owner. Bug: 921145 Change-Id: Ifd83760f8b9000576570f85c895d34c76c4c8bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621392Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#665149}
-
Ian Kilpatrick authored
I don't believe(?) there is actually a way to set the opacity on a viewport. (Either with the @viewport rule, or the style fixup[1]). This removes one of the unittests, and removes the logic which was reading the opacity from the viewport. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/document.cc?q=viewport_style&sq=package:chromium&dr=C&l=2122 Bug: 813068 Change-Id: I29d1b45c848c3ddca48a04523ec358094e97755b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637044Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665148}
-
Xiaohan Wang authored
CDM_10 CDM has been supported and shipped by default for a year and CDM_9 usage is very low. This CL removes CDM_9 interface support. Bug: 799219 Test: Tests updaetd. Change-Id: Icdc7f467ed977346734a1114b78b1261cbbfd0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628837Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#665147}
-
danakj authored
The ServiceManagerContext is set up after starting the browser threads, and the BatteryMetrics uses it on creation, so it should not be created before. This was working because ContentMain() creates a ServiceManagerContext and passes it to BrowserMain() in the StartupDataImpl. However Android browser tests do not do so (and doing so induces flakiness in the NestedMessagePumpAndroid), so this exposed a crash in these tests. R=jam@chromium.org Bug: 961849 Change-Id: I54b535b040ad3c10985b087aed0410ff0c731196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637682 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665146}
-
liberato@chromium.org authored
This CL allows out-of-order codec output buffer releases. Previously, discarding buffer n would release without rendering buffers 0..n-1 as well. However, in the case where a previous buffer had been selected for display, it might not have been used by the time the later release shows up. In that case, it would be dropped, then be unable to promote it for drawing later. This CL also changes MediaCodecBridge to allow out-of-order presentation timestamps. Originally, it discarded earlier ones to avoid a problem with spurious zero timestamps during seek. However, that also prevents it from processing edit lists correctly. Bug: 967892, 966512 Change-Id: I22246e49a5e0644957f6b644ccdf8a8d694259c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637612 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#665145}
-
Maks Orlovich authored
This reverts commit e102db8b. Reason for reland: Test fixed w/o NetworkService Also incorporates a follow up fix to dealing with network service reconnect. Original change's description: > Revert "RestrictedCookieManager: report activity to ContentBrowserClient" > > This reverts commit b128ac8e. > > Reason for revert: Some cookie tests failing on linux-chromeos-dbg > > The following tests are failing consistently when the network service is disabled (aka the non_network_service_browser_tests task)" > CookieSettingsTest.AllowCookiesUsingExceptions/1 > CookieSettingsTest.AllowCookiesUsingExceptions/3 > CookieSettingsTest.BlockCookiesUsingExceptions/1 > CookieSettingsTest.BlockCookiesUsingExceptions/3 > > Failure output: > ../../chrome/browser/content_settings/content_settings_browsertest.cc:390: Failure > Expected equality of these values: > 1u > Which is: 1 > blocked->GetCookieCount() > Which is: 0 > > Failing build: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12530 > > Original change's description: > > RestrictedCookieManager: report activity to ContentBrowserClient > > > > ...So that things done via async cookie-store API show up in used/blocked > > cookies GUI. > > > > This is done via NetworkContextClient, with some existing reporting via > > NetworkServiceClient converted to it, as in case of service worker it's > > not associated with process + routing ID pair. > > > > This now invokes ContentBrowserClient::OnCookie{sRead,Change} on IO, > > not UI, thread. > > > > Bug:958923 > > > > Change-Id: I7d1832ad30f57c67ea292481444a5e6ca07657df > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1577493 > > Reviewed-by: Tom Sepez <tsepez@chromium.org> > > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Martin Šrámek <msramek@chromium.org> > > Commit-Queue: Maks Orlovich <morlovich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#662253} > > TBR=falken@chromium.org,jam@chromium.org,tsepez@chromium.org,msramek@chromium.org,pwnall@chromium.org,mkwst@chromium.org,morlovich@chromium.org > > Change-Id: I4e587a04252b135a48f5e0d09414f62df65f9278 > Bug: 958923 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626207 > Commit-Queue: Timothy Loh <timloh@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662541} Change-Id: Id6a4b2923f61f033b2ee9867fcbb7f741431438f Bug: 958923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625906Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#665144}
-
danakj authored
The strict mode prevents NativeBrowserTestActivity from reading and writing files. We want browser tests to be able to do so. Insert StrictMode disablers as close as possible in test targets to where files are read or written. Example 1: 05-30 14:28:31.154 6733 6733 D StrictMode: at java.io.File.getTotalSpace(File.java:1669) ... 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.deletePrivateDataDirectory(NativeBrowserTestActivity.java:86) 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.onStart(NativeBrowserTestActivity.java:52) Example 2: 05-30 14:28:31.154 6733 6733 D StrictMode: at java.io.File.listFiles(File.java:1137) ... 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.deletePrivateDataDirectory(NativeBrowserTestActivity.java:87) 05-30 14:28:31.154 6733 6733 D StrictMode: at org.chromium.native_test.NativeBrowserTestActivity.onStart(NativeBrowserTestActivity.java:52) Example 3: 05-30 14:28:31.155 6733 6733 D StrictMode: at dalvik.system.DexPathList.findLibrary(DexPathList.java:480) ... 05-30 14:28:31.155 6733 6733 D StrictMode: at org.chromium.base.library_loader.LibraryLoader.ensureInitialized(LibraryLoader.java:196) 05-30 14:28:31.155 6733 6733 D StrictMode: at org.chromium.content_shell.browsertests.ContentShellBrowserTestActivity.initializeBrowserProcess(ContentShellBrowserTestActivity.java:37) R=mheikal@chromium.org Bug: 961849 Change-Id: Iaacc6c76b56c4cd1d65e7ae348c359ab036d5610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637532Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#665143}
-
Nate Chapin authored
These experiments have been rotting for several months. We may want to see about pushing an API like this in the future, but not soon enough to justify its continued existence in the repo. Some similar non-worker task-scheduling experiments were using the WorkerTaskQueue runtime enabled feature. Rename that flag to ScriptedTaskQueue to better described the remaining uses. Bug: 879306, 898050, 928819, 966950, 967066 Change-Id: Ib69898585fb7e31c78c7738e3bb02ede3834e959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636224Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#665142}
-
Lan Wei authored
virtual/android/fullscreen/api/document-exit-fullscreen-vs-request.html is flaky on chromium.linux bots, because of recent change of user activation is consumed for fullscreen, disable it for now, we will fix once we confirm this change will be accepted. https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzZjYTRlMDhjYzJiYWJlZWI2YzlmOGMwYWU2MjFjYzYxNTdmMTcwMgw Bug: 852645 Change-Id: Idd8799adf603f45c2e6c1de94cef8824c7de83c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636820Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#665141}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/94d5e05157f0..bc30e72cb429 git log 94d5e05157f0..bc30e72cb429 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 jmadill@chromium.org Vulkan: Recycle command pools with vkResetCommandPool. Created with: gclient setdep -r src/third_party/angle@bc30e72cb429 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I747427be420452661704484229642f7d3e244a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638506Reviewed-by:
-
Chris Harrelson authored
This reverts commit 30d10c99. Reason for revert: Fixed underlying bug; see crbug.com/968255. Original change's description: > Revert "Adding fieldtrial testing config for FastBorderRadius" > > This reverts commit 987deaf1. > > Reason for revert: crash on browser_tests in linux-chromeos-dbg (see crbug.com/968255) > > Original change's description: > > Adding fieldtrial testing config for FastBorderRadius > > > > This patch adds a field trial testing config for FastBorderRadius. > > > > Bug: 947715 > > Change-Id: Iff94fdce62a195ead91bf338b40df0380a9aab5d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632829 > > Commit-Queue: Robert Kaplow (slow) <rkaplow@chromium.org> > > Auto-Submit: Mason Freed <masonfreed@chromium.org> > > Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#664252} > > TBR=rkaplow@chromium.org,masonfreed@chromium.org > > Change-Id: I1f36b1b44df65c43e09cab18f238bc0598985146 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 947715, 968255 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634424 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664424} TBR=mukai@chromium.org,rkaplow@chromium.org,masonfreed@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947715, 968255 Change-Id: Iecb9ee718680d3c751402da2a2e2773cc1736026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637871Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665139}
-
Eric Seckler authored
It's possible that the InterningIndex is modified after calling LookupOrAdd (e.g. by adding another entry), in which case the returned InterningIndexEntry pointer would become invalid. Return the entry by value instead and directly mark it as emitted when it is looked up. Bug: 928738, 968176 Change-Id: I3604bb8217a224060aee704f6bb37355bc405bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636132Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#665138}
-
Pâris MEULEMAN authored
Removes the round trip from native to java between the registration and fetching of the policy. Having the few tests directly handled in native. This simplifies the interface and improves readability on both sides. It also allows for the removal of the following members of native SigninManagerAndroid: dm_token_, client_id_, username_, which goes towards having a stateless SigninManagerDelegate. I couldn't make the native functions const due to the non-const WeakPtrFactory::GetWeakPtr. This is a precursor CL to moving the calls to SigninManagerDelegate. Bug: 963400 Change-Id: I187e607ed251c692d864e13fcf28125eac2550d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617838 Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#665137}
-
Adithya Srinivasan authored
Change-Id: Id1bd4f914af9eb3f35f646256fe4d2adaeca214c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634723 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665136}
-
Kevin Ellis authored
If an animation has a positive-valued end delay, we need an additional tick at the end time to ensure that the finished event is delivered. Otherwise we stop ticking the animation at the end of the active phase and the limit is not reached until triggered by another event such as a mouse move|click. Bug: 840637 Change-Id: Id811c787833a34f8739b2c10dc2af5b19fa4d17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634387Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#665135}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a4c30bf17adb..e90041ab4516 Created with: gclient setdep -r src-internal@e90041ab4516 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@google.com,hiroshige@google.com,mlamouri@google.com,loyso@google.com Change-Id: Ibf28137cd6ce083411ce6800fe979766cdd6a2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638285Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665134}
-
Tim van der Lippe authored
This CL introduces the interfaces as defined in https://w3c.github.io/push-api/#pushsubscriptionchangeevent-interface TBR=haraken for gni and json5 configuration files Bug: 646721 Change-Id: I68645a6f7e2bb63011b93c8a471504f7f628bd38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635611 Commit-Queue: Tim van der Lippe <tvanderlippe@google.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#665133}
-
Matt Falkenhagen authored
- For service workers, "fonts" and "cpu_profiler" may help diagnose slowness. - For navigations and renderers, "ServiceWorker" may help. Change-Id: Iab39827ff7d94ca503cdb13475d17ac00cff639b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635119Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
-
Andrew Xu authored
A part of code to enable dragging AppList by mouse. To achieve this goal, three key functions are required: (1) Drag AppList by mouse from Peeking/Half state. (2) Drag AppList by mouse from Shelf. (3) Drag AppsGridView by mouse. This CL implements the second function: enable dragging AppList from Shelf by mouse. Bug: 768484 Change-Id: Idfd794dc3d6177ed08001238413e95eb3260caa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1582978Reviewed-by:
-
Owen Min authored
Make two policy categories to have consistent capitalizations from others. Bug: 968495 Change-Id: Ie27f67d86559b9e6f2d9494a22ce9ff674676274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637148Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665130}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/209ff0ce90ce..f99d7ad5c045 git log 209ff0ce90ce..f99d7ad5c045 --date=short --no-merges --format='%ad %ae %s' 2019-05-31 kevin.petit@arm.com Validate OpenCL rules for ImageRead and OpImageSampleExplicitLod (#2643) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f99d7ad5c045 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I67b6ec96ca39139f83329d4964f0823eaa67146c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638557Reviewed-by:
-
Lan Wei authored
When we are scrolling pages with keys, we need to pass callback in ScrollManager::LogicalScroll to UserScroll function in RootFrameViewport, and in ScrollAnimator, we will execute the callback when the scroll animation finishes. Bug: 877132 Change-Id: I12d3dea8750e2971ecf9c0246e544df2a4afee99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573089 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#665128}
-
Sébastien Séguin-Gagnon authored
The STTSSyncService is null in incognito. Added a check for that. Bug: 967662 Change-Id: I59bc6b31545d60a5c94f974973f44b32361aba9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636344 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#665127}
-
Aga Wronska authored
Tablet mode controller is destroyed slightly before shelf widget in Shell destructor. Nullptr check is needed, because IsTabletModeEnabled() can get called when shelf is being destroyed. Bug: 967149 Change-Id: I42b6abd6cf24902cc1647d03dd813b070d9aec05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637982Reviewed-by:
-
Bill Budge authored
- Pushes the expiration date for JS and WASM code cache metrics by 1 quarter. Bug: chromium:719172 Change-Id: Ie774ef07de40f97e44e429cdf2bf47092a9c71cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637742Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#665125}
-
Etienne Pierre-doray authored
MessageLoopCurrent::task_runner() is depecated. This CL replaces it with with ThreadTaskRunnerHandle::Get(). A small step towards deleting MessageLoop. This CL was generated with git cl split. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1631693 Please CQ if LGTY! This CL was uploaded by git cl split. R=olka@chromium.org Bug: 616447 Change-Id: Ia10950715bac15b647f4dc886cc5cd33a5d10bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636357 Auto-Submit: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#665124}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/26d3cf08c209..839053b90c77 This roll also updates DawnCallbackUserdata in Chromium to match the API change. git log 26d3cf08c209..839053b90c77 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 cwallez@chromium.org Replace dawn::CallbackUserdata with void* Created with: gclient setdep -r src/third_party/dawn@839053b90c77 CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Change-Id: I9d8cef8ade080668016ecd97f332d100876b48ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637528Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#665123}
-
Bryan McQuade authored
Change-Id: I82bd9b293bce86995f67ba9aeb366637679b233f Bug: 968521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626497 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#665122}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=grt@chromium.org Bug: 887407 Change-Id: Ie77f0686e7317cd2ca6231c0a18d09a5fd846df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632432Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665121}
-
Dominic Battre authored
The added debug output indicates that the interactive UI tests of autofill fail during the setup of the fixture, before the test logic starts (see crbug.com/967588). This CL adds more debug data to pin point the location where things fall apart. Bug: 967588 Change-Id: Ib7b9df7ba7a9ad09f65c11e50feeaa6c81aab0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635682 Auto-Submit: Dominic Battré <battre@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#665120}
-
Takuto Ikuta authored
If update script failed while downloading clang, this script left inconsistency state between stamp and clang state (crbug.com/968765). Let me remove directory having stamp so that next update correctly downloads clang when previous download failed. Bug: 968821 Change-Id: I095e4b037b9f513908551dfb1eee2496ace5936a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635087Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#665119}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Iebf88d7109756182f58c6f554d6f3f4450d30052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635071Reviewed-by:
-
François Doray authored
With this CL, the TaskPriority, TaskShutdownBehavior and ThreadPolicy fields of TaskTraits use 1 bit for a flag indicating whether the value was set explicitly and 7 bits for the value. Before, TaskShutdownBehavior and ThreadPolicy had 8 bits that could hold either a valid value *or* a flag indicating that no value was set explicitly (could not have a non-default value not set explicitly). TaskPriority had 8 bits that could hold a valid value and a separate boolean to indicate whether that value was set explicitly (could hold a non-default value not set explicitly, but used 2 bytes instead of 1 byte). Change-Id: Icb63aecd4a356705c047423872af0bc06abdb56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635677 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#665117}
-
Peter Kotwicz authored
This CL changes the activity which is launched on first run for new-style WebAPKs. The CL changes the default to H2OOpaqueMainActivity which has a solid color background theme. This change means: - On N+, users will get a faster pixels-on-screen first run experience for WebAPKs that they install - Pre-N, on first run, H2OOpaqueMainActivity will be launched, finished, and the app will be relaunched with H2OMainActivity. The relaunch is necessary in order to switch which android.intent.action.MAIN is enabled. BUG=817263 Change-Id: I7728a26e9d41024fdc53db97b97116c863b449b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638237Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#665116}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=rouslan@chromium.org Bug: 887407 Change-Id: I4a7a2499e776c7e783d860a5b7ca055b302c1394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632473Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#665115}
-
rnasri authored
Draw layout shift rects. First transform the jank region found by the sweep line algorithm into a blink region. Clear the layout shift rects vectors for the next update. Finally, draw the layout shift rects in a fading yellow color. Bug: 961846 Change-Id: Iad3d4a2bef4eace679f30eb23a66a2f73436d0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631715 Commit-Queue: Rasha Nasri <rnasri@google.com> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#665114}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9978b88c. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." 1bbbd106 "Add feature policy for client hints, used for third-party subresources." ab94a58b "Add the remaining Client Hints to Feature Policy." d206e4f4 "[css-properties-values-api] Properly implement '|' in syntax strings." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I982a5389da86681de18d1dfaf9eb99fa83335197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638477Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665113}
-
