- 18 Jul, 2017 40 commits
-
-
Jeremy Roman authored
This symbol is used very frequently; saving the lookup is likely to be worthwhile. Found due to insight from RCS report. This improves a local microbenchmark that measures adding/removing event listeners from script by about 25%. Change-Id: I786a94f5bedcf6ea5ec45cf0d1ee19b791e7235d Reviewed-on: https://chromium-review.googlesource.com/575273Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#487548}
-
Daniel Bratell authored
IDBRequestTest and IDBTransactionTest both had an identical helper function CreateIDBValue. In jumbo builds those identical functions collided so this patch moves the code to a shared helper file. Bug: 745732 Change-Id: I36c658509c76deca4e03590858140e02a07f38d3 Reviewed-on: https://chromium-review.googlesource.com/575145 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch consolidates a few discardable image related work into fewer classes in cc. Specifically, it moves all of the generation code into discardable image map. It also removes display item list functionality and just exposes discardable image map from there, since most of those functions were pass-through. R=enne@chromium.org, khushalsagar@chromium.org Bug: 741775 Change-Id: I483d4544f35356465c09f9084d9a0ec3ae0a9029 Reviewed-on: https://chromium-review.googlesource.com/575347 Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#487546}
-
Gauri Manikpure authored
Bug: Change-Id: I616d2f8c72bfd3c871aded779c63e6ed47da7e88 Reviewed-on: https://chromium-review.googlesource.com/575784Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Cr-Commit-Position: refs/heads/master@{#487545}
-
stkhapugin@chromium.org authored
Converts web_state-related files to ARC. Notable issues: - Had to fix WebUIMojoTest.MessageExchange. See comment. Bug: Change-Id: Ia8a58433ab82d67ebae4f61b8c4ea954f84df202 Reviewed-on: https://chromium-review.googlesource.com/570402 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#487544}
-
Adenilson Cavalcanti authored
This allows to avoid copying text runs character-per-character for 16bits text. Also there is no need to hash per character, just hash the whole string in one go. This also helps to save the construction of a StringHasher object (as we use the static method to hash the strings). Finally, reserve in HashTable space for 500 words (this reduces the number of rehashes in up to 4x). Bug: 735674 Change-Id: I4c5e23bb1e21dad995d4948fae0943a2b01309e0 Reviewed-on: https://chromium-review.googlesource.com/564076Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#487543}
-
xdai authored
Wire up the SplitViewController with the overview mode. It's a following up CL of https://codereview.chromium.org/2960843004/. Changes in this CL: 1. The split view mode can be initiated by dragging the window in overview mode to the side of the screen 2. After one window is snapped to one side of the screen, all the other overview windows will display in the other side of the screen, allowing the user to select another window to snap. When two windows are snapped to both sides of the screen, the overview mode will be ended. 3. The first snapped window will remain snapped until the user explicitly exit the split view mode. All the other windows (incluing newly created window) will be open in the other side of the screen. Clicking/Tapping on the overview button also open the overview windows in the other side of the screen. Not covered in this CL: 1. The highlighted region showing where split will occur is not implemented in this CL. 2. The split divider is not implemented in this CL. BUG=725683 Review-Url: https://codereview.chromium.org/2955203002 Cr-Commit-Position: refs/heads/master@{#487542}
-
Nicolas Pena authored
In this CL, WorkerGlobalScope's |time_origin_| is set to the time of creation. As a result, many time origins are no longer needed in constructors. Bug: chromium:688542 Change-Id: Ie15dccd7c81e6c29ad23244278fb7cc5131bdaf2 Reviewed-on: https://chromium-review.googlesource.com/563957 Commit-Queue: Nicolás Peña <npm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Bence Béky authored
Rename CreateSecureSpdySessionWithIpBasedPoolingDisabled to CreateSpdySessionWithIpBasedPoolingDisabled (since every SpdySession is now secure). BUG=737143 Change-Id: I0882d68eeb6f348da88d1904f04ab2b2748fe007 Reviewed-on: https://chromium-review.googlesource.com/570624Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#487540}
-
Siddhartha authored
A common behavior on Android is for the user to press home or recents button accidently and get back to the app. This behavior would cause Chrome to clear the contexts and recreate which is a waste of time. So, add a 5 second delay before clearing the context. As a side effect, this delay also considerably lowers the risk of the renderers initializing the GPU command buffer after clearing since they usually receive the "not-visible" message within 5 seconds. BUG=725303 Change-Id: I7d2655c75b66cf073b82c270baa3f1f3b27b3a8a Reviewed-on: https://chromium-review.googlesource.com/571294 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487539}
-
Geoff Lang authored
TBR=kbr@chromium.org NOTRY=true BUG=745888 Change-Id: I74fc63416e07782daa5915fafcdd51fc4d40cb67 Reviewed-on: https://chromium-review.googlesource.com/576081Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
-
Alexei Filippov authored
This reverts commit bc12faf7. Reason for revert: Broke ash_unittests https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28275 Original change's description: > reland: shelf: Add a back button to the shelf. > > This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. > This approach of adding a back button expands the current app list button to be modal and have two functionalities > depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what > is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The > exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the > meantime. > > Screenshots: > https://screenshot.googleplex.com/ZVNP0aq0cc3 > https://screenshot.googleplex.com/fDcGTuoyZg5 > https://screenshot.googleplex.com/ZFBzk72LLVt > > Test: ash_unittests --gtest_filter="ShelfViewInkDropTest.*" > Bug: 721940 > Change-Id: I0b2be5cc66583d521721ec1378a19e0026c5c7e1 > Reviewed-on: https://chromium-review.googlesource.com/572434 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487491} TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org,msw@google.com Change-Id: I24a268a0850db947ffb9674653837fb11ed64621 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721940 Reviewed-on: https://chromium-review.googlesource.com/576195Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#487537}
-
Alexei Filippov authored
NOTRY=true TBR=rogerta Bug: 745887 Change-Id: Id57a77c44fb2ec0846c2ae179269dd7fbb0db3b5 Reviewed-on: https://chromium-review.googlesource.com/576225Reviewed-by:
-
Florin Malita authored
Use the flat data accessor instead. BUG=728627 Change-Id: I0ff48a9e4d1ce60c0fcc822ac6b839f3fb1ad6e0 Reviewed-on: https://chromium-review.googlesource.com/574576Reviewed-by:
-
Becky Zhou authored
+ Infobar secondary text from #646464 to 54% black + Infobar big icon control message to 20sp + Conneciton info url from bold to medium + Conneciton info description line height to 20 + Page info secure scheme "https" text to medium + Page info and connection info link text to #3367D6 + Bluetooth dialog link text to #3367D6 + Bluetooth dialog bottom margin to match button right margin BUG=723044,723054 Change-Id: I2646135c31d3328d0028b831275941ab00278382 Reviewed-on: https://chromium-review.googlesource.com/572545Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#487534}
-
Jungshik Shin authored
Add a check to SetICUDefault() and fall back to en-US when an incoming locale id fails to create a valid icu::locale instance. Roll ICU to b971435d43 to pick up an upstream fix. icu::Locale::setDefault() can fail when an invalid/too long locale id is passed. It appears that this might happen when the locale id comes from GetOverrideLocale() on iOS. A test added is similar to what the upstream added in the upstream fix ( http://bugs.icu-project.org/trac/changeset/40267 ) which was cherry-picked in https://chromium-review.googlesource.com/c/574935/ . BUG=chromium:734093 TEST=base_unittests --gtest_filter=SetICU* Change-Id: If8d3522b23a257466ca3c31b66089cb415fec3a2 Reviewed-on: https://chromium-review.googlesource.com/574936Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487533}
-
Georges Khalil authored
BUG= Change-Id: Id1fe889bc5395fc7d4de8911437705e090dbf436 Reviewed-on: https://chromium-review.googlesource.com/576230Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#487532}
-
sczs authored
As we develop the new architecture, some actions/items/flows,etc. will be no-op since they are part of a working component, but its functionality hasn't been developed yet. (e.g. Some menu items. The Menu itself is working and it displays the items, but some of these items are not working yet). In order to differentiate no-op actions from broken ones, we will display a simple alert for no-op actions, this way we'll know if something was/is broken, or if it still hasn't been implemented yet. This CL implements these alerts for the NTP, Toolbar and ToolsMenu. Bug: 740793 Change-Id: I128a289403f3fb20342d451cd15699fbacade2e1 Reviewed-on: https://chromium-review.googlesource.com/570846Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#487531}
-
Tina Quach authored
Specify labels that are referenced using the aria-labelledby attribute to passwords section's searchInputs and passwords. Remove the for attribute, not needed since we are using aria-labelledby instead. Bug: 737739 Change-Id: Ibdc7d0752d2e1972c8692ca743e39ababc24f868 Reviewed-on: https://chromium-review.googlesource.com/568240Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tina Quach <quacht@google.com> Cr-Commit-Position: refs/heads/master@{#487530}
-
Scott Violet authored
Apparently there is still an x11 chromeos bot. This should fix the build for it. TBR as this is trivial change to add ifdefs and should fix bot. BUG=701068 TEST=none TBR=erg@chromium.org Change-Id: I55aad4f264ece847338e98eac635262c1583ac26 Reviewed-on: https://chromium-review.googlesource.com/576280Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487529}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/61a3cb81a298..fe1c8e616680 $ git log 61a3cb81a..fe1c8e616 --date=short --no-merges --format='%ad %ae %s' 2017-07-18 reed colortables are unused, so remove plumbing 2017-07-18 rharrison Correct lexer handling of FormCalc identifiers 2017-07-18 rharrison Add tools for generating coverage information Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ibf68e8b115637a659281fdd25fd8c6c8be0987d5 Reviewed-on: https://chromium-review.googlesource.com/576190 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487528}
-
Alexei Filippov authored
NOTRY=true TBR=rogerta Bug: 713049 Change-Id: I33dbfdd3de58f03472d95f42abd60977f2749a0b Reviewed-on: https://chromium-review.googlesource.com/576254Reviewed-by:
-
Hidehiko Abe authored
This CL migrates ArcNotificationManager. BUG=672829 TEST=Ran try. Ran on DUT. Change-Id: I4b7283246b9d808fe61a97e20061a4b87c8c0321 Reviewed-on: https://chromium-review.googlesource.com/574890Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#487526}
-
sataya.m authored
Add ScrollableArea only if the box size is not zero and there is a horizontal or vertical overflow scroll. BUG=711474 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2857583007 Cr-Commit-Position: refs/heads/master@{#487525}
-
Christian Biesinger authored
This is a prerequisite for fragment caching (https://crrev.com/c/516042/) Bug: 635619 Change-Id: I8d4995082b638c7073513dc2b11f4d01934fbe4a Reviewed-on: https://chromium-review.googlesource.com/575652Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#487524}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1c7f2213..b906454a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ie47786cb683c2f4025ea3162a662af797dcf91cb Reviewed-on: https://chromium-review.googlesource.com/575693Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#487523}
-
Weidong Guo authored
Changes: 1. Make StartPageView vertically centered in fullscreen mode. specs: https://screenshot.googleplex.com/Stf7U5FGsgB BUG=735487 Change-Id: I9795e23e73d8cd28acb6217584fc08c0bc8e0f3c Reviewed-on: https://chromium-review.googlesource.com/575665 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Shivani Sharma authored
Bug: 745102 Change-Id: Iabf7a1a2dbe8ea53ec1616134b777f9bf576c704 Reviewed-on: https://chromium-review.googlesource.com/575679Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#487521}
-
Tommy C. Li authored
Removes people no longer on Chromium team. Bug: NONE Change-Id: Ib710dae406e9691ff7abb33e8faad0ffff13dd06 Reviewed-on: https://chromium-review.googlesource.com/576141Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487520}
-
Mike Klein authored
Change-Id: Ieadeef0f6bec8f767505a72aad0cbafec19c99c7 Reviewed-on: https://chromium-review.googlesource.com/575674Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#487519}
-
Emil A Eklund authored
Follow up to the CL that moved PaintFillLayer to BoxModelObjectPainter, this change moves the PaintFillLayers method to the box model class. Bug: 743221 Change-Id: Iefcb91e4e2ec21e338fa0d6f6ea00f5a87ebaa7a Reviewed-on: https://chromium-review.googlesource.com/572146Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#487518}
-
Edward Jung authored
Set the blue action buttons on a per interstitial page type basis rather than having it as a default colour. Bug: 731250 Change-Id: I45d8d6f3beacf211522ea2cc2de2569914aa20cc Reviewed-on: https://chromium-review.googlesource.com/570036Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Edward Jung <edwardjung@google.com> Cr-Commit-Position: refs/heads/master@{#487517}
-
Yusuf Ozuysal authored
Change-Id: I410e86b47399202ca2871d9e284e37d7668897e0 Reviewed-on: https://chromium-review.googlesource.com/575661Reviewed-by:
-
Bence Béky authored
Change-Id: If62f6b1eb3ea7b84ad80512d33930b3dc3ce331b Reviewed-on: https://chromium-review.googlesource.com/570859 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#487515}
-
Kenichi Ishibashi authored
We don't have to use V8PrivateProperty to anymore because PerformanceObserver holds PerformanceObserverCallback in TraceWrapperMember and wrapper tracing makes sure that a callback will be alive while the corresponding observer is alive. BUG=700680 Change-Id: I4aeabe6c379f6a07fd4bc882206db1a24dcba87f Reviewed-on: https://chromium-review.googlesource.com/574985Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487514}
-
Wez authored
Bug: Change-Id: I8a06cac29c4820b02b3f4d0fee971fd3b1b5cb3e Reviewed-on: https://chromium-review.googlesource.com/575610Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487513}
-
Wez authored
PostDelayedTask_Basic verifies that the call waits at least as long as the requested delay, but was using wall-clock time to verify this, rather than the tick-clock that PostDelayedTask itself should use. Bug: 738001, 738275 Change-Id: Ia12423ae46646a348932a8eff6dd1c4e8047fdb7 Reviewed-on: https://chromium-review.googlesource.com/575788Reviewed-by:
-
Bernhard Bauer authored
Bug: 718925 Change-Id: Icf37ad3a7f6ace1869b9d17721960e6c844b0b88 Reviewed-on: https://chromium-review.googlesource.com/576093Reviewed-by:
-
Cooper Knaak authored
This CL sends a notification to FeatureEngagementTracker when the user clears their browsing data. The notification was added to -[ClearBrowsingDataCollectionViewController clearDataForDataTypes:] because both entry points (History and Settings page) use this code path. The notification was not added to -[MainController chromeExecuteCommand:], despite it ultimately being the place that executes the action, because chromeExecuteCommand also is used for non-user initiated actions (such as clearing the browser data on sign out). Non-user initiated actions should not be logged by the FeatureEngagementTracker because that would interfere with the ability to present in-product help promotions to users who haven't used a given feature. Bug: 738164 Change-Id: I7f79b724757fc990f93cdaff95c5bfa44f10c36f Reviewed-on: https://chromium-review.googlesource.com/560721Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Ed Chin <edchin@chromium.org> Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Cooper Knaak <cooperknaak@google.com> Cr-Commit-Position: refs/heads/master@{#487510}
-
Takumi Fujimoto authored
This CL limits the height of the sink list view in the Media Router dialog to 5 items (including the search box). This CL also adds margin-bottom to #sink-list-view instead of dynamically adding padding-bottom to various elements. Screenshots: https://docs.google.com/document/d/12e2KFrz_sltuGsI6VcB_0W7FdgQD8_Z3j3xQXHXOiTU/edit Bug: 738580 Change-Id: Ie97e4d04faec148ceb9a2870cbcebce494738f78 Reviewed-on: https://chromium-review.googlesource.com/574972 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Jennifer Apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#487509}
-
