GitLab

Don't use SCRIPT_UNDEFINED in the case of font fallback,
unless font fallback actually fails to return a script
that can display the characters. This fixes the problem
of some scripts not being properly displayed.

This actually makes RenderTextWin properly validate whether
a text position accepts a cursor, which caused several tests
to fail and revealed some additional issues in RenderTextWin.

The CL includes some modifications to address this.

Also, fixes some lint warnings.

BUG=90426
TEST=Run chrome.exe --use-pure-views and paste some Bengali
text into the omnibox. It should show up properly.

Review URL: http://codereview.chromium.org/8575020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112983 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
BUG=106402
TEST=valgrind bots go greener

Review URL: http://codereview.chromium.org/8803015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112982 0039d316-1c4b-4281-b951-d872f2087c98

R=ivankr@chromium.org
BUG=None
TEST=None


Review URL: http://codereview.chromium.org/8806009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112981 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20156
TEST=None


Review URL: http://codereview.chromium.org/8788011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112980 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jar@chromium.org
BUG=106326
TEST=valgrind bots go greener

Review URL: http://codereview.chromium.org/8800008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105028
TEST=none (no functional change)
TBR=zea@chromium.org

Review URL: http://codereview.chromium.org/8784006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112978 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8695004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112977 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8802005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112976 0039d316-1c4b-4281-b951-d872f2087c98

The Java Bridge makes repeated use of numerous JNI method IDs. We wish to avoid
repeatedly looking up these IDS, so we cache them.

Currently we use Singleton objects to achieve this. However, this seems
inappropriate for several reasons ...
- Requires excessive boilerplate
- Thread safety not required
- Exit cleanup not required

We can avoid using Singleton, without introducing static initializers, by
simply using a static local.

See http://codereview.chromium.org/8659007 for background.

TBR=avi
BUG=105547


Review URL: http://codereview.chromium.org/8769005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112975 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:20552
TEST=None


Review URL: http://codereview.chromium.org/8769043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112974 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib

Review URL: http://codereview.chromium.org/8802006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/8771037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112972 0039d316-1c4b-4281-b951-d872f2087c98

Ordinal IME shows candidate window under the cursor, but Mozc should show
"suggest window"(same view but different location) and it's location is sent
by mozc-engine.

BUG=chromium-os:21356
TEST=manually confirmed it works fine and no conflict with other CJK engine.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112452

Review URL: http://codereview.chromium.org/8505051

TBR=nona@chromium.org
Review URL: http://codereview.chromium.org/8799005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112971 0039d316-1c4b-4281-b951-d872f2087c98

The feature is behind a command line flag --enable-restore-session-state.

BUG=1870
TEST=CookieMonsterTest.PersistSessionCookies, SQLitePersistentCookieStoreTest.Test(Dont)?LoadOldSessionCookies, SQLitePersistentCookieStoreTest.PersistHasExpiresAndIsPersistent


Review URL: http://codereview.chromium.org/8533013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23434
TEST=See bug.

Review URL: http://codereview.chromium.org/8770044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105028
TEST=no functional change

Review URL: http://codereview.chromium.org/8785004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112968 0039d316-1c4b-4281-b951-d872f2087c98

Ordinal IME shows candidate window under the cursor, but Mozc should show
"suggest window"(same view but different location) and it's location is sent
by mozc-engine.

BUG=chromium-os:21356
TEST=manually confirmed it works fine and no conflict with other CJK engine.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112452

Review URL: http://codereview.chromium.org/8505051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112965 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scheib

Review URL: http://codereview.chromium.org/8800005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112964 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dvyukov
BUG=105706
Review URL: http://codereview.chromium.org/8806005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112963 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104946.
TEST=As described in the bug.

Review URL: http://codereview.chromium.org/8606007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112960 0039d316-1c4b-4281-b951-d872f2087c98

Avoid collapsing the preferred size reported by RenderView when WebKit
is unable to calculate scrollable height.

BUG=103423
TEST=http://docs.google.com/demo 'Sign In' and 'Get Started' shouldn't wrap.

Review URL: http://codereview.chromium.org/8670014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112959 0039d316-1c4b-4281-b951-d872f2087c98

a long while back the NTP showed some sort of UI depending on whether it was your home page or not, but that's long since gone so we don't need to reconstruct the cache if it's changed.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8774014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112957 0039d316-1c4b-4281-b951-d872f2087c98

if entries_ is larger than kMaxEntries, some pointer math goes askew

BUG=106082
TEST=included


Review URL: http://codereview.chromium.org/8776018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112955 0039d316-1c4b-4281-b951-d872f2087c98

When a download is detected as malicious by the safe browsing service, the download shelf now displays a warning message along with a 'Discard' button and a drop down menu with additional actions.

BUG=102540
TEST=Initiating a download that is flagged as malicious by the safe browsing service causes the new malicious download warning to be displayed on the download shelf.


Review URL: http://codereview.chromium.org/8757007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112954 0039d316-1c4b-4281-b951-d872f2087c98

If the user is already logged in pre M17 and user sets
up notifications, the user will be asked to sign in.
AppNOtifyChannelUI::OnStateChanged is called more than
once before the oauth2 token is generated.

Fix it by:
Remembering if the wizard ever became visible instead of
whether the callback happened once.
Review URL: http://codereview.chromium.org/8787013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112953 0039d316-1c4b-4281-b951-d872f2087c98

Add chromeos tab to chrome://net-internals.
Move ONC file import input field to chromeos tab, from network options.
Support for encrypted onc files.
Fix net_internals browser test.

BUG=chromium-os:23472,chromium-os:19397
TEST=Go to chrome://net-internals, click on chromeos tab. Should be able to import an onc file from there. If the file is encrypted, should be prompted for a passcode.

Review URL: http://codereview.chromium.org/8741009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112952 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112951 0039d316-1c4b-4281-b951-d872f2087c98

This DEPS roll pulls in a new script for downloading NaCl toolchains.

TRB= bradnelson@chromium.org
Review URL: http://codereview.chromium.org/8742033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112950 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112949 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vsevik

Review URL: http://codereview.chromium.org/8797001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112948 0039d316-1c4b-4281-b951-d872f2087c98

Capitalize column headers and buttons as appropriate for the platform.

BUG=none
TEST=Private Memory, Shared Memory, JavaScript cache, End process, etc. should have consistent capitalization


Review URL: http://codereview.chromium.org/8711001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112947 0039d316-1c4b-4281-b951-d872f2087c98

These objects were created differently than any other resoures. This cleans
them up to behave like the other resources.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8790009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112946 0039d316-1c4b-4281-b951-d872f2087c98

|printable_size| is a misnomer. |content_size| is correct.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8784012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112945 0039d316-1c4b-4281-b951-d872f2087c98

This is really re-landing 112937 and attempting to avoid a warning from the
Linux builder.

R=jar@chromium.org
BUG=106326
TEST=needs to run on the CQ


Review URL: http://codereview.chromium.org/8796006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112944 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jstritar@chromium.org
BUG=106331
TEST=valgrind bots go greener

Review URL: http://codereview.chromium.org/8797002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112943 0039d316-1c4b-4281-b951-d872f2087c98

It was enabled in r112775.

TBR=brettw@chromium.org
BUG=87625,104535
TEST=mac valgrind bots go greener

Review URL: http://codereview.chromium.org/8796008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112942 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jstritar@chromium.org
BUG=106331
TEST=memcheck and heapcheck bots report less leaks

Review URL: http://codereview.chromium.org/8796007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112941 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/linux-release/sizes/report.html?history=150&rev=112933&graph=chrome-si
http://build.chromium.org/f/chromium/perf/linux-release-64/sizes/report.html?history=150&rev=112933&graph=chrome-si

BUG=94125
TEST=none
TBR=cmp
Review URL: http://codereview.chromium.org/8793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112940 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jar@chromium.org
BUG=106326
TEST=memcheck bots go greener

Review URL: http://codereview.chromium.org/8794004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112939 0039d316-1c4b-4281-b951-d872f2087c98