- 10 Sep, 2020 40 commits
-
-
Collin Baker authored
This metrics records the total time spent capturing a tab for thumbnails. It is emitted once per video capture on a given tab. Bug: 11261624 Change-Id: I9dfdd4168738d59e048aab2238c78db62f9af917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399127Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#805785}
-
Morten Stenshorne authored
It times out now and then. TBR=mek@chromium.org Bug: 1092048 Change-Id: I7416f6ee0279c00fa578a51e92e436e67562ac97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403483Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805784}
-
Evan Stade authored
This one slipped through the cracks when the rest were updated in 63d5fba9 Bug: 1126716 Change-Id: Ia67f0f60a4f7bcc89c98a550f16dd31974e80f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402208Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#805783}
-
Jesus David Garcia Gomez authored
This CL add new metrics enums to allow measuring when an issue in the issue panel is expanded and when a resource is opened. The corresponding DevTools CL is at https://crrev.com/c/2303882 Bug: 1100658 Change-Id: Ia85587441dd4d11063ac3d6ed9d722fd65ff714a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305018Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
John Emau <John.Emau@microsoft.com> Commit-Queue: Jesus David Garcia Gomez <jegarc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805782}
-
Olivier Robin authored
Change-Id: Ic3b4511444a691de76537616be0f82193a953dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403561 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805781}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f13b78ef. With Chromium commits locally applied on WPT: 5083fb9d "sensors: Rewrite the frequency hint test." 70d18388 "[COOP] reporting WPT > rename + update expectations." c42229d8 "Fix double zooming in StyleBuilderConverter::ConvertBorderWidth()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I238c39f825744eee810e79ce8bc7a6ca59c45f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403700Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805780}
-
Robbie McElrath authored
This CL changes the layout of the shell app so the main weblayer FrameLayout has the correct height. The incorrect height was messing with the positioning of the bottom bar when scrolling it. Change-Id: I81808ee10a4c3a46ce25c4e5755c086199da5743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402286Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#805779}
-
Tanmoy Mollik authored
This cl removes signin_promo_status_message string. This string was used in personalized sync promos. But this string is now hidden and no longer shown on the UI for sync promos. It is replaced by sync_error_card_title that is used in SyncErrorCards. Bug: 1124701 Change-Id: Id111d1df6fbee1b336b253867161cfb9b3c217fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391086Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805778}
-
Jeff Yoon authored
linux-chrome is used by PGO to ensure validity of the profile being rolled and to warm up the goma cache. this trybot is currently not triggerable (ie/ crrev/c/2403600). Bug: 1105530 Change-Id: I9d8b8082d5817f9f7e7f97beae3faf0c2adf2088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403587 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805777}
-
Olivier Robin authored
Change-Id: I98d66c0f0a0a21fe6aa99190c0248faad10dae35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403468 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#805776}
-
Hiroki Nakagawa authored
|is_control_group| param on PrerenderContents::StartPrerendering() was removed in: https://chromiumcodereview.appspot.com/11348357 Bug: n/a Change-Id: I4ee52257916e596dc8517c2b7421e7abb8de6c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400590 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#805775}
-
David Tseng authored
R=jamescook@chromium.org AX-RelNotes: n/a Fixed: 1124714 Change-Id: Ibb84e2e76a5fb6e68b24151d5de747e6ef0a6dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401702Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805774}
-
Eugene But authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios.git/+log/959e66d5aea0..58ae5f81390b Manual change: Remove tabs from components list $ git log 959e66d5a..58ae5f813 --date=short --no-merges --format='%ad %ae %s' 2020-09-09 andrewoverton [TextControls] Refactor sizing behavior + expose sizing delegate method 2020-09-09 bryanoltman [BottomNavigation] Remove supplemental directory from examples. 2020-09-09 afweiss Update Bottom Navigation Item View accessibility traits so that VoiceOver works correctly on iOS 14. 2020-09-09 afweiss Remove unused StringsConstant file from Tabs 2020-09-09 no-reply [Banner] Change the trailing padding constraint for textView on MDCBannerView to match the Material Banner specs (https://material.io/components/banners#specs). 2020-09-08 afweiss Remove now unused TabBar resources from Podspec 2020-09-08 randallli [MDCSnackbar] Example: Dismiss snackbars when push or popping the example VC. 2020-09-08 andrewoverton [TextControls] Add `containerRadius` to MDCBaseTextField 2020-09-08 afweiss Remove pre-iOS 10 handling for voiceover now that components support iOS 10+ 2020-09-08 bryanoltman Bumped version number to 115.0.0. 2020-09-08 bryanoltman Hand-modified CHANGELOG.md API diff. 2020-09-08 bryanoltman Automatic changelog preparation for release. 2020-09-08 bryanoltman Delete now-unused BottomNavigation resources from Podspec 2020-09-08 featherless [Slider] Expose thumbBorderWidth and thumbIsSmallerWhenDisabled. Created with: roll-dep src/ios/third_party/material_components_ios/src Change-Id: Id797db06ab92d8e159510db744412afc33b6375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402439 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#805773}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88a5d76f5f62..2b117e76f5dc 2020-09-10 tvanderlippe@chromium.org Implement GRD file check for devtools_pre_built 2020-09-10 jobay@google.com Move filterRegex from String prot to string-utilities.js 2020-09-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-10 jacktfranklin@chromium.org Revert "Add lit-html/directives/live.js to the grd" 2020-09-10 jacktfranklin@chromium.org Add lit-html/directives/live.js to the grd 2020-09-10 jacktfranklin@chromium.org Revert "Expose the live directive from LitHtml" 2020-09-10 szuend@chromium.org Migrate COEP issue descriptions to use Markdown 2020-09-10 patrick.brosset@microsoft.com Grid: Fix misplaced grid overlay labels on high DPI monitors 2020-09-10 kprokopenko@google.com Add elements component 2020-09-10 jacktfranklin@chromium.org Fix optional params in bridges function types 2020-09-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-09 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewUnusedDeclarations.js with TypeScript 2020-09-09 chrche@microsoft.com [Loc] Presubmit#3: LocV2 Checking the shape of localization API calls 2020-09-09 aerotwist@chromium.org Migrates theme patching to top-level ThemeSupport 2020-09-09 chrche@microsoft.com [Loc] Presubmit#2: prevent using of LocV1 APIs in migrated files 2020-09-09 jacktfranklin@chromium.org Persist the network filter text input. 2020-09-09 jacktfranklin@chromium.org Expose the live directive from LitHtml 2020-09-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1099162,chromium:1114694,chromium:1126348,chromium:1126630,chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8a1d1d6417827c6f55042ebdfab8bc114a3a9715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805772}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I6f6fb791f00075cffdb791d8297289cbea383a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401047Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805771}
-
ckitagawa authored
Improve test coverage for PaintPreviewTabService by covering auditing. Change-Id: I4482732105561f1576900a79f4d68479b90f4604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402161Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805770}
-
Jan Wilken Dörrie authored
This change removes Desktop only code checking the state of the Password Check feature flag. This feature is fully launched on Desktop, and the flag should be removed eventually. For now we keep it around, because we use it in cross-platform code to guard the implementations on mobile. Bug: 1049177, 1126051 Change-Id: I9331ffc97133d2df80f3aec7cad1e17482a459a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401462 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#805769}
-
John Budorick authored
Bug: 1097306 Change-Id: I9c23dae3e78aa6d975692c0d8ce98b549a7e7756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396621Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#805768}
-
Mohamed Amir Yosef authored
Bug: 1125725,1125726,1125727,1125728,1125729,1125736,1125737,1125796,1125817,1125818,1125819,1125820,1125821,1125822,1125823,1125824,1125825,1125826 Change-Id: I3b8191a914375111f7acd1e09d4a0aee1a62c6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397617Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#805767}
-
K. Moon authored
Adds a new study to the field trial testing config to experiment with disabling PDF partial loading. PDF loading fails under certain circumstances, and disabling these features should help. The feature switches were added previously in crrev.com/c/2349429 and crrev.com/c/2352217. Note that the PdfPartialLoading feature requires the PdfIncrementalLoading feature, since it relies on PDFium to issue requests for additional segments of the PDF. Fixed the ChromeFindRequestManagerTest.FindInChunkedPDF browser test to enable the partial loading features explicitly. Bug: 1115149 Change-Id: I3aa5333c088687d5b299459335a386e4b889b55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387436 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805766}
-
Vasiliy Telezhnikov authored
CheckResetStatus need to three different things and in specific order if it detects problem: 1. Set `device_needs_reset_` to true. This needs to happen first as it's used in MarkContextLost. 2. Call MarkContextLost 3. Return true. This must happen only if context was lost. Before this CL there was couple of problems: * default case in switch would return true, but never lose context. * OutOfMemory case would lost context before setting device_needs_reset_ This CL extracts logic for checking errors from CheckResetStatus into GetResetStatus to make sure we do all the actions above in one place and make code less error prone. Bug: 1126490 Change-Id: I1a86ad2cc783ee2fd2dcf828612f2b657aba23ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401400Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#805765}
-
Fergal Daly authored
It's no longer doing anything interesting anymore, so removing it makes the code easier to follow. Change-Id: Ia4b71aedd483395eb1afe250461876e1a239a410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359591 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805764}
-
Victor Hugo Vianna Silva authored
TBR=droger@chromium.org Bug: None Change-Id: Id67464ecc19669fe82666dc4c4c38042ef2827d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403482Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#805763}
-
Mark Mentovai authored
This previously landed at d4fb5657 (https://chromium-review.googlesource.com/c/2399518) but was reverted at 31db08c8 (https://chromium-review.googlesource.com/c/2401271) due to test failures caused by a bug expressed on macOS 10.12.1–10.13.3. This update includes the fix for that bug via Crashpad 9a5a789123d7. Update Crashpad to 9a5a789123d7528d1c1cb71e66134fe0d7a9d37a 7547d0aa874f android: Remove orderfile configs from handler trampoline b4724081350e fuchsia: Remove run_tests.py functionality ebab28f30d33 Remove a variable-length array* to enable compiling with -Wvla 1509aadd6364 Remove a variable-length array to enable compiling with -Wvla 45ca490687af Build with -Wvla, forbidding stack-allocated variable- length arrays 59e8120e7ada [Wconversion] Suppress warnings on Fuchsia 71695216f9bb ios: Fix Xcode project buildgen dc9f3a58aabb fuchsia: Fix Wconversion on Mac/iOS builds 364fdd65a01e fuchsia: Fix Wconversion on Mac/iOS builds (take two) bdf94713241b mac: Switch from <AvailabilityMacros.h> to <Availability.h> 56937e1df569 mac: 11.0 SDK support b3d84e0d0571 mac: System libraries are no longer found on disk on macOS 11 df3bc64246ab mac: Be more positive c4acae9f961a fuchsia: fix configs clobbering in GN template 3965bc7d7894 Refactor OS_LINUX usage for coming LaCrOs update 5412beb63386 mac: Replace MacOSXMinorVersion with MacOSVersionNumber e0d8a0aa01ac mac-arm64: Cope with signal handling quirks abfc89bb9b70 mac-arm64: Set expectations for tests that crash via __builtin_trap ca83774eea9c mac-arm64: Make MacModelAndBoard use target-type instead of board-id f8563cb8626a mac-arm64: Omit the cl_kernels workaround on this platform 0bc3826129d5 mac-arm64: Allow target_cpu = "mac_universal" to create universal builds df12d57e97b4 mac: Don’t build 32-bit ProcessReaderMac support where it’s unusable ca88ff1edb8e mac-arm64: Don’t attempt to determine the CPU frequency fc97e5cbb21d mac: Work around broken {CTL_KERN, KERN_PROCARGS2} sysctl in 11.0db6 9a5a789123d7 mac: Fix MacOSVersionNumber for 10.12.0 < version < 10.13.4 Bug: crashpad:345,crashpad:347,crashpad:352,crashpad:355,chromium:1103944 Change-Id: I3389051cfbd4fa3e7e503d43a5242789e266213d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403660 Commit-Queue: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805762}
-
Yutaka Hirano authored
Bug: 1109855,1037381 Change-Id: Ief5b3631c257aef10650d16968d4d9050ec82ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397457Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#805761}
-
danakj authored
These (non-include) references should now point to content/browser/renderer_host where the code has moved to. TBR=avi@chromium.org, arthursonzogni@chromium.org Bug: 1091083 Change-Id: I8d0ace9fab6c04e3b498eee8d442ff6bd52fd7a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402185Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805760}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bdb38e31199e..13bf12548291 2020-09-10 landrey@webrtc.org Make token logs easier to use in BigQuery. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1114055 Tbr: skyostil@google.com Change-Id: If1ee1b428a7606f05f4ae4534a063571e96b8081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805759}
-
Fritz Koenig authored
Make sure that there is no pending change resolution after the last buffer is received. BUG=b:161904111 TEST=seek test starting to pass on trogdor Change-Id: I7e01216d3f24f19d097d72c99a4f2ed8598c5f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382950Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805758}
-
Randy Rossi authored
Patch set 1 is baseline of unmodified downstream files. Downstream refs will change to point to this ax bridge once this lands. Test: Unittest Bug: None Change-Id: I5157c0a9caa1f662998e1f3222b519008369d621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386102Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805757}
-
Xida Chen authored
We have seen that the kUniversal tracker penalizes the throughput too much, so remove this code. Bug: 1122176 Change-Id: I378eaa1327af7fa065c548abff7e99e822fa2d0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392768Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805756}
-
Paula Vidas authored
On sign in, FCM handler starts listening to invalidations. On sign out, it stops listening and deletes instance id. Bug: 1119294 Change-Id: Id6afaa49062662624fd239ba4302367e353340e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400997 Commit-Queue: Paula Vidas <paulavidas@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#805755}
-
Morten Stenshorne authored
We usually refrain from creating NG objects inside a force-legacy layout subtree (with the LegacyLayout enum). However, in some cases we might still want to insist on creating NG objects in such a subtree, e.g. if the box type has no legacy layout implementation (which is the case for e.g. MathML). This resolves bug 943574 - albeit as WontFix, since that bug asserts that we shouldn't have NG objects inside legacy subtrees. No behavior changes intended; this is just a preparatory CL for MathML to work inside legacy subtrees. Bug: 943574 Change-Id: Ic3d99c0f072f6bd5b849280ad29b4f4aaedde99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400501Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#805754}
-
Rijubrata Bhaumik authored
Origin Trial feedback was that webNFC is better without ignoreRead. Spec changes: PR: https://github.com/w3c/web-nfc/issues/579 https://github.com/w3c/web-nfc/commit/00509fc2df1fa63a0456034afb04eb16d03ca4cd Bug: 520391 Change-Id: I9ed23c65f20f028e4cc6621dc7e8eb29a1abb262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401021Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Kenneth R Christiansen <kenneth.r.christiansen@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arnaud Mandy <arnaud.mandy@intel.com> Cr-Commit-Position: refs/heads/master@{#805753}
-
Yuki Shiino authored
Fixes the installation of allocator shim at //base/BUILD.gn in the following way. 1. Hook the standard allocator functions. Add appropriate allocator_shim_override_xxx according to the platform so that we hook the standard allocators. 2. Add the default dispatcher of the allocator functions. Add appropriate allocator_shim_default_dispatch_to_xxx according to our own allocator (PartitionAlloc, TCMalloc) or, if we use the system allocator, according to the platform (glibc, MacZonedMalloc, WinHeap, etc.). This is a logical and comprehensive way to install the appropriate allocator hooks and shim. Bug: 998048 Change-Id: Id3d5b5708a94f7894971d2131c83b17f6eada096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392189Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#805752}
-
Bret Sepulveda authored
This is a reland of 85ae69b0. Fixes namespace conflict with branded builds. Verified by local compile. Original change's description: > Add new class ColorTrackingIconView to deduplicate subclasses. > > Upon investigating the associated bug, I noticed that there are a few > subclasses of ImageView that exist solely to override OnThemeChanged. > Since I also needed a subclass like this to fix the bug, I decided to > make a utility class to eliminate this ad-hoc subclassing, in the style > of ColorTrackingVectorImageButton (in image_button_factory.cc). > > Bug: 1125510 > Change-Id: I975a9b6a4676bb6b2a454172f211f406934d7869 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397737 > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804901} Bug: 1125510 Change-Id: Icbe7240ab8159f1c61f510f03dab7e5d6c5d563b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401018 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#805751}
-
Ioana Pandele authored
This reverts commit 551bbd27. Reason for revert: Reland with fix for the status update. TBR=tedchoc@chromium.org TBR-ing since the DEPS file has already been reviewed and hasn't changed. Original change's description: > Revert "[PwdCheckAndroid] Add delay between check status header updates" > > This reverts commit 849b3b5d. > > Reason for revert: The assumption that the progress signal comes after > status signal was wrong, so this change causes a bug when re-running the > check. > > Since this was meant to be merged, reverting + fix is easier than fixing > in a follow-up CL. > > Original change's description: > > [PwdCheckAndroid] Add delay between check status header updates > > > > This CL adds a delay to status updates whenever multiple updates are > > notified to the mediator in a short time window. > > The minimum time interval between updates is set to 1 second. > > > > Bug: 1122026, 1092444 > > Change-Id: I64d9c95a11a5ed9b9d6fcf8941c260bf8b3a64ac > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390642 > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805236} > > TBR=tedchoc@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com > > Change-Id: I737eee5e355033542dc9ba8393eedc3390baf5de > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1122026 > Bug: 1092444 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401620 > Commit-Queue: Ioana Pandele <ioanap@chromium.org> > Reviewed-by: Ioana Pandele <ioanap@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805385} TBR=tedchoc@chromium.org,fhorschig@chromium.org,ioanap@chromium.org,erocchi@google.com # Not skipping CQ checks because this is a reland. Bug: 1122026 Bug: 1092444 Change-Id: Ib43b92f88393634d958582270d5dd9a1edba5829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403281Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#805750}
-
Benoit Lize authored
Stable 1% experiment shows very positive results on memory with no adverse responsiveness/latency issues, so let's enable the feature by default. More specifically, 95th percentile footprints (from the experiment): - Browser: -12% - GPU process: -12% - Per-renderer: -6% - Total: -7% And for discardable memory, -43%@95th percentile. Also remove the testing config, since it is no longer needed. Bug: 1109208, 926186 Change-Id: I99b1f8d36e2b754879ada98468a4464358652cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403465Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#805749}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d41d509a6a9..fb5e0ebef07c 2020-09-10 kjlubick@google.com [canvaskit] Pass in paints via reference If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I986e3aa910ba9f0138440f00e6d4f8cce51494b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403315Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805748}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I3b4442e611378935cbd9f88736f1871ad1971f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375287 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#805747}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I83edc3ba736db0a5beece82166906b4a1478921c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401342Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#805746}
-