GitLab

PersonalDataManager now checks the sync feature state in its
OnStateChanged method, and if the sync the feature is not on, it will
use the ephemeral account storage, instead of the persistent store.

Note that we previously wanted to use the USS bridge as a source of this
information, instead of observing the sync service directly. However,
using that approach means that all updates need to switch from the db
thread to the main thread. That could mean that while an account switch
update is underway from the bridge to PDM, the PDM is still committing
changes to the database for the previous account.

A cleaner fix may be to do the entire switch on the database thread, at
which point PDM only needs to be notified that the storage changed.

Bug: 878858
Change-Id: I6581eb45f7e3510142142e25ede5e8b296fcaf9d
Reviewed-on: https://chromium-review.googlesource.com/1194126
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587536}

This test is broken; every browser fails it in the same way, and the
thing it actually intends to cover is addressed by the other six tests
in https://wpt.fyi/results/cookies/secure.

Change-Id: Ib7b8534b35ae16490f2cf71e67936b5636e33fbe
Reviewed-on: https://chromium-review.googlesource.com/1196544Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587535}

Added TrustedTypes.getExposedPolicy(name) and bool exposed in TrustedTypePolicyOptions
Added test
Changed Vector of created policies into Map of created policies

Bug: 739170
Change-Id: Ib5fe7a14ddadb88e3de70ee55f2783b9d10a01b5
Reviewed-on: https://chromium-review.googlesource.com/1193869
Commit-Queue: Orsolya Bernadett Batiz <orsibatiz@google.com>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587534}

We want to know on the sync server whether full sync is enabled or not
so that we can separate the different types of users in dashboards and
monitoring, and so that we can decide to hit the new payments backend
for transport-only users.

We're adding this boolean to ClientStatus, because we're already sending
that on all ClientToServerRequest messages.

Whenever we switch between full sync and transport-only sync, the sync
engine gets reconfigured. This CL adds a boolean to that configure call,
which gets forwarded to the sync_cycle_context. The syncer_proto_util.cc
picks it up from there, together with other information that was already
part of ClientStatus.

Change-Id: Ie9283e83c2fa92c1d1467fcce59057ffced577d2
Bug: 878857
Reviewed-on: https://chromium-review.googlesource.com/1193878
Commit-Queue: Florian Uunk <feuunk@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587533}

|scope_url| and |script_url| are verified in RegisterServiceWorker().


Change-Id: I8f397298f266006b8be57f1c6aa01f445e21c646
Reviewed-on: https://chromium-review.googlesource.com/1177441Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#587532}

This change adds a skeleton for a fake implementation of IDeviceWatcher.
No functionality is added yet, this will be done in a follow-up CL.

Bug: 821766
Change-Id: If51716beac17543975d42632b17c8af7f269ac5c
Reviewed-on: https://chromium-review.googlesource.com/1193890Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587531}

The test pushes a policy and then waits for the extension to be
installed. Installing the extension requires loading a website, waiting
for a service worker, parsing the website and finally installing the
app. This takes time but, on Windows, it takes so long that the test
times out.

We have extensive unit tests for all portions of the flow so we could
delete the test and wouldn't loose any coverage, but we just disable
it on Windows since it's the only platforms where the test times out.

Bug: 878797
Change-Id: I12a59e959d8e8dde12c67fac5cb1ce72636bd6ce
Reviewed-on: https://chromium-review.googlesource.com/1195306
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587530}

When the CustomTabBottomBarDelegate is notified of the Contextual
Search Bar being triggered, it hides the Bottom Bar (setting its alpha
to zero). However, it is still present in the View Hierarchy (and will
be above the Contextual Search Bar) so it will intercept touches.

This CL sets the Bottom Bar View Visibility to GONE so touches reach
the Contextual Search Bar.

Bug: 875458
Change-Id: I9491158ab540b0637a8828eabca9fb56a9a54979
Reviewed-on: https://chromium-review.googlesource.com/1196602
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587529}

After a timeout, as well as after activating the wrong key (not registered,
already registered), show an error sheet even after the promise is already
rejected.

Bug: 849323
Change-Id: I08c7403a0fae9c5cf19b6f775f6845bd28e8c6ed
Reviewed-on: https://chromium-review.googlesource.com/1195371
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#587528}

MovableStrings don't have anything to do with std::move(), change their
names to a more meaningful one.

Also fix a couple trivial "git cl lint" warnings.

Bug: 877044
Change-Id: I5a2b500c6161725bdb6b64b48af8554c2d6c260f
Reviewed-on: https://chromium-review.googlesource.com/1194024
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587527}

A subsequent CL will rename MovableString to a more suitable name, this
was split to minimize the diff.

Also fix trivial "git cl lint" warnings.

Bug: 877044
Change-Id: I2b96530bc227100e59d840f5abeb5e7995521af9
Reviewed-on: https://chromium-review.googlesource.com/1193442
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587526}

Bug: 878356, 867421
Change-Id: I0991a840a0787b6863bea79ee4079e5db7fdfe0b
Reviewed-on: https://chromium-review.googlesource.com/1194074
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587525}

1. replace enum in the ChromeContextMenuItem with @IntDef
2. rewrite buildContextMenu in the ChromeContextMenuPopulator:
   * remove unnecessary variables and code paths
   * instead of included / excluded rules put easy to understand
     "if" conditions

Change-Id: If617448a96e4bd78777507d36d6cc29c6f668a5a
Reviewed-on: https://chromium-review.googlesource.com/1175119
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587524}

Rationale:
* We should never need to clear the PersonalDataManager before a test,
  because it shouldn't be created with data anyway (this could disrupt
  tests intended to test merging/deduplication logic/etc.)
* "Credit card upload is enabled" is the default expectation nowadays,
  even though it's still technically only enabled for certain
  countries.  The goal is still to launch it worldwide.  Thus, make it
  the default, and we shouldn't be concerned with turning it on for
  every test, only turning it off in non-standard situations.

Change-Id: I2328cada08d3e219be2f02d7ee0e7dee9526a1db
Reviewed-on: https://chromium-review.googlesource.com/1196104
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587523}

Check the default |path| by providing it and call checkIfNoErrors() in
its own step (like every one else).

Bug: 878260
Change-Id: I12850b65da97967a6075cb9a2869eac2b2b48ec7
Reviewed-on: https://chromium-review.googlesource.com/1195308Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587522}

https://chromium.googlesource.com/angle/angle.git/+log/ddc41208c15f..f0d0408a355e


git log ddc41208c15f..f0d0408a355e --date=short --no-merges --format='%ad %ae %s'
2018-08-30 oetuaho@nvidia.com Use OES_texture_storage_multisample_2d_array


Created with:
  gclient setdep -r src/third_party/angle@f0d0408a355e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Idd88f801255f1cefb7068520f32190e6511cd082
Reviewed-on: https://chromium-review.googlesource.com/1195014Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587521}

This patch makes member varaibles of |NGPhysicalTextFragment| to const
for improving readability.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I811faf98d2e26a87fdbabafad381fa0c4093132b
Reviewed-on: https://chromium-review.googlesource.com/1196483Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587520}

This CL introduces the new InvalidationServiceProviderFactory as substitute for
DeprecatedInvalidationServiceProviderFactory.

Bug: 801985
Change-Id: Ie6fb532a38b027a11702fa0a3a7dee335e3bd7c0
Reviewed-on: https://chromium-review.googlesource.com/1189603
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587519}

This CL deprectates the invalidator Registrar. The new
InvalidatorRegistrar will not use the ObjectId internally.

TBR=poromov@chromium.org

Bug: 878446, 801985
Change-Id: I0844401a01055e7e0365b45f485651d7dde45a49
Reviewed-on: https://chromium-review.googlesource.com/1193947
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587518}

Also remove RefCounted for NGUnpositionedFloat objects.
This shows a 2-5% perf improvement of float performance tests.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6bf42c7bb076dbdafbc74cf8f7667c5ea5eb6357
Bug: 635619
Reviewed-on: https://chromium-review.googlesource.com/1193881
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587517}

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I03cf162ea6d0035b483be088ee7c45d39b32c8b5
Reviewed-on: https://chromium-review.googlesource.com/1196423Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587516}

The idea is to have a member variable on LayoutBlock where RunOldLayout
can store the last used constraint space, to avoid future layouts when
nothing has changed.

LayoutBlock::UpdateLayout clears the cached constraint space to avoid
issues when we don't enter it through NGBLockNode (e.g. because
it's a layout root)

Produces good perf results especially on the large-table-with-collapsed-borders
tests (~6%)

Rebaselines one invalidation test -- we now invalidate less than before, but still
more than legacy.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I174c3165bd9cc2ad1697368b510c0c2d701a0a45
Reviewed-on: https://chromium-review.googlesource.com/1145491
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587515}

Before this CL, the Sync.ConfigureDataTypeManagerOption histogram recorded
"transport only" when local Sync was active. This CL fixes that.

Bug: 871221
Change-Id: If45d6d9aa8e44841d544a9626539c60586206826
Reviewed-on: https://chromium-review.googlesource.com/1196523
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587514}

* adding checks for all menu options (order and existence)
* adding new tests

Change-Id: I80843b526c92b6df6b4eb13b3b1ab5647c193787
Reviewed-on: https://chromium-review.googlesource.com/1189402Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#587513}

There's a new console warning...

TBR=kojii@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8844df915849377cf57a9f21ed78006e35f00534
Reviewed-on: https://chromium-review.googlesource.com/1196268
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587512}

This patch changes  |ElementInnerTextCollector::ProcessNode()| to check object
type before casting to |LayoutTableRow|.

The issue is caused by |LayoutSVGRect|'s computed style of "display" property
is "table-row".

This patch is follow-up of the patch[1] to fix the bug found by Cluster Fuzz.

Note: The patch[2] changes similar to this patch for table-cell.

[1] http://crrev.com/c/1114673 Implement Element#innerText to conform the spec
[2] http://crrev.com/c/1189262 Make ElementInnerTextCollector::ProcessNode() to check LayoutTabelCell

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1091f7ff094b24ce8e081fbd115af4734c98191f
Reviewed-on: https://chromium-review.googlesource.com/1195509Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587511}

https://crrev.com/c/1194041 has changed strings used for UMA in
preferences, but hasn't updated the activity title appropriately, so
the title for activity is using the wrong string. This CL fixes this
issue.

TBR=twellington@chromium.org

Bug: 868826
Change-Id: I8795cc0b6e3f04b8b511e0db4b2e4ee1b537f545
Reviewed-on: https://chromium-review.googlesource.com/1196504Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587510}

navigator.serviceWorker.controller was returning null sometimes. This CL
changes the way the active registration is queried and posted to (similar to
https://jakearchibald.github.io/isserviceworkerready/demos/postMessage/index.html

Bug: 878605
Change-Id: I9ab08881db18a91933481ae7fabfe2ff25ce94f3
Reviewed-on: https://chromium-review.googlesource.com/1195505
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587509}

This function allows getting the manufacturer and model of the
computer where Chrome is currently running.
This is going to be used by the upcoming Hardware Platform
extension API.

Bug: 860311
Change-Id: I90f9b06de5c54c6062d303b2bacda2ec825afb02
Reviewed-on: https://chromium-review.googlesource.com/1190062
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587508}

Re-routing to newer bug which contains more analysis of the issue.

TBR=schenney@chromium.org

Bug: 636207, 876732
Change-Id: Ic857feff265217a0244fd0bd25999d0db354b0b2
Reviewed-on: https://chromium-review.googlesource.com/1196343Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#587507}

This change modifies FidoBleConnection to no longer hairpin callbacks
and updates the appropriate tests.

Bug: 763303
Change-Id: I85149d600e8c5f510958d117fdaac6de49111107
Reviewed-on: https://chromium-review.googlesource.com/1193860
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587506}

Nothing else uses it (it's only included from video_player_scripts.js).

Bug: 879035
Change-Id: I58e1b939201d466a65027ae48b73b9053afac59d
Reviewed-on: https://chromium-review.googlesource.com/1195179Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587505}

Furthermore, if we receive the caBLE extension, skip directly to the
caBLE screen.

Bug: 878999
Change-Id: Iea80f7cc71365591a1ece4eccc61bcf5c062e9f8
Reviewed-on: https://chromium-review.googlesource.com/1195734
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587504}

Currently Chrome browser attempts to power on Bluetooth adapter if
adapter is present and not powered on. Disable this feature so that
Bluetooth adapter is powered only when user consent is received from UI.

Bug: 877344
Change-Id: Ia81cef9cbdf13a72cbd3ab5fa02c412aded4d41a
Reviewed-on: https://chromium-review.googlesource.com/1195736
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587503}

Add logic to power on BLE adapter from WebAuthN UI.

Bug: 877344
Change-Id: I39a9bb563a268654d15586c4a6b8226fd07ff5f5
Reviewed-on: https://chromium-review.googlesource.com/1196229
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587502}

Design doc: go/cca-tap-to-focus

BUG=b:80271276
TEST=Pass capture_unittests
TEST=Check tap-to-focus works on a patched CCA with the back camera of
     Nautilus manually.

Change-Id: I2c09e62b20e0ff61d841fadb2f2f9513553e5ede
Reviewed-on: https://chromium-review.googlesource.com/1190462Reviewed-by: Ricky Liang <jcliang@chromium.org>
Commit-Queue: Shik Chen <shik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587501}

This helps avoid polluting the global namespace with some
functions like GetBrowserContextId().

Bug: 775415
Change-Id: Iac37e7067be5a42141cf06481a5cc1c97fae3b8c
Reviewed-on: https://chromium-review.googlesource.com/1195482
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587500}

It is often hard to point the exact cause why a preload is not used
for a request |r|. This CL adds a warning message when there is a
preloaded request for |r|'s URL and type, but somehow not used, with
the reason.

Bug: 878225
Change-Id: Ib4ed4655cd9a964c3d60058f8a330b1c098c93b6
Reviewed-on: https://chromium-review.googlesource.com/1193163
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#587499}

oom_score_adj should not be set to -1000 for ARC++ processes.

Bug: chromium:876976
Change-Id: I4259d646755761dce5429170a45be5f8faf34b9f
Reviewed-on: https://chromium-review.googlesource.com/1186282
Commit-Queue: Vovo Yang <vovoy@chromium.org>
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587498}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/34e1c43703b3..175653356591


git log 34e1c43703b3..175653356591 --date=short --no-merges --format='%ad %ae %s'
2018-08-30 gmeinke@chromium.org cbuildbot: remove saving emerge install plan


Created with:
  gclient setdep -r src/third_party/chromite@175653356591

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I7a0203d9696fefe15d632d8be483d9a481aab872
Reviewed-on: https://chromium-review.googlesource.com/1196173Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#587497}