- 14 May, 2019 40 commits
-
-
Takashi Toyoshima authored
Host header is expected to be set by the network stack and the value should be aligned with the destination host, or |url| in the ResourceRequest. Users' JavaScripts can not set this header because the name is listed in |forbidden header name| of the fetch spec, but still mojo IPC can be compromised potentially, and having this second check in the network service would reduce security risk. Bug: 925359 Change-Id: Idfe9209fec9c5ed72c384ff2592e02c96a2e77a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601086 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#659373}
-
Tetsui Ohkubo authored
Linux's input_id offers version field in addition to bustype, vendor_id and product_id. In USB spec, the field is called bcdDevice. In order to improve gamepad support in ARC++, we will need the field in addition to others. TEST=manual BUG=b:130597086 Change-Id: I6c47313b5d95b96787494fc782bc3090e6bb31e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599758Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#659372}
-
Zhenyao Mo authored
BUG=961558 TEST=manual R=piman@chromium.org Change-Id: Iea2a80e0cc85315008283e6e2470fc93c149309f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610489Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#659371}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I21cc0e19e385bd33732a2a794f6192de15421af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611082Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#659370}
-
Koji Ishii authored
When |LayoutBlockFlow| adds a child, it assumed all anonymous |LayoutInline|s are anoymous wrappers for ::first-line, but there are two other usage of anonymous |LayoutInline|. This patch checks if it is really an anonymous |LayoutInline| for ::first-line. Bug: 962275 Change-Id: Ibbde37297e4636e4f0c51f0ed8249e3166639d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610657Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659369}
-
Christopher Cameron authored
The versioned entrypoint ChromeAppModeStart_vX should ideally only contain code that could change across app shim versions. Similarly, the AppShimController structure shouldn't use any versioned structures. Somewhat improve this situation by: - Changing AppShimController to take a Params structure, instead of taking the versioned ChromeAppModeInfo structure. - Moving the code to find or launch Chrome from ChromeAppModeStart_vX to AppShimController (which was already managing that connection). Change-Id: I85361e776ec7a00bdd71fea5062029170a0935af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610468Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#659368}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/06f5b2262451..6a9b00e433cf git log 06f5b2262451..6a9b00e433cf --date=short --no-merges --format='%ad %ae %s' 2019-05-14 raul@tambre.ee scm: Replace invalid UTF-8 in Git output Created with: gclient setdep -r src/third_party/depot_tools@6a9b00e433cf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942522 TBR=agable@chromium.org Change-Id: I7ff4cfafe3ca2d5f425b3aa6844bbbd9aab1275e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659367}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/147d8dd0..d1fbae93 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I80177fe9cdce8b5de21bf305900e2b67ccad5568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611135Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659366}
-
Tetsui Ohkubo authored
This CL adds a feature to forward gamepad device information to ARC container. The feature can be enabled by ExoRawGamepad feature flag. In order to forward the information, this CL adds a new Wayland event gamepad_added_with_device_info. This is a part of the effort to improve ARC Gampad compatibility. Design doc: go/arc-improved-gamepad TEST=manual(--enable-features=ExoRawGamepad to /etc/chrome_dev.conf) BUG=b:130597086 Change-Id: If492a8a7a46d1cf321e4e8b3daa94645bb55a7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602193 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima (slow - gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#659365}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a5b7536b5998..b286dfef4182 git log a5b7536b5998..b286dfef4182 --date=short --no-merges --format='%ad %ae %s' 2019-05-14 akeshet@chromium.org test_stages: remove schema change workaround 2019-05-14 dburger@chromium.org Use common image types in image controller. Created with: gclient setdep -r src/third_party/chromite@b286dfef4182 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ifbcbfced779141f2c7750d7f0d0cda1ea82b5205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610888Reviewed-by:
-
Takashi Toyoshima authored
Since andrewhayden@ left the project, and has been inactive for two years, remove his account from this OWNERS file. Change-Id: If53dc51e18ff7267d0a220592c785dffb3c55ca0 NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598903Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#659363}
-
Jinho Bang authored
There are subtle differences between ThreadUtils.* APIs and TestThreadUtils.* APIs. Using TestThreadUtils might cause to change task scheduling timing and it ends up with causing breaking some existing tests. So, we use ThreadUtils.* instead of TestThreadUtils.* for now and then should split the migration work into smaller changes. Reason for revert: broke the Android CFI build https://luci-milo.appspot.com/p/chromium/builders/ci/Android%20CFI/5312 Original change's description: > This clean-up patch includes the following things: > - Replace ThreadUtils with TestThreadUtils > - Replace runOnUiThreadBlocking with runOnUiThreadBlockingNoException > - Remove unnecessary ExecutionExceptions > - Remove unnecessary Callable > - Replace (Runnable) type-casting with () -> {} > > This patch is triggered from here[1] > > [1] http://crrev.com/c/1575307/9/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java#394 > > Bug: none > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601612 > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658044} Bug: none Change-Id: Ifa4bc1dab29313acec3ca6daf9dd3b6abff4df65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605325 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#659362}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df5951368ef0..a0cc08d19d95 Created with: gclient setdep -r src-internal@a0cc08d19d95 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I42969364afd6cd16e303470920fc88b9f5553881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610889Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659361}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/726ece1b5340..2169a778183b git log 726ece1b5340..2169a778183b --date=short --no-merges --format='%ad %ae %s' 2019-05-14 thomasanderson@chromium.org Move pdfium sources into fpdfsdk Created with: gclient setdep -r src/third_party/pdfium@2169a778183b The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:960288 TBR=pdfium-deps-rolls@chromium.org Change-Id: I41be15646bb372865d104d30144a6f90eec5ae61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610890Reviewed-by:
-
Matt Falkenhagen authored
In APP_CACHE mode, the eviction is somewhat disabled by design, but callers were specifying a size limit which caused eviction anyway. This was causing undesired eviction for service worker scripts, where we expect the quota manager to manage the space usage instead. This CL changes APP_CACHE callers use int64_max as the size limit, including service worker and appcache. The Cache Storage API was already using int64_max. Note that the int64::max is only respected by the Simple cache backend. Service worker uses Simple cache[1] while AppCache has a build flag that allows toggling between Simple and Blockfile.[2] The Blockfile backend goes up to int::max only. [1] https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_disk_cache.cc?l=12&rcl=c7a9d26cc435f6074ee2372fef360245524e2cf8 [2] https://cs.chromium.org/chromium/src/content/browser/appcache/appcache_disk_cache.cc?l=198&rcl=8e7751dff574550f053ff580f4c174dc54130c74 There is no test added because I can't think of a way to test this. Bug: 526915 Change-Id: I808a15312adaa3fc26c78eb165fa79dc13058aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608868Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#659359}
-
Kent Tamura authored
https://dom.spec.whatwg.org/#dom-document-createattribute document.createAttribute("foo:bar") created an Attr object with prefix="foo" localName="bar" namespaceURI=null. It should be one with prefix=null localName="foo:bar" namespaceURI=null. The new behavior matches to Firefox and Edge. Bug: 961328 Change-Id: If18c9c427dba3eaa38b3b69c32544ea8b91c2f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611059Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#659358}
-
Vlad Tsyrklevich authored
Refactor CrashAnalyzer to create a new GetAllocatorState method to run early error handling logic from AnalyzeCrashedAllocator(). This has almost no functional change, the only change is that now some error histograms may be reported twice if both malloc and PartitionAlloc hooking is enabled and those errors occur. This is in anticipation of a change that will change the metrics to be reported per-allocator. Bug: 960532 Change-Id: I0efd4d0fd20e8085877e3e81b5b77923e60fbfc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611207 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659357}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8fae51b699a6..01eaf1779b3a git log 8fae51b699a6..01eaf1779b3a --date=short --no-merges --format='%ad %ae %s' 2019-05-14 herb@google.com Remove global mutex around CG Created with: gclient setdep -r src/third_party/skia@01eaf1779b3a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: I5fdcb7a4774f23c693859107f37aff9efae3c0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610886Reviewed-by:
-
Ian Vollick authored
Changes event propagation for no-touch activity. Bug: 961833 Change-Id: I57427cd9b899c4f65ee3d9d5a466eb04334d4b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610648Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#659355}
-
rbpotter authored
This test only runs correctly as part of test_suite_all.py. Fix it so that it can be run with: python tools/grit/grit/gather/chrome_scaled_image_unittest.py (on Win) or ./tools/grit/grit/gather/chrome_scaled_image_unittest.py (on Linux) Also clean up some > 80 character lines. Bug: 961359 Change-Id: Ib8fa07da899c6e45a4a4522889c801f5081c258b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611080Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#659354}
-
Tetsui Ohkubo authored
It seems gaming-input-unstable-v1 is no longer used as there's gaming-input-unstable-v2. TEST=trybot pass BUG=b:130597086 Change-Id: I4e904ba126a50d956051e45eb1ebab07bc9e3d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602192Reviewed-by:
-
Justin Cohen authored
This is a speculative change to mitigate the crashes in https://crbug.com/959499 Bug: 959499 Change-Id: I37e9d088abf8093cf0a74d410d38a42edac0e5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604522 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#659352}
-
Meredith Lane authored
This change removes the write capabilities of Element.accessibleNode, for string properties only. Other attributes will be decoupled in future based on type, and sparse attributes are not part of this change. This is due to a simplification of the API to avoid computing the Accessibility Tree in order to modify it. See: https://github.com/WICG/aom/blob/gh-pages/explainer.md BUG=746523 Change-Id: I63ccd52f7193f017559402d76d4c446423e27743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605322 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#659351}
-
Gyuyoung Kim authored
As the first step to deprecate WTF::CString, the bug has suggested replacing EXPECT_STREQ with EXPECT_EQ. This CL replaces EXPECTED_STREQ with EXPECT_EQ in the cases of converting WTF::String to const char* in order to use EXPECTE_STREQ. Bug: 950077 Change-Id: Ida8b633a3439d9072ca133678be17bf02d9fd4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607704 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659350}
-
Sam Zackrisson authored
The acoustic echo canceler AEC2 is deprecated. There are no existing Chrome clients reporting WebRTC.AecDelayBasedQuality. Bug: webrtc:10563 Change-Id: I10e6cd376524564fd1b355b34d510e376ecb4dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609240 Auto-Submit: Sam Zackrisson <saza@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#659349}
-
Sergey Ulanov authored
fuchsia.sysmem.Allocator interface will be used to allocate buffers for video frames. Bug: Fuchsia: WEB-41 Change-Id: I08f2d23b31c8a2faa9422b1ecdc2ec45f4bfedfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609720 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#659348}
-
Caleb Rouleau authored
Currently it only works with the story name, i.e.: '--isolated-script-test-filter=dummy_page.html' but we need it to work with the full '/'-delimited path along the test results json, i.e.: '--isolated-script-test-filter=dummy_benchmark.noisy_benchmark_1/dummy_page.html'. Bug: 894254 Change-Id: Ib9ebee49007369fc28a45e986738771e22784d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611197Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#659347}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/8f877b2e3820..726ece1b5340 git log 8f877b2e3820..726ece1b5340 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 tsepez@chromium.org Beef up tests for CFX_XMLNode insertions. 2019-05-13 tsepez@chromium.org Rename CXFA_LayoutPageMgr functions that operate on children only. Created with: gclient setdep -r src/third_party/pdfium@726ece1b5340 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Iad4638f871cdbc039a617b0db470bc668d3f2465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610885Reviewed-by:
-
rajendrant authored
The tests use some neterrors that are internally falledback and handled by the NetworkService. So the DRP loader throttle does not receive them to record DRP InvalidResponseHeadersReceived.NetError histograms. This test instead relies on warmup fetch failures being recorded. Theere is some difference with M74 and M75, that the WarmupURLFetcherCallback.SuccessfulFetch.InsecureProxy.Core is recorded in M75 and InsecureProxy.NonCore. The test is fixed to run only for M75+. Bug: 934875 Change-Id: I2a2147b2d0d94343334494dd7d3558b1e6ec4201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610508Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#659345}
-
Alexei Filippov authored
This reverts commit 10ac3cfb. Reason for revert: The revert didn't help, see https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/33371?blamelist=1#blamelist-tab Original change's description: > Revert "Native Theme support for System Tray Focus Rings" > > This reverts commit 4f6f29a2. > > Reason for revert: > Speculative revert for possibly breaking BookmarkBubbleViewTest.SyncPromoNotSignedIn > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/33302?blamelist=1 > > Original change's description: > > Native Theme support for System Tray Focus Rings > > -> Set Native Theme for UnifiedSystemTrayView > > -> Remove hardcoded transparency for all focus rings > > -> Add transparency to default focus border color in common theme > > > > Bug: 948959 > > Change-Id: Ia4ee4315a894623ca9e5c20944972ce29714e2c3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597114 > > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> > > Reviewed-by: Tim Song <tengs@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#658705} > > TBR=sky@chromium.org,tengs@chromium.org,beccahughes@chromium.org,amehfooz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 948959 > Change-Id: I9c42c2c959cdaa63fcad61719e62a2036a905086 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610860 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Commit-Queue: Alexei Filippov <alph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659236} TBR=sky@chromium.org,tengs@chromium.org,alph@chromium.org,beccahughes@chromium.org,amehfooz@chromium.org Change-Id: Iea836dc38e03f3d1a5f2c51063e3b44d89d84037 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611133Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#659344}
-
John Lee authored
Bug: 962357 Change-Id: I834c12978f37ddba38c8c3be70ff34e5ba139823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611139 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#659343}
-
rbpotter authored
Do not attempt to prefetch recent destinations. On Windows, separate printer driver instances may not be independent, so we have to perform all capabilities fetches in sequence on a single thread. This may cause hangs when some recent printers are no longer available. Instead, fetch recent printers only when the user selects them from the dropdown. If a printer cannot be found when it is selected, show a UI error. This change means that Print Preview won't confirm recent destinations exist with the backend before showing them in the dropdown, so users will be able to select printers that may no longer be available. If this happens, display a UI error (existing "printer is not available or not installed correctly" message) when they select the printer and fetch fails. Change-Id: Iaa227bd0c7cb806b36cdc9fa0b8d15e846db0bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607133 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#659342}
-
Jeevan Shikaram authored
Enable App Management by default. Current entry points are about:settings and about:app-management. Bug: 906508 Change-Id: I0118a4b51eda6e65bc72186e771fc2ede2acb45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610658Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#659341}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/23a97021347c..df5951368ef0 Created with: gclient setdep -r src-internal@df5951368ef0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I96a49027f37419939c202da853414c24ec06e6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610788Reviewed-by:
-
Robert Liao authored
Dark mode support is now enabled by default on all supported platforms. BUG=923516,927180 Change-Id: I3486b3714149c311b60f7114cb08883335129221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597930 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659339}
-
David Jacobo authored
Bug: None Test: Build, doesn't modify funcionality. Change-Id: I5c741baea2e143884ca750eafac1070fd19c0e8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609592 Commit-Queue: David Jacobo <djacobo@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#659338}
-
Kelvin Jiang authored
This CL modifies the behavior of tab switches in activity log where: 1) If a user switches from the stream tab to history tab, then back to the stream tab, the previous items in the stream should still be visible. 2) The stream is paused if the user navigates away from the stream tab. In order to accomplish this, some logic to manage the stream's state and its event listener was moved from activity_log_stream to activity_log. Bug: 932768 Change-Id: I1f6197533d099b4c643c05c5c7280f8ec2217b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601834 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: -
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bbc5238c48bb..a5b7536b5998 git log bbc5238c48bb..a5b7536b5998 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrome-bot@chromium.org Update config settings by config-updater. 2019-05-13 gbiv@google.com afdo: don't merge branch profiles into ToT profiles 2019-05-13 gbiv@google.com cbuildbot: Add a local OWNER for AFDO scripts 2019-05-13 saklein@chromium.org scarlet-compile-only-pre-cq: Use -chrome_internal 2019-05-13 manojgupta@google.com cros_fuzz: Add checks for msan. Created with: gclient setdep -r src/third_party/chromite@a5b7536b5998 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I502647c6dc84a4ede6dfc544ef8b66b4de652b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610883Reviewed-by:
-
Dan Beam authored
R=kristipark@chromium.org BUG=957353 Change-Id: I8eae1cad80062ff3ee97f8eef2bfad774058f5ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609588 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#659335}
-
Vlad Tsyrklevich authored
Refactor the CrashAnalyzerTests to use CrashAnalyzer::GetExceptionInfo() instead of AnalyzeCrashedAllocator()--this is in anticipation of an upcoming refactor. There is no functional change, but it does have the benefit of having these tests use the public interface instead of a private internal method. Bug: 960532 Change-Id: I19cf964e15f08c0b6444103087acb050b63da228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611201 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
-
