- 29 Sep, 2020 40 commits
-
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I65aefa50029d343f21beb321df3d95fd39fabd91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432768Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#811604}
-
Koji Ishii authored
r810360 crrev.com/c/2429204 changed to `white-space: pre` but it was not effective because we have: white-space: pre-wrap !important; in the UA stylesheet for view-source. This patch updates the UA stylesheet accordingly. Verified this change prevents line wrapping in content_shell. Note the "!important" has been there since 2007, in the initial commit of this file[1], but the CL message does not explain why it is needed. This patch removes it because I do not find it is necessary. We can bring it back if we find it is necessary for any reasons. [1] https://source.chromium.org/chromium/chromium/src/+/0e882e3da67c5efbd3b292a643d79867a4968950 Bug: 920571 Change-Id: Ic3221778142f697e7baa82725b3d54db397e3933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432706Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#811603}
-
Tim Song authored
This is a reland of ac56b3e7 Original change's description: > [CrOS PhoneHub] Add PhoneHubUiController. > > This class translates the PhoneHubManager state into the corresponding > UI state and view that is shown in the tray bubble. Each state has > it's own view class and the PhoneHubTray bubble transitions through > these content views as the UI state changes. > > This CL also refactors PhoneConnectedView into it's own class. > > BUG=1106937,1126208 > > Change-Id: Ie012077a1905f80be91fbfb0b084d89219bd6c26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427060 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810942} Bug: 1106937 Bug: 1126208 Change-Id: Idd71d6828f4a4bee3ecbbd5b598d57be3de2fadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436758 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811602}
-
Xing Liu authored
This reverts commit 1be8a3ba. Reason for revert: Still crash. Original change's description: > Download notification: Fix a crash that startForeground is not called. > > If stopForeground is called between startForegroundService and > startForeground. startForeground will not be called since we clear the > cached service object. This will lead to a crash on O_MR1+. > > Android can reuse the service binder object when this happens. > > Bug: 1121096 > Change-Id: Ic4088af174ca9561714442b29c2e6162995ddc51 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429635 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Xing Liu <xingliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810857} TBR=dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1121096 Change-Id: I59ae44f21cbb0ae41f01d698c7c1faddccd2156c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436784 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811601}
-
Nick Diego Yamane authored
xdg-decoration spec says: > [...] clients are responsible for preventing configure loops and > must make sure not to send multiple successive set_mode requests > with the same decoration mode. which wasn't being done so far and issues like crbug.com/1131662 were observed. This patch fixes it by avoiding re-sending subsequent set_mode requests with the same decoration mode. Additionally a few cleanups and style fixes are made. R=msisov@igalia.com Bug: 1131662 Change-Id: I7cb64557775fa8562284067fb90d8cba0dea5d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436851Reviewed-by:
Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#811600}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/ssl This CL was uploaded by git cl split. R=estark@chromium.org Change-Id: Ifc807a2bc88c612e3099ec92c5a14d693a2fccb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435581 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#811599}
-
Jon Mann authored
This performs a one-time re-enabling of the Messages feature if the PWA is installed but the feature is in the disabled state. This also prevents showing the pairing lost notification if unpaired when re-enabled. Bug: 1131140 Change-Id: I1114cab793c9bad4387c6edf886bcbd735fa7ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432109 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#811598}
-
Emily Stark authored
This reverts commit 0d9bc827. Reason for revert: Breaks QUIC, see crbug.com/1133030 Original change's description: > Remove net::ct::CTVerifyResult and merge with net::CertVerifyResult > > As part of moving CT verification to occur within the state machine > of cert verification, move the CTVerifyResult fields into the > CertVerifyResult as appropriate. > > As a nice side benefit, this allows CT verification details to be > handled in browser tests using ContentMockCertVerifier. > > Bug: 848277, 1016635 > Change-Id: I365358ca12ecd9205d8103ed0e3396cdb48144b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423060 > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810364} TBR=rsleevi@chromium.org,kouhei@chromium.org,estark@chromium.org,cthomp@chromium.org,rmcelrath@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848277 Bug: 1016635 Bug: 1133030 Change-Id: Icbce690d6a2e9a61d668e3fce7c39f7662117129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436762 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#811597}
-
Yunke Zhou authored
Bug: 1131942 Change-Id: Ib7b448093e0d456f4be9822a8b6fabffa1d01f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428971Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yunke Zhou <yunkez@google.com> Cr-Commit-Position: refs/heads/master@{#811596}
-
Tom Anderson authored
This is necessary to reland [1], which caused the MSAN bot to fail because the system libwayland-client0 was being used. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2416941 R=msisov CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: I2c2c2394830abda8389704bb61109a361d09aa06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436869 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#811595}
-
Alexandre Courbot authored
Next MinVersion should be used per-file, not per-interface. BUG=None TEST=Chromium builds. Change-Id: Ib437263f070957eec532e8876e6fd14fe4c4b548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071464 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#811594}
-
Daniel Cheng authored
Blink has some logic for rendering a custom error page if a navigation fails due to an HTTP error and the response body is empty, so the user does not simply seen a blank page on error. https://crrev.com/796508 added a number of `CHECK`s to assert that navigations always commit. However, it incorrectly trips in the case of a navigation to a media document that results in an HTTP error since: 1. Media documents synchronously complete loading while handling the `CommitNavigation` IPC. 2. When loading is complete, //content checks if the navigation resulted in an HTTP error—and if so, whether the response body was empty. 3. If both of those conditions are true, //content synthesises a custom error page and calls `blink::WebNavigationControl::CommitNavigation`. Step 3 currently asserts that no commit is in progress, which is not true in the case of media documents. This CL is intended to be a small and mergeable patch and simply updates the error page handling in `RunScriptsAtDocumentReady()` to better handle reentrant commits. Bug: 1127837 Change-Id: Ied6ce00e10ff8e3b75306e97dba3d28fcd2e4c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430769 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#811593}
-
Jazz Xu authored
Add unittest that tests controls are frozen while we waiting for new session. Bug: 1128883 Change-Id: I37bc04d27366dcba3670da2038c7ba270c382b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426506 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#811592}
-
tby authored
- Increases the max response size to 1MB. 10KB was too small, and valid responses were being ignored. - Removes the `type_detail_fields` in the request. I may re-add this later once we have a good idea of what fields we want to filter. - Adds TODOs for error metrics in drive_zero_state_provider. - Fixes how the FilePathOrErrorPtr is used in OnFilePathsLocated. Calling get_error() isn't valid unless is_error(). - Reparents result file paths into the Drive mount. It turns out the LocateFilesByItemIds only returns paths relative to the root of the user's drive fs mount, so we need to prepend the location of the mount itself. This is copied from drive_quick_access_provider. - If suggested files is enabled, create chip results. Bug: 1034842 Change-Id: I1aa8aad4b313a9e15af7beb1a6346bb00e1ba98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434596 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#811591}
-
btolsch authored
https://chromium.googlesource.com/openscreen.git/+log/6d0991e9c086..53a6a132f50c 2020-09-26 jophba@chromium.org Disable discovery tests in Chrome 2020-09-26 jophba@chromium.org Roll JsonCpp dependency 2020-09-26 jophba@chromium.org Fixup standalone_{receiver, sender} 2020-09-26 emaxx@chromium.org Fix useless move() in //discovery/ 2020-09-25 jophba@chromium.org Fix standalone build with libs 2020-09-25 jophba@chromium.org Cleanup Receiver, ReceiverSession APIs 2020-09-25 jophba@chromium.org [Hotfix] Fix Mac OSX build 2020-09-24 jeffyoon@google.com Update Mac mixin to Mac-10.15 2020-09-23 jophba@chromium.org Update MdnsReader::Read to return ErrorOr 2020-09-23 jophba@chromium.org Remove duplicate cert code, refactor 2020-09-22 jophba@chromium.org [Hotfix] Fix Mac OS X build 2020-09-22 jophba@chromium.org Add note about Abseil StrFormat 2020-09-21 jophba@chromium.org [Cast Streaming] Implement CastAgent for standalone sender 2020-09-21 jophba@chromium.org [Cast Streaming] Implement sender session class 2020-09-16 jophba@chromium.org Fix Mac OS X builders 2020-09-14 gbeaty@chromium.org Remove refs.cfg. 2020-09-11 gbeaty@chromium.org Switch builders to use builder_group property instead of mastername. 2020-09-10 mfoltz@chromium.org [Open Screen] Remove obsolete TODOs. 2020-09-09 jophba@chromium.org Remove unused private DER key 2020-09-01 jophba@chromium.org Remove string_view from message port 2020-08-26 miu@chromium.org Cast Standalone Receiver: Start CastAgent and Discovery within a Task. 2020-08-24 joshuaduong@google.com Accept service names with multiple non-adjacent hyphens. 2020-08-19 sokcevic@google.com Rename PRESUBMIT constants If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098560,chromium:1109276,chromium:1122844,chromium:1128042,chromium:1128044,chromium:1132604,chromium:166160029,chromium:169447969 Tbr: jophba@chromium.org Test: Test: openscreen_unittests Change-Id: Ie84792699ac9c2e0827eb2a009513b3e38e14fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437050Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#811590}
-
David Grogan authored
Also add a finch flag in case we need to kill it. There have been 0 bugs reported against these bugfixes from folks running with experimental web platform features, so I doubt we'll need the kill switch. out/Release/chrome shows the bugfixes out/Release/chrome --disable-features=FlexAspectRatio doesn't show them Change-Id: I875f3ca1f34bee680c4c94035247cb6ff6adf385 Bug: 1132627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433630 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#811589}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e862368a..95c0414b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0aa373f5565d0684a9e8bf6eb752cc3027788c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437601Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811588}
-
Greg Thompson authored
This metric shows that the number of failed verifications owing to out-of-order relocations is double digits (has been in the low triple digits within the past year). This is insignificant in the grand scheme of things, so let's stop reporting it. BUG=1088958 R=chromium-metrics-reviews@google.com, proberge@chromium.org Change-Id: Ifc2c3e2d9ab407ddd978a4c028d16b079ab30041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435091 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#811587}
-
Asanka Herath authored
There are two methods of converting a value to a IdentifiableToken: either directly via the IdentifiableToken constructor or through IdentifiabilityDigestHelper. Differences between the two can result in different digests. This change removes the latter. Bug: 973801 Change-Id: Ic4fa466afe76abb6288fc024d34f32f05be32018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433029 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811586}
-
Lei Zhang authored
std::unique_ptr should not be used at the global scope. Switch to a raw pointer. Bug: 537099 Change-Id: I2d3b6ba65cf528003cfae21edb683405d62f9082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430726 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811585}
-
Mike Wittman authored
Second in a series factoring the ThreadProfiler platform specific configuration state from the code that takes action on the state. Defines functions to handle runtime module state, which is necessary for Android profiling. The end goal is to reduce the configuration complexity, to support enabling per-thread on Android. Bug: 1129939 Change-Id: I4cb619ce15c94ec0b5d05d99de2b02eda6dab199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425184 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#811584}
-
Maggie Cai authored
This CL adds the support to share a Google Drive folder in Sharesheet. BUG=1097623, 1128829 Change-Id: I30dffaa3428cc82e0209ff52abfa97e757a273f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434118Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#811583}
-
Fergal Daly authored
R=tikuta@chromium.org Bug: 984869 Change-Id: I07a131c587e921a11ff1ac63a90831b794677a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437651 Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#811582}
-
Tom Anderson authored
R=sky BUG=1066670 Change-Id: Ia9232be6f923aaea4c9860d6c0087dd91340ba5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432141 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811581}
-
Minoru Chikamune authored
GetCurrent() and SetCurrent() static functions are not used anymore because these functions are moved to MainThreadSchedulerImpl. So this CL removes these static functions. [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: I3def70869cd97cf6b2f06642630c1c707d28ae3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437650Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#811580}
-
Matt Menke authored
In particular, remove the ability to make it use a raw data pointer. This isn't safe if Mojo is configured to copy data for same-process calls, and nothing is using it, anyways. Also remove the ability to mutate stored data directly. Also remove SetToFilePath(), which nothing is using. This does not remove SetToFilePathRange(), which is what it calls. We do want to remove that, too, eventually. Bug: None Change-Id: I0dcb291c5c2988d3e45a00d92201d0352fe03d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431431 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#811579}
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves page_state.mojom from content to blink and replaces {Web}HistoryScrollRestorationType with blink::mojom::ScrollRestorationType. Bug: 1110246 Change-Id: I3cf3db19aabb7bbd574dcaf6b5ebc2b2ce1ab23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417678Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#811578}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/306abde46d50..0d33d0e062db 2020-09-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I62160b2193033b82c133d77e874c554f127c7163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437643Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811577}
-
Brandon Jones authored
This time with the Oculus code path fixed too! This value is not used by Blink, and does not need to be communicated over the mojo interface. The XRDeviceId enum should not be removed because it is used for usage stats. Bug: 1017477 Change-Id: I84115dafd37288afa2425aeebb863e9dee9d3093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435938Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811576}
-
Alexander Alekseev authored
This CL adds latest graph values to the legend to make current system state easier to read. Screenshots: https://screenshot.googleplex.com/7GEoQ34yCo4LGuX.png https://screenshot.googleplex.com/A2jgLi6Nt8x6erc.png Bug: 1132183 Change-Id: I4d0ac763487fe3259da22cbe84e624ddd2ef9688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430090Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#811575}
-
Omid Tourzan authored
The other elements in the panel push icon to the right so it shrinks. Changing to min-width to fix it. Bug: 1133113 Change-Id: I9f2cfbbaf0bb111b3b80cd4a685effba08f720a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437652Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811574}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d921f1b2c56..e96cdd18ac5f 2020-09-28 ethannicholas@google.com moved SkSL IntLiteral data into IRNode 2020-09-28 johnstiles@google.com Remove fKind field from BasicBlock::Node. 2020-09-28 herb@google.com air gap SkStrikeServer API from implementation 2020-09-28 ethannicholas@google.com moved SkSL DoStatement's data into IRNode 2020-09-28 jvanverth@google.com Add deprecation warning when running Metal on older OSes. 2020-09-28 bsalomon@google.com Work around python 2 shutil.copy2 date bug 2020-09-28 egdaniel@google.com Fix offscreen drawing when cleaning up vulkan viewer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I41d4b21227a026f7543f788b5951db4d051a31d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437096Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811573}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ifca12b4c615d89c595946ef6223d63b776373768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811572}
-
Chunbo Hua authored
This reverts commit 3234b57f. Reason for revert: AUD stripping patch from WebRTC has been rolled to Chromium: https://webrtc.googlesource.com/src/+/9345dcfeea73f9dd68dc83dee60255e86dac3f97 and https://source.chromium.org/chromium/chromium/src/+/76165ce5bf99790f8dbae685259723e867458337. CBP for H264 support can come back in. Original change's description: > Remove constrained baseline profile support for H264 in M86. > > Bug: 982799 > Change-Id: Ibe20d74bfe6182b8464855106ca2d09f5dca087c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363462 > Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799783} TBR=dalecurtis@chromium.org,chunbo.hua@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982799 Change-Id: Ib1c0212181d7efffe1cd4b82a0a1ddc9a603a0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427573Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#811571}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ie796f6598a821ba63596efecdb7683fbadbeac08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429259Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#811570}
-
Wei Lee authored
For historical reason, we put our js files, html files and resources under src/ directory of CCA directory. However, we reference the resource differently on platform app/SWA. On platform app, a resource foo.js is referenced as "chrome-extension://.../js/foo.js". While on SWA, it is references as: "chrome://.../src/js/foo.js". We should align the path between two versions of CCA and further replace the relative path by absolute paths in resource files. By doing so, we can further support launching CCA (SWA) when typing random CCA URL in Chrome. (e.g. chrome://camera-app/foo) NOPRESUBMIT=true Bug: 980846 Test: cca deploy [DUT] Test: cca test [DUT] Test: Both version (Platform app / SWA) works normally Test: tast run [DUT] camera.CCAUI* Change-Id: I845fe698ad92ee8da003b2ac3d12519509bdedd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434188 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811569}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/chromeos/login This CL was uploaded by git cl split. R=antrim@chromium.org Change-Id: I295668a0311ddb164cd898569faf9041ca0e431b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435750 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#811568}
-
Yutaka Hirano authored
https://github.com/WICG/web-transport/pull/135 Bug: 1011392 Change-Id: Ifd765d9986a3e3cb47358cd5c1c5572445a408d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435025Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#811567}
-
Caitlin Fischer authored
More specifically, check the feature's state after field trials have been created from the variations seed and before the variations header is updated. Checking the state for the first time in VariationsIdsProvider::GenerateBase64EncodedProto() could cause a deadlock. Bug: 1094303 Change-Id: I53fe3446e3a4567d4b9122b54642b5744eb8b46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431556 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811566}
-
Jon Mann authored
Recent changes to the apps framework caused a delay in loading app information during login. This requires that we wait for WebAppProvider::on_registry_ready() before querying the apps database for information on installed PWAs. This issue was resulting in the Messages feature getting disabled after the app was perceived to be uninstalled. Bug: 1131140 Change-Id: Ie2448fed1d04a9525b5dd5a452cb0b000a29ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429527 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811565}
-