- 25 Aug, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
Parsing of the 'none' keyword was already supported, so this CL simply connects the dots between the parsed timeline name and the timeline we pass to the CSSAnimation. For the InertEffect, the inherited_time now needs to be a base::nullopt to prevent an effect value from being produced, so a small adjustment was needed there. Note: Changing from IsScrollTimeline() to IsMonotonicallyIncreasing() is just a cosmetic change. Note also that the test animation-timeline-in-keyframe.html required a small adjustment: previously, the computed value of animation-timeline was 'bar', but there was no @scroll-timeline corresponding to 'bar', so according to spec the animation has no timeline in this case, and therefore no effect value [1]. We previously fell back to the DocumentTimeline, which is not correct: we should have fallen back to "no timeline", which is what we do as of this CL. [1] https://drafts.csswg.org/css-animations-2/#animation-timeline Bug: 1074052, 1097046 Change-Id: Ia664f92f70dff68a17eb82315d6bb7bf18de79f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367835Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#801363}
-
Minggang Wang authored
This patch moves RecordLoadHistograms into Blink, which is needed when implmenting sort of URLLoaderClientImpl inside Blink along with the OnionSoup work. Bug: 860403 Change-Id: I3a2abecd963547d989d31510cf6906e5b7609e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363506Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#801362}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d6482730a5b0..41db2fb64914 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I3f2f26561ad530952947829cb457033df86fdd14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374607Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801361}
-
Ewann authored
This CL fixes the background color of items presented in a context menu from the NTP. The previous color displayed was clear color, or it seems that Apple doesn't handle the transparency of the background during animations linked to context menus. To fix this bug, I set the background color to be the same as the NTP. Bug: 1120321 Change-Id: Ibe8d5aece84802b03c2baddf9e43c2fe796b9b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371631 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#801360}
-
Andrew Grieve authored
Bug: 1040534 Change-Id: Ic9873612462612e510b91d713c24c046e017cafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368510 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#801359}
-
Mohamed Amir Yosef authored
This reverts commit a39032ce. Reason for revert: Suspect to have caused egtest failures https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/26041 Original change's description: > [Passwords] Save CompromisedCredentials in the correct store > > Bug: 1108422 > Change-Id: I3a96f9d3a422590df5c0b0947e6b803c074ef9a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372322 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801346} TBR=jdoerrie@chromium.org,mamir@chromium.org Change-Id: I93de62690d0d950243d48e36ad10d14fd866fb43 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375365Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#801358}
-
Matt Jones authored
The update to the theme color was removed here: https://chromium-review.googlesource.com/c/chromium/src/+/2343269 Bug: 1121108 Change-Id: I6af81f699c69b4c919fed02c6777a4765e1b5485 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372805 Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801357}
-
Mohamed Amir Yosef authored
This reverts commit d705fd61. Reason for revert: the parent CL is suspect for test failures Original change's description: > [Passwords] Remove passwords from the correct store in ... > > ... CompromisedCredentialsManager() > > Bug: 1108422 > Change-Id: I66ea95309a1c3242fe8e32591ae986d68dbe5ee2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372429 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801348} TBR=jdoerrie@chromium.org,mamir@chromium.org Change-Id: I39199d239fe2053dc6f0a2c6f7dacefd1eb78651 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1108422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375325Reviewed-by:
-
Clemens Arbesser authored
This adds a new flag to the prompt action that controls whether the UI should be detached during BROWSE mode or not. Bug: b/162065211 Change-Id: I38c38903edea236d749313dfb6ca39e13cd1a3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372324 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801355}
-
Michael Tang authored
- Formalize coordinate space of subframe placeholders to be in their parent's space. Bug: 1009552 Change-Id: I75c44a648acc18696e019c669d850bc842823af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363875Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#801354}
-
harrisonsean authored
Add harrisonsean and javierrobles as owners to the safety check UI code on iOS . Bug: 1078780 Change-Id: Ifbe9e38c88e6bb0dfe9604c1e1a01b9fec4e58b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375245Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#801353}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47054c84..f6e6c933 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I670260ad489728442cd4e5a48ec0cc36eee8dd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375065Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801352}
-
Nohemi Fernandez authored
Sync.SyncErrorInfobarDisplayed will expire after 2020-09-27, this patch extends the expiration date and ensures that new enums are properly tracked. Bug: 1117118 Change-Id: Ic1fcd8afd068ec79aa3bdeb8568f8545c78f35ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372367 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801351}
-
David Roger authored
Bug: 1076880 Change-Id: Ia9a7663c0089ee891853ef3458e0f1d449695295 Fixed: 1121189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372393Reviewed-by:
-
Luke Zielinski authored
These expectations are overwritten by checked-in metadata ini files introduced in crrev.com/c/2327138 TBR=robertma Bug: 1116091 Change-Id: I0096780c0a07b38d61eff548b7338c140e4f90a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372594Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801349}
-
Mohamed Amir Yosef authored
... CompromisedCredentialsManager() Bug: 1108422 Change-Id: I66ea95309a1c3242fe8e32591ae986d68dbe5ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372429 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#801348}
-
Christian Dullweber authored
The boolean BlockThirdPartyCookies preference was replaced by CookieControlsMode enum. Existing settings were migrated since M83. The preference is still used in the UI and extension APIs and will be removed in followup CLs. Tbr: jianli@chromium.org Bug: 1104836 Change-Id: I44f896c4191af2b49decdc01696f2974b99b9120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366721 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#801347}
-
Mohamed Amir Yosef authored
Bug: 1108422 Change-Id: I3a96f9d3a422590df5c0b0947e6b803c074ef9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372322 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Justin Cohen authored
TBR=mrefaat Bug: 1121425 Change-Id: I77602b224fe06577aa7d2a7da50df17b036b54e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373705Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801345}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/cccd55094dbe..59230836579a 2020-08-25 mbonadei@webrtc.org RTC_OBJC_TYPE RTCWrappedNativeVideo{Decoder,Encoder}. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0b67048ca040f5d12ca61b73597962f41fa187d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374672Reviewed-by:
-
Benoit Lize authored
Virtual size and size are reported by each segment in detailed memory dumps, and also by the heap implementation. This is not an issue in reported metrics, but can lead to double-counting in about:tracing, as the per-segment sized are summed with the overall ones in the UI. Bug: 1106364 Change-Id: I7099909b50d7902c3b7f0117934d3ca6dba75cfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372327Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#801343}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd8de1d295b4..d6482730a5b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia5a0bd618e71afcab887d6e1e3975773363a2de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374236Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d6482730a5b0..41db2fb64914 2020-08-25 treehugger-gerrit@google.com Merge "Added Flow Events panel for selected slice" 2020-08-25 lalitm@google.com Merge "ui: mark non-IO uninterruptible sleep in a different colour" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3d0a5f7a1f74ef925ef8e4ac64c5aed66141c6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374671Reviewed-by:
-
Elly Fong-Jones authored
Use WidgetDelegate::SetModalType instead. This allows us to delete some subclasses of WidgetDelegate. Many more now only need the forthcoming WidgetDelegate::SetContentsView before they can be safely deleted. Bug: 1075649 Change-Id: I7c1cafce5a8c61ecfe0f986b40eed9c326995e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373169Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#801340}
-
Clemens Arbesser authored
Change-Id: Icfdb23eb07a680d445ac89e853459c3483b62ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374528 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
Viviane Yang authored
This change adds a new push_messaging namespace with general utils methods needed in chrome/browser/push_messaging. Change-Id: Iea9b5f54fe01b9a1b3eb027432731b23b4838bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374745Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#801338}
-
Maria Kazinova authored
processed by PasswordManager. This fixes an issue when websites trigger events on fields on a pageload before the base value for unique is received from the PasswordManager, leading to invalid values being set. Bug: 1121523 Change-Id: I58aee1dd065de7a547d016d4a35a0ec30c63e5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374866Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#801337}
-
Mohamed Amir Yosef authored
... when joining stored and compromised credentials. Follow up CLs will support Account Store during other operations in CompromisedCredentialsManager. Bug: 1108422 Change-Id: I023026589c4717e0db002901104d7353a6dbae08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370635Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Richard Knoll authored
This times out outgoing connections after 1 minute. This only includes the initial connection accept flow that happens without user intervention. The payload accept / decline step has a separate timeout later on in the send flow. Bug: 1085067 Change-Id: Icb0f091879f2a657875e2ad8442102a6fccd0c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367951Reviewed-by:
Alex Chau <alexchau@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801335}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c8f0a829. With Chromium commits locally applied on WPT: 9f52c7e4 "COOP: add reporting to redirects" d18db804 "Fix test flake in animation-state-changes-positive-playback-rate.html" 323cee1a "Rename OverrideBuiltins to LegacyOverrideBuiltins." f503f766 "Correct waiting for negotiationNeeded in test" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I56e98ab4a2803bb62d54b1591fc2120de02f2bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374090Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801334}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bccf9d55..47054c84 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I97f6d14bca9dfcc1db0691db6d6996a79042eb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374089Reviewed-by:
-
David Jean authored
Fixed crash on exit with connectedScenes empty while the last scene tries to get interfaceProvider from it. Fixed crash with disconnected states remaining as dangling pointer observers in AppState Bug: 1114586 Change-Id: I4865d261082e81c2684065f97a8a6d94ffd2164d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374785Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#801332}
-
Jonathan Mengedoht authored
Bug: 927473 Change-Id: Ib87706aeb8c6e100ba542a31e7374b2fe8c12210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372325 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d37b0ec2bb0c..cccd55094dbe 2020-08-25 nisse@webrtc.org Delete unneeded dependencies on deprecated build target webrtc_common 2020-08-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0c4572c2..ba69b98d (801101:801212) 2020-08-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6cc8efac..0c4572c2 (800536:801101) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia13aa4ec9c7eb685c987c45fe3c34a2278f22005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374805Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd8de1d295b4..d6482730a5b0 2020-08-25 treehugger-gerrit@google.com Merge "Fix typo in sqlite BUILD define" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I177d7209896bf478f3b3847b07e6333812b9efdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374232Reviewed-by:
-
Peter Kasting authored
* Remove string arg to constructor, since SetText() already existed. * Strip trailing whitespace in SetText() as was previously done in the constructor, and comment about why it matters. I doubt this ever triggered outside of unittests. * Default the listener arg to null, which a lot of callers want. * While touching the callers anyway, use std::make_unique<>(), T* AddChildView(), etc. more. Bug: 648382,1108460 Change-Id: I7b3893ce922264581a7696d8fbcbdc70aecefaf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360498 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801328}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a8fc1fe06a2..cdedf581e53e 2020-08-25 wolfi@chromium.org Revert "Update Mocha and rollup-plugin-terser" 2020-08-25 sigurds@chromium.org Add filter in network panel for resource type 2020-08-25 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-25 chrche@microsoft.com [Elements]: Fixing issue when searchConfig is unexpectedly undefined 2020-08-24 jegarc@microsoft.com Hide color picker on scroll 2020-08-24 patrick.brosset@microsoft.com Allow horizontal scrolling in the Elements tree 2020-08-24 michael.liao@microsoft.com [Accessibility - XHR Breakpoints]: Set accessible name for text input 2020-08-24 michael.liao@microsoft.com [AriaUtils]: Removing NVDA workaround for alert function 2020-08-24 petermarshall@chromium.org components: Use the new PieChart2 everywhere 2020-08-24 petermarshall@chromium.org css: Remove our implementation of data-keyboard-focus 2020-08-24 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-24 tvanderlippe@chromium.org Fix contextmenu for console view messages 2020-08-24 tvanderlippe@chromium.org Update Mocha and rollup-plugin-terser 2020-08-24 hablich@chromium.org [Docs] Fix link to workflow.md 2020-08-24 nsatragno@chromium.org Flip webauthnPane experiment flag 2020-08-24 alexrudenko@chromium.org Partially revert: [Perfmon] Improve contrast of labels in dark theme If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1116327,chromium:1120103,chromium:1120844,chromium:1121086,chromium:1121141,chromium:880265 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib1d2e1953a818f81decffa8dda47e9f19115a6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374229Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25e9f126d8c3..a5c279111d94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fergal@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fergal@google.com Change-Id: I021bf56752d15d9655a08119718856d56b8183f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373238Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801326}
-
Aaron Leventhal authored
This patch removes the now unused method BrowserAccessibilityComWin::IsListBoxOptionOrMenuListOption() AX-RelNotes: n/a Bug: None Change-Id: I21e076c5a5ec8de83b0a7919ebb63de5350e7c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368460Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#801325}
-
Hirokazu Honda authored
The bitrate is not specified in MultipleOutstandingEncodes case. So the default bitrate is used. It causes a failure in higher resolutions because of the bad stream quality. This fixed the issue. This also removes the default argument value to the bitrate argument in order to refrain this bug. Bug: 1045825 Test: video_encode_accelerator_tests on atlas Change-Id: I9c638db22175a7bc0573868fadc2057ec34bbdb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371903 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#801324}
-
