- 11 May, 2018 40 commits
-
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/394f1c63d58a..a8050d3d8618 $ git log 394f1c63d..a8050d3d8 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 bpastene cros_run_vm_test: Pass board and cache dir args down to deploy_chrome. Created with: roll-dep src/third_party/chromite BUG=chromium:823996 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I1fb09689cbf824cf46c5332a473261f6c6ca55b8 Reviewed-on: https://chromium-review.googlesource.com/1055193Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557833}
-
Max Morin authored
It checks that the stream is allowed and forwards the request to the relevant ForwardingAudioStreamFactory if so. This will cause the stream to be served by the audio service. The old RenderFrameAudioInputStreamFactory which creates streams living in content/ is renamed to OldRenderFrameAudioInputStreamFactory. Since the class was renamed, the files were moved (by adding "old_" to the beginning). No need to review those files. Also note that replacement is diffed against the previous implementation. It's probably best to just ignore the diff and review render_frame_audio_input_stream_factory{.cc,.h,_unittest.cc} as new files. The same flag as for output is used to switch between the old factory and the new one. Approximate diagram of stuff: https://docs.google.com/drawings/d/1_ZIKj6lihGKRjq4Mflduitmkn_REqpHFeqVNelBGHHk/edit Bug: 830493, 836226 Change-Id: Ib0f58a52d849a48ba79405f0d499444c66029b58 Reviewed-on: https://chromium-review.googlesource.com/1050245 Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#557832}
-
Noel Gordon authored
These extensions are not used by the Files.app browser tests and cause ASAN flakes due to an unrelated NaCl bug 788671. Skirt around that bug here by not loading these NaCl-using extensions. Side-effect: these browser tests hopefully run a little faster. Bug: 788671,836254 Change-Id: Ie528cad328d76f2ff0ee97c994f2bc539de86a98 Reviewed-on: https://chromium-review.googlesource.com/1055351 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#557831}
-
vitaliii authored
Add a static_assert, which fails wen a new protocol type is added, to EntitySpecifics visitor, so that people don't forget to update this visitor. That's precisely what I did when I was adding a new type and it took me couple of hours of debugging to understood what was wrong. Change-Id: Idd35e143b1fcbda089de3552ac07b9754e344235 Reviewed-on: https://chromium-review.googlesource.com/1054010 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#557830}
-
Tetsui Ohkubo authored
In UnifiedSystemTray, information that was shown in TraySupervisedUser default view will be shown at the right bottom of the system tray. The style is same as one for enterprise managed devices. TEST=UnifiedSystemInfoViewNoSessionTest BUG=none Change-Id: I7cb1512a41894a2005a4d4a76a2a667c231ea0ad Reviewed-on: https://chromium-review.googlesource.com/1051927 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#557829}
-
Max Morin authored
Tbr: cbiesinger No-Try: true Bug: 833215 Change-Id: I3807d48df11e6b4416357896b7af4564b0ef7c6e Reviewed-on: https://chromium-review.googlesource.com/1055448Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557828}
-
Donna Wu authored
Implementation of MTPManagerClientChromeOS is mostly copied from media_transfer_protocol_device_observer_chromeos.h/cc files which will be replaced in subsequent CLs. This is a preparation CL for the conversion of MTP mojo interfaces' usage in the client side without any functional changes for the notifications to upper level clients have been blocked. BUG=769630 Change-Id: I28076cc4a4e30783426c6ccb5af1805ef913d7ae Reviewed-on: https://chromium-review.googlesource.com/1046376 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#557827}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a75468d15a3e..6ccd021839d2 $ git log a75468d15..6ccd02183 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 perezju [soundwave] Create timeseries table if needed Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I48240234d07696b2b0a5459ce91b1a0ff080fd29 Reviewed-on: https://chromium-review.googlesource.com/1055199Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557826}
-
Manuel Rego Casasnovas authored
Change-Id: I3c085d43bc1fa2b3ebe3d90c50b3d1e269de58a0 Reviewed-on: https://chromium-review.googlesource.com/1054289Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#557825}
-
Patrik Höglund authored
This reverts commit ee35ff8f. Reason for revert: New USB card in place, let's see if still flaky Original change's description: > Reland "Disable flaky capture unittests on Linux." > > This reverts commit a99efe4b. > > Reason for revert: Still flaky. > > Original change's description: > > Revert "Disable flaky capture unittests on Linux." > > > > This reverts commit 46bf6346. > > > > Reason for revert: New webcam plugged in; let's see if they're still flaky. > > > > Original change's description: > > > Disable flaky capture unittests on Linux. > > > > > > The tests went flaky when we replaced the bot and get VIDIOC_STREAMON > > > errors about 25% of the builds. I have no idea to fix that; we tried > > > replacing the webcam and moving it around in the USB ports and that > > > didn't help. See http://crbug.com/828568 for discussion. > > > > > > Bug: chromium:831514 > > > Change-Id: Ic55c09a16a22dd0402c3360b710e310c733ec5f9 > > > Reviewed-on: https://chromium-review.googlesource.com/1016301 > > > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > > > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#552165} > > > > TBR=phoglund@chromium.org,chfremer@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: chromium:831514, chromium:828568 > > Change-Id: I01b21c5073e79e004c74430cc6eeb3422b602745 > > Reviewed-on: https://chromium-review.googlesource.com/1039425 > > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#555342} > > TBR=phoglund@chromium.org,chfremer@chromium.org > > Change-Id: I9c976f8bb2e0812029d13ae020896bebadf4ef1c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:831514, chromium:828568 > Reviewed-on: https://chromium-review.googlesource.com/1041945 > Commit-Queue: Patrik Höglund <phoglund@chromium.org> > Reviewed-by: Patrik Höglund <phoglund@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555996} TBR=phoglund@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:831514, chromium:828568 Change-Id: I253b9c60032543f55533b8f53442dcabbebffbf6 Reviewed-on: https://chromium-review.googlesource.com/1054669Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#557824}
-
Max Morin authored
Also has issues on 10.13 and a Windows 7 bot. Tbr: steimel@chromium.org No-Try: true Bug: 833658, 841922 Change-Id: If202d5a9750d5e3b96e8022884bd0ed088840466 Reviewed-on: https://chromium-review.googlesource.com/1054235Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557823}
-
Ramin Halavati authored
Network traffic annotation test script sends the list of changed files in a CL to the traffic annotation auditor and auditor passes them to clang tools for actual processing. If the list of files would be too long, this may create errors in argument passing buffers. A threshold for size of change list is added to trigger full test of annotations and avoiding sending long list of changed files. Bug: 690323 Change-Id: I3f9386ade4b93041a27fb21f9c9d3205caf6f17e Reviewed-on: https://chromium-review.googlesource.com/1054869Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#557822}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I56d62fa2f09ff07aa2fc462fe7a530ac48bc30bd Reviewed-on: https://chromium-review.googlesource.com/1055200 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557821}
-
Dean Liao authored
Currently, V4L2VDA allocates output buffers for client to use. However, we need V4L2VDA to accept output buffers allocated by client. BUG=b:73327993 TEST=run video_decode_accelerator_unittest /usr/local/autotest/deps/chrome_test/test_src/out/Release/video_decode_accelerator_unittest \ --test_video_data=/usr/local/autotest/deps/chrome_test/test_src/\ media/test/data/test-25fps.vp8:320:240:250:250:35:150:11 \ --thumbnail_output_dir=/usr/local/autotest/results/default/video_VideoDecodeAccelerator/results \ --ozone-platform=gbm \ --rendering_fps=0 \ --test_import Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id68e4ae8f87e3d86853cba8505abf1fc5147f9e2 Reviewed-on: https://chromium-review.googlesource.com/1002718 Commit-Queue: Shuo-Peng Liao <deanliao@google.com> Reviewed-by:
Wu-Cheng Li <wuchengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#557820}
-
https://chromium.googlesource.com/angle/angle.git/+log/2fc0806f5595..8073a9511a1e $ git log 2fc0806f5..8073a9511 --date=short --no-merges --format='%ad %ae %s' 2018-05-09 oetuaho Enable warning for non-virtual destructors Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I757ed6890c1a4f03084400756e51a068e74a9eb0 Reviewed-on: https://chromium-review.googlesource.com/1055196 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557819}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5603eb9. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17282 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=markdittmer No-Export: true Change-Id: I67eb3e30091a1ae3e7c82eb7ca8c32235ad74c98 Reviewed-on: https://chromium-review.googlesource.com/1055308 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557818}
-
Max Morin authored
Flaky on Mac Bug: 841986 Tbr: miu Change-Id: I8ad9ee53fb175b4d62146e9e5298000ba075d682 Reviewed-on: https://chromium-review.googlesource.com/1054872Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557817}
-
arthursonzogni authored
In this test, the following lines looks legitimate, but they are not: ~~~ window.onload = setTimeout(function() { window.location = "resources/go-back.html" }, 10); ~~~ The issue is that setTimeout is executed immediately instead of on load. This CL wraps it into a function. It also reduces the timeout from 10ms to 0ms. Bug: 831155 Change-Id: I7e35fcaeedf918a29fa12ae1f8292d07e08ac213 Reviewed-on: https://chromium-review.googlesource.com/1051908Reviewed-by:Nate Chapin <japhet@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#557816}
-
Hajime Hoshi authored
The task runner is used only for RenderWidget::Close and RenderWidget:: DoDeferredClose, and I think unthorttled task runner is not necessary here. Note that the original task runner before kUnthrottled was ThreadTaskRunnerHandle::Get(). We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Change-Id: Iac3487edef157ff1261cfdde0b318f49cf469176 Reviewed-on: https://chromium-review.googlesource.com/1055140Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557815}
-
Hajime Hoshi authored
The task runner is used at: - RenderWidget (See https://chromium-review.googlesource.com/c/chromium/src/+/1055140) - RenderViewImpl::SendFrameStateUpdates - RenderViewImpl::CheckPreferredSize I think unthorttled task runner is not necessary here. Note that the original task runner before kUnthrottled was ThreadTaskRunnerHandle::Get(). We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Change-Id: I8c1bbb2112c62b1e37fdb4d5a4ea387ddbf1da50 Reviewed-on: https://chromium-review.googlesource.com/1055249Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557814}
-
Denis Yaroshevskiy authored
and generally applying noexcept where it make sense. https://google.github.io/styleguide/cppguide.html#noexcept Noexcept until recently didn't work with out of line default declarations. This CL tests that now it compiles on all platforms by applying noexcept for a few default move operations. Since this CL is useful not only to test but to merge too, I suggest we merge it. Discussion on noexcept: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/cxx/ze4WJFg7RvU/6wU_9xltBgAJ Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If65a9da6dc803e4dbd03765656a6f122bcb8210e Reviewed-on: https://chromium-review.googlesource.com/1046005Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Denis Yaroshevskiy <dyaroshev@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#557813}
-
Max Morin authored
This reverts commit 46c1bd55. Reason for revert: crbug.com/841871 Original change's description: > Enforcing freezing a tab prior to proactive discard. > > This CL enforces that a tab is frozen prior to being proactively discarded. This will allow the website to have enough time to persist any state prior to being proactively discarded. Urgent discard behavior is unchanged. > > Bug: 775644 > Change-Id: Ia3ec9e8f53f80d2c940edd065090415cbcdd1f6c > Reviewed-on: https://chromium-review.googlesource.com/1041138 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557209} TBR=fdoray@chromium.org,fmeawad@chromium.org,pavely@chromium.org,varunmohan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 775644, 841871 Change-Id: Ia784d8aada40321e14f14133a7a6bb9403d7dda0 Reviewed-on: https://chromium-review.googlesource.com/1054668Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557812}
-
Ben Chan authored
This CL updates dbus::MockBus to mock dbus::Bus::AddFilterFunction and dbus::Bus::RemoveFilterFunction. Neither method is exercised in existing Chrome unit tests. However, some Chrome OS unit tests (e.g. CL:1048028) need to mock them, which is currently done by sub-classing dbus::MockBus. This CL alleviates the need of such sub-classing. Bug: None Change-Id: Ib5f3e41573ec900351ebedad030bb6147db3b74f Reviewed-on: https://chromium-review.googlesource.com/1054159Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557811}
-
Yutaka Hirano authored
net::URLRequest clears its request_start on redirect, so we should do the same in the renderer. Bug: 824155, 835502 Change-Id: I74252d62d98aae0e26e4ee30ad21eeefb5fda267 Reviewed-on: https://chromium-review.googlesource.com/1054907 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#557810}
-
Kenichi Ishibashi authored
Server side config is going to be updated and the new experiments have "_R3" suffix instead of "_R2". Bug: 764481 Change-Id: I7ec3123096ba27f0c16d63d879e2e323b8963197 Reviewed-on: https://chromium-review.googlesource.com/1053855 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#557809}
-
Felix Ekblom authored
BUG=b:78171027 CQ-DEPEND=cl:1042575 Change-Id: I7886f3ac5483f381b677630dd966cdfacd483aaa Reviewed-on: https://chromium-review.googlesource.com/1044366Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Felix Ekblom <felixe@chromium.org> Cr-Commit-Position: refs/heads/master@{#557808}
-
Zinovy Nis authored
- Get rid of redundant .c_str() for std::string, - Get rid of redundant .get() for std::unique_ptr, - Get rid of redundant member initializations - Replace NULL -> nullptr. R=blundell@chromium.org, caitkp@chromium.org, jochen@chromium.org, meacer@chromium.org, sdefresne@chromium.org Change-Id: Ibcd0f6ad0ab6610a334fb4a5309caa6ad00b5766 Reviewed-on: https://chromium-review.googlesource.com/1046085 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#557807}
-
Matt Falkenhagen authored
When a new registration is made, it attempts to notify all ServiceWorkerProviderHosts for an in-scope clients. This way navigator.serviceWorker.ready and Clients#claim etc work correctly, as the ServiceWorkerProviderHost is aware of the best matching registration. Before this CL, new registrations would miss reserved clients. So if a page was still undergoing navigation while a registration was created, the page would never be aware of the registration. So if a SW from that registration called clients.claim(), the page would not be claimed. Bug: 841070 Change-Id: I615f416ac27cadb88dcae0bde368226a92a6c481 Reviewed-on: https://chromium-review.googlesource.com/1053928Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557806}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c77a6a1be7d..0cc01b753ac6 $ git log 8c77a6a1b..0cc01b753 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 fmalita [skottie] Guard against asset cycles Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: Id55c4847c1916a9f30fe5a539ba4a3d96f42b2d9 Reviewed-on: https://chromium-review.googlesource.com/1055210 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557805}
-
Makoto Shimazu authored
This change is to create EmbeddedWorkerInstanceClient from the Renderer interface. It used to be created from the InterfaceRegistry, but we didn't have guarantee of IPC message orderings between StartWorker and messages onto the Renderer interface. StartWorker needs to be run after initialization of the renderer (crrev.com/c/1031693 will introduce SetUserAgent message), so this CL is to put the very first IPC for the service worker, which is establishing the Mojo connection, on the Renderer interface. Bug: 818450 Change-Id: I5a5d64fa9aef73ca602633b2b3664110d0a761c9 Reviewed-on: https://chromium-review.googlesource.com/1053042 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557804}
-
Matt Falkenhagen authored
These still seem to pass locally. I suspect a merge caused them to be accidentally added in https://chromium-review.googlesource.com/c/chromium/src/+/1041126 PlatformAppBrowserTest.AppWindowAdjustBoundsToBeVisibleOnScreen PlatformAppBrowserTest.CreateAndCloseAppWindow MimeHandlerViewTests/MimeHandlerViewTest.SingleRequest/0 Bug: 752372 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id2713b0196ed1cfa666a2d62c37da8600b02fbd0 TBR: jam NOTRY: true Reviewed-on: https://chromium-review.googlesource.com/1055129Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557803}
-
Kenichi Ishibashi authored
Store client_id supplied via ServiceWorkerContainer::SetController() in ServiceWorkerProviderContext::ProviderStateForClient so that we can pass the client_id to WorkerFetchContextImpl. This enables us to set FetchEvent#clientId accordingly in shared workers. Bug: 840668 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie03290b9d70c3fd0d2a74e83d7881057ec3e1b51 Reviewed-on: https://chromium-review.googlesource.com/1049210 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#557802}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0db9f061b85f..394f1c63d58a $ git log 0db9f061b..394f1c63d --date=short --no-merges --format='%ad %ae %s' 2018-05-11 manojgupta > > Revert "generic_stages: temporarily ignore all target prebuilts." > > > > This reverts commit 887fe7d05033cd814d9390b2f3ebcd9262330d7b. > > > > Original change's description: > > > generic_stages: temporarily ignore all target prebuilts. > > > > > > Ignore the target prebuilts and rebuild packages from source. > > > > > > This is a temporary CL. Revert this CL once in has participated in > > > a green CQ run. This process is documented at: > > > > > > https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries > > > > > > BUG=chromium:826418 > > > TEST='./cbuildbot/run_tests' passed. > > > > > > Change-Id: Id80097c2721001598efa294ea0a7cfc69eac038d > > > Reviewed-on: https://chromium-review.googlesource.com/1044745 > > > Commit-Ready: Yunlian Jiang <yunlian@chromium.org> > > > Tested-by: Yunlian Jiang <yunlian@chromium.org> > > > Reviewed-by: Manoj Gupta <manojgupta@chromium.org> > > > Reviewed-by: Lann Martin <lannm@chromium.org> > > > > Bug: chromium:826418 > > Change-Id: Ibc01cf44e64d921088ab48d65eac624f5aeb463d > > Reviewed-on: https://chromium-review.googlesource.com/1054268 > > Reviewed-by: Lann Martin <lannm@chromium.org> > > Tested-by: Lann Martin <lannm@chromium.org> > > Bug: chromium:826418 > Change-Id: Ib85d9b279c8d6738aa893492529c64da6fa0456c > Reviewed-on: https://chromium-review.googlesource.com/1054269 > Reviewed-by: Lann Martin <lannm@chromium.org> > Tested-by: Lann Martin <lannm@chromium.org> Created with: roll-dep src/third_party/chromite BUG=chromium:826418 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4025fa965c9f5b1e2846a282317e52cd8d5a236f Reviewed-on: https://chromium-review.googlesource.com/1055209Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557801}
-
Satoru Takabayashi authored
The metrics were added long time ago crrev.com/99811 without the corresponding changes to histograms.xml. The metrics still look interesting hence this change is to update histograms.xml. BUG=797623 Change-Id: I2445387d21a5ff51519638e0c4efce74108fe747 Reviewed-on: https://chromium-review.googlesource.com/844008 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557800}
-
Shakti Sahu authored
Fixed an accidental change to the feature list which was introduced in the CL https://chromium-review.googlesource.com/c/chromium/src/+/1003754 Change-Id: I4b1261a50f4e637453ea6b273d063f4af3a7dce9 Reviewed-on: https://chromium-review.googlesource.com/1054780Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#557799}
-
Satoru Takabayashi authored
The metrics were added long time ago crrev.com/64367 without the corresponding changes to histograms.xml. The metrics still look interesting hence this change is to update histograms.xml. BUG=643563 Change-Id: I0ea55648b27b938dc5780932ac9dde31f4e1ff09 Reviewed-on: https://chromium-review.googlesource.com/842427 Commit-Queue: Satoru Takabayashi <satorux@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#557798}
-
Scott Violet authored
When a client is notified of events it's told if the event matches a pointer observer. If the event does match a pointer observer, a single event is sent to the client. This implies I need a post event processing hook to determine if the client was notified already and not send if appropriate. This is why I added WindowEventDispatcherObserver as a way to deal with this. I'll be more obvious in a following patch. BUG=837692 TEST=covered by test Change-Id: Ifb3e332466b3e6a6ee09c625020d6dbf9ed1a54e Reviewed-on: https://chromium-review.googlesource.com/1054413 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#557797}
-
spqchan authored
Bug: 838873 Change-Id: I22e5a8a54d372abc84993ef1cd33e4325856cb6b Reviewed-on: https://chromium-review.googlesource.com/1042726Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#557796}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3d894aa45e08..e7273d25017a $ git log 3d894aa45..e7273d250 --date=short --no-merges --format='%ad %ae %s' 2018-05-10 ehmaldonado Reland "gclient: Get rid of parsed_url." Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic0e6386f9d2f7b62b49ddc3e69dce7f4f20dcd76 Reviewed-on: https://chromium-review.googlesource.com/1055050 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557795}
-
Yoshisato Yanagisawa authored
Since runtest.py depends on modules listed in build/third_party, we need to set --with-third-party-lib when we execute runtest.py via runit.py. Bug: 825290 Change-Id: Ic780388a9b9086364c1e4dcbd4a70a2cd2ed2425 Reviewed-on: https://chromium-review.googlesource.com/1053674Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#557794}
-