- 02 Aug, 2017 40 commits
-
-
Emily Stark authored
As of https://codereview.chromium.org/2926803002, when navigating to an existing entry, the new navigation's SSLStatus remains unchanged from the existing entry. This is incorrect for content status flags, which depend on the content of the page; navigating to an existing entry does not mean that the content on the page is the same as it was when we navigated away from the existing entry. For this reason, this CL clears content status flags when a navigation commits. Any content status flags that do apply to the new navigation should be re-added as the content on the page loads. Bug: 750649 Change-Id: I41441c90ddeb85b6cbf35e4b102ce322cffb7db9 Reviewed-on: https://chromium-review.googlesource.com/597488Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#491504}
-
Yuke Liao authored
testRotation, testOmnibox and testScrollToolbar fail on iPhone 6 Plus, iOS 10, and this CL disables them on iOS 11 to unblock running the test case on iPhone 6 Plus, iOS 11. Bug: 751803 Change-Id: Ibcda582e2f86617b1fcea89a5296dde182b9b81c Reviewed-on: https://chromium-review.googlesource.com/598646Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#491503}
-
Brian White authored
There are checks inside the PMA that limit any passed size to whatever was defined when the memory segment was created. But that could be wrong if the segment is corrupted. Bug: 749223 Change-Id: Ib0f5416e4c43b597b15e2cb05b3787677e5c0ea1 Reviewed-on: https://chromium-review.googlesource.com/596487 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#491502}
-
Will Chen authored
F/u from https://chromium-review.googlesource.com/c/595238 Bug: 667560 Change-Id: I4e387fae79ab4de0965f84a045c4fd04631b9e7d Reviewed-on: https://chromium-review.googlesource.com/597312 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491501}
-
Yuzhu Shen authored
BUG=699569 Change-Id: I0697f40e286a3ea7fbcccff3c02a605abc7bd8c5 Reviewed-on: https://chromium-review.googlesource.com/592280Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Yuzhu Shen <yzshen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491500}
-
erikchen authored
This is a reland of f5345de1. The problem with blink trybots was fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=669240#c45 Original change's description: > Bump macOS SDK to 10.12. > > Bug: 669240 > Change-Id: I97cf582b97fac7aec2aa92bbdda02f5c17482c1d > Reviewed-on: https://chromium-review.googlesource.com/570459 > Reviewed-by: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491060} Bug: 669240 Change-Id: I73b54eedbd0eab105adecfb6e817de8aa2b968ef TBR: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/598670Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491499}
-
erikchen authored
Users who specify an 'ios' solution in .gclient will pull the iOS toolchain. This is used by 'ios' bots to pull the toolchain. But macOS developers who happen to specify an 'ios' solution will also pull the iOS toolchain. This CL is a temporary hack to work around this: if the machine appears to be a corp machine, always pull the macOS toolchain. Bug: 742527 Change-Id: Ic49785078f0e15c06f44f61a0daab54dd552ec9e Reviewed-on: https://chromium-review.googlesource.com/598776Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491498}
-
David Bokan authored
Th eoverlay scrollbar fade delay determines how long a period without scrolling will cause the scrollbars to fade out. It also determines how long the mouse must hover over the scrollbar area before it fades in. The fade delay is currently set to 1000ms. In practice, this feels a little long and difficult to discover that the scrollbars appear when the mouse hovers near the page edge. Reducing it to 500ms to see how= that feels Bug: 307091 Change-Id: I463b086fc17c5166e009f2440258e1e1fdf808f9 Reviewed-on: https://chromium-review.googlesource.com/598116Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491497}
-
Wez authored
TBR: dcheng Change-Id: I3865d168844f7abc94ceb2ee9c07171d4da690a8 Reviewed-on: https://chromium-review.googlesource.com/597470 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491496}
-
Hiroshige Hayashizaki authored
This makes PrepareScript() return true (previously returning false) for a classic inline script blocked due to CSP (*). This causes |script_element_ = nullptr| only in XMLDocumentParser::EndElementNs() and thus no behavior changes, because this return value is only used in EndElementNs(), and ReadyToBeParserExecuted() and WillBeParserExecuted() are false in such (*) cases. Bug: 686281 Change-Id: If9bb3f9dc89ba46efd6c24a24fc8727a0174c403 Reviewed-on: https://chromium-review.googlesource.com/564200Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#491495}
-
Will Chen authored
Bug: 667560 Change-Id: I1e41ec9991ef0c1aff5acb3ccc177318fd2c79bd Reviewed-on: https://chromium-review.googlesource.com/595238Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#491494}
-
Scott Nichols authored
Change-Id: Ifcb9b811b00bf009a202196623430a9d30d25c65 Reviewed-on: https://chromium-review.googlesource.com/596609 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#491493}
-
Hiroshige Hayashizaki authored
To make it clearer that ExecuteScriptBlock() is the single entry point of script execution by removing the similarly-named ExecuteScript(), which is now only called from ExecuteScriptBlock(). No behavior changes. Bug: 686281 Change-Id: I0e2bcdcf05cc9c3141398a3a465fa6fb268b0913 Reviewed-on: https://chromium-review.googlesource.com/564301Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#491492}
-
chaopeng authored
Revert of Disable hover state change for touch event on page with viewport meta and mobile. (patchset #5 id:80001 of https://codereview.chromium.org/2931433002/ ) Reason for revert: Revert for some website break. Original issue's description: > Disable hover state change for touch event on page with viewport meta and mobile. > > This patch prevent hover state change for touch event on mobile. > > We have 2 checks for this: > 1. Event is from touch. > 2. Viewport enabled (on mobile). > 3. Page with viewport meta. > > BUG=369044 > Review-Url: https://codereview.chromium.org/2931433002 > Cr-Commit-Position: refs/heads/master@{#478777} > Committed: https://chromium.googlesource.com/chromium/src/+/876bb220728d85b1c8a8fe93a0a95bafcf448cd6 TBR=bokan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=369044 Review-Url: https://codereview.chromium.org/2991253002 Cr-Commit-Position: refs/heads/master@{#491491}
-
Chong Zhang authored
According to the latest spec we should filter non-glyph modifiers if the produced characters are part of Unicode 'Other, Control' General Category. e.g. http://www.fileformat.info/info/unicode/category/Cc/list.htm This patch changes implementation to match spec and fixes issues on 'Dvorak - QWERTY Command' layout. Spec: https://w3c.github.io/uievents-key/#selecting-key-attribute-values Bug: 747358 Change-Id: I792b472132ea6deb4213206593136343a2050ccd Reviewed-on: https://chromium-review.googlesource.com/585638Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491490}
-
Jun Cai authored
This is a follow-up CL for: https://chromium-review.googlesource.com/c/591467 This CL updates documentation for LINEAR_ACCELEROMETER on Windows. Bug: 741315 Change-Id: Id79a4fd5292dc084a2c373daa1b86650b00714cf Reviewed-on: https://chromium-review.googlesource.com/598637Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#491489}
-
Ken Rockot authored
It's no longer necessary to use SetUpContext to compensate for individual field accessors being called twice, as they are no longer called twice. This removes all such uses of SetUpContext/TearDownContext. BUG=None Change-Id: I1162f095bc40fd73b2f06323c4f78ed5025e0ee6 Reviewed-on: https://chromium-review.googlesource.com/596497Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#491488}
-
Adrienne Walker authored
This refactors RasterSource to make it possibly to reuse the preamble of transform/clip/clearing that it does when moving raster to the gpu process. The followup to this patch will be to use this preamble and send it as its own PaintOpBuffer ahead of the PaintOpBuffer that gets rastered. Bug: 671433 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia2139f82ad0186df22afeb120fa8944625971ef9 Reviewed-on: https://chromium-review.googlesource.com/592237 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#491487}
-
Hayley Ferr authored
If a touchstart event is not send to the renderer but we receive a whitelisted touch action, we need to reset the touch actions from the previous touch event sequence and start the touch ack timeout. This change adds the InputEventAckState to the SetWhiteListedTouchAction IPC so the needed changes can be made in a later CL. Bug: 727866 Change-Id: Ib4dbc7caf26c278a67fde2bfbfae0fd39d909fc7 Reviewed-on: https://chromium-review.googlesource.com/598247Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Hayley Ferr <hayleyferr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491486}
-
Jared Saul authored
At least 2 unit tests were passing for the *wrong* reasons in this file. The main focuses of this change are: 1) Changing credit cards to be the correct length. The 12-digit numbers in use in this file were failing card.IsValid(), dropping out of the ImportCreditCard() path earlier than expected. 2) Calling base::RunLoop().Run() whenever the database is changed and confirming that setup was correct. The lack of this was causing credit cards to not be added after setup. 3) Minor grammatical/consistency fixes Bug: Change-Id: I313c18bd9ad8d9e89ff6681a19f4412e186657ec Reviewed-on: https://chromium-review.googlesource.com/592509 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#491485}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1dc40944..bfb1b022 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifa82d012c773ea9f84faa77797614ab241409a24 Reviewed-on: https://chromium-review.googlesource.com/598767Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#491484}
-
Xida Chen authored
In a previous CL: https://chromium-review.googlesource.com/c/581907, when we access to the |composited_layer| inside the for loop, we didn't perform any null check, and that's causing crash. This CL adds the null check. NOTRY=true Bug: 751389 Change-Id: I5a0861d416b017af5c51ea82ce3add032b0b2316 Reviewed-on: https://chromium-review.googlesource.com/598123 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#491483}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/50f7a1e4abea..828930677138 $ git log 50f7a1e4a..828930677 --date=short --no-merges --format='%ad %ae %s' 2017-08-02 mtklein Revert "remove another SkConvertPixels "fast path"" 2017-08-02 rmistry Update webpages_playback.py to use the new Golang impl of WPRs 2017-08-01 benjaminwagner Update all Debian bots to 9.1. 2017-08-02 fmalita Delete legacy radial gradient impl 2017-08-02 egdaniel Revert "Revert "Revert "Revert "Add support for semaphores to be inserted on GrContext flush"""" 2017-08-02 fmalita Fix sweep gradient tiling w/ makeColorSpace 2017-08-02 skia-deps-roller Roll skia/third_party/externals/angle2/ b0761934b..df7d7c9ec (1 commit) 2017-08-02 liyuqian Reduce SORT_THRESHOLD to 256 2017-08-02 mtklein remove another SkConvertPixels "fast path" 2017-08-02 fmalita Fix sweep_tiling GM sizing Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: Ia063146367c3bbceff05a39d5fae1f7db5a8c629 Reviewed-on: https://chromium-review.googlesource.com/598497Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#491482}
-
Chris Pickel authored
The factory will remain in the Android tree (it has to, to test against the ChromeHome feature), while the service itself will move to a place where it can be shared with Desktop. I'm not expecting this code to be shared with iOS, which has its own logo service for some extra caching behavior, so the Profile deps can stay. BUG=583290 Change-Id: I5f2840277a787f51cf4523b89bc23a6a0d8dae34 Reviewed-on: https://chromium-review.googlesource.com/597947 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#491481}
-
Fernando Serboncini authored
This is a simple refactor to allow more classes to accept FontSelector instead of CSSFontSelector. Most changes are due to s/FontSelector/GetFontSelector/ on StyleEngine. This builds up ground so we can have a WorkerFontSelector. Bug: 722393 Change-Id: Ib4e891706d306a6fd5d4cf6d3ebb9567f4f8cbfb Reviewed-on: https://chromium-review.googlesource.com/596675 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491480}
-
Jeremy Roman authored
It duplicates work done by wrapper tracing. This change: - reduces time spent in a microbenchmark of add/removeEventListener by 30% (approximately, measured on Linux) - simplifies code (including removing some custom callback epilogues) - avoids the need for an additional internal field on EventTarget (other than Node) wrappers Change-Id: I06023a6bb01ac54bb9e514def17c0aaf4ae50bf0 Reviewed-on: https://chromium-review.googlesource.com/576472 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#491479}
-
Eric Roman authored
Bug: 634443 Change-Id: I415c4d968b29325307401bf1c8b23c24ba977d37 Reviewed-on: https://chromium-review.googlesource.com/597409Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#491478}
-
Steven Bennetts authored
In https://chromium-review.googlesource.com/576567 we unifed some of the default_user_image logic. In doing so it is now possible to call GetDefaultImageUrl with a negative index. Rather than require all callers to test their parameters or handle an empty image, this CL returns the default avatar image for invalid input parameters which should be handled correctly in the UI. Bug: 751335,750577 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3f52af21748d37b55fbed95f24ba2ec07e91e311 Reviewed-on: https://chromium-review.googlesource.com/598451Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491477}
-
Luna Lu authored
Bug: 749251 Change-Id: I5d7ce0b08e979f861b3e560872de58ff6972bcc5 Reviewed-on: https://chromium-review.googlesource.com/598537Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Luna Lu <lunalu@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Commit-Queue: Luna Lu <lunalu@chromium.org> Cr-Commit-Position: refs/heads/master@{#491476}
-
Fady Samuel authored
The handles_frame_sink_id_invalidation bit was introduced because in the OOP display compositor case, each CompositorFrameSinkSupport handled its own FrameSinkId invalidation. Now that HostFrameSinkManager has introduced explicit RegisterFrameSinkId and InvalidFrameSinkId APIs, this bit is no longer necessary. This CL removes it and updates unit tests accordingly. Bug: 657959 TBR: jam@chromium.org for content stamp: already reviewed by boliu@ and kenrb@ Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I901614988ada0134cb029a7bbb98f58d94ada337 Reviewed-on: https://chromium-review.googlesource.com/598529 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#491475}
-
yucliu authored
Use base::UnguessableToken for random origin id. MediaDrmStorage will persist the origin id in the origin map. BUG=493521 TEST=shaka player demo Change-Id: I01690c9f1985c5346306b1b19e60fb5d434a867e Reviewed-on: https://chromium-review.googlesource.com/582212 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491474}
-
erikchen authored
This CL hooks up the plumbing from chrome://memory-internals, so that pressing "dump" causes a message to be sent to the profiling process, with the pid of the process to dump, and a file ScopedHandle ready for writing. For now, the file is always at {USER_DATA_DIR}/memlog_dump, and any existing file is overwitten. Bug: 751302 Change-Id: I1c120aef5c19b67b652aadf2e90c198d577beb7a Reviewed-on: https://chromium-review.googlesource.com/595113Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#491473}
-
Robert Ma authored
Bug: 740175 Change-Id: Id391cbd1e60b34a5ef4cc4ac988f04d3a343e224 Reviewed-on: https://chromium-review.googlesource.com/587270 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491472}
-
Vladislav Kaznacheev authored
The 2x icon had incorrect values in the PATH_COLOR_ARGB command. Copied the correct values (30% opacity white) from the 1x version. TBR=oshima@chromium.org Bug: 751725 Change-Id: I582d393c22201678c16c9ba9a819850e5add01de Reviewed-on: https://chromium-review.googlesource.com/598807Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#491471}
-
Kevin Marshall authored
This adds code to query the process' debug symbol maps for offsets and produces an externally symbolizable backtrace using that data. R: thakis@chromium.org,wez@chromium.org CC: jamesr@chromium.org Bug: 706592 Change-Id: I7b3257ff154671b2eb1c90f7ab91947f55cfa873 Reviewed-on: https://chromium-review.googlesource.com/575290 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#491470}
-
Fady Samuel authored
In order to clarify this requirement, this CL switches the callback to use base::OnceCallback. Bug: 722935 Change-Id: I9fb96cfa794e0aa3d5765e533c5a0f9ac34d995f Reviewed-on: https://chromium-review.googlesource.com/598543Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#491469}
-
Vladislav Kaznacheev authored
The previous implementation only used the device scale to convert from DIP to the screenshot bitmap coordinate space, which did not take into account the scaling applied when the user presses Ctrl+Shift+Plus or Minus. The new implementation deduces the correct scale from the window's transform. Added unit tests for gesture recognition, with regular, rotated and scaled displays. Bounding boxes are now computed and kept as gfx::RectF and rounded to gfx::Rect just once at the last possible moment. This ensures predictable rounding and makes it possible to write readable that do not have to work around quirky implementation details. Bug: 750816 Change-Id: I0ef3fb258917c72220c31b8c0cf37ddb43037958 Reviewed-on: https://chromium-review.googlesource.com/595069 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491468}
-
Ben Goodger authored
R=rockot@chromium.org Change-Id: I151aa6ce13d9c3e60c96864b416af52dea2deb81 Reviewed-on: https://chromium-review.googlesource.com/587034Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ben Goodger <ben@chromium.org> Cr-Commit-Position: refs/heads/master@{#491467}
-
Brian White authored
All of the corrupted histograms are from subprocesses so adding checks where subprocess histograms are merged into the browser (called by SubprocessMetricsProvider::MergeHistogramDeltasFromAllocator). Bug: 744734 Change-Id: Ie6593f2d2ad5fa2e957307b153248bc882174458 Reviewed-on: https://chromium-review.googlesource.com/598189Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#491466}
-
Devdeep Ray authored
Change kMaxNumDelayableRequestsPerClient to kDefaultMaxNumDelayableRequestsPerClient to be consistent with the naming in cc. Bug: 746640 Change-Id: I5d85e93099e92c437c61e87038a81d6296d327bd Reviewed-on: https://chromium-review.googlesource.com/598493Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Devdeep Ray <devdeepray@chromium.org> Cr-Commit-Position: refs/heads/master@{#491465}
-