- 09 May, 2018 40 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f25391b703a2..718dbe7d3244 $ git log f25391b70..718dbe7d3 --date=short --no-merges --format='%ad %ae %s' 2018-05-07 dtu [pinpoint] Reorganize /job API response format. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia14f73378f99265e72fcfbe2213eccdefeed62b2 Reviewed-on: https://chromium-review.googlesource.com/1050948Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557071}
-
Ryan Sleevi authored
The current structure of //net is that there is a base CTPolicyEnforcer that implements the "CT in Chrome" policy documented at https://github.com/chromium/ct-policy/blob/master/ct_policy.md , and embedders or implementors that wish to override this can derive from this base and override the concrete virtual method. However, the CT policy expressed by the CTPolicyEnforcer is intrinsically tied to the set of logs - both notions like "one Google, and one non-Google log" (from the policy), but also the ability to update and maintain those logs over the lifetime of the product. While this is true for Chrome, this is not true for a number of embedders. As part of moving the CT configuration 'out' of //net and closer to the product-level configuration, this changes the CTPolicyEnforcer to be a pure virtual base, and provides a DefaultCTPolicyEnforcer that always treats the build as 'out of date' (equivalent to not making any statement about CT, as it lacks timely details about the logs or the status of the policy). Because EV treatment right now is mixed between the cert layer (which flags CERT_STATUS_IS_EV) and the socket layer (which removes CERT_STATUS_IS_EV if not CT qualified), the socket layer is updated to allow 'out of date' CT status to grant EV. A future change will move the EV policy check out of the socket and closer to the CT policy, so that embedders like Chrome/Chromium can ensure an out of date log list can result in EV status removal. The Chrome-specific policy is now moved into //components/certificate_transparency, the highest it can be moved while still being usable by the Network Service. The Network Service gains a new configuration parameter to configure enforcement of the Chrome CT policy, which works for both the in-process URLRequestContext used by Chrome and the out-of-process Network Service, as a temporary solution. This is a significant change in the API contract of the URLRequestContextBuilder, as it's now effectively moving to disable CT-by-default for //net embedders other than Chrome/Chromium. This is intentional, as the widescale rollout of enforcing CT is coupled to reliable and rapid update mechanisms, and having stale clients with old lists of logs or old policies can negatively impact the CT ecosystem - both site operators worried about compatibility with these products and for CAs wanting to ensure their certificates reliably work. Mobile versions of Chrome/Chromium are, for the time being, also move to disable enforcement, similar to how static HPKP is disabled for Android and iOS. Additional work will be done to ensure that the list of logs is reliably updatable for these clients, which will then facilitate enabling CT enforcement. BUG=702062 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic5145b6759d8843cb9134e7718e5834c7b5bb010 Reviewed-on: https://chromium-review.googlesource.com/1020160 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557070}
-
Carlos Knippschild authored
This change adds a new trigger to the downloading of thumbnails for prefetched offline articles right after GeneratePageBundle is requested. This is in addition to the later attempt made when a prefetched article is successfully downloaded and aims at improving the availability of article thumbnails. Bug: 794828 Change-Id: Ic857ab91f4f2befb327e91300005c59c10bc417d Reviewed-on: https://chromium-review.googlesource.com/1047991 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#557069}
-
David Black authored
This also requires modifying layout padding on visibility change. Bug: b:79387198 Change-Id: I6b7b734badd3bf054b63d6517d82b2c976a9ddf2 Reviewed-on: https://chromium-review.googlesource.com/1050734Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#557068}
-
David Black authored
Unit test tracked in b/77656544. Requires writing a test version of AshAssistantController which I will do after slight refactor. Motion spec not yet defined. Bug: b:79425648 Change-Id: Ic953d3c8c2e85af9929a425a55a794e55bab3a91 Reviewed-on: https://chromium-review.googlesource.com/1050582Reviewed-by:
-
Philip Rogers authored
This patch fixes a regression from [1] where MapToVisualRectInAncestorSpaceInternal was changed to not apply a counterscroll offset for fixed position descendants. Interest rect calculations incorrectly relied on this behavior. MapToVisualRectInAncestorSpace is exclusive of the clip and scroll on the ancestor object. To account for this, the interest rect logic would call MapToVisualRectInAncestorSpace and then apply the root clip and scroll offset, but this is not correct if there are fixed-position children. This patch updates the callsite to MapToVisualRectInAncestorSpace to map to nullptr instead of the root view which will include the layout view's clip and scroll. [1] http://crrev.com/e931d2aecb Bug: 838111, 831380, 840504 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I14b023279ef58e0123febae367a2ea0c67733c50 Reviewed-on: https://chromium-review.googlesource.com/1047193Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557066}
-
Fergus Simpson authored
Adds a new DISPLAY_BRIGHTNESS_CHANGED value to AvSettings's Event enum. This event should be fired when display brightness is changed. BUG=internal b/76421244 BUG=internal b/77479163 TEST=None Change-Id: Ifd9661c63fb5684e04358b5a44e2035bee87c10c Reviewed-on: https://chromium-review.googlesource.com/1045311Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Fergus Simpson <afergs@chromium.org> Cr-Commit-Position: refs/heads/master@{#557065}
-
Abhishek Arya authored
TBR=mmoroz@chromium.org Change-Id: Ic835553e8955ca3618a6c0b3a4187d4e5f94ddfe Reviewed-on: https://chromium-review.googlesource.com/1051034Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#557064}
-
Steven Holte authored
Bug: 755407 Change-Id: If7dc53455d023c653e184cdbfe5066875aea7052 Reviewed-on: https://chromium-review.googlesource.com/1028851 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#557063}
-
https://chromium.googlesource.com/angle/angle.git/+log/de1c1db091aa..e95a7f077e8b $ git log de1c1db09..e95a7f077 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 jmadill Make EGLThreadTest cross-platform. 2018-05-08 fjhenigman Revert "ANGLETest: Reuse test windows per-renderer" Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Ib0bdb0c1a729ccfad45e9df88e4bbfc6f2374ff9 Reviewed-on: https://chromium-review.googlesource.com/1050409Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557062}
-
Zhenyao Mo authored
BUG=840035 TEST=gpu_unittests R=kbr@chromium.org,yang.gu@intel.com Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I24164e419c78d116d7ef665345690f17381764fb Reviewed-on: https://chromium-review.googlesource.com/1045613 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557061}
-
Peter Boström authored
This reverts commit a6598e5d. Reason for revert: Partial reland that doesn't remove caching of tint_. Original change's description: > Revert "Use GG700 / Chrome icon color for toolbar" > > This reverts commit b5d6fee9. > > Reason for revert: Speculative revert for mash_browser_tests failure on linux-chromeos-rel > https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/7672 > > Original change's description: > > Use GG700 / Chrome icon color for toolbar > > > > Replaces GG800 with GG700 as icon color in a couple of places: > > > > * Omnibox default chip (HTTP (i) icon for instance). > > * BubbleIconView inside omnibar (these used to be GG700 but regressed > > to GG800 in Touchable / Refresh recently). > > * Toolbar button icons. > > > > Bug: chromium:821996, chromium:834510 > > Change-Id: I9e953c9da1e0eee1da132e3e0e71474ff7877aef > > Reviewed-on: https://chromium-review.googlesource.com/1040875 > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Reviewed-by: Peter Kasting <pkasting@chromium.org> > > Reviewed-by: Evan Stade <estade@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#556646} > > TBR=pkasting@chromium.org,estade@chromium.org,pbos@chromium.org,bsep@chromium.org > > Change-Id: I1d56fd212cbe1ed50b620b61b9287cfa8abc5b48 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:821996, chromium:834510, chromium:840657 > Reviewed-on: https://chromium-review.googlesource.com/1049445 > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556700} TBR=pkasting@chromium.org,estade@chromium.org,bsep@chromium.org Change-Id: I280c016c9cf772ce5919c29ebee4dba8535e44e3 Bug: chromium:821996, chromium:834510, chromium:840657 Reviewed-on: https://chromium-review.googlesource.com/1050486 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#557060}
-
Khushal authored
ImageFrameGenerator ensures that accessing the cached ImageDecoders is thread-safe using a mutex, locked for the duration of ImageFrameGenerator::TryToResumeDecode. However, the bitmap returned by this method holds a reference to the pixel buffer which can still be mutated by the ImageDecoder. This can introduce a race between copying the pixel buffer to the caller's memory and another thread writing to it to decode a subsequent frame. Ensure the above is avoided by holding the mutex for the duration of the decode and copying the pixel buffer to the caller's memory if necessary. R=chrishtr@chromium.org BUG=840946 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I110c54232385b5d335001f221a480371968f9551 Reviewed-on: https://chromium-review.googlesource.com/1050619 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
dpapad authored
Elements that use md-select are already directly including such style. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib7ac481f19a76ea46958220f66acb8c4b4f32543 Reviewed-on: https://chromium-review.googlesource.com/1048947Reviewed-by:
-
Jennifer Apacible authored
Currently, the OverlayWindow does not adhere to the video aspect ratio while resizing. It only does that the first time the window is created. This changes makes the window snap to the original (and intended) aspect ratio when the window is resized. The window will always keep to the original orientation, whether landscape or portrait (or square). This change includes a non-smooth behavior where the user is able to make the window whatever aspect ratio while in the process of resizing. After the user 'completes' the action, such as letting go of a mouse drag, the window will snap to adhere to the aspect ratio. The layer contents will only be refitted in the window when it's adhering to the aspect ratio. There will be future work on making this smooth. BUG: 829677 Change-Id: Ic7bea948b901f7a5174ea5bd50c921c29fb2f487 Reviewed-on: https://chromium-review.googlesource.com/1043546 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#557057}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71a6995084bd..88b12e9a8628 $ git log 71a699508..88b12e9a8 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 khushalsagar fonts: Fix subpixel position mismatch in font remoting 2018-05-08 scroggo Treat SkFILEStream's fOriginalOffset as the start Created with: roll-dep src/third_party/skia BUG=chromium:b/78866720 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I968f86777b7aa82e30363d9e706a738786c72b31 Reviewed-on: https://chromium-review.googlesource.com/1050874Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557056}
-
dpapad authored
Bug: 840591 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6fdde8fc17af9592cb2bb6d52a6ef476c50309ab Reviewed-on: https://chromium-review.googlesource.com/1048884 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Justin Cohen authored
Followup to tab strip refresh. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iac880a7a687e413badef031451a24c61d855175d Reviewed-on: https://chromium-review.googlesource.com/1050472Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557054}
-
Tien-Ren Chen authored
This CL adds code to collect contents layers as foreign layers for BlinkGenPropertyTrees mode. Most layout tests involving canvas / composited images / video / plugins should now pass. Composited scrollbars should also draw, though the thumb position may not be synchronized. BUG=840037 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I905b4b30136fcbc30133fc50f0133a46d3f922ee Reviewed-on: https://chromium-review.googlesource.com/1048841 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#557053}
-
Tetsui Ohkubo authored
This CL adds UMA to mute button on the left side of volume slider in SystemTray. It applies to both old SystemTray and UnifiedSystemTray. This CL also fixes volume slider UMA in UnifiedSystemTray. TEST=manual(chrome://user-actions) BUG=b/79256317 Change-Id: Ic0da732c360e72578d099a82db5ae9fbde05013a Reviewed-on: https://chromium-review.googlesource.com/1049408Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#557052}
-
Qiang Xu authored
changes: In the past, ash::HighlightController calls mojom::HighlightControllerClient with events like enable state, selection rect. For native assistant, introduce HighlighterController::Observer to let AshAssistantController to observe Highlighter status. This CL makes highlighter enabled state control interaction state and its input modality. This cl also: - Some changes in ash::AssistantBubble, don't need to close bubble widget and recreate every time, we just need to hide it. - In ash::AssistantBubble, remove widget observer just needs to happen in either OnWidgetClosing or OnWidgetDestroying. - Add AshAssistantControllerTest class and add this CL's tests. unittest: AshAssistantControllerTest.HighlighterEnabledStatus Bug: b/78193960 Test: enable assistant fully and then manual test. Change-Id: If8847b2258103f581653cfec83493324217ee3bd Reviewed-on: https://chromium-review.googlesource.com/1048866Reviewed-by: -
Tetsui Ohkubo authored
This reverts commit fd312950. Reason for revert: tools/metrics/actions/actions.xml presubmit check fails on another CL. Please run tools/metrics/actions/extract_actions.py and add the description. Sorry for inconvenience. Original change's description: > Add UMA event for entering Android tab switcher by toolbar swipe > > We currently don't have any UMA events for entering the Android tab switcher by > swiping down on the toolbar. In > https://chromium-review.googlesource.com/c/chromium/src/+/1048042, I am updating > the MobileToolbarShowStackView logging to include this case. In this CL, I am > adding a new MobileToolbarSwipeOpenStackView event specifically for this case so > we can measure how many people are entering the tab switcher by swiping on the > toolbar. > > Bug: 828224 > Change-Id: I2b2f7e4dafd08192355618273d7069a03b4d9e4e > Reviewed-on: https://chromium-review.googlesource.com/1048308 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556954} TBR=dtrainor@chromium.org,rlanday@chromium.org Change-Id: I1f26c5b544e759b76b68db6478ae147b5475c40a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828224 Reviewed-on: https://chromium-review.googlesource.com/1051065Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#557050}
-
Joel Einbinder authored
This removes some features from UI.Fragment: x-shadow states inline styles It adds a simple helper method, UI.html which returns an element. As a driveby, also fixes the jsdoc validator to parse spread operators. Change-Id: I569f697bbe29530b7a494c75727dcf37769f8f05 Reviewed-on: https://chromium-review.googlesource.com/1050617Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#557049}
-
agrieve authored
This reverts commit dc92f9db. Reason for revert: Tests consistently fail on https://ci.chromium.org/buildbot/chromium.android/Marshmallow%20Tablet%20Tester/12646 Original change's description: > Reactivate deflaked keyboard accessory tests > > After having landed https://crrev.com/c/1028230, the problems of the > linked bug seem to have gone (as assumed). > > I removed the Disabling and RetryOnFailure annotations to test on 3 > devices (one physical, two emulator with different screen sizes and OS) > and couldn't find a single broken test. > Edit: I changed the font size recently (not finally) which seems to > bother some bots - unrelated from the filed bug. Changed that back. > > This CL now reenables all the tests but keeps the RetryOnFailure > annotation. That way, I can test whether the tests start failing on > some bots again without making the sheriffs life harder. > If the bots don't notice any flakiness, I will remove the > RetryOnFailure annotation as well and mark the linked bug fixed. > > Bug: 838922 > Change-Id: I9781e6d820ac39e43435ad1529da817601967ed4 > Reviewed-on: https://chromium-review.googlesource.com/1044371 > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556798} TBR=bauerb@chromium.org,fhorschig@chromium.org Change-Id: I60198d2fbcd36c4687b379d07995e1b873112d51 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 838922 Reviewed-on: https://chromium-review.googlesource.com/1051026Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557048}
-
Kent Tamura authored
It replaces prettifier written in Ruby. This CL moves the remaining content of prettypatch.py to tools/ commands/pretty_diff.py because it's very small and there are no other callsites. Bug: 672651 Change-Id: I91e94356a5cfd73cf714b09f3b47bb4cab738454 Reviewed-on: https://chromium-review.googlesource.com/1039121 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557047}
-
Rohit Rao authored
Adds skeleton implementation of a mediator and consumer interface for the BookmarksHomeViewController. Business logic will be added in a future CL. The ChromeTableViewConsumer protocol is added to serve as a base protocol for all tableview-based mediators. Individual subclasses can extend this protocol and add feature-specific methods. BUG=840381 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I42ff91edfaa6c85a3e534ce515bb9fc82ae1e1fc Reviewed-on: https://chromium-review.googlesource.com/1050196Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#557046}
-
Stefan Zager authored
BUG=827639 R=chrishtr@chromium.org Change-Id: I21f63aed1e3bac1cae3e5ec0f9253371508579f4 Reviewed-on: https://chromium-review.googlesource.com/1050695 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
-
kapishnikov authored
Make the map that contains collected metrics data leaky. This fixes the issue when the static objects are deallocated by the main thread while the network thread is still active. This can happen when the app that uses Cronet is terminated. BUG=840488 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5d8a3f06ead10071d5598fee0ae0203490a0a412 Reviewed-on: https://chromium-review.googlesource.com/1050766 Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#557044}
-
Xiaocheng Hu authored
RenderedPosition is no longer a general purpose class, and is being deprecated. This patch removes unused member functions and cleans up comments for it. Bug: 811502 Change-Id: Ifc49e2c1dd554b0fc51126a692c7873591f61dca Reviewed-on: https://chromium-review.googlesource.com/1050928Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#557043}
-
Tibor Goldschwendt authored
When clicking on a tab in the VR tabs overview (tabs switcher) select that tab and go to the main browser environment after the tab has been selected. Bug: 840511 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: If373166215b2a1dae10bd714dec084fc90087e9d Reviewed-on: https://chromium-review.googlesource.com/1048269Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#557042}
-
Christopher Grant authored
The Text element is now the only handler of text in the VR UI. BUG= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I16501feb6274aebad33426c53798eec21bb6d832 Reviewed-on: https://chromium-review.googlesource.com/1048400 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#557041}
-
Zhenyao Mo authored
This reverts commit c8d6aa16. Reason for revert: crbug.com/841085 (this is blocking CQ) Bug: 841085 Original change's description: > [autofill] Suppress the use of invalid profile data. > > This CL adds feature flags that causes Chrome to suppress suggestions, > votes and quality metrics based on profile data which has been flagged > as likely invalid. > > This will allow Chrome Team to evaluate the utility of attempting to > filter out this data. > > Bug: 835984 > Change-Id: I63f51ac893d2bf657af9eb136d920cb0b7f2bddd > Reviewed-on: https://chromium-review.googlesource.com/998132 > Commit-Queue: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556900} TBR=rogerm@chromium.org,jwd@chromium.org,sebsg@chromium.org Change-Id: I549b1fa0af8f367a62e8afa57fcda43ee592fa12 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835984 Reviewed-on: https://chromium-review.googlesource.com/1051025Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#557040}
-
Hiroki Nakagawa authored
Bug: 825740 Change-Id: I669a1cfaaf6600d6eaf4d6f5fbcb06a6f1f1ef50 Reviewed-on: https://chromium-review.googlesource.com/1009348Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#557039}
-
Bailey Berro authored
This change implements SetupKerberos on SmbProviderClient. This allows SmbService to call SetupKerberos over D-Bus. BUG: chromium:757625 TEST: compiles Change-Id: I538d503ac8462ff145d956553890b9e1f06a74e8 Reviewed-on: https://chromium-review.googlesource.com/1045129 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#557038}
-
Sam McNally authored
The code that depended on this was removed in https://codereview.chromium.org/1989163002/. Change-Id: Ia4d72409159d42b65cea15c24c2f6002baabfffd Reviewed-on: https://chromium-review.googlesource.com/1049725Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#557037}
-
https://pdfium.googlesource.com/pdfium.git/+log/b7c41498ac1f..df1298a228ab $ git log b7c41498a..df1298a22 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 npm Add several FPDFPageObj_* APIs 2018-05-08 hnakashima Revert "Ensure that XFA Pages always have a corresponding PDF page" 2018-05-08 thestig Mark CPDF_Object pointers as const in CPDF_ViewerPreferences. 2018-05-08 thestig Add APIs to work with a FPDF_PAGERANGE. 2018-05-08 npm Remove almost all usages of CFX_FixedBufGrow with std::vector 2018-05-08 thestig Remove PDFTRANS_KNOCKOUT. 2018-05-08 thestig Add constants for PDF 1.7 spec, table 7.2 and 7.3. Created with: roll-dep src/third_party/pdfium BUG=chromium:840922 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0d8227d226a1a75bcba66dcfa03f908112897016 Reviewed-on: https://chromium-review.googlesource.com/1050626Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557036}
-
Yuichiro Hanada authored
An application id of notification surfaces is needed to distinguish notification surfaces from ARC++ apps from surfaces from other exo clients. IsArcNotificationWindow() in arc_ime_service.cc will be updated after client side code is updated. Bug: 829383, 834027 Test: Build pass & Inline reply on ARC++ notifications works corretly. Change-Id: I471d8f6be2fdd40e02178cdeb1a27b4e71b03842 Reviewed-on: https://chromium-review.googlesource.com/1039505 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#557035}
-
Evan Stade authored
- originally landed as 5d480c70 - reverted as e14e1aed - test failures fixed as 22800d9f Original change description: 1. Move BrowserFrameHeaderAsh to //ash/frame and rename to CustomFrameHeader. 2. Use CustomFrameHeader for browser windows (in HeaderView). Continue to use DefaultFrameHeader for other windows. Possible TODO: share more code between the two FrameHeader classes. 3. Transport frame images over mojo so Mash can apply them via CustomFrameHeader. For now, only the active frame image is propagated (as a POC). The inactive image, overlay images, and frame colors are TODO. Ideally, there should be no behavioral changes in classic Ash. BUG=704942,836992 TBR=sky@chromium.org Change-Id: Ic0763d3cebfe2a6f354d1345ed84ed02631e8210 Reviewed-on: https://chromium-review.googlesource.com/1050799 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#557034}
-
Christopher Grant authored
This change restores the new prompt background to be inert, and adds a test to ensure this. It also extends the test framework to more reliably similate element clicks. We now can use a controller position and click to fire at the element, rather than poking directly at an element's click handlers. This overcomes the problem of invoking a handler that otherwise would not be triggered by the input manager, if the element is non-hittable or obstructed by other elements. BUG= R=vollick Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ia4b8a80ff7908dc3dbfbde878b0d32c815b1b513 Reviewed-on: https://chromium-review.googlesource.com/1050410 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
-
Donn Denman authored
Adds some Log statements to try to help isolate a crash on older versions of android that happen when we use a text view with ellipsis=start. BUG=834959 Change-Id: I66656eea53cc9f36a09bed26705c010e02be0112 Reviewed-on: https://chromium-review.googlesource.com/1044540 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#557032}
-
