- 20 Jan, 2021 40 commits
-
-
Nate Fischer authored
record_netlog.py was constructing an on-device path with "os.path." This isn't correct on Windows, where we want to use posixpath for on-device paths and os.path for on-host paths. Fixed: 1156518 Test: validity check the script still works as intended on Linux Change-Id: I8120bf5416fc957d4cc0605a49d2a32d190aa2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577634 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#845284}
-
Kevin McNee authored
We recently added a CHECK that MimeHandlerViews can't navigate away from their handling extension. However, attempting to perform a lighthouse audit of the PDF viewer causes it to navigate to about:blank. While this is still a bug, we no longer CHECK in response to about:blank. Bug: 1168046, 1158381 Change-Id: I84f137cffb1dbf6173bd6ad53d7bf24703acba3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637404Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845283}
-
danakj authored
The Frame mojom is removed, and FrameNavigationControl inherits its members and is renamed to Frame. The FrameFactory is deleted, and we pass a pending Frame receiver to the renderer when we create the RenderFrame. Likewise, when a child frame is created in the renderer, we pass a pending Frame remote to the browser. Then the Frame mojom interface is present in the browser as long as the RenderFrame is created (aka render_frame_created_ = true). This means we remove the concept of pending RenderFrames in the renderer as well. This was discussed on chromium-dev@ and navigation-dev@ here: https://groups.google.com/a/chromium.org/g/navigation-dev/c/ROWqf4OSAc8/m/ayWK5o5HAwAJ RenderFrameCreated() is now solely responsible for setting up the mojom bindings pulled off the content::mojom::Frame interface, and assumes that the remote Frame interface has been given to the RenderFrameHost before-hand. This should be done as at the time of sending or receiving and IPC to create the renderer-side Frame, the pending remote is generated or received in the browser process. R=dcheng@chromium.org, dtapuska@chromium.org Bug: 1158869, 859110 Change-Id: Ibbb91855ea5428d21b6bfe2328fa845eaa4794c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593750 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845282}
-
Ken Rockot authored
Bug: 1004256 Change-Id: Id69210a2c22bd64da82492fae5da41f4eaf0da98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636851 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845281}
-
Collin Baker authored
For security reasons, the thumbnail system must be able to clear the thumbnail for a tab and notify subscribers. A recent CL implemented this behavior but resulted in crashes in TabStripUIHandler::HandleThumbnailUpdate This CL fixes the crashes due to the null pointer access and handles blank thumbnails by sending an empty URI to the WebUI. Fixed: 1167502 Change-Id: I679500882b671b799f3a3c00b55ac20d8e1fb561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638635 Auto-Submit: Collin Baker <collinbaker@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845280}
-
Alex Newcomer authored
The debouncing we have in place is not slow enough for the web async clipboard api. Pasting from the google searchbox results in multiple clipboard reads, and debouncing requires more of a delay than provided by PostTask. Add a 100ms delay instead. Bug: 1167403 Change-Id: Id24b6a7d21b7dd6e471a8f79635fc25cdae194f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636886 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#845279}
-
Andrey Kosyakov authored
Add an ability to enable HUD display for performance metric on a per-renderer basis through CDP. Bug: 1152089 Change-Id: Ia6f097fc90ceae5a3e9dc878d7880adbf02ce7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639393Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#845278}
-
Ken Rockot authored
Minimal changes are made here to adapt the webmidi tests to WPT and move them into wpt_internal. Bug: 1004256 Change-Id: I78fe61ca5885c9896f63472d2b564eae6ec68951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638773 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845277}
-
Javier Ernesto Flores Robles authored
To be submitted between Jan 13-20 after PSA and reach of deadline. Context: https://docs.google.com/document/d/1zR3Zewjo6ACEFZBMSG_YWTg9vouaeGAmbIzmp0bTpzY Bug: 1161027 Change-Id: Ie198bbd9cd99e301ee893b3caff36e75dd868a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599927 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#845276}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/22be66d40712..e27e7488e4ad 2021-01-20 amaiorano@google.com VulkanBenchmarks: factor out code into separate files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I75acb85222c7b980b5dcbebdc48a54d315ae9eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845275}
-
Kevin Marshall authored
Fixes a test flake that was caused by incomplete precondition criteria. Now the test case will wait until the document is parsed before executing the test case. Bug: 1162433 Test: Executed test case with --gtest_repeat=500, no issues found. Change-Id: I0c5f58965906ec4e83b6212287a529d5b0190034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638333 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845274}
-
Patrick Noland authored
This change moves setUrlFocusChangeInProgress, onUrlFocusChange, and finishUrlFocusChange to LocationBarMediator, consolidating phone- and tablet-specific logic as appropriate. Moving these together allows us to move several pieces of state into LocationBarMediator together, e.g. mUrlFocusedWithoutAnimations and mUrlFocusChangeListeners. Unit and instrumentation tests covering the migrated logic are also included, and some on-focus triggered accessibility logic has been moved to UrlBarCoordinator. Bug: 1147581 Change-Id: I4cab5b32402b86a953d22418eb94f375a21b9cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598036Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#845273}
-
Ken Rockot authored
This is in preparation for moving the tests to internal WPT where they can consume Mojo JS modules. Opportunistically modernizes and simplifies many of the tests as well. Bug: 1004256 Change-Id: I2fcfa11034c82d5cde8d300fed98188aa6088b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638569 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#845272}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/710f03fa..1d681a1a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifb7da2ade04690d20d683728f3a586567a2195b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640676Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845271}
-
Yutaka Hirano authored
Bug: 1168407 Change-Id: I5faa426fac6c53e1219dfe3ae7805a2eff26e393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639499 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#845270}
-
John Delaney authored
Update expiry of PageLoad.HeavyAds.ComputedTypeWithThresholdNoise and PageLoad.HeavyAds.InterventionType as they are still used to measure impact of heavy ad intervention. PageLoad.HeavyAds.ComputedType2 is no longer needed and is obsoleted. Bug: 1160766,1160767,1160768 Change-Id: I5bdc902b7fee7915741d80110dc64c3c2ecde933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638104Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#845269}
-
Eugene But authored
Change-Id: I9d2be54c92815a0dffcf1c01c28c537a0ff6839d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638784Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#845268}
-
Yann Dago authored
The field "program_files_dir" will accept the full path to the system's Program Files or Program Files (x86) directory (typically found in C:\). This field will be linked to the MSI installer's PROGRAMFILESDIR property. This new field will only be used for fresh system-level Chrome installations and will be ignored for other kind of installations and updates. Bug: 1165921 Change-Id: Id688133c2b2740a953569c9453b808f2aeb7d1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439784 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#845267}
-
Rushan Suleymanov authored
The FlocIdComputedEventLogging feature toggle might cause failures in some sync integration tests. Disable it as a temporary solution to mitigate the flakiness. Bug: 1153297 Change-Id: Ibda3ea651751cc19709f3a2c0f56956b3702b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640420Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#845266}
-
Evan Stade authored
The unit test is ported to be run outside of Chrome. Bug: 1164069 Change-Id: I8c047e8497cc738ede8c20d5ae43b30089a81357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631626 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#845265}
-
Robert Flack authored
This histogram tracks the time from all wheel events to when the swap begins for the resulting frame. However, we typically only look at the more specific Event.Latency.Scroll(Begin|Update).Wheel.TimeToScrollUpdateSwapBegin4 metrics which reflect the same values. Bug: 1081296 Change-Id: Ibd1fd7dd684c31405d4cbdad98216ca82553d760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627765 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#845264}
-
Dominique Fauteux-Chapleau authored
This relands crrev.com/c/2633701 that was reverted by crrev.com/c/2637406. The cause of the flakiness was that the WebContents corresponding to the scan would get destroyed before the scan had finished, resulting in a segfault with |web_contents_|. The solution is to break the dependency of ContentAnalysisDelegate on that WebContents by extracting the required data from it at a moment when it's known to be non-null in the ctor. Original change's description: > Handle sync paste deep scanning crash > > This fixes the crash observed in crbug.com/1166233 and adds tests for > it. See the comments in that bug for more details. > > This fix also removes the dialog for unauthorized users for pasting > after the initial scan that does authentication, so crbug.com/1028133 > is affected. > > Bug: 1166233, 1028133 > Change-Id: Id3c992fdeccfa92a9f88e25c13e7a15bcb1afd8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633701 > Reviewed-by: anthonyvd <anthonyvd@chromium.org> > Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844787} Bug: 1166233, 1028133 Change-Id: Ifc760b9489d810c460889e396430c82b4f80e858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638533Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#845263}
-
Mason Freed authored
With this CL, navigator.plugins and navigator.mimeTypes will both return empty arrays. With the removal of Flash, there is no longer the need to return anything for navigator.plugins and navigator.mimeTypes. These APIs were used primarily for a) probing for Flash player support, or b) fingerprinting. As such, we'd like to return empty for these two properties. Gecko already switched to returning *only* Flash starting with Firefox 52, and returning empty as of Firefox 85. I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/bbxAGu90LgM Fixed: 1164635 Change-Id: I445fa2d034444938c08ef721d997f8acc1389c56 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629990 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#845262}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101200600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/q5f0_t4xSQ4mERL5xl7GFgy2LTd5J4sdL_sUp44LNFUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021 Tbr: help-app@grotations.appspotmail.com Change-Id: I2b4f5ad5e421a1505b3587de5ae59c50924017c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639516Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845261}
-
Polina Bondarenko authored
ARC data snapshots must be expired in 30 days if not updated. Added timer to SnapshotInfo and tests. BUG=b:161221001 TEST=components_unittests Change-Id: If5cffeeba0957a0e5e9225c835241ec47a486c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502690 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845260}
-
Findit authored
This reverts commit c072c8c7. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 845219 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2MwNzJjOGM3NDZlYjA5OWYzNzE5MGU0YzZjNWEzOWM0Yzk0N2I2OGUM Sample Failed Build: https://ci.chromium.org/b/8857563414825836112 Sample Failed Step: bf_cache_unit_tests Original change's description: > Fix bug in reservation monitoring. > > In ScopedReservation destructor did Reserve instead of Discard! > This is now fixed, and unit tests provided for this and other cases. > Also, Storage tests now verify that all memory has been released after > the storage is reset. > > Bug: b:174509632 > Change-Id: Ic3594f569f53c103d6ae9c6a73bd030c5f25d698 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638220 > Commit-Queue: Zach Trudo <zatrudo@google.com> > Reviewed-by: Zach Trudo <zatrudo@google.com> > Auto-Submit: Leonid Baraz <lbaraz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845219} Change-Id: I453d14fd867294c134b72a40331ffd98a7a6e12c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:174509632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639575 Cr-Commit-Position: refs/heads/master@{#845259}
-
Shahbaz Youssefi authored
Facilitates renaming a variable in that class inside ANGLE. Bug: angleproject:3580 Change-Id: I5b00e1b72ada0aa77f9276f7af28b33518e77d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637956 Auto-Submit: Shahbaz Youssefi <syoussefi@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845258}
-
Ulan Degenbaev authored
Bug: 1157095 Change-Id: I947cfdcd5796e4d19aaf0d3e03b6c9ca4aa7b759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610782Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#845257}
-
David Maunder authored
Speedup ThumbnailDiskStorageTest: 43532ms -> 7442ms (83%) Speedup ThumbnailMediaParserTest: 12166ms -> 5897ms (52%) Bug: 1168182 Change-Id: I50883068f8bc2d9ee92a5bb6e782ac555a0176d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638079Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#845256}
-
Roman Sorokin authored
This CL fixes DCHECK on Chrome OS when trying to run Guest session from the login screen. Fixed: 1163345 Change-Id: I9b4ad69186dd217fc792d67c480743430b171664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632653Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#845255}
-
Matthew Mourgos authored
Bug: 1168331 Change-Id: I4a098d0c02826fc287de17183cef49f494c2c030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638721Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#845254}
-
Shuran Huang authored
This part was missed from the CL https://crrev.com/c/2363389. Bug: 1090128 Change-Id: I94fbb62dd2feb74a4c1e660e338ddddb6d740233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638398 Commit-Queue: Shuran Huang <shuuran@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845253}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2c92c33564e4..a3c06205b28b 2021-01-20 fmayer@google.com Merge "Use hermetic linker for non cross compiling hermetic compiler." 2021-01-20 dproy@google.com Merge "protos: Fix next reserved id comment in trace_packet" 2021-01-20 treehugger-gerrit@google.com Merge "Disallow extra guardrails profiles on traced_perf on user." 2021-01-20 treehugger-gerrit@google.com Merge "tracing: Distinguish between global and per-thread default track" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I00e8437c94501182c3369b5b412f541b03cbe8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638924Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845252}
-
Jordan Taylor authored
Changed internal type of Animation::current_time_ and Animation::start_time_ to AnimationTimeDelta This change will make it easier to change the API return type of these attributes to CSSNumberish. It also removes the need to convert back and forth between seconds and milliseconds in internal functions. Bug: 737867 Change-Id: I83cd9df096d8695909768d6f9081757fff2cccb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591488Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845251}
-
Ahmed Fakhry authored
Fixed: 1168347 TEST: Manual Change-Id: I65aa794b8f4f0692ed881a4ba3abfe49437a528d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638496Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#845250}
-
Howard Wolosky authored
I missed the fact that you need to explicitly press the "Start Review" button with one of my recent CL's. I figure that there are other new Chromium contributors who may have a similar experience -- so, updating the checklist to explicitly call this out. Change-Id: I96a9b97df38bd876b28bf5dc5c493baaf0f561fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636685 Commit-Queue: Howard Wolosky <Howard.Wolosky@microsoft.com> Reviewed-by:
Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#845249}
-
John Abd-El-Malek authored
Add field trial config for CalculateNativeWinOcclusionCheckVirtualDesktopUsed since it'll be tested on beta. Bug: 1162132 Change-Id: I684dee12e2b6034197881ebab5752499c980f525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633528Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#845248}
-
Aaron Leventhal authored
Do not create AXObjects for head, style and script subtrees unless known to be visible (and we don't know that if it's display locked, so in that case we assume those subtrees shouldn't be created). Bug: None Change-Id: I86649a346d0ffaa1ca402c7076e7ccfe197600c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633925 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#845247}
-
Etienne Pierre-doray authored
This CL removes Jobs deprecated function overrides in gin: IsRunning() IsCompleted() Change-Id: Ib7b39c4004bf2429e4e4a585062a8fbabfe54c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638334Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#845246}
-
Steve Cho authored
SetupPastIndependence This CL fixes a bug reported about ref_frame_sign_bias issue in Vp9UncompressedHeaderParser::SetupPastIndependence. Also, unittest is added for SetupPastIndependence function. There are two bugs: 1. SetupPastIndependence() is not invoked in some cases. 2. ref_frame_sign_bias is not reset in SetupPastIndependence(). Their triggering conditions are identical, that is !show_existing_frame && frame_type!=KEYFRAME && !intra_only && error_resilient_mode According to VP9 Bitstream & Decoding Process Specification, section 7.2 (page 64), ref_frame_sign_bias should be reset in setup_past_independence. Change-Id: I4928e8363406ae7ee0e3f7c59ea4926483c68bf8 Bug: b:176566296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629652 Commit-Queue: Steve Cho <stevecho@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#845245}
-