- 23 Aug, 2019 40 commits
-
-
Charlie Harrison authored
Bug: 975411, 975641 Change-Id: I2de34b8a0d9e2f9acc4bea4538eafc94276eed06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763195 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#689984}
-
Tommy Li authored
ZeroSuggestProvider / RemoteSuggestionsService likely will not need custom endpoint support anymore, so remove it from the code. Bug: 995393 Change-Id: Ifa0ad89ac8d71679cdc6c0563790f7600ba9f5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761063Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#689983}
-
Raymond Toy authored
WebAudio legacy code often does something like: DCHECK(foo); if (!foo) return; The style guide says the if/return should be removed; DCHECK failures should not be handled. Part 4 of N: Update a few more files and for the most obvious cases where we can remove the if/return. Bug: 957654 Change-Id: I85c8c87e02b319ea1fa95768b7297500d36a0d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762763 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689982}
-
Jeroen Dhollander authored
Previously we used |std::shared_ptr| but a new pre-submit check blocks that meaning we can not create new code using |AssistantInteractionModelObserver| until this API is modified to use |scoped_refptr|. This is required for crrev.com/c/17564278 Change-Id: Id5963917160dee2761a35cb933e02616cc823122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766451 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689981}
-
Bettina authored
The call to SecurityEventRecorder causes Chrome to throw a segmentation fault. Commenting out to be able to allow non-sync password protection to be available in dev/canary. Bug: 914410 Change-Id: I67c5deef7f206fac204b9fe459be2ac15dd958ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765995 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689980}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/65f775037b67..0f15d7373bf1 git log 65f775037b67..0f15d7373bf1 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 reed@google.com optimize verts Created with: gclient setdep -r src/third_party/skia@0f15d7373bf1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: Ic891e4ee3093cc97a609654c2c0f8f1b3be72dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689979}
-
Mason Freed authored
Prior to this CL, and after [1], the mask_type() field of the PictureLayer created by UpdateMaskLayer was not properly set. This meant that for large masks, the standard tiling logic kicked in and tiled the mask, which (after [1]) was not supported and resulted in a DCHECK and/or the mask not properly being applied. This fixes that bug. I also added a backdrop-filter/mask test with a large mask to ensure this works. [1] https://chromium.googlesource.com/chromium/src/+/310cae44aff889a75fc85ce5ec89d9341eccc665 Bug: 992782 Change-Id: Ibc461638abdeedd8ff9f4730a1e81f6442400bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764679 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689978}
-
Toby Huang authored
MixinBasedInProcessBrowserTest is a lightweight descendant of InProcessBrowserTest (IPBT) that can be used as a base class whenever IPBT is used as a base class. I moved MixinBasedInProcessBrowserTest into chrome/base/test/ and out of the chromeos namespace to match IPBT. This change would enable a wider scope of tests to use mixin functionality. Bug: 990542 Change-Id: I1f3510fb4726732a8e4f181d301d9bfb7c8075ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747643Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
This CL adds a new parser, as well as a fuzzer to the network service. In the future, it'll be used to parse incoming CSP headers to allow enforcing of frame-ancestors in the browser process. Bug: 759184 Change-Id: Idd6f1e73e8ed801e6add35105a0ad849eaeb0262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682265 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#689976}
-
Andres Calderon Jaramillo authored
This CL adds the Renderer4.{Browser,Renderer}.RasterTaskSchedulingDelay UMAs which measure the wall time elapsed between creating a raster task in the client and being ready to issue raster work to the driver in the GPU process. The beginning timestamp is obtained by recording the creation time of a RasterBufferImpl in the renderer (which should practically coincide with the creation of the raster tasks). The end timestamp is obtained using a GL_COMMANDS_ISSUED_TIMESTAMP_CHROMIUM command buffer query. The motivation is to make sure that hardware accelerated image decodes do not make this part of the rendering pipeline regress. Therefore, these UMAs are only computed and recorded in Chrome OS and when OOP-R is enabled. Bug: 995155 Test: coverage for the new UMA. Change-Id: I51d4b2d87c07577ca5f710d94a15dac2e4312ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753583 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689975}
-
Lei Zhang authored
CreatePrinterHandlerTaskRunner(), which was added in https://crrev.com/658397, used ifdefs to only handle the supported build configs. Add a #else case as a catch-all to conservatively handle the unsupported configs. Since it is only a couple lines of trivial code, doing this does not create much of a maintenance burden. Bug: 990727 Change-Id: I07bd21abaeffc8223e88b519c3891185d5d2be12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765998Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#689974}
-
Alex Cooper authored
TBR=grt@chromium.org Change-Id: I7ccc19d5cf5d4956b534f7ca3ebd72bf3cb68b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769043Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#689973}
-
Joe DeBlasio authored
This CL mostly reverts crrev/c/1717191, but includes updated strings. The interstitial now looks like this: https://storage.cloud.google.com/chromium-translation-screenshots/a0e10eb89867355fc98c930e468397e8dadf4f17 Bug: 996794 Change-Id: Ib5b85f16184bab7cbad955d07a75b648b6f34b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765661 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#689972}
-
Tomasz Wiszkowski authored
Add metric counting how frequently - and what kind of suggestions our users delete. Bug: 991430 Change-Id: Iea6a65e08829149ac8607cfaee84e2c7652f9eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746759Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#689971}
-
Darin Fisher authored
This is in preparation for fixing bug 989458. The main change is to make the dependencies between the various files no longer circular. This makes the code and state transitions a bit easier to follow. A bunch of types are extracted out of webrtc_logging_handler_host.h and into webrtc_log_uploader.h. This makes WebRtcLoggingHandlerHost more cleanly the "frontend" part of the logging system, and WebRtcLogUploader and its associated types as the lowest level "backend" part. WebRtcLogBuffer is extracted out into its own header file since it is needed at various levels and from places that don't need to depend on webrtc_log_uploader.h. Also cleans up some stale comments about code running on the IO thread that now only runs on the UI thread. Simplifies StartRtcDump method and hides WeakPtr capability of WebRtcLoggingHandlerHost. Cleans up a few other random small things. Bug: 989458 Change-Id: I997c04d535114801029f077357e975c95b0bd7e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762465 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689970}
-
Jonah Chin authored
Due to using the actual constructed layoutObject font (which already has zoom applied) for font-sizes measured in ex and ch, we end up applying zoom twice. This problem was specific to the use of ex and ch measurements on fonts, and not on other html components. This patch involves factoring out a single zoom where ex and ch sizing is applied to a font. Bug: 408777 Change-Id: If9ae7e9efcca472ca7518b7c7d62537e6842bac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752935 Commit-Queue: Jonah Chin <jochin@microsoft.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#689969}
-
Dana Fried authored
Label text was previously middle-aligned even in the multiline case, despite our text renderer being able to render all vertical alignments. This caused hover card titles to animate vertically and be cut off strangely during transitions between tabs with different numbers of title lines. This CL adds the ability to support vertical alignment for multiline labels, and then aligns the title label on the hover card to ALIGN_TOP so that during transitions from a hover card with one line to one with two title lines results in the first line of the title staying in place while the bottom line is revealed during the animation, which is far more visually pleasing. Because RenderText does not yet support vertical alignment for single- line text, DCHECK guards have been added (as they were previously added to prevent incompatibility between multiline and elision mode) and also TODO reminders to extend functionality to single-line in the future. Bug: 984963, 996905 Change-Id: Ibd2ef6a3c8502a272654b673f83893e06ac5fb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764942 Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#689968}
-
Dana Fried authored
This was a visual bug with the new tab previews system active - a card could continue to update as it was animating away from a tab, causing it to become stuck on the old tab. Bug: 996820 Change-Id: If0023dd1eaa275ed9660aa36eaad3cc2389f834f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766003 Auto-Submit: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#689967}
-
Andres Medina authored
The script default behavior changes with this patch. The script will now use the clang revision defined in //tools/clang/scripts/update.py instead of ToT if no extra parameters are passed. Also, script now provides a "revision" flag in case the user wants to use a particular clang revision. Bug: 996873 Test: Manual build. Change-Id: I5e196782b84dc8d461e1c0daa33582b977563b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766007Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andres Medina <medinaandres@chromium.org> Cr-Commit-Position: refs/heads/master@{#689966}
-
Jinsuk Kim authored
This CL extends the experiment milestone to M80. Bug: 937946 Change-Id: If91159b3c490a3cad9440008aae9dcfd04150993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767461Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689965}
-
Friedrich Horschig authored
This CL replaces only the credit card icons for Android with versions without gray borderline. Only the credit card settings are immediately affected — all other instances seem to use images from the native side. The larger goal is to have nicer icons in autofill chips and fallback sheets in the keyboard accessory. Bug: 985318 Change-Id: I4c140233f13ce68acc3b72af105f16b73233f421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730916 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#689964}
-
Avi Drissman authored
This used to fail on non-Google Chrome builds due to the use of custom resource rules, but we don’t do that any more. Adjust defaults. BUG=none Change-Id: Ic9e0b110fdcb47feb8878be35feb60f326556789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762759Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689963}
-
Brian Geffon authored
BUG=chromium:993569 Change-Id: Ib6725b6dc708882a67132973d20db8240e5ad489 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765331Reviewed-by:
-
Gaoping Huang authored
This CL contains the graph model that tracks the events fired from WebAudio backend. A follow-up CL will be uploaded soon to use `dagre` to layout the graph model. A relevant CL is uploaded to add `dagre` as a front_end module: https://chromium-review.googlesource.com/c/chromium/src/+/1749643 Bug: 974343 Change-Id: Ie276e593e3b35c12d898677993c994256fc0df41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753704Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689961}
-
Egor Pasko authored
Re-enabling the test after mitigation landed (crrev.com/689916). Bug: 990551 Change-Id: I657cd9088191ebe22b7fa918b4b44b3ed3567ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768525Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#689960}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/222a4fb01b0a..b6e0bc79fa4e Created with: gclient setdep -r src-internal@b6e0bc79fa4e The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I60ac119b943f62995a9c1a84a306d17d0025e5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769029Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689959}
-
Yasmin authored
Before: https://screenshot.googleplex.com/8JxHd0a026T After: https://screenshot.googleplex.com/S5TARg9MT8t Bug: 994703 Change-Id: I5f6905cb5730c8f35bb997ec0114d6df36b90c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763766 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#689958}
-
Lijin Shen authored
Currently, incognito bg color is identical to tab switcher bg color. This CL tries to update tab switcher bg color to match the latest color matrics. Bug: 985064 Change-Id: I2d64346fa91bbb4e034a98a9f929b676ff2a9af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1767243Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#689957}
-
Yasmin authored
Bug: 988461 Change-Id: I820bca05f073ef379178d7cf17fbbb7efbaba4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764131Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/2b2ee71..952ccb9 952ccb9 CherryPick LocaleMatcher API in ICU Fuchsia also needs LocaleMatcher. https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=35401 Bug: v8:7051 Change-Id: I66c7b07b776962358fd4cbcd16b12d9626383ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1766892Reviewed-by:
Jungshik Shin <jshin@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#689955}
-
John Abd-El-Malek authored
TBR=treib@chromium.org Change-Id: I1e3310dc4a689bb6f1fb862b2c3a03b575da2b77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769046Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#689954}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/890a65b17d95..472c74c60ca2 git log 890a65b17d95..472c74c60ca2 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 syoussefi@chromium.org Translator: Allow tree validation in children of TCompiler Created with: gclient setdep -r src/third_party/angle@472c74c60ca2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org,jonahr@google.com Bug: None Change-Id: I63a7983e9b4c61c0c61582b0e499cb36e9691bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769019Reviewed-by:
-
Alex Clarke authored
We had problems going on with test flakiness caused when ChromeTabbedActivity.setupCompositorContent runs earlier than it used to, typically before NewTabPage is constructed. This is problematic because the LayoutManager tries to hide the empty page when the NTP is created resulting in MainIntentActionType.SWITCH_TABS getting recorded. With the exception of MainIntentBehaviorMetricsIntegrationTest#testCreateNtp these seem to have gone away so I'm reverting the changes. Bug: 982081, 980587 Change-Id: I64809492ed8bfda932f9a93ff8e3329e61e57e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749189Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#689952}
-
Andrew Lee authored
Change-Id: I9524e0dc0eadeb51cf53c16d756bd4f641debf55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764932Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Cr-Commit-Position: refs/heads/master@{#689951}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/07489b86416c..e7aecaad3386 git log 07489b86416c..e7aecaad3386 --date=short --no-merges --format='%ad %ae %s' 2019-08-23 primiano@google.com Merge "Minor refactoring to config protos" Created with: gclient setdep -r src/third_party/perfetto@e7aecaad3386 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ifbdb28f5f16fdf6d3720cabaf4095e734d980593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769024Reviewed-by:
-
Piotr Bialecki authored
Ship anchor information from ARCore side to blink. The data will be surfaced to the JavaScript side in subsequent CLs. Bug: 992029 Change-Id: Ica8a0d424c64c96d9d1c3679be07e5569bc6bd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763876Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#689949}
-
Himanshu Jaju authored
The user could disable the default dialer app which would cause chrome to crash since no activity can be resolved for dial intent Bug: 996644 Change-Id: If410e7b8ff491fc6321f23414ff8007ebb77f6ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768760Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
-
Ben Mason authored
Fixed: I have disabled building of the system image in next-* builds so there should no longer be an issue. next-* builds can be re-enabled when bundletool is updated. This reverts commit 7c77403d. Original change's description: > Revert "Enable dist fusing for all feature modules." > > This reverts commit 27ca1df7. > > Reason for revert: This CL causes an official build failure > https://crbug.com/996658 > > Original change's description: > > Enable dist fusing for all feature modules. > > > > Change-Id: I66848fec159450a6d531e0af3f867988aa8b148f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763431 > > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > > Commit-Queue: Ben Mason <benmason@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#689075} > > TBR=tiborg@chromium.org,benmason@chromium.org > > Change-Id: Ib696df42847a54c1257fae41ecb544df40f47e75 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764159 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689454} TBR=alexilin@chromium.org,tiborg@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Id4687e7980b238cdbea04a1c8921b57a974f7cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768946Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#689947}
-
Sigurdur Asgeirsson authored
Also use an empty match regexpr for maximal compliance with output. Bug: 996826 Change-Id: I8aaf27cc561752a6f202fed44b9f41f529b00aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768858Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689946}
-
James Cook authored
Specifically, assistant, IME, and cros_network_config headers. The forward headers are much smaller (best case, tens of thousands of lines smaller, considering all transitive includes). Also introduce TrayNetworkModelObserver as a separate class so that classes wanting to inherit the observer interface don't need to include the whole TrayNetworkModelState header (and its transitive cros_network_config.mojom.h includes). Bug: 996418,922875 Test: bots Change-Id: Ib1d28c0dfedcae91743e3367f4462726d37014b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764522 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689945}
-
