GitLab

Added a condition to avoid the DCHECK for a valid situation where the
check should have been applied.. A test was added to capture the
specific case that was triggering the DCHECK.

BUG=303413
TEST=SourceBufferStreamTest.Remove_PreviousAppendDestroyedAndOverwriteExistingRange

Review URL: https://codereview.chromium.org/58663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232998 0039d316-1c4b-4281-b951-d872f2087c98

crtbeginS was removed from PNaCl as part of PNaCl+glibc
cleanup. If we continue listing crtbeginS as part of the
gyp outputs list, ninja will think we need to rebuild.

BUG=313636
TEST=ninja nop build && browser_tests --gtest_filter=*Pnacl*

Review URL: https://codereview.chromium.org/58343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232997 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix for the old M-31 multi profile mode in M-32.

BUG=314286
TEST=visual

Review URL: https://codereview.chromium.org/55143010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298036

Review URL: https://codereview.chromium.org/50883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232995 0039d316-1c4b-4281-b951-d872f2087c98

> Disable AppRTC test on win until we can figure out symlink problem.
> 
> BUG=
> TBR=xians@chromium.org
> 
> Review URL: https://codereview.chromium.org/40143004

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/60183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232994 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314809
R=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/59133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232993 0039d316-1c4b-4281-b951-d872f2087c98

Add a VLOG(1) message containing event details to
UserActivityDetector. This makes it easier to debug
unexpected user activity, which we've seen in the past.

BUG=none
TBR=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/58293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232985 0039d316-1c4b-4281-b951-d872f2087c98

UMA reporting values are temporarily broken. This change will fix the
value and add a definition for the new item.

TEST=unit_tests
BUG=n/a

Review URL: https://codereview.chromium.org/58253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232984 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313809
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/59763003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232983 0039d316-1c4b-4281-b951-d872f2087c98

 - Updating unittests to conform to Compositor constructor change.

BUG=

Review URL: https://codereview.chromium.org/57803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232982 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286528
TEST=Top notification in Wallet mode (i.e. when signed in) should have a subtle
     darker gray border.
R=groby@chromium.org

Review URL: https://codereview.chromium.org/55973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232981 0039d316-1c4b-4281-b951-d872f2087c98

Add ResourceMetadataStorage::RecoveredCacheInfo
Recover title in ResourceMetadataStorage::RecoverCacheInfoFromTrashedResourceMap
Use title in FileCache::RecoverFilesFromCacheDirectory

BUG=277333
TEST=unit_tests

Review URL: https://codereview.chromium.org/55713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/55413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232979 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/54983009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232977 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the MustRemainDisabled function to the ManagementPolicy::Provider
interface and calls it in appropriate places.

BUG=314276

Review URL: https://codereview.chromium.org/54903011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232976 0039d316-1c4b-4281-b951-d872f2087c98

to not set any of the output parameters unless all of them are valid.
Before we could set e.g. the session_id but return false.

BUG=315051
R=xians@chromium.org

Review URL: https://codereview.chromium.org/59763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232975 0039d316-1c4b-4281-b951-d872f2087c98

The mostly_smooth metric doesn't show up on the dashboard,
because it is a boolean value (False/True). Switch to float (0.0/1.0).

R=dtu@chromium.org
BUG=

Review URL: https://codereview.chromium.org/54793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313168
TEST=RemoteDebuggingTest.RemoteDebugger

Review URL: https://codereview.chromium.org/54333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232973 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies the compositor rate limiting code to only rate limit the
shared main thread context, which as it happens is the only context that uses
this feature at all.

BUG=181120

Review URL: https://codereview.chromium.org/53153006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232972 0039d316-1c4b-4281-b951-d872f2087c98

R=thakis@chromium.org
BUG=302284

Review URL: https://codereview.chromium.org/52823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232971 0039d316-1c4b-4281-b951-d872f2087c98

Desired behavior: Clicking on a field or giving it focus via tab should
result in the validation error message coming up, if any.
Clicking on an already focused field should toggle autofill suggestions
with validation messages.
Leaving an input field with either a validation message or an autofill
suggestion should hide both.

The tricky part: distinguishing mouse clicks that would give focus, and
mouse clicks that are on a focused field. Since mouseDown: messages in
OSX are only sent to fields that already have firstResponder status,
this requires a bit of trickery - this CL exploits the fact that for an
NSTextField, the first click goes to the NSTextField, and subsequent
ones go to the field editor.

Bonus trickery: Rapid clicking on an NSTextField prevents the field
editor from taking over until the user has calmed down, so the code
filters only the first click after becomeFirstResponder.

R=rsesek@chromium.org
BUG=308156

Review URL: https://codereview.chromium.org/51933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232970 0039d316-1c4b-4281-b951-d872f2087c98

We're getting close to actually swapping RenderFrameHosts instead.

BUG=99379, 314791
TEST=none

Review URL: https://codereview.chromium.org/53153008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232969 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug where incognito split mode extensions were getting clicks from incognito browsers sent to the regular profile.

BUG=314142

Review URL: https://codereview.chromium.org/50433008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232968 0039d316-1c4b-4281-b951-d872f2087c98

R=arv@chromium.org
BUG=305742

Review URL: https://codereview.chromium.org/49903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232966 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232964 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/57433013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313848
TEST=views_examples_with_content_exe runs in Win Aura.
R=ben@chromium.org

Review URL: https://codereview.chromium.org/49533005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232962 0039d316-1c4b-4281-b951-d872f2087c98

In the guest mode, thumbnails were not loaded, because the token was unavailable, since Drive is disabled for the guest mode. Actually, the token is not necessary at all for local resources, therefore it should not be used.

This patch avoids fetching the token for local resources, what solves the problem.

TEST=Tested manually. Thumbnails work in the guest mode.
BUG=311212

Review URL: https://codereview.chromium.org/48553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232961 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a basic implementation of NativeViewport for X11. It puts a window
on screen and initializes GL for that window.

One disadvantage of this CL is that it requires use_aura to be set to 1 in
GYP_DEFINES.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/48323005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232960 0039d316-1c4b-4281-b951-d872f2087c98

util.WaitFor polls which is not appropriate for PerformActionAndWaitForNavigate.

Since DispatchNotifications blocks in recv until it gets some data, there is no
need to poll at an interval. Instead, we should call recv again as soon as
possible after dispatching a notification.

In the case of the image decoding measurement, it runs timeline recording. There
were so many timeline messages to receive that we were not always getting to the
important Page.navigate message before timing out.

Example:
http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/27098

BUG=314375

Review URL: https://codereview.chromium.org/47013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232959 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/46973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232958 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308535

Review URL: https://codereview.chromium.org/43793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232957 0039d316-1c4b-4281-b951-d872f2087c98

WebRTC is running the content_browsertests test
for ToT WebRTC revisions to track regressions on an
early stage. In order to save compile time and
build artifacts, we want to build only what's needed
(i.e. not the All target).
In https://codereview.chromium.org/27622005/ an
attempt was made to make content_browsertests_apk
to be enough of target to build (that CL made it also
build android_tools). Since that approach was having
bad sideffects, this helper target should give us
everything needed for our build.

NOTRY=True
TEST=local compile, verifying the apk and host_forwarder is built.
BUG=305749

Review URL: https://codereview.chromium.org/43463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232956 0039d316-1c4b-4281-b951-d872f2087c98

Reusing the details of the GetNumDisplays() implementation for returning
a vector of available displays. Reusing the existing code for actually
generating gfx::Display objects by converting to NSScreen and then
calling GetDisplayForScreen to be consistent with the behavior in other
parts of this file.

BUG=311132
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/40163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232955 0039d316-1c4b-4281-b951-d872f2087c98

There's a size regression for the Linux bot in
http://build.chromium.org/p/chromium/builders/Linux/builds/44555

PERF_REGRESS: nacl_helper/nacl_helper (0.29%), nacl_helper/nacl_helper (0.29%)

Details:
https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fnacl_helper&rev=232942&checked=core
(requires google.com signin).

TEST=none
BUG=315063
R=phoglund@chromium.org, phoglund@google.com

Review URL: https://codereview.chromium.org/59723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314848

Review URL: https://codereview.chromium.org/54993008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232951 0039d316-1c4b-4281-b951-d872f2087c98

Removed unused enum value.

BUG=314284
NOTRY=true
TBR=noamsml

Review URL: https://codereview.chromium.org/59083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232950 0039d316-1c4b-4281-b951-d872f2087c98

This has some performance optimzations, and adds some new functionality. It
also adds some function documentation.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/58573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232949 0039d316-1c4b-4281-b951-d872f2087c98

R=estade@chromium.org
BUG=314627

Review URL: https://codereview.chromium.org/58593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232948 0039d316-1c4b-4281-b951-d872f2087c98

BUG=298967

Review URL: https://codereview.chromium.org/58583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232947 0039d316-1c4b-4281-b951-d872f2087c98