- 01 Mar, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8e98c60f8483..328027b6c434 git log 8e98c60f8483..328027b6c434 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 danilchap@webrtc.org Replace fatal error with error log 2019-03-01 hta@webrtc.org Add GetSctpTransport to proxy map 2019-03-01 kwiberg@webrtc.org sdk/android:native_api_stacktrace: Declare a more narrow set of dependencies 2019-03-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d1e2a1cf..24eaf090 (636518:636660) Created with: gclient setdep -r src/third_party/webrtc@328027b6c434 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:818643,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I056c4eacdeacbf877d0c419e6ae4af29625e6f38 Reviewed-on: https://chromium-review.googlesource.com/c/1495783Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636777}
-
Michael Lippautz authored
HasPendingActivity() is called during garbage collection which may happen during constructing an AudioNode. Since the handler has not been set at this point we need to guard against derefencing null. Bug: 937208 Change-Id: I4ee92d08c97f044aca8043443f04d751428e8455 Reviewed-on: https://chromium-review.googlesource.com/c/1495977Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#636776}
-
Arthur Hemery authored
Currently, browser initiated navigations are never interrupted after binding the remote NavigationClient. This does not handle cases where the failure happens after ReadyToCommit. For example a download to a source url would be flagged as illegal in the blink frame and the DocumentLoader destructed, which should notify the browser. Bug: 784904 Change-Id: Idd39bbf702ad2cb53b1b0eb1c01ca1df7b58124c Reviewed-on: https://chromium-review.googlesource.com/c/1494888Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#636775}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/65cf8a9b9775..88ac583e6668 git log 65cf8a9b9775..88ac583e6668 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 taylori@google.com Merge "Add config protos to perfetto_trace.proto" Created with: gclient setdep -r src/third_party/perfetto@88ac583e6668 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If14a02128da4f757c1e6be76aa397c1a5a588ce8 Reviewed-on: https://chromium-review.googlesource.com/c/1495787Reviewed-by:
-
Sami Kyostila authored
If the target object of a Looper message gets garbage collected after the message is handled but before Looper logs the 'finished' line, the signature of the object may not match the original 'dispatching' log line. To work around this, store a reference to the original target signature to ensure a matching end event. This patch also adds some extra debug logging when duplicate early trace events are started simultaneously. Bug: 935869 Change-Id: I4bafba4a5469ca5743d9cd6d64cb043e82387b8c Reviewed-on: https://chromium-review.googlesource.com/c/1491612 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#636773}
-
Lutz Justen authored
Helps to track down issue with block_devmode for Chromad devices. BUG=chromium:889893 TEST=None Change-Id: Iad22f7b86ba5c2a69c31f23ec0fd221288eed767 Reviewed-on: https://chromium-review.googlesource.com/c/1477267Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636772}
-
Arthur Hemery authored
After running a callback in the renderer we destroy the NavigationClient interface that was used to commit, since by design, it is an interface that lives only during the navigation. This is not an issue, except with the introduction of mechanisms intercepting DidCommit* callbacks and messages execution. In this case, the callback is intercepted, but the destruction still is interpreted by the NavigationRequest to be an abort. To counteract this, we introduce a new helper function that we use to ignore interface disconnects when receiving the DidCommit* messages, and before processing it. This way we are guaranteed (because we receive the messages in order DidCommit -> Disconnect) that the disconnect coming from this source is always ignored. Bug: 784904 Change-Id: If169c3f9fb76a20200dbb1466e9bc48d736140bf Reviewed-on: https://chromium-review.googlesource.com/c/1491434Reviewed-by:
-
Jérôme Lebel authored
SyncSetupService::CommitChanges() should not be called when the user taps on the "Settings" link in the sign-in screen. Bug introduced with crrev.com/c/1010346 -[ChromeSigninViewController signinCompletedWithUnity] is created to get the correct behavior for Unity. This method is only called with Unity. -[ChromeSigninViewController acceptSignInAndCommitSyncChanges] has now the same implementation than before Unity. This method is only called without Unity. Bug: 936461 Change-Id: I23353fe199d5e31b66feefe9fc5416f452ab35aa Reviewed-on: https://chromium-review.googlesource.com/c/1495519Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636770}
-
Jordan Demeulenaere authored
This CL adds animations when carousels chips are changed. When setting the new list of chips, we compute the minimum set of operations (insert, delete, substitute) required to transform the old list into the new one (also known as Levenshtein Distance) and we apply those operations. Animations themselves are automatically added by the RecyclerView containing the chips. Videos: - Before: http://go/aa-carousel-before - After: http://go/aa-carousel-after Change-Id: Iaaf78e3a8280fead319dea338bd2a0eb5042aff6 Reviewed-on: https://chromium-review.googlesource.com/c/1491618 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#636769}
-
Julie Jeongeun Kim authored
This CL moves web_client_hints_types.mojom in public/platform to public/mojom/web_client_hints and updates paths for web_client_hints_types.mojom. Bug: 919393 Change-Id: I1f820c17bab97ff8a6e9cc4a4b5b2f9edeea6871 Reviewed-on: https://chromium-review.googlesource.com/c/1493628Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#636768}
-
Abhijeet Kandalkar authored
This CL is a part of OnionSoup effort and generate 'core/probe' sources to follow Blink coding style for function name. Bug: 936684 Change-Id: I58cf244b7d6ecb366603b8e8a30017617752cd22 Reviewed-on: https://chromium-review.googlesource.com/c/1494414 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#636767}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27fb2bec31ac..9539a2ce1044 Created with: gclient setdep -r src-internal@9539a2ce1044 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If47e8f1941c47f398882a843cc83951c73d8602d Reviewed-on: https://chromium-review.googlesource.com/c/1495786Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636766}
-
Alex Clarke authored
This reverts commit 606087eb. This is crashing and the speculative fix was ineffective. Original change's description: > SequenceManager to perform periodic housekeeping (sweep canceled tasks) > > Long delay canceled tasks can really pile up if we don't activly remove > them. We already do that in the renderer but we need to bring this > technology to other SequenceMangers. > > Bug: 863341 > Change-Id: Ie16674043028090f94c184c02acbef6efcf3471b > Reviewed-on: https://chromium-review.googlesource.com/c/1483076 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635497} TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org,carlscab@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863341, 936734 Change-Id: Ie948d9519dee14326137ad04aa88e53207db6eed Reviewed-on: https://chromium-review.googlesource.com/c/1495976Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#636765}
-
David Roger authored
Mice wants to enable account consistency even when Sync is disabled. To do this, it needs to have access to all the device accounts. Change-Id: I03d030eebe88f4af07770d0e56d1bd73503b008b Reviewed-on: https://chromium-review.googlesource.com/c/1491971 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#636764}
-
Javier Fernandez authored
Since we are already working on the implementation of this feature, we can unskip the import of the related tests. We can skip them from being run while the feature is not ready. Bug: 720205 Change-Id: I15d7e9b4ca7a12877c13dc35b85335fd6d56a7b0 Reviewed-on: https://chromium-review.googlesource.com/c/1495974 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#636763}
-
Boris Sazonov authored
This CL fixes SigninUtils.openAccountSettingsPage behavior on Android O+ where android.settings.ACCOUNT_SYNC_SETTINGS action no longer works. Also, openAccountSettingsPage is renamed to openSettingsForAccount and openSettingsForAllAccounts is introduced, so subsequent CLs can use it to specifically open settings page with all accounts. Bug: 814441 Change-Id: I4c5e6469701ae31835426a204b2d4d07b0fb5cd7 Reviewed-on: https://chromium-review.googlesource.com/c/1494662Reviewed-by:
-
Tao Bai authored
This patch includes below changes - Creates the ContentCaptureManager in main frame. - Injects the NodeHolder in paint stage. - Add integration test for multiple frames. Bug: 924681 Change-Id: Ic7104fab8b7ac33868193c2f12cffb93924bae48 Reviewed-on: https://chromium-review.googlesource.com/c/1484860 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#636761}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/df7065a0be96..fb02ade1a0b9 git log df7065a0be96..fb02ade1a0b9 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 sadrul@chromium.org telemetry: Add TraceValue.SerializeTraceData(). Created with: gclient setdep -r src/third_party/catapult@fb02ade1a0b9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935834 TBR=sullivan@chromium.org Change-Id: I7990aa2e69f86ee3070a3ffc28ee5e43a1da8d20 Reviewed-on: https://chromium-review.googlesource.com/c/1495785Reviewed-by:
-
David Jean authored
To replace ChromeLoadParams, WebLoadParams and OpenNewTabCommand as parameters passed in to LoadUrlInCurrentTab, SwitchToTab and OpenUrlInNewTab in url loading service. Bug: 907527 Change-Id: I911985c7f62bd9d807c71e5349f194cefd1d57a0 Reviewed-on: https://chromium-review.googlesource.com/c/1488925 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636759}
-
Yutaka Hirano authored
Currently the url argument for the trace event is {url: <url>}, but that prevents us to search for the url from the UI. Provide a simple string to the argument to make it work. Bug: 937173 Change-Id: Ic4a344b52a0967018d3955b9909f967d655357c6 Reviewed-on: https://chromium-review.googlesource.com/c/1496119 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:Taiju Tsuiki <tzik@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#636758}
-
Alexander Dunaev authored
The handler of configure surface events didn't take whether the window had normal state when responding to zero width and height passed by the compositor. This resulted in unnecessary restoring of window size when it should remain maximized of expanded to full screen. This CL fixes the behaviour and improves the test to cover the scenario explained above. R=msisov@igalia.com Bug: 934686 Change-Id: I4dd7e01484ccea663f0e0012288d6de70e48ad06 Reviewed-on: https://chromium-review.googlesource.com/c/1489195 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#636757}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3e8b031e3e8e..19dd955a0744 git log 3e8b031e3e8e..19dd955a0744 --date=short --no-merges --format='%ad %ae %s' 2019-03-01 allenwebb@google.com usergroup_baseline: Allow homedir for nobody and sshd to be /dev/null. 2019-03-01 seanabraham@chromium.org testingconfig: Purge chromite testingconfig directory 2019-03-01 saklein@chromium.org commandline: Add argument deprecation support. 2019-03-01 dhanyaganesh@chromium.org BuildStore: Redirect GetBuildHistory through BuildStore 2019-03-01 lamontjones@chromium.org signing: Add DumpConfig() and binaries. 2019-03-01 dhanyaganesh@chromium.org HWTestStage: Remove insertion of empty Subsystem message 2019-03-01 saklein@chromium.org Build API: Naming convention changes for clarity. 2019-03-01 vapier@chromium.org dev-install: use new package.installable path Created with: gclient setdep -r src/third_party/chromite@19dd955a0744 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I4ffecb0933fc8e219f75593be46a5f5a0f4b5663 Reviewed-on: https://chromium-review.googlesource.com/c/1495784Reviewed-by:
-
Marc Treib authored
TBR=bokan@chromium.org No-Try: true Bug: 937215 Change-Id: I24f1a7920284a1ed87255e1948088004a4d5c7f5 Reviewed-on: https://chromium-review.googlesource.com/c/1495522 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#636755}
-
Robbie Gibson authored
Currently, when the omnibox popup is open, Voiceover will highlight and read the items from the WebView, even though those views are covered by the popup. This is because the popup is just added to the same parent VC (not presented). We need something to manually say that the webview is covered. Bug: 786940, 912419 Change-Id: I70ce9abcfff8c3f0e48aa990d383eabe78b6ef47 Reviewed-on: https://chromium-review.googlesource.com/c/1485951 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636754}
-
Peter E Conn authored
Bug: 929169 Change-Id: I06cf33cb79c42052adc460ce0ccce54e43a379a4 Reviewed-on: https://chromium-review.googlesource.com/c/1472719 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#636753}
-
Yi Su authored
This CL converts ios_web_shell_egtests.MetaTagTestCase to ios_web_inttests.MetaTagTest, because it doesn't require UI for testing. Bug: 930859 Change-Id: Idad9e27707ded89a180d9e47e127a8e3cf5260d1 Reviewed-on: https://chromium-review.googlesource.com/c/1488917 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#636752}
-
Robbie Gibson authored
Before, the option would appear regardless of the default search engine, but would DCHECK if the default search engine didn't support search-by- image. Now, the option doesn't appear in that case. Bug: 935386 Change-Id: Ic1e1ef896674b72bd8de8f159cf8afb9718c93a5 Reviewed-on: https://chromium-review.googlesource.com/c/1486093 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
-
Adam Rice authored
Add an |is_settled_| member variable to StreamPromiseResolver. This is used to protect against cases when Resolve() is called re-entrantly inside Resolve(), which can happen when resolving with an object that has a getter on "then". Also use IsSettled() in two places rather than a check of State(), as it is considerably cheaper. Include a test for re-entrant use of Resolve(). BUG=902633,931640 Change-Id: I38aeea82cf2e1499fccacda2e9f27f871ff8e9af Reviewed-on: https://chromium-review.googlesource.com/c/1488489Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#636750}
-
Mugdha Lakhani authored
This adds logic to verify that the background task that wakes up Chrome is called with network connectivity. Unit tests are also added to verify the same. Follow-up CLs will add more unit tests to verify the behavior of BackgroundSyncBackgroundTask. Bug: 924490 Change-Id: I1950e00704054c120b6668ebabcb99c32ec9f5c3 Reviewed-on: https://chromium-review.googlesource.com/c/1482462Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#636749}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/100cc47d5e0a..27fb2bec31ac Created with: gclient setdep -r src-internal@27fb2bec31ac The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I506dd7d2adf6b15e8b6968108ec2f9c2d1163624 Reviewed-on: https://chromium-review.googlesource.com/c/1495782Reviewed-by:
-
Marc Treib authored
This reverts commit 46584179. Reason for revert: Still breaks http/tests/devtools/application-panel/storage-view-reports-quota-and-clear.js on Mac, see https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests Original change's description: > Reland "[DevTools] Application>Clear Site Data: stop service worker when unregistering it" > > This is a reland of 3dc09a0d > > Original change's description: > > [DevTools] Application>Clear Site Data: stop service worker when unregistering it > > > > We should stop the service worker before unregistering it. > > > > Originally, clicking "Clear site data" will unregister the service worker. In > > Application>Service Workers, the service worker's tab title is marked as > > "deleted", but its "status" says it's still running. > > > > Bug: 894783 > > Change-Id: Ib1550cfab8274a27495bb795501f54e9a19f6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/1480725 > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#635263} > > Bug: 894783 > Change-Id: I4b1b9a2f3764391846e47f8752cab6e223adbb1d > Reviewed-on: https://chromium-review.googlesource.com/c/1490432 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636612} TBR=dgozman@chromium.org,pfeldman@chromium.org,hhli@chromium.org Change-Id: I3935ddfc1374e418e4ec935e3387dabf8c183161 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894783 Reviewed-on: https://chromium-review.googlesource.com/c/1495979Reviewed-by:
-
Yutaka Hirano authored
Some callers, notablly flash, with |grant_universal_access| want to have an origin matching with referrer. Bug: 935662 Change-Id: I99fc48266015d1a6ef611102f2cfbe2330ccc465 Reviewed-on: https://chromium-review.googlesource.com/c/1496125Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#636746}
-
Darwin Huang authored
- I saw that we use HashSet::Find(T Value) == HashSet::End(). HashSet::Contains is simpler, so I figure we should change it where applicable. Thankfully, we don't use Hashset::Find(..) == HashSet::End() too often. - Likely no logic changes. Change-Id: If6d595877318d0de9c8510a2b489871a16767c56 Reviewed-on: https://chromium-review.googlesource.com/c/1496249Reviewed-by:
-
Hayato Ito authored
The return value is always non-null there. Change-Id: I114d563d10736cfb4cefdf0b40ec44d645ebeed4 Reviewed-on: https://chromium-review.googlesource.com/c/1496269 Auto-Submit: Hayato Ito <hayato@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#636744}
-
Lowell Manners authored
This logic is no longer needed after https://crrev.com/c/1372318. Change-Id: I15db2bf94d54fd92c92cdd455d58fed9bc8421f6 Bug: 913400,933109 Reviewed-on: https://chromium-review.googlesource.com/c/1488871Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#636743}
-
Clemens Arbesser authored
The new parameter is 'autofill-assistant-url'. This allows us to remove the dependency on finch trials to be able to override the server url from the command line (see related CL cr/235482708). Bug: 806868 Change-Id: I25c75201c92d02540b5fa44e75a07d90a990fbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1494656Reviewed-by:
-
Juan Antonio Navarro Perez authored
Tidy up a bit the directory structure in tools/perf by adding a new command_line_tools module. It is intended to include, as submodules, packaged implementations for each of the scripts available within tools/perf itself. Currently update_wpr and flakiness_cli are moved as the first two submodules. This is in preparation for moving over further tools from catapult/experimental/soundwave. Bug: 922030 Change-Id: I6a568e13916cd607047ef301bd77f5597709b637 Reviewed-on: https://chromium-review.googlesource.com/c/1489246 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636741}
-
Marc Treib authored
This reverts commit 932fdb31. Reason for revert: use-of-uninitialized-value on ChromiumOS MSan: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/11553 Original change's description: > Introduce ash::network_icon::NetworkIconState > > This CL: > * Introduces a NetworkIconState to cache state that the network > icon code cares about in an intermediate format that will be > compatable with Mojo network state. > * Fixes a rather bad edge case (that I previously introduced) > where ActiveNetworkIcon stores pointers to NetworkState that could > possibly be accessed after being deleted. > * Modifies the criteria for ActiveNetworksChanged() to include > significant changes to signal strength. > * Adds some verbose logging for continued debugging. > > Bug: 923444 > Change-Id: I917b353c9da7a3c5e20dc8e69191a6a97f752aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/1469521 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636562} TBR=stevenjb@chromium.org,tbarzic@chromium.org,khorimoto@chromium.org Change-Id: If8523f3b782bf78c858d1390a5fc89e5b3a34c2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923444 Reviewed-on: https://chromium-review.googlesource.com/c/1495521Reviewed-by:
-
Marc Treib authored
This reverts commit 1e0ea868. Reason for revert: Depends on crrev.com/c/1469521 which needs to be reverted for introducing a use-of-uninitialized-value. Original change's description: > network_icon: Use GUID instead of path to track state in cache > > NetworkHandler uses Shill service paths to identify network services, > but the forthcoming mojo API and the rest of the UI code uses GUID > so this code needs to switch to GUID to support the mojo API. > > Bug: 923444 > Change-Id: I739b36762b6f380ae70e054eba9284bad2773ba9 > Reviewed-on: https://chromium-review.googlesource.com/c/1470939 > Commit-Queue: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636603} TBR=stevenjb@chromium.org,tbarzic@chromium.org,khorimoto@chromium.org Change-Id: Ib21003e61b5cd5e819463ba4c6d66fa2c9a4f92b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 923444 Reviewed-on: https://chromium-review.googlesource.com/c/1495520Reviewed-by:
-
Min Qin authored
With recent changes, the target path is not a content Uri if download is written to a content Uri. This may cause some undesirable effect for resumption. We kept the target path earlier due to display names. This Cl solves both issues by loading the display names from ContentResolver on initialization time, and pass them to all the download items so that could be used later. The target path will be changed to content Uri once intermediate file rename completes. TBR=dtrainor@chromium.org BUG=931021 Change-Id: I36bf5245ea1f7d36aa707a4b0f1065a5b0f8b133 Reviewed-on: https://chromium-review.googlesource.com/c/1479934 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636738}
-
