- 18 Dec, 2019 40 commits
-
-
rbpotter authored
Restore the recent printer prefetching behavior that was removed in https://chromium-review.googlesource.com/c/chromium/src/+/1607133 : don't display printers in the dropdown until their capabilities have successfully been retrieved from the backend. Also adds a test to verify that if a recent printer's capabilities are not fetched successfully, the printer does not appear in the dropdown. Note that printers will still be cached in the recent destinations until the user selects new recent printers that override them, but will not be displayed unless they are actually available. This so that if a frequently used printer is temporarily unavailable, it will still re-appear in the dropdown in future Print Preview sessions when it becomes available again. Bug: 1007614 Change-Id: Ia7eca78631094ca29bb1e9b43998fe8a6d35966e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966585Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#726079}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a02676614519..b65f3282baa9 Created with: gclient setdep -r src-internal@b65f3282baa9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1030991 Tbr: jbudorick@google.com Change-Id: I622b6002e9fb663bc939dc72b6211b60c1ab84ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974473Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726078}
-
Garrett Beaty authored
This will free up a small amount of Mac hardware which can be used elsewhere. It also creates a template for other OSes with builder/tester splits to follow. We know that this works because the mac-osxbeta-rel CI builder already does this (as can be seen by the smaller diff in its generated config). Bug: 1003062 Change-Id: Iecdb68404dd3ae16eabfc657981f0e82478a040a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974510 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#726077}
-
Eric Willigers authored
WebAppFrameToolbarView::ToolbarButtonContainer now creates the views that it contains, and listens for updates that affect its members. The outer class WebAppFrameToolbarView is now much simpler, as it does little more that create the two containers for the controls on the left and right of the toolbar, manage their layout and implement the ToolbarButtonProvider interface. Design doc: https://docs.google.com/document/d/1gOU3F8Zk1VGTPZQIr7Bq8gultJ7vg5AZJuujmRuG9To/edit?usp=sharing TBR=tapted@chromium.org Bug: 1007151 Change-Id: I0d31dee8a9a19a1e6939c1c2b0f611a377dafc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966791 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#726076}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/3d2d62813fc5..9bba4a936e85 git log 3d2d62813fc5..9bba4a936e85 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 natlee@microsoft.com Add DeviceLostCallback to dawn.json and dawn_wire Created with: gclient setdep -r src/third_party/dawn@9bba4a936e85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ifa544bf42379224a8c270b16473b0fbc878f0dcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974470Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#726075}
-
Saman Sami authored
Disable on: - Win10 FYI x64 Release (AMD RX 550) - Linux FYI GPU TSAN Release See bugs for context. TBR=kbr@chromium.org Bug: 1035461,1035178 Change-Id: I2f4d981cef32066646d4f6d24e248d4385a504ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974531Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#726074}
-
Ilya Sherman authored
Change-Id: I18e768c84442c5c0d473dd8af2bbe672f26512d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974475 Auto-Submit: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Gabriel Charette authored
See crbug.com/1035189 for explanation of issue and fix and why it ever worked (ish). R=carlscab@google.com Bug: 1035189 Change-Id: Id1c5468e631c00ab2ea4de6065bd20a28dc8af0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972294 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#726072}
-
Gang Wu authored
Update the description for clipboard Omnibox metrics, since now Omnibox support more clipboard content types(URLs and text) other than URLs only. Change-Id: Ic07c2d3ba7704ccbee7e34753bc1401b71b4ca9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953202 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#726071}
-
Yue Zhang authored
Bug: 1034843 Change-Id: Ie09c3a057737d412b135f9630cce3a1064aac7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973964 Auto-Submit: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#726070}
-
John Lee authored
Bug: 1032650 Change-Id: I8ebe7f78ce1aefe57ef94986b82f43249b033210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966393 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Devlin authored
This reverts commit 79199032. Reason for revert: A slew of BookmarkBarViewTests started flaking heavily in the last few days (and not being overly flaky before), including BookmarkBarViewTest20.ContextMenuExitTest BookmarkBarViewTest27.MiddleClickOnFolderOpensAllBookmarks BookmarkBarViewTest22.CloseSourceBrowserDuringDrag BookmarkBarViewTest28.ClickWithModifierOnFolderOpensAllBookmarks BookmarkBarViewTest16.DeleteMenu BookmarkBarViewTest5.DND BookmarkBarViewTest14.ContextMenus2 BookmarkBarViewTest9.ScrollButtonScrolls This is a speculative revert based on: - proximity of code - timing - the fact that ink drops and menus are both subtle, so even though this isn't an obvious culprit, it may be responsible. I'll monitor these tests, and re-land if they don't de-flake after this lands. Original change's description: > Changed default behavior for inkdrops on buttons. > > Changed the default value of has_ink_drop_action_on_click_ from false > to true. This has the effect of triggering the > InkDropState::ACTION_TRIGGERED transition animation on click. With > this enabled the inkdrop will fade out by default after a mouse click > event. This better represents the expected behavior for the button > class. > > Given there might be buttons that currently rely on the false default > value, an audit that looked at all existing uses of the inkdrop in > buttons was made to ensure that existing code continues to function > as expected. Changes have been made to maintain old functionality > where necessary. > > Bug: 1025666 > Change-Id: I0074030a56ca3de4c5249598e04897dd22ddae21 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963195 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#725332} TBR=jamescook@chromium.org,pkasting@chromium.org,tengs@chromium.org,tluk@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025666 Change-Id: Id5072810d7ac05541a5907e49506720bbd9c9475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974395Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726068}
-
Olga Gerchikov authored
Refactoring DocumentAnimations, AnimationTimeline, DocumentTimeline and ScrollTimeline classed to support ticking timelines individually. This is needed to support scroll timeline specific functionality, such as timing update on scroll change and timeRange: 'auto'. Changes made: - Moved timeline common functionality to AnimationTimeline. - Instantiate DocumentAnimations per document and have it manage all document timelines. - Attach animation to the timeline it was instantiated with instead of the document's global document timeline. Bug: 1030797 Change-Id: Ic4b61ac5ea0e7dbe0369b6b3ba81838208aa7d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940301Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Cr-Commit-Position: refs/heads/master@{#726067}
-
David Tseng authored
An active descendant is always set on the currently focused node. However, in some editables, ChromeVox can have its range on a descendant of the focus. With the new eventing model in AutomationAXTreeWrapper, we never get the active descendant change. Fix this by intorducing a FocusAutomationHandler which groups all events for which we want to observe on the currently focused node. Bug: 1035509 Test: manual. Change-Id: I94566a7ea34df788f40d8baf2789aae8809db888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972500 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726066}
-
Sean Harrison authored
My apologies, used the wrong name for the feature for the trial. Bug: 1014143 Change-Id: I654553e97de23ff2b54967ad6fb08b2e9aa6fbd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972138Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#726065}
-
dalyk authored
This new blink::URLLoaderThrottle will disable DoH for navigation requests issued in windows that were created for captive portal resolution. This change is a no-op since CaptivePortalTabHelper::is_captive_portal_window currently always returns false. Change-Id: Idabd81c0b7db57c95d93e0f89c7acf9ab61630e4 Bug: 10161646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869728Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#726064}
-
Kurt Horimoto authored
A destruction callback is used to reset the reference to a mediator's OverlayRequest upon destruction. When a request is cancelled, it is immediately removed from its queue and destroyed, but it's possible for the UI to outlive the request while it's being dismissed. This CL adds early returns to prevent accessing the request after destruction. Bug: none Change-Id: I256f17e35572c168aecf8c714601ceb17153ceb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963439 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#726063}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ee94693c7ab1..0d7e2f158e9b git log ee94693c7ab1..0d7e2f158e9b --date=short --first-parent --format='%ad %ae %s' 2019-12-18 robertphillips@google.com Change signature of several gpu backend methods 2019-12-18 mtklein@google.com roll clang_win 2019-12-18 kjlubick@google.com [canvaskit] Fix SaveLayer constants 2019-12-18 brianosman@google.com Runtime SkSL: Reflect inputs in SkRuntimeEffect 2019-12-18 bsalomon@google.com Reland x3 "Remove most of GrConfig.h" Created with: gclient setdep -r src/third_party/skia@0d7e2f158e9b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I14417ff4ac266699d2a85d3520159f60ef1ec6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974354Reviewed-by:
-
Brandon Wylie authored
UX provided me an asset that makes the specialty drawing logic obsolete. Replacing that drawing logic with the xml drawable. Bug: 1020774 Change-Id: I3683c79a61c67764996da94da0b70701b405beee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954933Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Ender <ender@google.com> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726061}
-
Tom Anderson authored
There are many steps to adding a new dependency. This document explains them all in one place. BUG=None R=thestig CC=msisov Change-Id: I268881a8fe539e553a7577de5a7caa5f90acaa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974319 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#726060}
-
Tomasz Wiszkowski authored
This change allows all suggestions to highlight suggestion sections that match user query. Bug: 982818 Change-Id: I047660c81d3d62925c2ee1b9519149bef87eac6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967757 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#726059}
-
Darwin Huang authored
Bug: 1028722, 1029027, 1029210, 1029506, 1032390, 1028402, 1029002, 1030709 Change-Id: I0a51eceb98bd6724ed279386b0fb5dc85ee177db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970738Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#726058}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fd2e3212e078..99420bb95152 git log fd2e3212e078..99420bb95152 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 brgoddar@microsoft.com Animations: make the full node text visible when keyboard focused. Created with: gclient setdep -r src/third_party/devtools-frontend/src@99420bb95152 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I66d6509cf872aaa2a5ccd6889eb4039794a90d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974207Reviewed-by:
-
Joon Ahn authored
Bug: n/a Change-Id: Ib1f697bce7350753cf3802bc6dac176f36139a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963437Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#726056}
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. The keys in the following classes are moved: - DataReductionProxySettings - DataReductionPromoUtils - DataReductionStatsPreference Bug: 1022108 Change-Id: I49d607b9c0d3246f3fdd3d80675d659eb06aea02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972090Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#726055}
-
Will Cassella authored
This CL implements the ArLightEstimate and ArImage functions, as well as more of the ArConfig and ArFrame methods. Additionally, it cleans up some of the preprocessor weirdness, preferring to use a higher-order macro rather than redefining an existing macro. Bug: 1034135 Change-Id: I95cd5101888b53d54abe432ea94d993b6678328e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972909Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#726054}
-
Henrique Nakashima authored
Files named FooTestUtil.java and FooTestUtils.java don't need to use SharedPreferencesManager. Bug: 1034960 Change-Id: I462a6e4c638eebef390b00939ebd782c87e1940e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974397Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#726053}
-
Demetrios Papadopoulos authored
On ChromeOS, this subpage is now displayed from the OS Settings instead. Same holds for the settings-captions subpage, even though it is still in the browser settings on non-ChromeOS. Also removing chromeos/localized_link/localized_link.{html/js} from settings_resources.grd again, since they were accidentally re-added at r725414. Will move the related files that are now only used by OS Settings to c/b/r/chromeos in a follow up CL. Bug: 1026455 Change-Id: Id3eeae79c75feb5886a6091797d105743bdd7db8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970845 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#726052}
-
Kenneth Russell authored
Canvases with display:none don't participate in compositing, so if they're drawn by applications, they never get a chance to reset their count of frames since the last commit. Handle visibility changes similarly. Bug: 1032171 Tbr: fserb@chromium.org Change-Id: I0eb7c3965627df533eb0617575618ec2dccb5ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968324 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#726051}
-
sczs authored
Adds infobarBannerActionWillPresentModal to InfobarCoordinatorImplementation so the banner is not dismissed (causing the Modal to be dismissed) after its action button has been tapped. Bug: 1032623 Change-Id: Ie0b0d81b451353c3d4815e43ada08de36ce54d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970836Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726050}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8a5c96f0b89..a02676614519 Created with: gclient setdep -r src-internal@a02676614519 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:702834 Tbr: jbudorick@google.com Change-Id: I9a1c4342426606bfa4e5d4f77ff242526173cd09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974206Reviewed-by:
-
Bettina authored
Log UMA metric when a non-sync signed-in user first saves their password on sign in and when they sign out. Right now, we only log when the signed-in non-sync account is saved in content area or it's changed. @tienmai inline_login_handler file only @vasilii password_manger files only Bug: 1034766 Change-Id: Ia6b407570433aa4f7df6c3365bd5cdf5f3ce4cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970768Reviewed-by:
Tien Mai <tienmai@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#726048}
-
Kurt Horimoto authored
This is an auxiliary OverlayRequest config that will be used to set up infobar banner UI. This CL also adds code to produce the appropriate banner config for save passwords overlays. Bug: 1030357 Change-Id: I9b455a3ffb696138b4cff1dad7c0cd4a827c8736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963384 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#726047}
-
minch authored
1. Always activate the snapped window that is underneath the back start point. 2. Put the affordance below the finger instead of above if it will exceed or overlap with the splitview divider while in portrait orientation. Bug: 1034040 Change-Id: I62c22bdb716ccd5540ebfd67f290a13a4ab989dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967130Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#726046}
-
Tarun Bansal authored
Bug: 988641 Change-Id: I0ac5898783fd01c90a50accb9a7270a3c0c3336c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973553Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#726045}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/703bcab9106c..5bddc336299d git log 703bcab9106c..5bddc336299d --date=short --first-parent --format='%ad %ae %s' 2019-12-18 fmayer@google.com Merge "Remove leftover reference to idle page tracking." 2019-12-18 fmayer@google.com Merge "Document args that are only valid in new versions." 2019-12-18 fmayer@google.com Remove Idle Page Tracking instructions. 2019-12-18 khokhlov@google.com Merge changes Ic732c2e5,Ib843c04c,I6b340067 Created with: gclient setdep -r src/third_party/perfetto@5bddc336299d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iec81ddfc4625fe56366cc8d3a09759aee377240d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974205Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/65e2f03bd23e..17b3c2f3f8b1 git log 65e2f03bd23e..17b3c2f3f8b1 --date=short --first-parent --format='%ad %ae %s' 2019-12-18 shaobo.yan@intel.com Implement SamplerVideoWEBGL for WEBGL_video_texture extension on desktop Created with: gclient setdep -r src/third_party/angle@17b3c2f3f8b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:776222 Tbr: jmadill@google.com Change-Id: Ie1b6d0f84f5e7041a88dab8dc835e757e9cfde12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973946Reviewed-by:
-
Bo Liu authored
The zygote can only use the system linker for loading library as it cannot communicate with the browser process at all. Relax the assert that was not aware of zygote. Bug: 1035101 Change-Id: If88e09224992aff5e28c3b540d232b6f38fbd16f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973215 Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
Andreas Haas authored
This CL replaces calls to DeprecatedByteLengthAsUnsigned by calls to ByteLengthAsSizeT. Unfortunately the current implementation cannot deal with huge ArrayBuffers yet. Therefore I reject the incoming ArrayBuffers with a RangeError if its size is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=reillyg@chromium.org Bug: chromium:1008840 Change-Id: Ia0af7fb8c57ec522cf8cd0963d6e0dd3fad9dd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973910Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#726041}
-
Ken Rockot authored
This reverts commit c6e3166e. Reason for revert: https://crbug.com/1036299 It looks like the refresh callback used throughout UsbServiceImpl might need to be Repeating... Original change's description: > Convert base::Bind etc in services/ (1/2) > > This covers removal of deprecated base::Bind, base::Callback, > base::Closure, base::Passed across services/data_decoder/ and > services/device/. > > Bug: 1007831 > Change-Id: I03ca32424d53e91e6720e9209cb19a564a19de96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970231 > Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#725374} TBR=rockot@google.com,mattreynolds@chromium.org,odejesush@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1007831 Fixed: 1036299 Change-Id: Ice2f343d2f25df88a9c4740449026975f04f4612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974311 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#726040}
-
