- 14 Dec, 2020 40 commits
-
-
Wei Li authored
Bug: none Change-Id: I387f48a86be50c70c10d107d30c6b35328a3b7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587766Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#836723}
-
Clark DuVall authored
With isolated splits enabled, the classes from a DFM will not be available in the base ClassLoader. This change makes sure all of the calls to inflate in autofill_assistant are able to access the classes defined in the DFM. Bug: 1158028, b/174219371 Change-Id: I6e6599f0831b089d97d5041864ce9df41c00e0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587872Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836722}
-
Dylan Cutler authored
private. This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Bug: 1102874 Change-Id: I842f1d66d746bffe17bc060c2554ba1e269d3774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588647Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#836721}
-
Abigail Klein authored
This ensures that the tab strip name is announced when it is focused by the accessible pane manager. Bug: 1097760 Change-Id: Ieba4986c83ae750feb3c4b0690a3d0bc6eca39d7 AX-Relnotes: Tab strip is named "Tab strip". Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588892 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#836720}
-
Kyra Moed authored
Implement multipage PDF file format saving capabilities atop PNG to PDF image format conversion. Bug: b:161237869 Change-Id: Ib74311185a3e4a6535b88042f203db956a77669a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580363 Commit-Queue: Kyra Moed <kmoed@google.com> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#836719}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d0f99d5405b4..3df29be28445 2020-12-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from c594de23cdd7 to c0bcfaf3bae9 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8a95ab819cb16357199bc42ab10f293f8dda3333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588616 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836718}
-
Aaron Leventhal authored
Hypertext is updated when a node changes, or on a parent of a textnode that changes. There are some cases where the hypertexts do not match the available children. In some cases this results in returning a null hyperlink, because cached data in AXHyperText was stale. A DumpWithoutCrashing() was added to help narrow these situations down, and the situation occurs quite often. The problem is that when AXPlatformNodeBase::UpdateComputedHypertext() is called, IsLeaf() is not updated nor are the platform children. This occurs because although the SendPendingAccessibiityEvents() has sent an updated root, the change for the root is not merged with other changes (TreeUpdatesCanBeMerged() returns false for any root update, even if it has the same id as the previous root). This causes all updates to be processed separately. When the root is processed, other updates have not yet occurred and the root object still appears to be a leaf. Other possibilities to fix this: - Do not send root_id in an update unless it's actually a new root. This may not catch all cases of the issue, but perhaps it's a good thing to do anyway. - Allow updates to be merged, even when there is a change on the root. - Compute hypertext on demand and memoize, so that it's computed after all atomic updates are finished - Instead of calling OnAtomicUpdateFinished() at the end of AXTree::Unserialize(), return the updates back to the caller and allow the caller to collect the updates and process a single call to OnAtomicUpdateFinished(); With any of these alternate approaches, it should be possible to remove the logic to ensure hypertext updates on parents in CollectChangedNodesAndParentsForAtomicUpdate(), because the renderer already sends parents nodes to the serializer with ChildrenChanged or TextChanged(). Bug: 1157731 Change-Id: I4e9eefa9b0f90d80daa1b7db2305ca92caaf32b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587371Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#836717}
-
Kinuko Yasuda authored
Bug: 1010491 Change-Id: Ic86d00d46d6dad7a0f3db31562e68e268273c496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586454Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#836716}
-
Leonard Grey authored
Bug: 1152274 Change-Id: I81358a8df4b853654ba031bce0a251ed8445a8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586156 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#836715}
-
Adithya Srinivasan authored
Change-Id: If231540e44354a1dcf1c4d8e8e4deb13516b3059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589913Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#836714}
-
Julie Jeongeun Kim authored
This CL replaces base::Contains() and find() with one find() call for the map lookup avoid performing a double map lookup from |process_mojo_map_| in extensions::RendererStartupHelper. Bug: 1157200 Change-Id: Ie16f2269fa0ad70d22e81c9f7018a172105b63ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588671 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#836713}
-
Stephen Chenney authored
This unblocks moving the study to Beta. Bug: 1120345 Change-Id: I9c74480ae41d45aa4d1647f5848367ff89bd0a42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586122Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#836712}
-
Dylan Cutler authored
constructor is private. This is part of a larger effort to make CanonicalCookie's generic constructor private. This CL replaces uses of the constructor with the factory CreateUnsafeCookieForTesting. This factory is meant for test-only code and should not be used in production. Bug: 1102874 Change-Id: I548be72deb5985faa27d7a0dd5119f3fa8e185f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590056Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
This will allow us to easier move this class to the Libassistant mojm service. All dependencies have been moved to the new class |AudioInputHost|. This class currently talks directly to |AudioInputImpl|, but later it will instead talk to the mojom APIs. Some notes: - |AudioInputImpl| still depends on |AssistantClient::Get()->RequestAudioStreamFactory()|, because the Libassistant mojom service will also use an audio stream factory to open/close its audio input. In a follow up CL I will introduce a delegate to sever this dependency. - There is one behavior change: |power_manager_client_->NotifyWakeNotification()| was previously only called when DSP was enabled, and it is now always called (when Libassistant starts a conversation). I can think of no reason why this would be an issue. Bug: b/171748795 Test: chromeos_unittests, deployed on real hardware with and without DSP. Change-Id: I119521c7a72bf5361019d70240c02ba47a23d6ad Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582537 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836710}
-
Victor Costan authored
This CL reduces the places where the IO thread is plumbed through the IndexedDB browser-side implementation. This is intended to reduce the cognitive effort of moving IndexedDB and its QuotaClient to the Storage Service. This CL relies on the following observations: * IndexedDBBackingStore::io_task_runner_ was unused. It can be removed. * QuotaManagerProxy can be used on any thread, and proxies the calls to QuotaManager on the IO thread. * IndexedDBContextImpl::io_task_runner_ was used via IndexedDBContextImpl::IOTaskRunner() in QuotaManagerProxy invocations (covered above) and by IndexedDBDispatcherHost. Moving it to IndexedDBDispatcherHost::io_task_runner_ clarifies its use. No functional changes are introduced. Bug: 1015214, 1016065 Change-Id: I79ccd5540f4ef5b3b8e387ab335aab656e6e0478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587796Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836709}
-
David Van Cleve authored
The org.chromium.url.Origin class is a user-friendly wrapper around an org.chromium.url.internal.mojom.Origin, which also happens to be the type one obtains from Mojo-generated interfaces in Java that take url.mojom.Origin in their .mojom definitions. In order to make it possible (or, at least, explicitly "supported", without the stigma of accessing fields of a class in an "internal" namespace) to manipulate the origins obtained via these code-generated interfaces, this CL adds a new url.Origin(url.internal.mojom.Origin) constructor. In the long run, it would be best if Mojo could just give us the user-friendly type instead of the "internal" type: that's also tracked in the associated bug. Bug: 1156866 Change-Id: I2e52feaca9bbd6c5514a15b07c27e7300c8e34e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586327Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#836708}
-
David Maunder authored
Apply batching to CriticalPersistedTabData tests so that they run faster. Speedup: 3984 ms -> 2676 ms (33% improvement). Bug: 1152295 Change-Id: I0054ef160bf969d3c1ab4be6851743a7c76a6e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587518Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#836707}
-
Saurabh Nijhara authored
This reverts commit b886f7f1. Reason for revert: The enum values are not in sync with the error codes in update engine code. The update engine team wants to first correct the enum before adding more values to it. This change needs to be re-landed after the enum is corrected by the update engine team with correct enum value. Original change's description: > Add enum value for error update download canceled per policy > > This CL adds error code for update download canceled due to > DeviceAutoUpdateTimeRestrictions policy to the > enum so that it can be reflected in the histogram. This error code is > already added in update engine code in the following CL - > https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2567121 > > Bug: chromium:1117450 > Change-Id: I69d109553c28a4948d725183293640d8eb044731 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584984 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Commit-Queue: Saurabh Nijhara <snijhara@google.com> > Cr-Commit-Position: refs/heads/master@{#836042} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1117450 Change-Id: I8bf8eb277af123d8a220a1ea1bf488df059c2eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587729Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#836706}
-
Joel Riley authored
Previously disabling word highlighting caused focus ring to highlight individual nodes instead of paragraphs, which caused the navigation control panel to bounce around too quickly. Bug: 1157941 Change-Id: I3f73ac13f8595df9ceb5c205e1fb0c1041654931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587489Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/bd6d8e4204b5..a3edbfa983ba 2020-12-14 wl@gnu.org [type42] Pacify static analysis tools (#59682). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: I0aa14a64c054fe60cd58df829b868aa36033c990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589285Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#836704}
-
Andrii Shyshkalov authored
R=gbeaty Change-Id: Ic567bb94e9505b5e5b3f5f6c7908652fc00da20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589318 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#836703}
-
Scott Lee authored
Change-Id: Ifeb9bef8dae18092e105085b1497859bd67865c9 Bug: 1084332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589042Reviewed-by:
-
Victor Costan authored
* Replace base::PostTask*() calls with calling PostTask*() methods directly on TaskRunners. * Use PostTaskAndReplyWithResult() instead of equivalent implementation based on PostTaskAndReply(). * Add comment clarifying that IndexedDBContextImpl::IDBTaskRunner() is a thread-safe getter. * Fix incorrect mapping of failure (success = false) to blink::mojom::QuotaStatusCode::kOk in DidDeletedIDBData(). The last improvement may result in elevated error rates while attempting to delete IndexedDB data. This is because this CL correctly propagates reported errors in a situation where they were ignored before. Bug: 1016065 Change-Id: Ibde1154fb1c42dc412a40c0ccbcd3cb6b8e3f627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588448 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by:
-
Brian Ho authored
Promoting a quad using the fullscreen overlay strategy results in a segfault when using SkiaRenderer. This is because for fullscreen overlays, we remove the frame's OutputSurfaceOverlayPlane [1]. In turn, this means we call SchedulePrimaryPlane with a null frame which sets a flag [2] that prevents |current_image_| from being cleared later in PostSubBuffer [3]. On the next frame, there is no damage on the primary plane because the entire contents have been promoted to a fullscreen overlay. Thus, we never render the root render pass [4] which results in |SkiaOutputDeviceBufferQueue::current_image_| never being set [5]. Since we never set a new |current_image_| and |current_image_| wasn't cleared as mentioned in the first paragraph, we end up re-using the |current_image_| from the last frame. This is where we get our segfault because various |current_image_| members are reset after their first use [6]. This CL fixes this issue by explicitly clearing |current_image_| (and adding it back to the |available_images_| queue) if the output surface plane is null. This makes sense because we shouldn't be presenting an image anyways since the primary plane is empty. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/overlay_processor_using_strategy.cc;l=232;drc=c6b95e6511da9afc58debb10a67fceb6b230341a [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=218;drc=58ff9e17fba96d56e68842b570b37d88a70d7f73 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=332;drc=c6b95e6511da9afc58debb10a67fceb6b230341a [4] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/direct_renderer.cc;l=383;drc=0348a1421914f3609d287cb5645a856f5eb2542c [5] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=506;drc=619ddf10544160ce22caec007a31873b2e28f691 [6] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/output_presenter.cc;l=103;drc=b621c956cfd2712c38f05b2240b0a5780066a07c Bug: 1156158 Change-Id: I2f030652166212cf6e28073c660e07526e67dcce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585811Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#836700}
-
Sophie Chang authored
In practice, this doesn't happen at all and cannot happen at all after the incognito CL goes in Change-Id: I0daf1c4cbb189840913ee4a368dda437e07efaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587396 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#836699}
-
Scott Lee authored
Steps with junit_tests and resultdb ran successfully 3368 times, but one failed. The failure was from the test itself. https://screenshot.googleplex.com/AmZp5peQzJrzz3c https://ci.chromium.org/p/chromium/builders/ci/Android%20arm%20Builder%20(dbg)/53534 R=gbeaty@chromium.org CC=chanli@chromium.org,nodir@chromium.org Bug: 1084332 Change-Id: I416787631a029491b758be2b5df17a4ffb59b41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589640Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b46e4dd997f0..928ad2740611 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com,ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: atotic@google.com,ftirelo@google.com Change-Id: I2d178f89c423ff032b077777f1bed218f5cdd773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589665Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836697}
-
Tina Wang authored
Previous: https://screenshot.googleplex.com/9kgVDiHMWknAeAN Now: https://screenshot.googleplex.com/3nRzSdcki58YoQU Bug: 1148843 Change-Id: If1c2bef46754f15496e4c9247fba9ff8e46cd17e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584564 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#836696}
-
Michael Thiessen authored
Possibly due to a bug on the version of M the tablet runs on (older than the M phones we test on), or possibly due to the tablets being extremely slow, this test times out on those devices. This is extremely difficult to diagnose without access to a Nexus 7, and not worth pursuing right now, so I'm disabling the test for that configuration. Bug: 1153686 Change-Id: I4e386f97b7052ebf0efc8c19f2683e21f73caafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588646Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#836695}
-
Eugene But authored
Bug: 688063 Change-Id: Ibf48e4ffe33ecf24aea08188b7579eab1de0e47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586012 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#836694}
-
Evan Stade authored
This namespace will be necessary when (some of) the code is componentized, and is isolated into a separate CL to minimize the size of the future code relocation change. Bug: 1147274 Change-Id: I2b3f2de04c9169b767c9abb7b1e9385e60bffe8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581032 Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#836693}
-
Alex Gough authored
Adds sandbox mitigation flag to disable CET. As these currently crash in v8 we apply this for renderer processes. For the default build this will have no effect as CET is not yet enabled for any binaries. However, for builds with `enable_cet_shadow_stack = true` or where users have configured CET by setting an appropriate `Image File Execution Option` in the registry it should be possible to run Chrome on CET capable hardware. A sandbox integration test is added which checks this policy works. On hardware without CET support the test exits early. Both browser_tests and content_browser_tests pass at least the same set of tests that pass with CET disabled on test hardware. Manual tests confirm chrome works with and without cetcompat, and with and without IFEO to force strict checks. Bug: 1131225 Change-Id: Icaf8d3f039c924e937973b6c01239c1635d43790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542726 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#836692}
-
Filip Gorski authored
TBR=arbesser@chromium.org Bug: 1158435 Change-Id: I3a1a17be1b5657cb85804db21bb77c089e536205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588298Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#836691}
-
Liquan (Max) Gu authored
Now that ExpandablePaymentHandler has been launched, this CL is to remove the support of CCT PaymentHandler UI (PaymentHandlerActivity) should be removed. The names of the removed elements: * PaymentHandlerActivity * CustomTabsUiType.PAYMENT_REQUEST * addPaymentRequestUIExtras * isForPaymentRequest * payments_handler_window_minimum_height Bug: 1157896, 1085001 Change-Id: Icc78167a58d1b21261352c7f1a94d1f8f0ce2bf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585642 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The histogram has been expired. Cleanup the dead code. BUG=1061971 Change-Id: I2bd0a6096b464261e0bf60c50dfea28b172002a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587374Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#836689}
-
siashah authored
CVC Unmask Dialog: Light mode: https://screenshot.googleplex.com/7V2eZSLwhQyMEwa Dark mode: https://screenshot.googleplex.com/3oPqiHUtd6hJueF Autofill Suggestion: Light mode: https://screenshot.googleplex.com/5NmaJyRkGKSediS Dark mode: https://screenshot.googleplex.com/AeKMk3r5ETbaiPw Upstream Save Dialog: Light mode: https://screenshot.googleplex.com/3hC25sp8ckmTwVz Dark mode: https://screenshot.googleplex.com/A4g4qREkFEPn99A Bug: 1124968 Change-Id: I43985d7fc3fe5790713a93e8acf70a25c0d34b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587581Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#836688}
-
Xida Chen authored
Bug: 1152278 Change-Id: If83a350ef97138a884ced934ab1f29f5d7819213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586159Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836687}
-
Ian Kilpatrick authored
TBR: dgrogan@chromium.org Bug: 1157962 Change-Id: Icdd1e0b4a15a1f4e6f729f35a77b66f13ba1483e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590165Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836686}
-
Dominik Röttsches authored
We need additional people be able to roll / update OTS. Bug: 1158389 Change-Id: I0cea226158183545e8bc4b06aca2f21ff088a68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590037Reviewed-by:
Ben Wagner <bungeman@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#836685}
-
Nico Weber authored
Bug: 1158410 Change-Id: Ic8f006dbb391699016a608c9cf328ea269b9e66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590054Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836684}
-
