- 16 Jul, 2020 36 commits
-
-
Joey Arhar authored
The current TestExpectations for this test seem too widely scoped - this test is either timing out or passing. Bug: 1105957 Change-Id: I34733445a33907d185da03155aa83b31e6070261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300772Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#788833}
-
Trent Apted authored
4 of the 5 allowed extensions are "quickoffice" and they all want to handle the same mime types, when multiple are installed. And this is not the right place to attempt to protect against multiple copies of the extension being installed. Fixed: 970227 Change-Id: I83922b6973c252dc497a04b623582878bfcde23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282545 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788832}
-
Yuke Liao authored
This CL cleans up the merge script by: 1. Remove unused logic. 2. Remove unless loggings as there are too many of them that clutters the stdout. 3. Fixes some wording. Change-Id: Ifa0e90a13ff2bf8f1cf99c41be0574fe2f7577bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231095 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#788831}
-
Zhenyao Mo authored
This driver is old and buggy and should not be used. We tried to disable accelerated video decode first, but crashes/hangs arose again recently on these old drivers. Let's just follow AMD advice and disable this driver entirely. BUG=1069262 TEST= R=sunnyps@chromium.org Change-Id: I7d29cc86162eeaa4ec175030d761447a6fcb6106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297711Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#788830}
-
Sorin Jianu authored
This CL is trying to reland a combination of https://chromium-review.googlesource.com/c/chromium/src/+/2293461 and https://chromium-review.googlesource.com/c/chromium/src/+/2297696 with an additional fix to make NetworkFetcherFactory a thread-safe type. The original CLs were reverted since the code had a race condition on the destruction of CrxDownloader instances, which triggered various sequence checkers when the objects were destroyed by a sequence other than main. Bug: 1105924 Change-Id: I84f071518f930964ec08611bb14b7fb2aa243fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300599 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#788829}
-
Robert Ma authored
testdriver-vendor.js must be included after testdriver.js. This CL fixes all the affected tests; there will be a new lint rule to prevent regressions later. Bug: 1105751 Change-Id: I793c5d3c65f4cdeeed3f120f6fad063dffaaa406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300261 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#788828}
-
Tibor Goldschwendt authored
Previously, the titles honored the theme setting. However, the title is shown in a white pill and, therefore, was invisible if the theme set a light color. Thus, this CL always sets the title color to dark. This is also what the local NTP does. Before: https://screenshot.googleplex.com/3W85KAw7sbv After: https://screenshot.googleplex.com/d2pAxBWjRx9 Fixed: 1105941 Change-Id: I4ca38bd3e70cf0e669ea2f5d23f6821ef822bf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300662 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788827}
-
Nodir Turakulov authored
Dash is more typical in builder names Bug: 1102997 Change-Id: I1edbb1f78cc77cccac56e34c23cce5a5d9ab90ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300837Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#788826}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d9199a509bf..ed9e5acd61d7 2020-07-15 ehmaldonado@google.com bot_update: Don't checkout 'master' after clone. 2020-07-15 ehmaldonado@google.com gclient: Unset core.worktree after cloning on Windows. 2020-07-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-07-15 thestig@chromium.org Add default filters to git cl lint. 2020-07-15 thestig@chromium.org Simplify a block of conditionals for git cl lint. 2020-07-15 ehmaldonado@google.com presubmit_canned_checks: Add DIR_METADATA presubmit checks. 2020-07-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1070694,chromium:1097674,chromium:1102997,chromium:1104182,chromium:1106028 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I10f82704f3dfa69e14262ce504f22e49888d5923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788825}
-
W. James MacLean authored
This CL completes the renaming process started in https://chromium-review.googlesource.com/c/chromium/src/+/2246923 for Android webview. Bug: 1067389, 846155 Change-Id: Ie5d20a0b18bd4eaf56c3eb4296941978d78ffb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300682Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#788824}
-
Yuke Liao authored
This CL generates a wrapper for each test target of format: "bin/run_{target}", and the wrapper then invokes the lacros test runner. Bug: 1104318 Change-Id: I0e33e745068fe08173e077a593a3c83501bf9fb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295925 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#788823}
-
Andrew Xu authored
This CL ensures that the navigation widget's size constant to reduce repaints during transition between home launcher and in-app shelf. In order to show the correct appearance of navigation widget, a clip layer is applied in tablet mode. Bug: 1097807 Change-Id: I43f2460ac32cf3e6804fcf60de0f1b7ce3b46771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290766Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788822}
-
Scott Little authored
This CL updates the default distance-from-viewport loading thresholds used when determining when to start loading-in images and iframes that were deferred either by being marked with "loading=lazy" or by automatic lazy loading (which is currently specific to Lite Mode users on Android Chrome). These thresholds were determined by running experiments to tune them, and may be updated further in the future if better values are found (e.g. in response to new optimizations/improvements to lazy loading). Bug: 989246, 1005490 Change-Id: I949be351947f200ace68ef9916bb8afa1006e730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159529 Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#788821}
-
Jesse Schettler authored
The Document Scan API is only supported on Chrome OS, so ensure it is only built on Chrome OS. Additionally, remove the unnecessary DocumentScanInterface layer now that there doesn't have to be interface implementations for Chrome OS and non-Chrome OS builds. Bug: None Test: Perform a scan using the Scan extension Change-Id: Ie18d15cac752e9166be6ee538cae3a7e3c8fe4bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296642 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788820}
-
Justin Cohen authored
Change-Id: I04d5a1c1d499109d73947fb5833fe1ad70249178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295225 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#788819}
-
Alexander Cooper authored
Converts the SessionRestore::CallbackList to a RepeatingCallbackList and converts the Registration method to take a RepeatingCallback, due to usage. Converts quit_closure_for_sync_restore_ into a OnceClosure. Converts a bind in tab_loader whose receiving end had previously been converted. Also converts one session restore notification registration in chrome_browser_main_posix to base::BindRepeating, as part of ongoing efforts to convert the top-level chrome/browser files. Bug: 1007635 Change-Id: I5034a3f801e162f987becdbe9c64073a905bac5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300604 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#788818}
-
Lan Wei authored
Avoid testRunner.eventSender in paint/invalidation/table/ table-overflow-scroll-in-overflow-scroll-scrolled.html. Bug: 1047176 Change-Id: I0e9d6d35c1b5033f6c084867a23eeb1b6da1fe1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298115 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#788817}
-
Gang Wu authored
This is a reland of be1e9636 Update the test to run on UI thread. Original change's description: > [Omnibox] Use ActivityState to check if we are in browser mode > > > In multi windows mode, check if we are in browser mode by WindowAndroid > is not working, should check ActivityState instead. > > Bug: 1102640 > Change-Id: I35a720a2aa6f337cc9f9ae43e39d83c9368fcb5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2286478 > Commit-Queue: Gang Wu <gangwu@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#786636} Bug: 1102640 Change-Id: Iefba5a5d0c181535bd7fb86cf0e073be2ebdbcdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293074Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#788816}
-
Xianzhu Wang authored
This allows us to calculate visual rect during painting for each display item, instead of calculating FragmentData::VisualRect() during PrePaint. Bug: 1104064 Change-Id: I80646991142c7407f921b92dde83123f745b4cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296485 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#788815}
-
Alan Cutter authored
This CL stores the background_color manifest field in the WebApp database for use by experimental tabbed web app windows. This CL has no user visible changes. Bug: 1104083 Change-Id: I69ad67c17b61161e721a4639340187550e0644b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291515Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#788814}
-
Vincent Boisselle authored
We are planning on keeping that metric for a while to detect regressions in the feed. Bug: 1104930d Change-Id: Ibfdf3bf5dd9242dbeb476e0de67196ea6e9e4c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295949 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#788813}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1a82e68482aa..ddc86ef759d8 2020-07-15 fmayer@google.com Merge "In-tree build of static heapprofd." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I8cdb00e31e64f53a0748bccf3910947788457ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300719Reviewed-by:
-
nancylingwang authored
Similar to the CL:2271958, modify the load icon interface for the intent picker, to load the new standard icons. Design doc: go/appservice-adaptive-icon BUG=1083331 Change-Id: Ie6b047961cd0a402595d30d734c33325a1e6f9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299684Reviewed-by:
-
Erik Chen authored
lacros-chrome is allowed to make synchronous mojo IPC calls to ash-chrome. To avoid deadlocks, the sequence responsible for handling lacros-chrome mojo IPC must never block. Prior to this CL, the class LacrosChromeServiceImpl was affine to the main-thread, which could and did block. See bug for a concrete example of a deadlock. This CL create a new private class LacrosChromeServiceNeverBlockingState. This class is affine to a never-blocking sequence. Most state has been moved from LacrosChromeServiceImpl to the private class. The exception is the public endpoint mojo::Remote<crosapi::mojom::SelectFile>, which is affine to the main thread. Bug: 1103765 Change-Id: I462311f7b2b68db5eeaab799a83d2bb6391dc575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293011 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#788810}
-
Kristi Park authored
TBR=donnd@chromium.org Bug: 1105488 Change-Id: I342bd468a30caf5ff0da6779b969accc8e16bb15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300829Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#788809}
-
Matt Menke authored
ur_request.h transitively includes a number of files that are not often included in headers - primarily net/net_buildflags.h, no_destructor.h, and command_line.h. url_request.h is also included in a number of the network service's traits files, which are used throughout a large potion of the code base. As a result, a lot of files are depending on those header files without including them. This CL fixes all of those include issues. In a followup CL, I'll remove the url_request.h includes from the traits files, which should help prevent this from happening again. It will also drastically cut the number of files that have to be rebuilt when modifying url_request.h, and may speed up builds times modestly. Bug: 110378, 1104380 Change-Id: I920acd605ce86d15ed604476c52513b38cdf7a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293078 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#788808}
-
John Williams authored
- Changed {,Cast,Mirroring}ActivityRecord to {Cast,App,Mirroring}ActivityRecord. - Removed "Record" suffix from names. - Updated all related names. Change-Id: I47326cd87820ad32d166c3f7a51c3dcf989f9065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288478 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#788807}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/212c5bd9b2f0..82961129b054 2020-07-15 kainino@chromium.org Use canned CheckPatchFormatted instead of our own linting 2020-07-15 tommek@google.com Adding TextureZeroInitTests for WriteTexture 2020-07-15 kainino@chromium.org Add .clang-format files and format more files 2020-07-15 natlee@microsoft.com [D3D12] Add DXGIAdapter to AdapterDiscoveryOptions 2020-07-15 tommek@google.com Implementing Queue::WriteTexture in Metal If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1036711 Tbr: cwallez@google.com Change-Id: Ia103d1efcc9ad2ced809d3a712a5d03293f99756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300862Reviewed-by:
-
Christoph Schwering authored
This CL makes Autofill not fill fields whose fields have been user-edited, except if their value is empty and the initial value is empty as well. The rationale behind the exception is that if the user removed a non-empty field value, Autofill should honour this. There is an issue with TriggerRefill() causing fills with FormData with empty values. These FormDatas are the result of cached FormStructures converted back to FormData. This is addressed in a follow-up CL. Bug: 966873, 949094, 1075533 Change-Id: I7ab80dfa6edc85bf00b16ef5e99e777d032a9b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289410Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#788805}
-
Jun Kokatsu authored
Link tag modification that was moved down to body tag in crrev.com/c/2239707, which caused a blink when opening incognito NTP. This change move the code on top of head tag so that the blink won't happen. Bug: 1105744 Change-Id: I1bfb583208767e86058f77fd1757e4bd2eaad26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300278 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#788804}
-
Christopher Cameron authored
Specify a 0.005-1,000 nit luminance by default. This is a temporary measure in two ways: - We should plumb this through video and the compositor, and thereby get the correct values. - The default tonemapping affects the SDR range, which is undesirable. We should roll our own tonemapping that doesn't have this property. This will make HDR look less washed out on barely-HDR-capable monitors, such as the built-in Macbook Pro screens. Bug: 1101041 Change-Id: I4db344d35f5259dbeb4191e4901e9798882a06d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300979Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#788803}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ifc93d758802005dd99de07e254d2f81f159cd735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300819Reviewed-by:
-
Yue Zhang authored
http://crrev.com/c/2119188 exposes two bugs in the setup introduced in http://crrev.com/c/2143671, which jointly lead to a corner case where the dialog animation is not setup correctly. This CL fixes this issue by 1) restoring dialog view size and position after animation 2) restoring the animation view alpha in the correct position. This CL also revives a disabled test that could have caught this issue by removing the flaky parts and add some bug-specific checkings. Bug: 1075677, 1099563 Change-Id: Ie722d77f806dd556f69cb2df6b758500739cdc65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278923Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#788801}
-
Orin Jaworski authored
Now that the submatch mechanism is eliminated, this CL removes several related functions and collapses logic at call sites. The flag omnibox-tab-switch-suggestions-dedicated-row is also removed because the omnibox-tab-switch-suggestions and omnibox-suggestion-button-row flags are sufficient, and there are no dedicated tab switch suggestions. Bug: 1102619 Change-Id: Iaa0b86601b1968a182af74b5478ec8bc312d8bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300627Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788800}
-
Siye Liu authored
Some IMEs may start and complete composition within same edit session. Therefore, we should still fire composition events at the moment where we commit the text to blink. This change also contains several refactors: 1. Refactor code in |CommitTextAndEndCompositionIfAny|. 2. Moves logic to set |new_text_inserted_| from |TSFTextStore::SetText| to |TSFTextStore::InsertTextAtSelection| since IMEs may directly invoke the latter method. We need to correctly set the |new_text_inserted_| flag in order to push text states to blink. 3. |TSFTextStore::InsertTextAtSelection| may be called several times in single edit session. Therefore, we need to aggregate all replacement ranges into single |replace_text_range_|. 4. In |TSFTextStore::RequestLock|, we should also reset all caches such as |new_text_inserted_| even when the function early returns. 5. In |TSFTextStore::RequestLock|, use the replace text end pos instead of the cached |composition_start_| as the |new_composition_start|. Bug: 1099125 Change-Id: Ibfa2ff284a183939596d9ea2a5e7105e8139b099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274245Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#788799}
-
Martin Kreichgauer authored
WebAuthn GetAssertion requests originating from the cryptotoken extension, which implements Chrome's U2F API, currently may result in a CTAP2 request if the selected authenticator supports CTAP2. This hasn't really caused issues in the past: Lenient authenticators accept an appId as the makeCredential request's rp_id parameter and let us challenge the U2F credential that way. Or if the authenticator indicates over CTAP2 that the credential doesn't exist, GetAssertionTask would then automatically retry over the U2F interface based on the presence of the appId extension. Responses for both cases are equivalent. But sending CTAP2 GetAssertion requests in order to respond to a request to the U2F API is unexpected and inefficient. It may also cause issues with future authenticators that decide to treat user verification as non-optional for all requests arriving on the CTAP2 interface. Instead, change GetAssertionTask to never try its CTAP2 path for these requests. Bug: 1099782 Change-Id: Ice54122bf3b9f63814d594074a39b9b46279ded4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298541 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#788798}
-
- 15 Jul, 2020 4 commits
-
-
Andrew Grieve authored
Mostly left instances in feed since that will probably go away one day anyways. TBR=agrieve Bug: 1041930 Change-Id: I8191fe4f9b90f5eee2c46bfe2e5923fddf40bf22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298040Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#788797}
-
yilkal authored
This cl renames kEnableSecondaryAccountsForChildExperiment feature flag to kEnableSecondaryAccountsForChild. This is because the flag is now being used for a feature. Bug: 1101622 Change-Id: I981cd16fc0a9fa0ce993221f77c4eab7f7838f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300635 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#788796}
-
Peter Wen authored
Rather than using direct deps for javac compilation, use it only for turbine header compilation. The javac compilation process requires many potential transitive deps that will take a more comprehensive approach, perhaps similar to bazel's reduced java classpath. Turbine using direct deps would only affect annotation processors. In particular, possibly Dagger. Building chrome_java with only turbine's direct deps seems to have worked, but only removing more of the dirs in the allowlist can determine if this works for the entire codebase. Bug: 1092528 Change-Id: Ifc745d269ce8850a6c675458fcff25c46ca39937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299531 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Christoph Schwering authored
This CL turns AutofillAgent::submitted_forms_ from a std::set<FormData> with custom comparator into a set of renderer IDs. The sole purpose of this set is to avoid duplicate submission events per form. Unique renderer IDs suffice for this. And since the comparator used before this CL was generally not sound (false positives), this at least theoretically solves some missing form-submission bugs. Bug: 896689, 1007974 Change-Id: I8fab1ee692c26c26b2cc061b0045b9757820b553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297527Reviewed-by:
-
