GitLab

Bug: 844016
Change-Id: I5b4a92b25ae7f02c3d298241f283345a4ac58b4e
Reviewed-on: https://chromium-review.googlesource.com/1136657Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574956}

https://skia.googlesource.com/skia.git/+log/4a17501f5bbd..7651c1611e6c


git log 4a17501f5bbd..7651c1611e6c --date=short --no-merges --format='%ad %ae %s'
2018-07-13 caryclark@skia.org refresh generated includes
2018-07-13 caryclark@skia.org fix bookmaker


Created with:
  gclient setdep -r src/third_party/skia@7651c1611e6c

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=robertphillips@chromium.org

Change-Id: Id9e88aa43427f7ec3e730192f9f30d7be3cba193
Reviewed-on: https://chromium-review.googlesource.com/1136394Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574955}

This CL adds the implementation to check the preference of
enabling/disabling media remoting. The remoting dialog is only shown
when user has not set the preference.

The preference can be set through the remoting dialog. Though this CL
doesn't clear the preference once it is set. This will be done in a
later CL.

Bug: 849020
Change-Id: I89c4ed6b71a2e51bd81fae919531d15b53664b18
Reviewed-on: https://chromium-review.googlesource.com/1125355
Commit-Queue: Xiangjun Zhang <xjz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574954}

Google login page allows users to input their Gmail prefix or input the
full gmail email address for sign-in. For example, user's gmail is
user@gmail.com, then on https://accounts.google.com..., typing "user"
or "user@gmail.com" as username have the same effect. However,
current HashPasswordManager treats them as two separate accounts when
saving password hashes.

This CL improves the canonicalization of username by appending "@gmail.com"
to PasswordHashData.username if it is a Gmail email prefix.

Note that Dasher account always require full email as username.

Bug: 858865
Change-Id: I9ddf23f54ee67bd73bd754953a3b80758e062ef3
Reviewed-on: https://chromium-review.googlesource.com/1135906Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574953}

bootstrap.py does not exist in the gn.googlesource.com repo.  The script
gen/build.py is used instead.  However, there are some differences to
bootstrap.py: one obvious one is the name and location.  This breaks chromium
packagers relying on bootstrap.py, so this change adds the script back.  In the
long-term, it should forward to gen.py.

BUG=859536,863459,863460

Change-Id: I59ff81acb7f409d1975f99bcf0676e6103b2d7b9
Reviewed-on: https://chromium-review.googlesource.com/1136656
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574952}

In Mojave, apps should provide a reason string that will be shown in the
OS-mediated permission prompt for protected resources (e.g., camera,
microphone, location). This adds the reason string and places it in the
InfoPlist.strings files.

Bug: 850175
Change-Id: I1b5c250aa50a2b4086e95c34521a82fae2405ea1
Reviewed-on: https://chromium-review.googlesource.com/1135114Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574951}

Test: manual
Bug: 833443
Change-Id: Iaf64e0c4edea2ae444d6d55a6103f922c5f33ffb
Reviewed-on: https://chromium-review.googlesource.com/1132476
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574950}

Formalize the concept of local time and use it internally where we would
have done a one-off calculations before.

In this process I noticed and documented issues how pause time is being
applied. In particular pause time incorrectly include offset_time_ and
excludes total_paused_duration_. I suspect these issues flew under the
radar mainly because pausing is only ever used for simple test cases not
involving animations with start delays or multiple pause/unpause cycles.
I plan to fix this issues in a follow up patch.


Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I02030dbd5ef0656b2738353a6e468b81c9b259a8
Reviewed-on: https://chromium-review.googlesource.com/1037635
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574949}

As opposed to sharding between swarming bots, sharding within a swarming bot
seems to be broken over 50% of the time, and is causing flake.

Since when this type of sharding fails, it re-runs without sharding, disabling
sharding here shouldn't increase cycle time.

Change-Id: I80dc3b6360dc829fc34e9f3f35247c70b10642ee
Reviewed-on: https://chromium-review.googlesource.com/1136636Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574948}

This makes it so we don't:
- report text edit events while touch exploring other items on the screen
- don't go into gestures for editable text while exploring elsewhere

Test: manual
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ifc5c9256dc71e7a65d929d2b53a7cde28bd2ec0b
Reviewed-on: https://chromium-review.googlesource.com/1135993Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574947}

It allows using WaitUntilConditionOrTimeout in the iOS components code

Bug: 784735
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie370a3562c6774a24b0faa4838d05da3f379c201
Reviewed-on: https://chromium-review.googlesource.com/1132301
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574946}

WebRTCRtpTransceiver added for surfacing transceivers in future CLs.
Implementation added in content and test coverage added.

The content::RTCRtpTransceiver is implemented with a similar design as
content::RTCRtp[Sender/Receiver]:
- It has an "internal" ref counted class, allowing multiple
  WebRTCRtpTransceivers to represent the same webrtc layer transceiver.
- The "state" is in a separate class, allowing surfacing transceiver
  state information separately from implementation, and use of
  TransceiverStateSurfacer.

Stop(), blink-layer RTCRtpTransceiver and Unified Plan usage will be
added in follow-up CLs.

This CL also removes all dependencies on
webrtc_media_stream_adapter_map.[h/cc] unblocking its deletion.

Bug: 777617
Change-Id: Icbc4a6b53ef57df8da6bc10e9e432644368ba5dd
Reviewed-on: https://chromium-review.googlesource.com/1131475Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574945}

SubprocessMetricsProviderTest.SnapshotMetrics has been flaky for a while
but it is suddenly much worse now and I don't see an obvious culprit.
Disabling until someone can investigate.

Tbr: asvitkine@chromium.org
Bug: 863262
Change-Id: I33d62b866c00f7fd9386cb274773547a3815bb20
Reviewed-on: https://chromium-review.googlesource.com/1136051
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574944}

This ensures deterministic failure if the setsockopt() implementation
tries to make use of otherwise uninitialized fields.

Bug: 862189
Change-Id: I0be1dd6c9b830babf0911dc0d78910a20cbd0813
Reviewed-on: https://chromium-review.googlesource.com/1136374Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574943}

TBR: jam@chromium.org
Bug: 863166
Change-Id: I9e31154c0ba8cdc5fff7af5130c8a06029a4bdaa
Reviewed-on: https://chromium-review.googlesource.com/1136029
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574942}

Returning in a finally block causes exceptions to be discarded. There's
no reason to log a UMA stat for the performance of a startup that threw
an exception (since we're going to crash the app anyway), so just take
it entirely outside the finally block and invert the condition to only
record the UMA stat if mFactory.hasStarted().

Also adjust another place that had the same pattern without the "return"
to match, as again there's no need to log the UMA stat when there's an
exception.

Bug: 862662
Change-Id: Ie6d24cee5bb9342016c364244256c8b73a8184f7
Reviewed-on: https://chromium-review.googlesource.com/1133332
Commit-Queue: Richard Coles <torne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574941}

Add
Scheduler.Experimental.Renderer.CPUTimePerThreadType.{Tracked,NonTracked}
histograms to measure and report cpu time not captured by the scheduler.

BUG=852314
R=rkaplow@chromium.org,alexclarke@chromium.org
TBR=gab@chromium.org

Change-Id: I4ebdb22fac455ee1887abdc3b739162a970aa900
Reviewed-on: https://chromium-review.googlesource.com/1133258Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574940}

This CL reverses the value of the feature flag to mean enabled, and
fixes all tests to pass with the new My Files on navigation menu.

Change MyFiles tests to not append the flag anymore, because when the
flag is provided it now disables "My Files" :)

Fix navigation_list_model_unittest.js to pass flag true/false on
NavigationListModel with the desired flag state.

Stop calling "notifyEntriesChanged" on
DirectoryTree.updateSharedStatusIcon, because this causes the cache
invalidation, which was causing some metadata model to be invalidated
before being displayed on file list, in particular the modificationTime
column on file list. crbug.com/857343 tracks further investigation if
this call was really still needed.

Change folder_shortcuts.js to account to new My Files on directory
tree, because it changes the keyboard shortcut to select top-level
directories. Also fix and improve some comments.

Change tab_index.js to account to My Files on breadcrumbs being focused
during tab cycle. This requires adding an id on breadcrumbs.

Bug: 857335, 862897
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Iddb2545772e62c0e8adebd8b278bd3a5765f5040
Reviewed-on: https://chromium-review.googlesource.com/1131025Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574939}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/47b0a995..0551e649

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ib4888827f33c1d973045f5fd57f9f1783447fbb0
Reviewed-on: https://chromium-review.googlesource.com/1136382Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574938}

This patch makes the ResourceLoadScheduler show a console message
on receiving a network request when running requests reach to the limit.

This will help users to understand what is happening around the
background tab throttling.

Change from the original change (crrev.com/c/1057969):
- Rebase
- Not to show the message for kStopped (i.e. when a frame is paused)

The latter can be added when the owners of frame-pausing/stopping want
to add that later.

Bug: 837771
Change-Id: Ie17bb21a7172d2108d9cd10c4f3bde8b066b6fdb
Reviewed-on: https://chromium-review.googlesource.com/1136167
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574937}

This reverts commit f4924c30.

Reason for revert: Done with experiment.

Original change's description:
> android: Disable binding mangement for site isolation
> 
> This is a speculative experiment (since it's a simple change) to see if
> it has any effect on the rate of sad tabs when site isolation is
> enabled.
> 
> This should be reverted before M69 branch point, and definitely before
> site isolation actually ships to beta.
> 
> Bug: 855037
> Bug: 859208
> Change-Id: I90c7cce4a03603d8bd9772ead804eeabb4114bad
> Reviewed-on: https://chromium-review.googlesource.com/1120864
> Commit-Queue: Bo <boliu@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#571660}

TBR=boliu@chromium.org,alexmos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 855037, 859208
Change-Id: I70917a54a7f3a4c02baa95ddba5016ce7c8948ad
Reviewed-on: https://chromium-review.googlesource.com/1136611Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574936}

Bug: 845472
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ibe6443cfdb658cce9caf351171f2c23cbff492ed
Reviewed-on: https://chromium-review.googlesource.com/1136634Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574935}

concurrent.BulkForkAndCall(func, arg_tuples) calls |func()| with
arguments given by |arg_tuples|, which stores arguments over
independent forked calls as a list of tuples. Previously this requires
common parameters (e.g., tool_prefix) to be present in each tuple, and
decreases flexibility for |arg_tuples| preparation code.

This CL adds |kwargs| parameter to BulkForkAndCall(), thereby allowing
common parameters to be given once. As seen in the test changes, a
minor caveat is that |func()| will need to make common parameters
appear at end of argument list.

Bug: 723798
Change-Id: I9aa91b6081b8fe8fa9c87a9ae1cb959d3f17e9df
Reviewed-on: https://chromium-review.googlesource.com/1135204
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574934}

TBR=drott@chromium.org

Change-Id: I9c026944acad5c4783bbed7dcbea262479fbd707
Reviewed-on: https://chromium-review.googlesource.com/1136388
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574933}

Bug: 863350
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7f4ade68fd7d504d06f276660e66ee7c01f20806
Reviewed-on: https://chromium-review.googlesource.com/1136549Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574932}

This reverts commit 043b97ce.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Correctly initialize and test SnapContainerData in cc."
> 
> This reverts commit 0fc70abb.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Revert "Correctly initialize and test SnapContainerData in cc."
> > 
> > This reverts commit 37061f87.
> > 
> > Reason for revert:
> > The layout tests added by this CL is failing on the CL:
> > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
> > 
> > Original change's description:
> > > Correctly initialize and test SnapContainerData in cc.
> > > 
> > > This patch initializes the rect_ field in SnapContainerData in copy
> > > constructor and move constructor. Fixing a snapping issue in the
> > > composited pages.
> > > 
> > > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
> > > test suite so that they are tested with the composited cases.
> > > 
> > > snap-at-user-scroll-end-manual-automation.js calls
> > > mouseClickInTarget() of pointerevent_common_input.js. That method
> > > invokes programmatic scrolls. The test was written before programmatic
> > > scroll snapping was implemented so it worked at that time. However,
> > > with programmatic scroll snapping implemented, it will always snap
> > > in mouseClickIntarget() and cannot test whether the user scroll snaps.
> > > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
> > > to avoid invoking programmatic scrolls in the test.
> > > 
> > > This patch also checks nullptr for layout_box in
> > > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
> > > 
> > > Bug: 862406, 862571
> > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
> > > Reviewed-on: https://chromium-review.googlesource.com/1132386
> > > Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> > > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > > Reviewed-by: Robert Flack <flackr@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#574781}
> > 
> > TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
> > 
> > Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 862406, 862571
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Reviewed-on: https://chromium-review.googlesource.com/1136171
> > Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574825}
> 
> TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org
> 
> Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 862406, 862571
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1136671
> Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574926}

TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org

Change-Id: If9d1e6f73393a7dddc9f8f418606946f070b45be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1136612Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574931}

Bug: 853058
Change-Id: I4c816e84ca40c34d723043532c028a13f09e168e
Reviewed-on: https://chromium-review.googlesource.com/1133176
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574930}

BUG=852165
R=mthiesse

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iace7240f1cde3669a319375d0269397d32ea3f22
Reviewed-on: https://chromium-review.googlesource.com/1136576Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574929}

Bug: 846953
Change-Id: I6ee9d0d9557fa981726316994661ac0aad3c9631
Reviewed-on: https://chromium-review.googlesource.com/1135696
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574928}

It turns out that in order to migrate some specific unit tests more smoothly
from URLFetcher to SimpleURLLoader, it is useful to have a method where
indexing of the pending requests list is preserved after a given pending request is handled.

For instance some tests do this:

  request_load_1();
  request_load_2();
  request_load_3();
  (..)
  request_load_n();

  response_request_3();
  response_request_2();
  response_request_n();
  (..)
  response_request_1();

  // do stuff

  request_load_n+1()
  request_load_n+2()
  request_load_n+3()

  response_request_n+2()
  response_request_n+3()
  response_request_n+1()

In the above scenario, it is handy to be able to simulate responses at the original order
requests were made. This CL adds an API that fills this gap.

In practice, this is a preparation for https://crrev.com/c/1114998/.

BUG=773295

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Id9059f3d8f091eabfb21948f074599c180f44128
Reviewed-on: https://chromium-review.googlesource.com/1123236
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574927}

This reverts commit 0fc70abb.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Correctly initialize and test SnapContainerData in cc."
> 
> This reverts commit 37061f87.
> 
> Reason for revert:
> The layout tests added by this CL is failing on the CL:
> https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win10/37804
> 
> Original change's description:
> > Correctly initialize and test SnapContainerData in cc.
> > 
> > This patch initializes the rect_ field in SnapContainerData in copy
> > constructor and move constructor. Fixing a snapping issue in the
> > composited pages.
> > 
> > We also adds external/wpt/css/css-scroll-snap/ to the virtual/threaded
> > test suite so that they are tested with the composited cases.
> > 
> > snap-at-user-scroll-end-manual-automation.js calls
> > mouseClickInTarget() of pointerevent_common_input.js. That method
> > invokes programmatic scrolls. The test was written before programmatic
> > scroll snapping was implemented so it worked at that time. However,
> > with programmatic scroll snapping implemented, it will always snap
> > in mouseClickIntarget() and cannot test whether the user scroll snaps.
> > This patch adds a parameter shouldScrollToTarget to mouseClickInTarget
> > to avoid invoking programmatic scrolls in the test.
> > 
> > This patch also checks nullptr for layout_box in
> > ScrollManager::SnapAtGestureScrollEnd() to fix a crash.
> > 
> > Bug: 862406, 862571
> > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> > Change-Id: I6a53818cf74421a4100ad6f908158abf302a5b8e
> > Reviewed-on: https://chromium-review.googlesource.com/1132386
> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> > Reviewed-by: Majid Valipour <majidvp@chromium.org>
> > Reviewed-by: Robert Flack <flackr@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#574781}
> 
> TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org
> 
> Change-Id: I55c77c05c0381c8ac638bd106d2d18b1b4332745
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 862406, 862571
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
> Reviewed-on: https://chromium-review.googlesource.com/1136171
> Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
> Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574825}

TBR=flackr@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,tzik@chromium.org

Change-Id: I4a9480b68c15e0dfcfd13df6ed6c0e6b8ab5a8e3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 862406, 862571
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1136671Reviewed-by: Sandra Sun <sunyunjia@chromium.org>
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574926}

I was just doing a cleanup pass on VrShellDelegate, and ended up pulling
on a cleanup thread for VrSupportLevel.

I could split this into multiple changes if necessary, but that sounds
like a waste of time.

Change-Id: I2a5b962b4b7558b64f792c806314a7eb7b2e81ed
Reviewed-on: https://chromium-review.googlesource.com/1135727Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574925}

Duplications metadata and section_sizes from the header of a .size file
inside the data.ndjson file generated by html_report. We don't use this
for anything currently, but we're including it for potential future use.

Bug: 847599
Change-Id: I845dc76e86907db9bc1716fca2fd0233a2598f69
Reviewed-on: https://chromium-review.googlesource.com/1136579Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#574924}

This will be used in an upcoming update to the chrome://conflicts page
to show why a particular module was blocked or caused an incompatibility
warning to be shown.

Bug: 846953
Change-Id: I6e6eab9f4f9805b5fb67a00eb9f5521c006f11ff
Reviewed-on: https://chromium-review.googlesource.com/1135658
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574923}

https://chromium.googlesource.com/angle/angle.git/+log/523c5e3122ed..0cc291365934


git log 523c5e3122ed..0cc291365934 --date=short --no-merges --format='%ad %ae %s'
2018-07-13 lucferron@chromium.org Vulkan: Remove contextVk warnings in syncState


Created with:
  gclient setdep -r src/third_party/angle@0cc291365934

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ib251c243f4aa9f48adea74da35eb0f90fce71480
Reviewed-on: https://chromium-review.googlesource.com/1136393Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#574922}

As CL:1132541 removed layout-tree fixup for leading abs-pos &
floats, this patch removes additional support code for
'text-indent'.

Bug: 734554
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1fcb0efda87d1f1abba110b9bbdc36e6d1fd5da0
Reviewed-on: https://chromium-review.googlesource.com/1136268
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574921}

As remote clients trigger setting the primary surface we have to cache the
fallback until the primary is available.

BUG=863083
TEST=none

Change-Id: I3af87f1397bfa4f42f8ab3bb569ef115737f0e91
Reviewed-on: https://chromium-review.googlesource.com/1135524Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574920}

Without this, when building core,
`extern template class CORE_EXTERN_TEMPLATE_EXPORT foo<bar>;`
expands to
`extern template class __declspec(dllexport) foo<bar>;`
in a .h file using CORE_EXTERN_TEMPLATE_EXPORT.

The "extern" means "this template foo is explicitly instantiated with type parameter
bar in a cc file somewhere, so don't bother generating code for it if someone
uses it", while "dllexport" means "we're exporting this template foo with
type parameter bar from the dll we're currently building, so please make sure
to generate code for it". These two contradict each other.

cl emits C4910 and ignores the "extern" -- meaning the code for foo<bar> is
emitted into every translation unit in core including this header.  This
is harmless, but if we were still build with msvc it'd be slower than it needs
to be. (Then again, MSVC says "The extern keyword in the specialization only applies
to member functions defined outside of the body of the class. Functions defined inside
the class declaration are considered inline functions and are always instantiated.",
so maybe it doesn't really have an effect there either since all our templates
have all their functions inline, more or less by necessity.)

clang-cl emits Wdllexport-explicit-instantiation-decl (suppressed by /wd4910)
and ignores the dllexport. There, this patch doesn't change behavior but
the warning is no longer emitted.

(In either case, the cc file then says CORE_TEMPLATE_EXPORT on the instantiation
definition which _does_ export to __declspec(dllexport) and makes sure code for
foo<bar> is generated -- but only in a single cc file.)

So this patch doesn't really change behavior, but it allows us to no longer pass
/wd4910. It also makes CORE_EXTERN_TEMPLATE_EXPORT's behavior match
base/export_template.h and is a step towards maybe using that directly.

See bug comment 0 for more details.

Also remove a few CORE_EXPORTs on template classes. See the CL description of
ttps://chromium-review.googlesource.com/1133329 for why they make no sense,
and if they're there then the EXPORT gets inherited from the template class
to the specialization, triggering the warning again.

Bug: 859989
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1832bdf3d618a72be9b4d78cb435303ca1517677
Reviewed-on: https://chromium-review.googlesource.com/1135937Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574919}

Follow-up to https://crrev.com/c/1134884 now that all jinja_template
targets have proper includes.

Bug: 843562
Change-Id: Ibff629fe42644a21a4c9b1fe94a0e5e822168936
Reviewed-on: https://chromium-review.googlesource.com/1135711
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574918}

The tests were disabled when determined to be flaky (see CLs in the bug below).
The longtask-in-sibling-iframe.html test seems to pass all the time, and the
other is marked as Pass Timeout instead of Skip.

Bug: 796668
Change-Id: I4d297a0ad1dd5bfac6a6f5d1e0eb0aeb03b65935
Reviewed-on: https://chromium-review.googlesource.com/1135913Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574917}