GitLab

Revert of Only dispatch menu events if they have a valid target. (https://codereview.chromium.org/284903002/)

Reason for revert:
Made the asan bot red:

Direct leak of 664 byte(s) in 1 object(s) allocated from:
    #0 0x4b7c7b in operator new(unsigned long) /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62
    #1 0x5a4ffc in RunMenu ui/views/controls/menu/menu_controller_unittest.cc:158
    #2 0x5a4ffc in views::MenuControllerTest_EventTargeter_Test::TestBody() ui/views/controls/menu/menu_controller_unittest.cc:218
    #3 0xb2b838 in HandleExceptionsInMethodIfSupported\u003Ctesting::Test, void> testing/gtest/src/gtest.cc:2045
    #4 0xb2b838 in testing::Test::Run() testing/gtest/src/gtest.cc:2061
    #5 0xb2d2c8 in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2237
    #6 0xb2e006 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2344
    #7 0xb3e7fa in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4065
    #8 0xb3de40 in HandleExceptionsInMethodIfSupported\u003Ctesting::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2045
    #9 0xb3de40 in testing::UnitTest::Run() testing/gtest/src/gtest.cc:3697
    #10 0xafaee4 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2231
    #11 0xafaee4 in base::TestSuite::Run() base/test/test_suite.cc:206
    #12 0xaf2656 in Run base/callback.h:401
    #13 0xaf2656 in base::(anonymous namespace)::LaunchUnitTestsInternal(int, char**, base::Callback\u003Cint ()> const&, int) base/test/launcher/unit_test_launcher.cc:494
    #14 0x83846a in main ui/views/run_all_unittests.cc:43
    #15 0x7ff88421176c in __libc_start_main /build/buildd/eglibc-2.15/csu/libc-start.c:226



Probably easy to fix (and thus easy to reland), but from skimming the test it's not obvious to me what's supposed to free controller_. I'm guessing the second block in the new test just needs an explicit delete? (An "Owned by X" comment close to controller_ would've helped me)

Original issue's description:
> Only dispatch menu events if they have a valid target.
> 
> BUG=370162
> TEST=In touchview, open wrench menu and press a key (i.e. 'T'), nothing should happen.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271283

TBR=sadrul@chromium.org,flackr@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370162

Review URL: https://codereview.chromium.org/287233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374558
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/293543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271302 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271299 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374558
TBR=jamescook@chromium.org

Review URL: https://codereview.chromium.org/293533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271297 0039d316-1c4b-4281-b951-d872f2087c98

TBR=caseq,yurys
BUG=374411

Review URL: https://codereview.chromium.org/288423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271296 0039d316-1c4b-4281-b951-d872f2087c98

Currently, the lint warns against using the implicit default locale in String.format().
We should use the explicit locale instead of it.

BUG=327768

Review URL: https://codereview.chromium.org/287323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271295 0039d316-1c4b-4281-b951-d872f2087c98

This is happening when running the following command line:

$ gn gen out/Debug --args='is_component_build=true'
ERROR at //net/third_party/nss/ssl/BUILD.gn:122:18: Item not found
    configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
                     ^--------------------------------------------
You were trying to remove "//build/config/gcc:symbol_visibility_hidden"
from the list but it wasn't there.

BUG=None
TEST=above
R=brettw@chromium.org,wtc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/285293009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271294 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372578
NOTRY=true

Review URL: https://codereview.chromium.org/272013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271293 0039d316-1c4b-4281-b951-d872f2087c98

This change is mostly mechanical. There were no functional changes made other than updating the paths to the new location.

This moves the translation files (xtb) out of ui/base/ to ui/strings/translations.

BUG=369881
TEST=build locally + green trybots, no functional changes.
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/269363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271292 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271291 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174203:174227&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/291733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271290 0039d316-1c4b-4281-b951-d872f2087c98

This file used to be in /tmp, but then the security folks
decided that /tmp was too dangerous and it got moved to
/var/log, but that's the wrong place for it.
The corresponding Chrome OS change has just been pushed at
https://chromium-review.googlesource.com/#/c/200091/

BUG=chromium:373833
TEST=none

Review URL: https://codereview.chromium.org/292433009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/282393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271288 0039d316-1c4b-4281-b951-d872f2087c98

Using mojo::Application::AddService<ServiceImpl> results in the system taking care of error handling for you. There's no need to force ServiceImpl to override OnConnectionError in this case.

Review URL: https://codereview.chromium.org/289873008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271287 0039d316-1c4b-4281-b951-d872f2087c98

r=rch
BUG=374331

Review URL: https://codereview.chromium.org/291623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271286 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, this is to help us debug Win 8 Aura test flakes.

BUG=

Review URL: https://codereview.chromium.org/289033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271285 0039d316-1c4b-4281-b951-d872f2087c98

R=viettrungluu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/283363007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271284 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370162
TEST=In touchview, open wrench menu and press a key (i.e. 'T'), nothing should happen.

Review URL: https://codereview.chromium.org/284903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271283 0039d316-1c4b-4281-b951-d872f2087c98

BUG=337096
TEST=bots

Review URL: https://codereview.chromium.org/290003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271282 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Store and restore view focus in OnWindowFocused. (https://codereview.chromium.org/282223002/)

Reason for revert:
ConstrainedWindowViewTest.ClosesOnEscape introduced in this patch fails on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/31239/steps/interactive_ui_tests/logs/stdio

Original issue's description:
> Store and restore view focus in OnWindowFocused.
> 
> Mimic [Desktop]NativeWidgetAura::OnWindowActivated.
> Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls.
> (View focus changes update the TextInputClient as needed)
> Rewrite and enable related ConstrainedWindowViewTests.
> 
> Print GetLastError() in SendInput() error case for tests.
> (key presses get 5/ERROR_ACCESS_DENIED on locked desktops?)
> 
> BUG=368691,170331,177482,163931
> TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.).
> R=sky@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271249

TBR=sky@chromium.org,msw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=368691,170331,177482,163931

Review URL: https://codereview.chromium.org/289283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271281 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271270 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271265 0039d316-1c4b-4281-b951-d872f2087c98

Caused sync failures and check_licenses failure.

TBR=zty

Review URL: https://codereview.chromium.org/291743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271264 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271263 0039d316-1c4b-4281-b951-d872f2087c98

- Uploading from pure-svn and intending to commit manually to properly remove
  the directory from svn.
- Includes deps_whitelist change for new Skia DEP

R=iannucci@chromium.org, mkosiba@chromium.org, torne@chromium.org

Review URL: https://codereview.chromium.org/283163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271262 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Use real PlatformSupport in content unit tests (https://codereview.chromium.org/287043002/)

Reason for revert:
Caused mac_valgrind issues because TestWebKitPlatformSupport isn't cleaning up after itself properly

Original issue's description:
> Use real PlatformSupport in content unit tests
> 
> Once all pages are force composited by default, this allows these tests
> to not explode when trying to create GraphicsLayers because of a lack of
> Platform::compositorSupport.
> 
> BUG=none
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270894
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271229

TBR=piman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/290303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271261 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271260 0039d316-1c4b-4281-b951-d872f2087c98

Failing android browsertests for CanForwardRemoteStream720p

R=ckocagil@chromium.org
TBR=tomfinegan@google.com

Review URL: https://codereview.chromium.org/292573006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271259 0039d316-1c4b-4281-b951-d872f2087c98

UserContext offered a number of constructors aimed at specific use cases.
One of these ended up being used as a poor man's copy constructor that
took separate arguments to populate the various UserContext members. It
had already gotten out of sync with the full UserContext state (there are
8 members but this constructor copied only 6). The problem would likely
have become only worse in the future.

This CL replaces the existing constructors with a more well-defined set:
* A default constructor
* An actual copy constructor that copies all members
* A constructor that takes a |user_id|, which is required in almost all
  cases
The copy constructor also replaces the ad-hoc CopyFrom() method.

AuthAttemptState also offered several constructors, two of which took
credentials in the form of a |user_context| while one took |username|
and |password| separately. The CL combines these into a single
constructor that always takes credentials as a |user_context|.

BUG=367847
TEST=Updated unit and browser tests

TBR=pamg (chrome/browser/managed_mode/chromeos/manager_password_service.cc)

Review URL: https://codereview.chromium.org/290483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271258 0039d316-1c4b-4281-b951-d872f2087c98

This callback interface will replace the NOTIFICATION_GOOGLE_URL_UPDATED
notification once all clients have been converted. This CL converts
TemplateURLService and SearchProviderInstallData.

BUG=373236,373254,373258,373260,373253
TBR=brettw

Review URL: https://codereview.chromium.org/287103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271257 0039d316-1c4b-4281-b951-d872f2087c98

Instead of requiring every BPF policy to check IsValidSyscallNumber()
and return a fixed value when it's true, provide an alternative entry
point and guarantee that EvaluateSyscall() will only be called for
valid syscall numbers.

Review URL: https://codereview.chromium.org/293463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374349

Review URL: https://codereview.chromium.org/292593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271255 0039d316-1c4b-4281-b951-d872f2087c98

This cl depends on https://codereview.chromium.org/261753008

BUG=358657

Review URL: https://codereview.chromium.org/274743003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271254 0039d316-1c4b-4281-b951-d872f2087c98

The resource data is put into an in-memory instance of a net::DiskCache for now. That cache will be used for (some) subsequent starts of the worker in the current browsing session, but will not be used across browser restarts. The next step is to have the registration job store the resource ids with the registration data on disk and to also put the resource data to disk.

BUG=364318

Review URL: https://codereview.chromium.org/269373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:371878
TEST=verified with pepper plugin manually

Review URL: https://codereview.chromium.org/284853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271252 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371039

Review URL: https://codereview.chromium.org/275503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271251 0039d316-1c4b-4281-b951-d872f2087c98

BUG=374011,374011

Review URL: https://codereview.chromium.org/290693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271250 0039d316-1c4b-4281-b951-d872f2087c98

Mimic [Desktop]NativeWidgetAura::OnWindowActivated.
Simplify OnNativeBlur calls and OnNative[Blur|Focus] impls.
(View focus changes update the TextInputClient as needed)
Rewrite and enable related ConstrainedWindowViewTests.

Print GetLastError() in SendInput() error case for tests.
(key presses get 5/ERROR_ACCESS_DENIED on locked desktops?)

BUG=368691,170331,177482,163931
TEST=Automated tests; the focused Views change as expected between the browser, web contents, and web content modal dialogs (print preview, collected cookies, etc.).
R=sky@chromium.org

Review URL: https://codereview.chromium.org/282223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271249 0039d316-1c4b-4281-b951-d872f2087c98

These were missing from http://crrev.com/285343004, which added  two
new fields to AutocompleteMatch.

BUG=370192
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/290693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271248 0039d316-1c4b-4281-b951-d872f2087c98

This is mainly to prove my working env., but the bugs are real.

Thanks!

Review URL: https://codereview.chromium.org/288223006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271247 0039d316-1c4b-4281-b951-d872f2087c98