- 04 Jun, 2019 40 commits
-
-
Alexey Baskakov authored
Fix error handling if WebContents gets closed/destroyed or a blink renderer process dies. Drive-by: Avoid posting caller's callback to ThreadTaskRunnerHandle, let's PostTask with weak |this| and call the callback via std::move(calback) instead. Typically, an owner owns WebAppDataRetriever and posts Unretained |this| pointer for data retrieval completion. Bug: 901226 Change-Id: I3ed1928ae3acb0f5c89f62b7bfbe3772689ff7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637016Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#665834}
-
Maksim Sisov authored
Currently, WaylandWindow may attach a null buffer to a surface, which makes the Wayland compositor skip the buffer release call even though there was a buffer attached. The skipped buffer release call results in a missed submission callback, and the Chromium display compositor starts to lag behind one frame. What is more, we no longer trigger a buffer swap completion callback before presention feedback is provided, which also results in DCHECK when checking the order of the callbacks. Bug: 968497 Change-Id: I12494e78fa376d6c421b7366d0bddb52ae59a5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636354 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#665833}
-
Darren Shen authored
Causing failures on mac. TBR=hayato@chromium.org Bug: 970135 Change-Id: Ib8b96084ad5bfee19cabbe011524c7fa8419bf46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642611Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665832}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8893ef1b..cd6e781b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia67adbc2d4e83d086c129a8eecc5237dde7eeee9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643048Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665831}
-
Maksim Sisov authored
This is a prerequisite CL to make WaylandCanvasSurface listen to OnSubmission and OnPresentation callbacks. The following changes have been made to avoid code duplicates: * Added WaylandSurfaceGpu interface, which has two methods: OnSubmission and OnPresentation. * Moved RegisterSurface, UnregisterSurface, GetSurface from WaylandSurfaceFactory to WaylandBufferManagerGpu * Overrode WaylandSurfaceGpu methods in: ** GbmSurfacelessWayland and removed usage of WaylandSurfaceFactory. Now, everything is managed by the WaylandBufferManagerGpu instead. ** WaylandCanvasSurface and added NOTIMPLEMENTED. The idea is to propagate the results to a VSyncProvider and avoid tearing when submitting new frames. Bug: 963854 Change-Id: Ia91b359e505c152512db244b540d175ce1eeb0aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640977Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#665830}
-
Maksim Sisov authored
Wayland code uses "wayland" category. "Wayland" was added here by mistake. Thus, remove it. Bug: 578890 Change-Id: Ia8988559c6fc52177910c15a118ecd1602f21dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640409Reviewed-by:
Ehsan Chiniforooshan <chiniforooshan@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#665829}
-
Ramin Halavati authored
ContentSettingsPref and ContentSettingsPrefProfovider classes receive an |incognito| argument that actually triggers the off-the-record behavior and is not necessarily an incognito mode specifier. The argument and all related items are renamed to off_the_record to remove ambiguity. Bug: 968028 Change-Id: Ida0818f993baef9ebc3c9521d24c2b8ae2b10c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634729 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#665828}
-
Darren Shen authored
This reverts commit 207c5a51. Reason for revert: Possible culprit for 970084 Original change's description: > [ChromeDriver] Implements ExecuteAsyncScript promise-handling. > > Handles promises according to W3C-spec > (https://w3c.github.io/webdriver/#execute-async-script) for asynchronous > user scripts. This removes the global "result" object that contains > results of the latest script to execute and allows for scripts to wait > until results are ready before returning (instead of polling for > results after the script completes). > > run_py_tests.py. > > Tested: WPTs webdriver/test/execute_async_script, and python > Bug: chromedriver:2398 > Change-Id: I9f6cdeb5b3e93fcfd3e63090ce8b3aed275d71be > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636627 > Commit-Queue: Rohan Pavone <rohpavone@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665589} TBR=crouleau@chromium.org,johnchen@chromium.org,rohpavone@chromium.org Change-Id: I9e6c7aa0ac7f3df265c584a841afa9828a2cec4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:2398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642431Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665827}
-
Alexandre Courbot authored
This is a reland of 91b0391f. Original change's description: > media/gpu/v4l2svda: fix stateless API specification violation > > The stateless API states that resolution of frames should be set on the > OUTPUT queue, and the coded resolution read back from the CAPTURE queue. > However we were setting the resolution on the CAPTURE queue and > expecting the ioctl to update it to the coded resolution. > > This works with our current kernel drivers, but is not correct with > respect to the stateless codec API specification. The kernel drivers > have been updated to support the correct behavior, so carry that change > into Chromium as well. > > Bug: 948534 > Test: Checked that VDA unittest passes on Kevin and Minnie with kernel > driver fixes. > > Change-Id: I8f589f81ae1a7d8223235739f0748e58ac25e342 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553124 > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659876} Bug: 948534 Bug: 968392 Test: Checked that video_VideoSeek.vp8.switchres passed on Minnie. Change-Id: Id7b2e60947a275175622ac9cfcce3a604caeb0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635125Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#665826}
-
Takashi Toyoshima authored
This is a reland of 0fdf975b Original change's description: > OOR-CORS: Setup virtual layout tests for non OOR-CORS mode > > Now the OOR-CORS is enabled by default at m76, but we want to > run some of layout tests w/o OOR-CORS for the potential risk > to postpone the launch beyond the m76. Legacy code path should > work well until then. > > Bug: 905971 > Change-Id: Ife79c90a031c9b729c629509da83e1ff2ac2a2c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635081 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665506} NOAUTOREVERT=true TBR=yhirano@chromium.org Bug: 905971 Change-Id: I897730a276841da5c0b274ba446f84064ca8469b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642907Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#665825}
-
Yoichi Osato authored
This CL splits the interface to two parts so that WebRequestProxyingWebSocket or extensions proxy only handshake of WebSocket: interface WebSocketHandshakeClient { OnStartOpeningHandshake(WebSocketHandshakeRequest request); OnFinishOpeningHandshake(WebSocketHandshakeResponse response); OnAddChannelResponse(string selected_protocol, string extensions); }; interface WebSocketClient { OnDataFrame(bool fin, WebSocketMessageType type, array<uint8> data); OnFlowControl(int64 quota); OnDropChannel(bool was_clean, uint16 code, string reason); OnClosingHandshake(); OnFailChannel(string reason); }; Performance gain of receive-arraybuffer-1MBx100.html: Mine: 1050 ms ToT : 1221 ms Relanding: The previous patch was reverted because of a browser test of "--disable-features=NetworkService". This patch fixes it to adapt a WebRequestAPI test to both expectations. Reverted-change: https://chromium-review.googlesource.com/c/chromium/src/+/1628497 Bug: 865001, 942989 Test: browser_tests --gtest_filter=*ExtensionWebRequestApiTest* (--disable-features=NetworkService) Change-Id: I24d573c0a977d4557cc8c211900a110e73fb996e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630084Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#665824}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b75606a39adb..40ec586a32ab git log b75606a39adb..40ec586a32ab --date=short --no-merges --format='%ad %ae %s' 2019-06-04 tsepez@chromium.org Make fpdfdoc layer live above all of fpdfapi. Created with: gclient setdep -r src/third_party/pdfium@40ec586a32ab The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ia5465fb7e1acc11844c89420263866d67d23c10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640810Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665823}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9005e23a2639..bd002715a898 git log 9005e23a2639..bd002715a898 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 584b49b1..1070231d (665633:665750) 2019-06-03 sukhanov@webrtc.org Move datagram transport to JsepTransport Created with: gclient setdep -r src/third_party/webrtc@bd002715a898 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I50d9292906e6a0b892e6f9dfb00a4c5fb98ddf0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665822}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iab12971e8996897b10c96a62b2b776e6f6a3b666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665821}
-
Yuzu Saijo authored
This CL reverts back a part of https://chromium-review.googlesource.com/c/chromium/src/+/1627834 and making IPC task runner unfreezable for now. In the long run (after the next CL https://chromium-review.googlesource.com/c/chromium/src/+/1640738 is ready), it will be freezable again. This is just to make sure that we are not breaking anything by making the messages frozen. Change-Id: I97f06320dd9c65c1bc73e08fca55ca4aa4bfcfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642609Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#665820}
-
Alexandre Courbot authored
The stateless codec API requires us to set the resolution on the OUTPUT queue. This however can only be done if the queue is streamed off. Do this when changing resolution so we can conform to the stateless codec API. Bug: 968392 Test: Checked that video_VideoSeek.vp8.switchres passed on Minnie. Change-Id: I44e50fada7472d159b75711cde3fc0c5661e08e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635124Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#665819}
-
John Abd-El-Malek authored
Bug: 934009 NOPRESUBMIT=true Change-Id: Ib803d9eefd306ffb43f5550f9e9502668d0b6511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639350 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665818}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4c5f9b2027a6..4b1386c027fe Created with: gclient setdep -r src-internal@4b1386c027fe The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:967762,chromium:947531,chromium:947531 TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: Icd2b96ee9165b7cc033c8f172957104a37046f3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640746Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665817}
-
rajendrant authored
The WarmupURLFetcherCallback histogram could get recorded more number of times depending on retries. Bug: 969795 Change-Id: I13b65dfe4a0fd7a70047f912ff960c201c2eb719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641811Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#665816}
-
Abhijeet Kandalkar authored
ListHashSet is deprecated in favor of LinkedHashSet. HeapLinkedHashSet's invalidate iterators when the container is modified. This does not happen in this usage, so replacement is simple. Bug: 614112 Change-Id: I33452c4957e20babb222e6e0257cfd119e861896 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639725Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#665815}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0f6dd926..8893ef1b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76826d6563eaa4aa5e56796e91bb973a6e6c053e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641441Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665814}
-
Kenichi Ishibashi authored
Using CrossThreadWeakPersistent should be fine to hold a reference to an object that lives on the same thread, but there seems to be a mysterious behavior on CrossThreadWeakPersistent when we do that. To mitigate a risk of touching stale objects, use Member when we create WorkerResourceTimingNotifier for an inside fetch context. This is a speculative fix of crbug.com/959508. Bug: 959508 Change-Id: I28d398ece23973db67a20e9a8d864361c88c2b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638304 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#665813}
-
Maksym Onufriienko authored
Convert sync-methods to compile under EG2: -numberOfSyncEntitiesWithType -injectBookmarkOnFakeSyncServerWithURL -triggerSyncCycleForType -injectTypedURLOnFakeSyncServer -deleteAutofillProfileOnFakeSyncServerWithGUID Bug: 922813 Change-Id: I0b74ecf5061915c9424721845be830128956aea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628605 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#665812}
-
Kent Tamura authored
Our serializer detected serialization type with |node.GetDocument() .IsHTMLDocument()|. Usually it stays with a single value during a single serializer call. However, <template>'s content can be owned by a document different from the <template>. We should store serialization type detected with the specified node. * Change SerializationType enum items: kAsOwnerDocument / kForceXML ==> kHTML / kXML * SerializeAsHTMLDocument() doesn't need an argument. Also, rename it to SerializeAsHTML() for simplicity. Bug: 968079 Change-Id: I4e7b20068eb4518a53d0fbf0341fd114498a3231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640584Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#665811}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0183a1fe6c99..0f476788122d git log 0183a1fe6c99..0f476788122d --date=short --no-merges --format='%ad %ae %s' 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-06-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0f476788122d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie1e11dfe96fcb2a096b58cfd6018a2440ad77840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665810}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d8f5a88aa71a..455e2d59031c git log d8f5a88aa71a..455e2d59031c --date=short --no-merges --format='%ad %ae %s' 2019-06-04 gbiv@google.com artifact_stages: upload LLVM's HEAD SHA with PGO artifacts 2019-06-04 satyamsetti@google.com Issue 134067279: Enable CI builds for VCA COS image. Created with: gclient setdep -r src/third_party/chromite@455e2d59031c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I78ffbcb6e111f5cde5ce7e7ba12468416cdeb2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640808Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665809}
-
Wei-Yin Chen (陳威尹) authored
After Grid Tab Switcher (GTS) can be lazily cleared (added in http://crrev.com/c/1636621), when showing Tab-to-Grid transition animation while GTS is not cleared yet, a scrolling animation can be seen. This CL fixes that by disabling scroll animation when playing transition animation. Bug: 968822 Change-Id: Id067065808dfc40bd608b3b0c6b80ed735e547aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641809Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665808}
-
James Cook authored
This is a port of the "settings menu" tests from chrome/test/data/webui/settings/settings_menu_test.js For now, we have a similar menu, so we use similar tests. Change the browsePreload to chrome://os-settings/ so tests can load resources that only exist in the OS settings GRD. Bug: 967876 Test: browser_tests Change-Id: I12470ec43eeb0b1e588d1442ba26eacd6b5637b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636640 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#665807}
-
Yutaka Hirano authored
It's moved to platform/instrumentation/. Bug: 963306 Change-Id: Ifcfd77367705dcfcdc6ae6796b2759c46f45825c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642769 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#665806}
-
Darren Shen authored
This reverts commit 906024f5. Reason for revert: Perfetto roll seems to break compile: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911612852241220240/+/steps/compile/0/stdout?format=raw Original change's description: > tracing: Add thread names and types to perfetto traces and roll perfetto > > Roll src/third_party/perfetto/ fc15cad36..3cd1230c5 (6 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/fc15cad36895..3cd1230c5eb3 > > $ git log fc15cad36..3cd1230c5 --date=short --no-merges --format='%ad %ae %s' > 2019-06-03 ssid Fix idle_alloc.cc build > 2019-06-03 ssid Rename the thread names in ChromeThreadType to specify chrome > 2019-06-03 fmayer Update trace_to_text for heap_profile. > 2019-06-03 lalitm perfetto: add java proto targets and fix compile > 2019-06-03 lalitm docs: add toc entry and fix some links > 2019-05-31 fmayer Use IDLE bit instead of referenced bit. > > Created with: > roll-dep src/third_party/perfetto > > Depends on aosp/973864. > > Change-Id: Ib57d2b9005fea04673c133e8f5aed19fddcf4a29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637680 > Commit-Queue: ssid <ssid@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665798} TBR=ssid@chromium.org,eseckler@chromium.org Change-Id: I26be2dd8e6af0038f623d4b306124d2b54f758dd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642748Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#665805}
-
Emily Stark authored
This CL adds a new WebContentsObserver, LoginTabHelper, which observes completed navigations that have HTTP auth error status codes and associated auth challenge info. When LoginTabHelper observes such a navigation, it shows a login prompt on top of it. This is a step on the way to converting the HTTP auth interstitial to committed interstitials: when a main-frame cross-origin navigation receives an auth challenge, the HTTP body is committed (already implemented in https://crbug.com/963311), and the login prompt is shown on top of it (this CL). To accomplish this, this CL also includes some extra plumbing to surface the AuthChallengeInfo from the request. The AuthChallengeInfo is exposed on the NavigationHandle so that LoginTabHelper can read it and use it to trigger the login prompt. Bug: 963313 Change-Id: I9f0cdbf2a00efcfd5d9e4e3c629d9cc52746cc00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636985Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#665804}
-
Anand K. Mistry authored
The indicator is enabled using the show-loading attribute. This will be used by the SMB add share dialog to indicate that share discovery is occuring in the background. BUG=945188 Change-Id: I329e1c2192f54fb7c4338fb2fd7db0f811ff4e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631154Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#665803}
-
Bailey Berro authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1616999 hidden tag was removed making the "Connect to the internet to add a printer" string appear on the NFS settings page. This div should not have existed on the NFS page in the first place (whoops), but it wasn't showing up so no one noticed. Bug: 968840 Change-Id: If3f4418be2789e47951da6a2e27e6621f4e9b07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637999 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#665802}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fd813d113185..e5eebb43fb04 git log fd813d113185..e5eebb43fb04 --date=short --no-merges --format='%ad %ae %s' 2019-06-04 dberris@chromium.org SheriffRedux: Move config poller to main service Created with: gclient setdep -r src/third_party/catapult@e5eebb43fb04 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953181 TBR=charliea@google.com Change-Id: I07c2f7cd22fa6215b81f5958316150e6782a92ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640807Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665801}
-
Stefan Zager authored
A couple of flaky render throttling tests appear to have been un-flaked, probably by recent changes to the render throttling code, in particular this one: https://chromium-review.googlesource.com/c/chromium/src/+/1600078 timer-throttling-hidden-page.html turned flaky in 2015 and was disabled in 2017. In 2018, the test was changed to remove references to visibility=prerender, but the expectations were never updated (presumably because the test was disabled). BUG=956547,520170,956354 R=chrishtr@chromium.org Change-Id: Id49f0449a091b3ba548f64bc43576a16bce83e35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642031Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#665800}
-
Asanka Herath authored
DLOPEN_KERBEROS is a flag used to control whether the GSSAPI library should be loaded at runtime (via dlopen()) or linked to statically. The latter is used by some Linux distributions. Unfortunately this flag was not being passed to the net_unittests target, which resulted in the corresponding tests to not be compiled all these years. This CL moves DLOPEN_KERBEROS from being a compiler flag to being a buildflag in net_buildflag.h. This increases the visibility of DLOPEN_KERBEROS substantially, but is consistent with its sibling USE_KERBEROS. Ideally this buildflag should be called DLOPEN_GSSAPI which will happen after an announcement on net-dev@. Bug: 927182 Change-Id: I6d886595fcebabb222436113ea60f8879e08910d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639345 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#665799}
-
Siddhartha S authored
Roll src/third_party/perfetto/ fc15cad36..3cd1230c5 (6 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/fc15cad36895..3cd1230c5eb3 $ git log fc15cad36..3cd1230c5 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 ssid Fix idle_alloc.cc build 2019-06-03 ssid Rename the thread names in ChromeThreadType to specify chrome 2019-06-03 fmayer Update trace_to_text for heap_profile. 2019-06-03 lalitm perfetto: add java proto targets and fix compile 2019-06-03 lalitm docs: add toc entry and fix some links 2019-05-31 fmayer Use IDLE bit instead of referenced bit. Created with: roll-dep src/third_party/perfetto Depends on aosp/973864. Change-Id: Ib57d2b9005fea04673c133e8f5aed19fddcf4a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637680 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#665798}
-
Eric Willigers authored
The flag has been stable since https://chromium-review.googlesource.com/1175124 BUG=653531 Change-Id: I75a310aa9f92a08aa176bfe57e12e1e86c921d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616929Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#665797}
-
Wez authored
The WorkerThreadRegistry and its tests make invalid assumptions about PlatformThreadId values, leading these tests to flake, particularly on 64-bit platforms which do not recycle kernel object identifiers. TBR=falken@chromium.org Bug: 969562, 970088 Change-Id: I19fa473e08a7cec301944adc577c0df88ffab6a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640809Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665796}
-
Daniele Castagna authored
Exo exposes zwp_linux_explicit_synchronization wayland protocol that allows clients to request explicit synchronization for buffers on a per-surface basis. Exo protocol implementation currently waits for the fence on the CPU before sending the surface content to the display compositor. This CL propagates the in fence from Exo to the SharedImage implementation on the GPU service side and inserts a server wait on the actual GPU driver. Bug: 865708 Test: wayland_explicit_synchronization_client --use-drm=i915 on atlas Change-Id: I90f6eee8a959159a2342400918e3f75a8c38b783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611102 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Alexandros Frantzis <alexandros.frantzis@collabora.com> Cr-Commit-Position: refs/heads/master@{#665795}
-