- 27 May, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5b4c627389a6..f9826008618a 2020-05-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from 0c4ea014bf28 to 2bc4fcd9eba5 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I5dd66e0429bb847b3728555d24db52a7ca8a295c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772180}
-
Maksim Ivanov authored
Disable the non-fatal logging, because fuzzing triggers tons of such messages, which are useless and only slow down the fuzzing. Note that some of the logging spam - mainly caused by the SYSLOG macros - stays intact, since there's no easy way to disable those. Bug: 811690 Change-Id: I9f93b0e2450d8ff9ec7c7a9a8c88c3c23947e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215827Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#772179}
-
Jan Wilken Dörrie authored
TBR=mcasas Bug: 1086872 Change-Id: Iacb2b15812e91c24bf66f167a0f720d2a3096147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216773Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772178}
-
Friedrich Horschig authored
With this CL, the autofill popup isn't kept open anymore while unlocking the account suggestions. Instead, the flow changes to: 1. Store the popup state 2. Close the popup 3. Complete the reauth required for the unlocking 4. Reopen the popup from the stored state 5. Pin the popup so it waits for _potential_ updates Screencast in the linked bug. TBR=boliu@chromium.org,noyau@chromium.org TBR Reason: This change wraps the parameters for ShowAutofillPopup into a data object. It hides unused parameters but doesn't change anything on non-Desktop platforms. Bug: 1086170 Change-Id: I8220ca4fe1d57840c95dc2ee7bdf5f15f931f03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214391Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#772177}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I53e24ce80afe150ddaffe569537fd0cabdd7eed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215862Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772176}
-
Stephan Hartmann authored
Move assigment operator in ui::ColorSet is noexcept. Because this class has a member of type base::flat_map, move assignment operators of base::flat_map and base::flat_tree must be noexcept too. base::flat_tree noexcept is conditional to avoid build failure with NaCl. Otherwise GCC fails like this: ../../ui/color/color_set.cc:14:11: error: function 'ui::ColorSet& ui::ColorSet::operator=(ui::ColorSet&&)' defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification '' 14 | ColorSet& ColorSet::operator=(ColorSet&&) noexcept = default; | ^~~~~~~~ Bug: 819294 Change-Id: I10ce31851effc9ce78f2b5cbbb7148c339f065a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2179245 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#772175}
-
arthursonzogni authored
A DumpWithoutCrashing was added in CheckSandboxFlags. I suspected computing the sandbox flags from the browser process won't work on the first time, despite passing all the tests. It turns out this doesn't always work. The reason is unknown yet. The DumpWithoutCrashing() is triggered a lot. This patch removes it for now. TBR=mkwst@chromium.org BUG=1086734 Change-Id: I08497d51f80c1e9ffb3a37b64b6227fb01e2330c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217553Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772174}
-
Rouslan Solomakhin authored
Before this patch, C++ payment app implementations used an enum to denote their type to be used for app-specific logic, while Java used "instanceof". This prevented encapsulating multiple types of payment apps in a single wrapper, e.g., service_worker_payment_app.cc and android_payment_app.cc in a single JniPaymentApp.java wrapper. This patch expands the number of payment apps, exposes the payment app enum to Java, adds the type enum to PaymentApp.java class, and replaces "instanceof" with enum comparison in PaymentRequestImpl.java, where it makes sense. After this patch, both C++ and Java payment app types are defined in an enum, so JniPaymentApp.java can wrap multiple types of C++ payment apps internally. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I3636f83cda85c29113ad6bd0671b430c70c67a1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213405 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#772173}
-
Victor Hugo Vianna Silva authored
Bug: None Change-Id: I4382aa74e2c1de1f4186590bf35865491ad2e5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214554 Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772172}
-
Javier Ernesto Flores Robles authored
Updating preferred ContentSize inside updateViewConstraints was causing the popover arrow to not be pointing to the right place. Instead update the preferred size when the trait collection changes and before the view appears. There is still a bit offset when the bar button is bigger than the popover arrow and the button is on the screen margin. This is caused by the popover being also layout at the margin without space to center the arrow. Bug: N/A Change-Id: I10017b379c7688bea2cd6e514d0bf98a176c9c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215332Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1f72606..09f5f6d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2baaa5c5c1b6f04a42e9c464b4108df530499c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215920Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772170}
-
Anders Hartvoll Ruud authored
There's currently a bug where a transition on an element with appearance can cause these flags to disappear. This is because the cascade is applied (in full) _twice_ for style resolves where the base computed style optimization is not in use: the first apply produces the base computed style, and the second apply is the same as the first apply, except that it also includes animation effects. The problem is that the second apply can reset the flags if there's a transition (for example) for the property or properties to be set in the first apply round. For example, assume there's a regular declaration background-color:green. This causes HasAuthorBackground to be set after the first apply round. Then, in the second apply round, if there's an animation effect on background-color, then CascadeResolver::AuthorFlags will not have kBackground set, since transitions are not author declarations, and therefore the flag will be set back to false. Instead this CL makes the flags monotonic, such that we're not overwriting the flags later. This fixes a regression where artifacts are shown when transitioning UI elements. Note that it may seem weird that transition/animation declarations don't count as author declarations in this context, but this was done to match the old Blink behavior where transitions/animations also had no effect on the flags. Note also that the now-removed logic regarding Find/Reject/etc. in the if-statement is no longer needed. It was there because forced colors mode used a separate StyleCascade instance previously, which made matters a bit more complicated. However, this has since been changed, so the logic can be simplified. Bug: 1086732 Change-Id: I6e588a7e1d6805ab0a59a9a92bec0eb26e7120eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214552Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#772169}
-
Yoshifumi Inoue authored
This patch changes "drag-selected-image-to-contenteditable.html" to utilize |selection_test()| for ease of maintenance and help to implementing EditingNG. Bug: 707656, 679977 Change-Id: If75f018f18e30b392c8837c52f26ed267c17c5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195861 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772168}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590537495-1aec0e09840eb111f0a85749393637fa50872c10.profdata to chrome-win32-master-1590566295-b6fe751361b0ee5373100e3cddc0b82fdbd8c8ba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I814b2b36b3e20eb5194dff1e905a1ed4f0f6bda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216921Reviewed-by:
-
Omer Katz authored
These objects were never marked as fully constructed. Bug: 986235 Change-Id: Ia71abf4f8c118df29ccbd1e008d3ac484bdd6668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212162Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#772166}
-
Takuto Ikuta authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/7e8636295f47..90c5e17a8261 $ git log 7e8636295..90c5e17a8 --date=short --no-merges --format='%ad %ae %s' 2020-05-27 tikuta client: update cacert.pem 2020-05-21 tikuta client: update isolated client 2020-05-20 yekuang Cleanup: use assertNotIn instead of assertFalse 2020-05-20 yekuang Add @maybe_inject_user_agent decorator for the HTTP engines 2020-05-20 tikuta client: update isolated client Created with: roll-dep src/tools/swarming_client Bug: 944944 Change-Id: Ibacf839f4249b9aeabeda58ce4774fbd62e89373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216106 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Cr-Commit-Position: refs/heads/master@{#772165}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I6588232fe0a6e6d33a245fae9edf2598db34f950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215660Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#772164}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590551922-893b4e02197be5d53e80dcc9648783993fdfcda3.profdata to chrome-mac-master-1590566295-92309f25158961ce5d340e659f77e189eb24879f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3e5a5db88312f2a7d7c253bb1f9a13446ae935dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217463Reviewed-by:
-
Rijubrata Bhaumik authored
base/run_loop.h is only used in the test files, so use specific_include_rules in the DEPS accordingly. + some nits Bug: 897297 Change-Id: Ied0079aa6369c6b458e725a07458050ba8761588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214894Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#772162}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ia765946ac1c13882ce813c1769c1320a22f688eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217455Reviewed-by:
-
Sebastien Lalancette authored
When going from compact width to regular width, we swap the toolbar buttons. This allows us to add/remove buttons based on the screen constraints. Before iOS 13.5, setting the "items" property of a UIToolbar worked fine. However, in 13.5, this made the last button (Done button) to become non-responsive when going from compact width to regular width. Somehow, using the setItems:animated API fixes the issue. Tested on simulators: iPhone 13.5 and 12.4 iPAD 13.5 and 12.4 Bug: 1082723 Change-Id: Icde5b6760038560f9f8601af1afc328a4e2e4aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216285 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#772160}
-
Rune Lillesveen authored
There is no need for the extra call after ApplyAnimatedStandardProperties now that we trigger loading at the end of StyleForElement and PseudoStyleForElement. Also, we only need to have the extra loading for MatchedPropertiesCache case if when we actually add the ComputedStyle to the cache. Change-Id: I943c24f42f8ec945b901cdbf7572361dc68e280b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216076Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#772159}
-
Hiroki Nakagawa authored
This function declaration was added by the following CL, but wasn't implemented: https://codereview.chromium.org/1951853004 Bug: n/a Change-Id: I73657333974bca8255c40db94825660f1c6af949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215151 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#772158}
-
Yan, Shaobo authored
In CopyImageBitmapToTexture, it has high risk that user provided a gpu texture that has different color format with ImageBitmap backed texture/buffer. This patch leverage skia to do color conversion in CPU uploading path. Change-Id: Ie033f1e222f01cb02d455c54bac83fdfd7526c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199933 Commit-Queue: Shaobo Yan <shaobo.yan@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#772157}
-
Jan Wilken Dörrie authored
This reverts commit b7d9656d. Reason for revert: Tests are flaky on several builders, see https://crbug.com/1086794 Original change's description: > [Media History] Do not record background or muted watchtime > > Adds a fix so that Media History does not record > background or muted watchtime since they are not > useful to us (we only want foreground unmuted). > > BUG=1086511 > > Change-Id: I175c20ad88c136f291b72ae021b3cc22729bc5f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216375 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771995} TBR=dalecurtis@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: Ie59c985576436a2443448b4141cc51fd09f75176 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086511, 1086794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215828Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dfd24879a942..eaf51ab50b85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1069072 Tbr: tasak@google.com Change-Id: I12fa3985bd11a108bd948889159377d4e5053a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217325Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772155}
-
Jan Wilken Dörrie authored
Revert "[Sheriff] Disable MediaHistoryBrowserTest.DoNotRecordWatchtime_Background/0 and DoNotRecordWatchtime_Muted/0 flaky on 6 builders." This reverts commit 33fe2fc7. Reason for revert: Will revert original CL, rather than disabling on more platforms. Original change's description: > [Sheriff] Disable MediaHistoryBrowserTest.DoNotRecordWatchtime_Background/0 and DoNotRecordWatchtime_Muted/0 flaky on 6 builders. > > The builders are linux-chromeos-dbg, Mac ASan 64 Tests (1), Linux ChromiumOS MSan Tests, > Win7 Tests (dbg)(1), Linux Tests (dbg)(1), and Linux CFI. > > Bug: 1086794 > Change-Id: If0b9d37b3d4662880916f26b8acfc5612200e075 > Tbr: beccahughes@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216098 > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#772101} TBR=tasak@google.com Change-Id: Ieecb200736154d52763f397548bad284eae6eceb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217552Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/79dcb2a5abbd..9e718f962f87 2020-05-26 bclayton@google.com Update SPIR-V Tools to 55af3902f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ia7aca27e9fc8c9d084ae744ae9697dbbc54047ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217323Reviewed-by:
-
Jan Wilken Dörrie authored
This reverts commit de6734f7. Reason for revert: Likely culprit for https://crbug.com/1086863. Original change's description: > vma_wrapper: create VmaAllocator for vulkan 1.1.0 > > For vulkan 1.1.0, VmaAllocator will use dedicated memory > allocation for some big vulkan memory request, and free > it when the allocation is released. Without this change, > the VmaAllocator will allocate memory from self managed > memory blocks for all vulkan memory request. And the > memory may not be released when the allocation is > released. VmaAllocator may keep the memory for later > usage. It could be the reason for the memory regression > in fuchsia. > > Bug: fuchsia:52463 > Change-Id: I7b905435d31b927b2344724f8a2e1738e0544410 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215414 > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771927} TBR=penghuang@chromium.org,vasilyt@chromium.org Change-Id: I2bc3a572ff9e95b4dcb3cdd8bf7a9f6bb5969c0a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: fuchsia:52463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216254Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/6a029fc9d84e..55c85f66d2fd 2020-05-27 hao.x.li@intel.com Query API: Extensions 2020-05-27 xinghua.cao@intel.com Check FP16 support on vulkan backend 2020-05-27 jiajie.hu@intel.com Set a default value for dawn_glm_dir like other GN build overrides If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I10c75bd1e7f98df9b252e2f9c020afadd8fa06ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217329Reviewed-by:
-
Scott Little authored
The load-first-K-images-eagerly optimization (https://crbug.com/996963), which causes Automatic LazyLoad to avoid deferring the first K images encountered by the parser, should default to zero. This way, the default behavior will match the previous behavior without this optimization, and it'll be easier to experiment with other values as needed. Bug: 1086726 Change-Id: I806008bba93fee471a596f67842f5db1b3f0e0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216805 Auto-Submit: Scott Little <sclittle@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#772150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5c1a260a6cc9..1ba864348bde 2020-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 79dcb2a5abbd to 9e718f962f87 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I5bc6f8749a35b2a39abe1548790942433bdea12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217328Reviewed-by:
-
Bo Majewski authored
Adds .opus as a know extension for OGG files. Browser would return *.opus files as recent audio files, but file manager would not set the correct icon on them. Bug: 1067093 Change-Id: Ie14f06245004f96e6e86ba61353d0a3d7b584d09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215389 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772148}
-
My Nguyen authored
Update pref values in the toggle in smart_inputs setting page to enable/disable assist personal info. Bug: 1067108 Change-Id: I1595e2ae84dcc76d0819921f886ead9c019df965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213656 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#772147}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: Ic3150aaa466e7e114c6ad2f0d3e489453395be30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196131Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#772146}
-
dpapad authored
This fixes a runtime error thrown, when the search algorithm would force-render the password check subpage even when the PasswordCheck feature is not enabled. Fixed: 1086649 Change-Id: I82ed400713c85fa8c1a7fdd167a7219cebc5e731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216536Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b9e90b03da08..ea2ee251f623 2020-05-27 szuend@chromium.org Revert "Port IssuesModel to TypeScript" 2020-05-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-05-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-26 brgoddar@microsoft.com Automatic Symlinked workflow 2020-05-26 brgoddar@microsoft.com Memory: Disable failing snapshot test 2020-05-26 joselea@microsoft.com Devtools: Fix ally bug in Sources panel 2020-05-26 Rob.Paveza@microsoft.com ARIA submenus violation: Submenus should indicate they're submenus 2020-05-26 tvanderlippe@chromium.org Typecheck sdk/ChildTargetManager.js with TypeScript 2020-05-26 vidorteg@microsoft.com Fixing console placeholder in properties panel (Elements tab) 2020-05-26 tvanderlippe@chromium.org Disable webaudio test 2020-05-26 michael.liao@microsoft.com [Dom Storage]: Handle undefined storage case 2020-05-26 janscheffler@chromium.org Enable TypeScript in ScreenCaptureModel 2020-05-26 wolfi@chromium.org Port IssuesModel to TypeScript 2020-05-26 wolfi@chromium.org Port Resource.js to TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1058320,chromium:1066813,chromium:1079233,chromium:1081686,chromium:1084631,chromium:1086519,chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia4e74c9ae87ef0a0cb4f7ef9c494f4a71fa3af11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217327Reviewed-by:
-
Nicholas Verne authored
Some interfaces on multi-interface USB devices should be blocked from sharing with guests. The mechanism for this is a mask parameter sent to PermissionBroker for use when it opens the raw USB fd for the guest to use. The mask is a "drop privileges" mask that can only be used to narrow the privileges given to the fd. Change-Id: Ia37726384666a1b24e336d1e8b4ec66117b94384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196885 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#772143}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91637164. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I0e45944d791aa03e9dc7973223f8fcae5cbb930b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216740Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772142}
-
Dominic Farolino authored
R=kinuko@chromium.org Bug: 1086227 Change-Id: I32ba539f0c765f7c2248638738662a05081a675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212966 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
