GitLab

This was fixed in https://codereview.chromium.org/766523003

BUG=411235

Review URL: https://codereview.chromium.org/804903003

Cr-Commit-Position: refs/heads/master@{#308492}

BUG=442532, 433012
TBR=creis@chromium.org

Review URL: https://codereview.chromium.org/809553002

Cr-Commit-Position: refs/heads/master@{#308491}

This CL adds a setDesktopScale() method to ClientSession, allowing the JS console to be used to easily apply a new desktop scale factor, to be applied to the current session and all subsequent sessions to the current host from this client. If the connected host supports dynamic resize then desktopZoom changes will take effect immediately.

For example, a user with a Chromebook Pixel can set desktopScale to 2.0 to have a low-DPI host set to match the Pixel's physical resolution 1:1, rather than being set to match the logical resolution and up-scaled.

BUG=135089, 406100
TEST=Connect to Linux host w/ resize-to-client on & scale-to-fit *off*. Open Dev Console for app's main.html and run e.g. remoting.clientSession.setDesktopScale(scale) for different values of |scale|, and verify that: (1) |scale==0.5| gives a low-res desktop that is up-scaled to fill the client area. (2) on low-DPI devices, |scale==2.0| gives a normal-res desktop that is bigger than the client area. (3) on Pixel |scale==2.0| gives a desktop sized 1:1 to the device's native display resolution. (4) on Pixel |scale==3.0| gives a desktop scaled 1:1 to the device's native display resolution, and sized to be larger than the client area.

Review URL: https://codereview.chromium.org/761673008

Cr-Commit-Position: refs/heads/master@{#308490}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/41c9cbe..bc3d0de

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/795923004

Cr-Commit-Position: refs/heads/master@{#308489}

PERF-SHERIFFS: This patch will change all smoothness and SurfaceFlinger metrics on Android. Some metrics may go up or down significantly, with the new values being more accurate.

This patch cleans up the integration of SurfaceFlinger statistics by pulling the
raw timestamps into the timeline and calculating all metrics in
SmoothnessMetric. This approach also improves the metrics, because the
timeline ranges can now be properly bounded (no more percentiles!) and the
existing smoothness metrics can also use the more accurate SurfaceFlinger
timestamps.

BUG=351916

Review URL: https://codereview.chromium.org/765773004

Cr-Commit-Position: refs/heads/master@{#308488}

BUG=403138

Review URL: https://codereview.chromium.org/551823005

Cr-Commit-Position: refs/heads/master@{#308487}

Prior to this CL, if SendReplyAndDeleteThis is never called, the IPC::Message
gets leaked.

BUG=370588
R=jam@chromium.org

Review URL: https://codereview.chromium.org/766173003

Cr-Commit-Position: refs/heads/master@{#308486}

This pulls in the following Native Client changes:

r14202: (mazda) Non-SFI mode: Make nacl_helper_nonsfi build depend on libnacl_sys_private.a
r14203: (mazda) Fix stack alignment of child threads on ARM.
r14204: (jvoung) Switch -split-module-sched back to dynamic for the sandboxed case.
r14205: (jfb) Mark performance tests as broken  when running on VMs
r14206: (shyamsundarr) enable remaining disabled avx1 ops.
r14208: (dschuff) toolchain_build: Use 'build_noncanonical' target type for target libraries
r14209: (dschuff) Revert "toolchain_build: Use 'build_noncanonical' target type for target libraries"
r14210: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r14211: (bradnelson) Turn off graphing for pnacl-buildonly-spec.
r14212: (teravest) Always emit original sources from scan_sources.
r14213: (dschuff) toolchain_build: Use 'build_noncanonical' target type for target libraries

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk

Review URL: https://codereview.chromium.org/804143002

Cr-Commit-Position: refs/heads/master@{#308485}

BUG=432500

Review URL: https://codereview.chromium.org/798163003

Cr-Commit-Position: refs/heads/master@{#308484}

TBR=gcasto@chromium.org,vabr@chromium.org

Review URL: https://codereview.chromium.org/803353002

Cr-Commit-Position: refs/heads/master@{#308483}

Currently we are not serializing the data of a DecoderBuffer. The data will be
serialized into a separate DataPipe. Therefore, drop the data check in
MediaTypeConvertersTest.

See r307328 for details.

BUG=392236
TEST=This CL fixing failing tests.

Review URL: https://codereview.chromium.org/808633002

Cr-Commit-Position: refs/heads/master@{#308482}

That were otherwise filtered out (disabled) by the way depot_tools'
presubmit_canned_checks.py::CheckChangeLintsClean() worked.

As of
https://src.chromium.org/viewvc/chrome?revision=293357&view=revision, it
was changed, so clients can pass their own files and enable those that
were disabled.

BUG=None
TEST=None
R=tapted@chromium.org

Review URL: https://codereview.chromium.org/804763002

Cr-Commit-Position: refs/heads/master@{#308481}

BUG=440178

Review URL: https://codereview.chromium.org/785163002

Cr-Commit-Position: refs/heads/master@{#308480}

BUG=None
TBR=jamesr@chromium.org for mojo

Review URL: https://codereview.chromium.org/799113004

Cr-Commit-Position: refs/heads/master@{#308479}

Revert of Fix sandbox target in Windows GN build and enable it. (patchset #1 id:1 of https://codereview.chromium.org/804993003/)

Reason for revert:
breaks compile step on the win8 gn bot: http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/2037

Original issue's description:
> Fix sandbox target in Windows GN build and enable it.
>
> Committed: https://crrev.com/fdb4e8d624f1bfe1af5ccfebfa3faa0072caa71d
> Cr-Commit-Position: refs/heads/master@{#308471}

TBR=cpu@chromium.org,vchigrin@yandex-team.ru
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/810623002

Cr-Commit-Position: refs/heads/master@{#308478}

Add a baseline metric for the number of page reloads triggered by the
new pull-to-refresh gesture, allowing comparison with other avenues
for page reload (e.g., from toolbar reload icon).

BUG=442505

Review URL: https://codereview.chromium.org/803343002

Cr-Commit-Position: refs/heads/master@{#308477}

Needed for leveldb_main utility program to link.

Review URL: https://codereview.chromium.org/802633003

Cr-Commit-Position: refs/heads/master@{#308476}

Now we have real decoders abailable so MojoRendererImpl::Initialize() should
succeed.

Review URL: https://codereview.chromium.org/793973004

Cr-Commit-Position: refs/heads/master@{#308475}

Review URL: https://codereview.chromium.org/797813003

Cr-Commit-Position: refs/heads/master@{#308474}

- Quitting an app shim will close all associated windows.
- Closing all windows will quit the app shim.
- Can focus between Chrome and app shim windows.
- Can hide/show all windows associated with an app shim.

BUG=440651

Review URL: https://codereview.chromium.org/790043002

Cr-Commit-Position: refs/heads/master@{#308473}

BUG=438096

Review URL: https://codereview.chromium.org/804173002

Cr-Commit-Position: refs/heads/master@{#308472}

Review URL: https://codereview.chromium.org/804993003

Cr-Commit-Position: refs/heads/master@{#308471}

Otherwise it appears like nothing happened when a bookmark app is
created. This change does not affect bookmark apps created via sync.

BUG=441617

Review URL: https://codereview.chromium.org/804883002

Cr-Commit-Position: refs/heads/master@{#308470}

BUG=430194

Review URL: https://codereview.chromium.org/786813004

Cr-Commit-Position: refs/heads/master@{#308469}

The RelinquishGpuResource message from the browser process may
come before or after the rederer process closes it GPU channel.
As such, we need to wait until only the Browser GPU channel is
open until we can actually release the default off-screen
PBuffer surface and the EGL display.

This is a follow-up to https://codereview.chromium.org/712343003

Bug: 18724066
BUG=432268

Review URL: https://codereview.chromium.org/800103005

Cr-Commit-Position: refs/heads/master@{#308468}

Browser scheduler should trigger BeginFrame when children needs even if
it doesn't have a pending commit.

R=brianderson@chromium.org
BUG=372086
TEST=cc_unittests

Review URL: https://codereview.chromium.org/802353002

Cr-Commit-Position: refs/heads/master@{#308467}

No need to make a raster source that is never used.

R=enne, vmpstr
BUG=387116

Review URL: https://codereview.chromium.org/809433003

Cr-Commit-Position: refs/heads/master@{#308466}

ParseMethodAndError took a string as first param, but all callers started with a
Status object from which they derived the string. Simplified impl by just
passing in the Status object.

Review URL: https://codereview.chromium.org/805043006

Cr-Commit-Position: refs/heads/master@{#308465}

This test had been disabled because of failures in
smoothness.key_silk_cases, but these failures are no
longer reproducible locally or on the perf trybots.

BUG=404317

Review URL: https://codereview.chromium.org/791183002

Cr-Commit-Position: refs/heads/master@{#308464}

This reverts r304504.

TBR=jmadill@chromium.org
NOTRY=true
BUG=434033

Review URL: https://codereview.chromium.org/806773007

Cr-Commit-Position: refs/heads/master@{#308463}

See the bug to see the screenshot of problematic rendering
and the result of this fix.

There are several TODOs though:
- Renderers still remember the old font params.
- Changing hinting params will change the bounding box of the
  text, which means we should re-layout several views. This will
  be addressed by other CLs.
- Ideally, the font render params should change based on the display
  where the text is rendered.

BUG=441439
R=oshima@chromium.org, derat@chromium.org, msw@chromium.org
TEST=the new test case covers

Review URL: https://codereview.chromium.org/789583002

Cr-Commit-Position: refs/heads/master@{#308462}

WebRTC 7902:7905
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/e8dbbf4..25834b8

Libjingle 7898:7905
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/35f09c3..f99af5c

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/811553002

Cr-Commit-Position: refs/heads/master@{#308461}

This CL fixes the handling of the "." character in device names for audio
preferences. It also adds unit tests for the preference handler.

R=jennyz@chromium.org
BUG=294488,431133

Review URL: https://codereview.chromium.org/803303002

Cr-Commit-Position: refs/heads/master@{#308460}

There are several proposed content CLs which are making use of the MemoryPressureObserverChromeOS::GetCurrentPressureLevel() call to adapt dynamically to the current memory pressure. Examples: The |OomPriorityManager|, the |RendererFrameManager|, ...

BUG=440556
TEST=-

Review URL: https://codereview.chromium.org/800603002

Cr-Commit-Position: refs/heads/master@{#308459}

When looking for a RFH by last committed URL, there is no need to do a ForEach with a private FindFrame() predicate, since that logic is already available from a public FrameMatchingPredicate method in browser_test_utils.

BUG=

Review URL: https://codereview.chromium.org/807463003

Cr-Commit-Position: refs/heads/master@{#308458}

There should be no functionality change.

Previously autofill results were passed through as a set of three or four vectors:
  std::vector<base::string16>* popup_values,
  std::vector<base::string16>* popup_labels,
  std::vector<base::string16>* popup_icons
  std::vector<int>* identifiers
all of which have to stay in sync. This makes it impossible to add metadata, function calls are ugly, and the code is error prone. As part of wallet credit card autofill, we'll need to add more metadata here.

This patch replaces this with a new autofill::Suggestion struct containing all of the information, and pipes this around to all the affected places. It also adds a new SuggestionBackendID struct to replace the old GUIDPair typedef which makes the code clearer.

There are three types of IDs for autofill suggestions which is kind of confusing: a GUID created by the database which is actually a GUID + an integer (GUIDPair typedef in the old code), an integer ID used by the frontend and IPC, and an intermediate integer used by the autofill manager to create the frontend int ID.

This patch adds the GUID and frontend integer ID to the new Suggestion class as the backend_id and frontend_id. It is kind of confusing to have two different types of IDs in the same class, and previously most code dealt with only one or the other. But I think the code is much cleaner not having to keep separate parallel lists of IDs all over the place.

Unified the naming in the autofill popup controller. It previously used name/subtext and now that it uses the standard Suggestion struct, I changed them to value/label to match everything else.

Added constants for the card types used by RequestAutocomplete

Added some additional stuff to the CreditCard class for wallet sync. Add additional members to the autofill table for wallet card manipulation. These are currently unused.

Review URL: https://codereview.chromium.org/772253003

Cr-Commit-Position: refs/heads/master@{#308457}

R=lcwu@chromium.org,damienv@chromium.org
BUG=408189

Review URL: https://codereview.chromium.org/802833002

Cr-Commit-Position: refs/heads/master@{#308456}

Using "x()" in TupleLeaf's default constructor causes primitive types
(e.g., integers and pointers) to be zero initialized, whereas
previously Tuple left them indeterminate.  Arguably zero-initializing
is better, but the change was inadvertant and results in a measurable
code size increase, so this CL reverts it (at least for now).

BUG=440806

Review URL: https://codereview.chromium.org/791883003

Cr-Commit-Position: refs/heads/master@{#308455}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/70c04a5..5450ee0

TBR=lushnikov@chromium.org,vsevik@chromium.org,dglazkov@chromium.org,beverloo@chromium.org

Review URL: https://codereview.chromium.org/809483004

Cr-Commit-Position: refs/heads/master@{#308454}

BUG=441561

Review URL: https://codereview.chromium.org/797113002

Cr-Commit-Position: refs/heads/master@{#308453}