- 28 Jan, 2020 40 commits
-
-
Guido Urdaneta authored
This policy allows enterprises to disable screen sharing (desktop, window or tab) via the getDisplayMedia() and extension APIs. Bug: 1003720 Change-Id: Ie4271e7e6cf29f670f3730cae8119800520e6b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025347Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#736121}
-
Yi Gu authored
This reverts commit 4717f398. Reason for revert: Broke ios-simulator-xcode-clang bot. See https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8889981707645765280/+/steps/compile/0/stdout Original change's description: > Basic implementation and tests for HangWatcher. > > This class is a successor to ThreadWatcher which aims to be more > versatile and provide a larger coverage for hang watching. > > Bug: 1034046 > Change-Id: I365fe8824eb34c37c75e6ddf6874ff26ecd494c6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008189 > Commit-Queue: Oliver Li <olivierli@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736080} TBR=fdoray@chromium.org,olivierli@chromium.org Change-Id: I88af4ad3baf02af94adcc0770168ce7adc7ede45 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026174Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736120}
-
Elly Fong-Jones authored
Bug: None Change-Id: I90a426425fd15b06ea935b17be00094dcd0a5d01 Tbr: agrieve@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025788 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736119}
-
Manu Cornet authored
Also calculate the new hotseat state as part of calculating new target bounds instead of passing it in. Bug: 1042911, 1040177 Change-Id: Ie3471df435ba9ce49130e528811c17da0e249b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025428 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736118}
-
Darwin Huang authored
Bug: 1045591 Change-Id: I9d9b169f2abc286c84f0906658e9be9b8af31791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020406Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736117}
-
Tommy Li authored
Currently, the on-focus configuration in fieldtrial_testing_config.json is in the "NTPZeroPrefixSuggestions" trial. The problem is that about_flags.cc configures on-focus suggestions with the "OmniboxBundledExperimentV1" field trial. This mismatch between fieldtrial_testing_config.json and about_flags.cc causes a crash. It's most proper to match what's in fieldtrial_testing_config.json and about_flags.cc. We won't be able to match the server-side config all the time, since Dev/Canary uses the "unbundled" experiment format, and Beta and Stable use the "bundled" experiment format. But so long as fieldtrial_testing_config.json and about_flags.cc match, the client-side code is correct. Bug: 1015174 Change-Id: I93fd6cf6392f3de2a0e326bbdfe736bb9a10acc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019329Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736116}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8c52e8a2efb0..ed9a401f277b git log 8c52e8a2efb0..ed9a401f277b --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 01683979..5146474c (735581:735951) Created with: gclient setdep -r src/third_party/webrtc@ed9a401f277b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I66916bf3af6ef66fee2b3c40007163be6ddf7d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025699Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736115}
-
Nick Diego Yamane authored
This fixes libgtkui-based file dialogs support on Ozone X11 and prepares X11 event source implementations for the upcoming PlatformEvent migration CLs. Further details: CL standardizes the X11EventSource interface (i.e: Support XEvent => ui::Event translation, XEvent specific dispatchers and observers, etc), moving most of the code out of the default delegate implementation into X11EventSource itself. 2 reasons motivate this change: 1. Gtk-based file dialogs do not work in Ozone X11 with FdWatch-based source. So, as an initial fix, this CL makes it possible to use the pure glib-based implementation (i.e: uses glib API, GSource directly, etc) in Ozone builds with use_glib=true. FdWatch-based impl, originally used in ozone-based products, misses some events because it does not use the XPending() function to check for new events (instead it only watches for X11 connection FD changes). Thus, with this change, pure glib-based X11 event source is used in Ozone when use_glib GN arg is set explicitly, otherwise the fdwatch-based one is used (e.g: CrOS on Linux). 2. It is a preliminary and required step for the upcoming PlatformEvent migration CLs [1]. As one of the first speps of the migration, event source must support the same API and logic as the one originally used in ozone, as described above. As, at this point, it still must support the non-Ozone path (where PlatformEvent is still defined as XEvent*), Ozone specific code is guarded under USE_OZONE build flag. As a side effect, this simplifies a lot of X11EventSourceDelegate impls so that they turn into XEvent "watchers" instead, so this CL also renames them accordingly. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=965991 Bug: 1008755, 963419 Change-Id: I060ec0dab519590e485e5baa96b5e84a7afad5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863940Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#736114}
-
Arthur Wang authored
R=harringtond@chromium.org Bug: 1044242 Change-Id: I05b9eb75f8d1ae507492fbdb987e44719e9b2bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016188Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#736113}
-
chrome://settings/settings_v3.htmlDemetrios Papadopoulos authored
- Modify Settings data source to serve generated files. - Add top-level JS/HTML files that will host the V3 version. - Use a JS import for the generated chrome://settings/search_settings.m.js as a proof of concept. - Update BUILD.gn files as needed. Note that the dummy page is currently only available for optimized_webui=false builds. This is in preparation of migrating to Polymer 3. Bug: 1026426 Change-Id: I53dc831bfad3cf4645fa91c643bd5e34d14190de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024161 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#736112}
-
sczs authored
- Creates SaveCardInfobarMetricsRecorder inline with other Infobars, to record Save Card infobar specific metrics. - Creates Mobile.Messages.Save.Card.Modal.Event and its enum to record when a user starts editing any of the editable fields Bug: 1029067 Change-Id: Icc2588dad0578d8c232baa720b74585a15f5ef4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024282Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#736111}
-
Henrique Nakashima authored
TBR=pasko@chromium.org NOTRY=true Bug: 1033305 Change-Id: Ic5595b4315cd98ee92de1d820ffcfda81fc1a58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026149 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#736110}
-
Sami Kyostila authored
Remove the deprecated trace id mangling facility and convert the last remaining uses to the new API as follows: TRACE_ID_MANGLE() => TRACE_ID_LOCAL() // Process-local id. TRACE_ID_DONT_MANGLE() => TRACE_ID_GLOBAL() // Cross-process id. Test: Checked that a trace with input flow events still looks correct. Bug: 639003 Change-Id: I2493e89787a49368528f844e8d37cfd120558fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016648 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736109}
-
Yi Gu authored
The test is currently linked to a general purpose bug which has been marked as wont fix. This patch links it to a new bug to track the fix. TBR=aaronhk@chromium.org Bug: 1045346 Change-Id: Ib15d2f362b1c39e2e635a609dad922095b1088ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026108Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736108}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7488a0964115..4a8fa19f0574 git log 7488a0964115..4a8fa19f0574 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 spang@chromium.org Fuchsia: Switch to gfx_tests sandbox configuration 2020-01-28 shrekshao@google.com Turn on clampArrayAccess globally but off for compute shaders 2020-01-28 jmadill@chromium.org D3D11: Fix uninitialized BufferEx SRV. 2020-01-28 jmadill@chromium.org Fix overlay build. 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-headers/src 881bbb347a08..726435870206 (1 commits) 2020-01-28 ianelliott@google.com Vulkan: SwiftShader now getting correct sample positions 2020-01-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 1b3441036a8f..97f1d485b763 (1 commits) Created with: gclient setdep -r src/third_party/angle@4a8fa19f0574 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1042252 Tbr: tobine@google.com Change-Id: If355a57e253e59a906fb54cd74f9eb1c80fc8b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736107}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/153a537a3f87..6c3dc3581eaf git log 153a537a3f87..6c3dc3581eaf --date=short --first-parent --format='%ad %ae %s' 2020-01-28 capn@google.com Support LLVM 8+ build changes Created with: gclient setdep -r src/third_party/swiftshader@6c3dc3581eaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9a1a4055a5689f4fa52d0efe5486253873ecccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736106}
-
Oriol Brufau authored
If a ::marker has the 'content' property set to something different than 'normal', then the contents of the marker should be determined according to that value, not from 'list-style-type'. Before this patch, the behavior was already correct when laying out the marker for the first time. But if 'list-style-type' changed afterwards, the marker was updated to reflect the new value, ignoring 'content'. BUG=457718 TEST=external/wpt/css/css-pseudo/marker-content-021.html The test fails in legacy since 'content' is not supported yet. Change-Id: Id845774739927c9c574a66e9d1cc94e6ea59d5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020957Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#736105}
-
Sigurdur Asgeirsson authored
Also run all events through serialization and deserialization in the ports_unittests to make sure new event types go through this in a unittest. Bug: 1003391 Change-Id: I3347308db5e1c339b9f639b1cb32a5d41600d97b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024185 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#736104}
-
Dominic Mazzoni authored
This is a follow-up to http://crrev.com/c/1970742 - it adds a new interfaces to read the structure tree from PDFium, then generates a tagged PDF using the new command-line flag and tests that the resulting PDF file has the correct structure tree. Bug: 607777 Change-Id: I796b15ea477ae4e20099e95982430fe770166577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970744Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#736103}
-
Francois Doray authored
This reverts commit 015752ce. Reason for revert: Adds unnecessary complexity. Reverting it to simplify moving TabLoadTracker to PerformanceManager. Original change's description: > [tabloadtracker] Mark a visible tab as LOADING when navigation starts. > > The goal is to ensure that a policy that reduces background work when > a tab is loading is applied as soon as possible. In particular, on > startup, we don't want background work to start before the first tab > has received a response. > > We want to move TabLoadTracker to the PerformanceManager. However, > that shouldn't block experimenting with no background work when a > tab is loading. > > Bug: 839110 > Change-Id: Idf59ef95192200e76e3fe387fb76adab88ad85a0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906508 > Reviewed-by: Chris Hamilton <chrisha@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719364} TBR=chrisha@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839110 Change-Id: I23d9a9eccc2a20bd0b1513ece6b7f519c20a5988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017922Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#736102}
-
Sean Gilhuly authored
Simplify GpuProcessStartAllowed(), currently it returns false on Windows with GPU and swiftshader disabled, or on Chromecast with the flag --disable-gpu. This matches exactly when |gpu_mode_| is GpuMode::DISABLED. The test GpuStartsWithGpuDisabled has a special case for Chromecast audio-only builds, but it isn't run on Android Chromecast. Separate out the Chromecast-only test. Also fix a couple of typos. Change-Id: I166bf1c7f482e7b97c31ed607949044f3ef7ac6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023949Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#736101}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/912cec0c6822..109232bcf479 git log 912cec0c6822..109232bcf479 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 chshrest@microsoft.com [Elements]: Fix keyboard accessibility in color-picker Created with: gclient setdep -r src/third_party/devtools-frontend/src@109232bcf479 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id1bab803d488ea07cdf4f58e20efe88940b13fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736100}
-
Martin Šrámek authored
This enum must be kept in sync with the histogram of the same name in resources/settings/metrics_browser_proxy.js, but it's currently not. This causes a DCHECK when settings attempt to record this value. Bug: None Change-Id: If04dc1d3852854a02659d9bd056f10eafe80b8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025668Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#736099}
-
Bailey Berro authored
This change extendes the life of the ShowTaskManager histogram through M85 and updates the owner to zentaro@. Bug: 1036944 Change-Id: If6d48d26771a003a3c8a9cca9a68b46b4fc58c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992203 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#736098}
-
kylechar authored
SkiaOutputSurfaceImplOnGpu needs to make the GL context current before asking skia to check readback completion. Also avoid checking for completion if there are no readback requests pending and immediately after issuing the async request. Bug: 1040643 Change-Id: Ia78363c476dc697ce35dce24fab881e2a60c264e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025644Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736097}
-
Greg Kerr authored
This adds a new command line value (to the --scheduler-configuration flag) so that Chrome can be configured to allow SMT by default on certain chipsets. The new command line flag value is added so that session_manager, which knows the board and chipset, can configure Chrome to allow SMT by default on certain hardware. Users and admins can still override this with their own policy. BUG=b:147685035 Change-Id: I75f034e6c0a47f7e1ce71d5f7514f7945b71ceac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008609Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736096}
-
Wez authored
Bug: 829551 Change-Id: I0461ced34730e216a0d4a64383448c0008f36ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020772 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#736095}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 81-3987.39-1579516543-benchmark-81.0.4019.0-r1 to 81-4025.0-1580122052-benchmark-81.0.4019.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I908bfa68eb8cdecf3561cde0199bee99c0b21ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026018Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736094}
-
David Benjamin authored
If DoLoop() returned synchronously in ReadBufferingStreamSocket::ReadIfReady(), the data was never copied to the user buffer and we return zero. Instead, pull copying out of DoLoop(), which is now only responsible for filling the internal read_buffer_. The caller then handles the output portions. This bug has been there since we introduced ReadIfReady, but probably SpawnedTestServer was too slow to ever trigger this race condition. Now it uses EmbeddedTestServer which is faster. Bug: 1021109 Change-Id: I829d22e96de356679501dd175b5549296503b5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023478 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#736093}
-
Luum Habtemariam authored
Per bug below, this change adds the Printing.CUPS.InvalidPpdResolved metric to follow this issue as its resolved. Bug: chromium:1046125 Test: updated sync test passes Change-Id: Idc4c633d2859096e80de8c7648a34112fc96d87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015832 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#736092}
-
Chan Li authored
This reverts commit 43fcd55d. Reason for revert: Suspecting this change caused the compile failure at https://cr-buildbucket.appspot.com/build/8889983375245058816. Original change's description: > [Android] don't map zh-hk to zh-tw in bundle builds. > > To give Clank language parity with Android 27 new locales are being > added. 26 of those locales have been added in two previous CLs: > > - https://crrev.com/c/1941058 > - https://crrev.com/c/1952288 > > zh-hk was skipped because currently resources for it are mapped to > zh-tw. This CL skips that mapping for bundle builds where zh-hk is > now included. zh-hk is still mapped to zh-tw in apk builds. > > There is an increase in size even when language splits are used in > bundles. A bug has been created to look into this: > - APK Bundles wastes a lot of space in resources.arsc (400kb) > - https://crbug.com/1031645 > > Bug: 1034774 > Binary-Size: Size increase is unavoidable (see above). > Change-Id: I4edb9d5213e8dd3443522deee5395e500af34371 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970258 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: (gone) Eric Stevenson <estevenson@chromium.org> > Commit-Queue: Trevor Perrier <perrier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736071} TBR=yfriedman@chromium.org,tedchoc@chromium.org,agrieve@chromium.org,estevenson@chromium.org,perrier@chromium.org Change-Id: I6748ad1e997bb5e2e05d6a99a52fd3e3595253fd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026151Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736091}
-
kylechar authored
This reverts commit 61bb69af. Reason for revert: Removing debug instrumentation before branch. Original change's description: > Add debug BeginFrame tracking > > Add some temporary member variables to BeginFrameTracker that stores the > total sent/received and the last 10 sent/received BeginFrameIds. Despite > adding logic to stop sending OnBeginFrame() to unresponsive clients it > didn't help with the large number of unread messages in mojo message > queue. This information will do a better job of verifying if client is > in fact reading (and responding to) the OnBeginFrame() messages. > > The |begin_frame_tracker_| is included in a few minidumps I looked at > it, so this information should be available in crash reports. Otherwise > we'll have to copy the information into the stack in OnBeginFrame(). > > Bug: 1011441 > Change-Id: I44112d933fb4470fb037e7bfd2d9dc05dd826a94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994093 > Reviewed-by: Saman Sami <samans@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#730310} TBR=kylechar@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1011441 Change-Id: I3c7d5572c19ede7d653d24175d7023e7a7e282c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025768Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#736090}
-
Alex Turner authored
Adds the --record-histogram benchmark command line argument to the ad_tagging.cluster_telemetry benchmark. This allows for specifying additional UMA histograms to record without generating a patch. Bug: 1046108 Change-Id: I95a4d1bc2e5bda91e5147a0cfd65999baca5bf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025530Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#736089}
-
Alex Turner authored
The current PercentAds/PercentAds2 metrics only consider resources in ad frames and are not recorded for pages with no ad frames. These are renamed to PercentAdFrames to make their definition clearer. We add the PageLoad.Clients.Ads.AllPages.PercentNetworkBytes and PageLoad.Clients.Ads.AllPages.PercentTotalBytes histograms, which are logged for all page loads with non-zero bytes and which includes all ad resources in its calculation. They will be used as overall metrics for tracking filter list accuracy. Currently, the metric used is a percentage of aggregate bytes across various page loads. The new metrics will be less affected by outliers as each page's influence on the average percentage will be the same, rather than weighted by number of bytes. Bug: 1045120 Change-Id: I59beccbcf96394d584ddc6293e7d0c7f379892bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018162Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#736088}
-
Daniel Rubery authored
To accommodate a possible need to separate these handlers on the backend, Chrome will send APP deep scans to a different URL than WebProtect deep scans. Bug: 1020418 Change-Id: Icf859f1d746118a16de1677e74e27bf50593a37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024697Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#736087}
-
Thomas Lukaszewicz authored
Fixed a bug where boundary calculations used to determine whether a tab belongs to a given tab strip were not taking into account RTL mode. TabDragContext now specifies both a begin and end x coordinate to use for bounds checking. Bug: 1044868 Change-Id: I6f73f681605f202e189356a6cb917f2522cecbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024492 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736086}
-
David Bokan authored
Change-Id: I3d894ec6faeef8b1d7243bb2721fe66b58c4ace8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023522 Commit-Queue: David Bokan <bokan@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736085}
-
Reilly Grant authored
These metrics are being used to track the results of an experiment to use the new ISensor API on Windows 10 clients. This should launch to 100% in M-81 or M-82. Bug: 1036868 Change-Id: If5842f698e812b345065aa711ccd09483b4b616b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024544 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#736084}
-
Findit authored
This reverts commit d5274dbb. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 735947 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDUyNzRkYmI0OGZlMDU2ZGRmNmFlMWNmZjQ2YjQ3OTVkNTU1NDFmOQw Sample Failed Build: https://ci.chromium.org/b/8889996165162517568 Sample Failed Step: browser_tests Sample Flaky Test: SecurityTokenSamlTest.Basic Original change's description: > Reland Add browser tests for smart card SAML login > > This relands the commit 8fd76b23 that > got reverted in commit 319c9b41 due to > failing on official trybots. > > The fix in the reland is to suppress the sync consent screen that is > normally enabled on the "branded" builds and that was breaking test > expectations (the test expected the user session to start straight away > after the successful authentication without any extra screens). > > Original change's description: > > Add browser tests for smart card SAML login > > > > Provide test coverage for the scenario where a new user authenticates > > via SAML using a smart card (or, generally speaking, using a security > > token via an extension using the chrome.certificateProvider API). > > > > This also provides some test coverage for the <security-token-pin> > > Polymer element used on the Login Screen. > > > > Bug: 1033936 > > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914 > > Reviewed-on: > https://chromium-review.googlesource.com/c/chromium/src/+/1968989 > > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#734510} > > Bug: 1033936 > Tbr: alemate@chromium.org, hendrich@chromium.org > Test: run the test locally with is_chrome_branded=true > Change-Id: I0e8394bb78030137c7570d58c2462a773c13ce06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017430 > Commit-Queue: Maksim Ivanov <emaxx@chromium.org> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#735947} Change-Id: Ifc621efff2f069cd90b25f9fff6d778a6732c2c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1033936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025885 Cr-Commit-Position: refs/heads/master@{#736083}
-
Ian Kilpatrick authored
Previously if a fragment didn't provide a baseline, and had baseline alignment we wouldn't consider it as having the default baseline. This was incorrect. Causing fast/css-grid-layout/grid-baseline.html to fail when FlexNG was turned on: https://test-results.appspot.com/data/layout_results/linux-rel/294412/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html Instead this patch changes the flex baseline propagation logic to prefer any flex-item with baseline alignment, even if we have to synthesize the baseline. Bug: 845235 Change-Id: I4cc40da42a8d6be41b028f1170246b8004f0654d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024546Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#736082}
-