GitLab

This eliminates the need for using gn executable wrapper in cases
where a custom script interpreter is always being used.

Review-Url: https://codereview.chromium.org/2936773006
Cr-Commit-Position: refs/heads/master@{#481105}

Bug: 695939
Change-Id: I6afd1044629edb5771c28be162bd15bd63898863
Reviewed-on: https://chromium-review.googlesource.com/541117Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481104}

Revert of update content_browsertests filter for --enable-network-service (patchset #1 id:1 of https://codereview.chromium.org/2949693002/ )

Reason for revert:
It should be fixed by https://chromium-review.googlesource.com/c/540999/.

Original issue's description:
> update content_browsertests filter for --enable-network-service
>
> TBR=rdsmith@chromium.org
> NOTRY=true
> Bug=729849
>
> Review-Url: https://codereview.chromium.org/2949693002
> Cr-Commit-Position: refs/heads/master@{#480659}
> Committed: https://chromium.googlesource.com/chromium/src/+/abd930241ad01df52b3f9171f53040ca2c3cb401

TBR=rdsmith@chromium.org,scottmg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Bug=729849

Review-Url: https://codereview.chromium.org/2951933002
Cr-Commit-Position: refs/heads/master@{#481103}

This patch changes the following storage_only fields to be primitive
or external fields:
- flex-basis
- flex-grow
- flex-shrink

so that their getters/setters can be generated.

Diff: https://gist.github.com/cdc56f6747da1a925498c52831557fa2/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2943413003
Cr-Commit-Position: refs/heads/master@{#481102}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/88178697..1c4fcefc

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2951033002
Cr-Commit-Position: refs/heads/master@{#481101}

-Adds accessibility labels for all ToolbarButtons.
-Creates Showcase EG tests for the ToolbarVC.

BUG=683793

Review-Url: https://codereview.chromium.org/2936773003
Cr-Commit-Position: refs/heads/master@{#481100}

The cr-action-menu element previously cached its child elements during
attached. This was causing errors in MD Bookmarks, which has a
action-menu which stamps its children in a dom-repeat (which will happen
asynchronously after attached).

This CL removes the cache so that cr-action-menu checks its children
during keyboard navigation. This allows items to be added and removed
dynamically while preserving correct keyboard navigation.

Bug: 729939
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5b438d06a1e711c3f943b17d0e495ef557eec5c7
Reviewed-on: https://chromium-review.googlesource.com/528033
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481099}

Currently, GpuJpegDecodeAcceleratorFactoryProvider class is declared inside
gpu_jpeg_decode_accelerator.h. This CL moves it outside to its own file.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic57e6a689923798d269d27129a3d8e9bca16f4aa
Reviewed-on: https://chromium-review.googlesource.com/536219Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Chandan Padhi <c.padhi@samsung.com>
Cr-Commit-Position: refs/heads/master@{#481098}

Cr-Commit-Position: refs/heads/master@{#481097}

This patch includes the following things:
  - Make WebKitCSSMatrix an alias of DOMMatrix (Reland the revert patch[1])
  - Enable GeometryInterfaces by default (DOMMatrix, DOMPoint, DOMRect, DOMQuad)
  - Remove unnecessary runtime flag in CSSMatrixComponent.idl.

[1] Reverted patch: https://codereview.chromium.org/2943213002

Intent to ship:
  https://groups.google.com/a/chromium.org/d/msg/blink-dev/cAiTOdSGyes/Su7dlx32EQAJ

BUG=388780

Review-Url: https://codereview.chromium.org/2938413005
Cr-Commit-Position: refs/heads/master@{#481096}

Revert of Use CTFontCreateForString for RenderTextHarfbuzz on Mac (patchset #5 id:80001 of https://codereview.chromium.org/2927953003/ )

Reason for revert:
Causes views_unittest LabelSelectionTest.MouseDragSingleLineRTL to fail on 10.10 and 10.11

Original issue's description:
> Use CTFontCreateForString for RenderTextHarfbuzz on Mac
>
> The approach ends up pretty close to what's already done for Windows.
>
> On Mac, CTFontCreateForString() gives better fallbacks (i.e. they more
> often match what native UI does) and requires RenderTextHarfbuzz to do
> less work. However, it doesn't guarantee that the returned font can
> display every glyph in the provided string.
>
> So still use CTFontCopyDefaultCascadeListForLanguages (which is now a
> public API - hooray) to provide a last-resort list of fallback fonts.
>
> BUG=696867, 619684
>
> Review-Url: https://codereview.chromium.org/2927953003
> Cr-Commit-Position: refs/heads/master@{#481062}
> Committed: https://chromium.googlesource.com/chromium/src/+/62cbc10d4dbfeed614eb23c3d996793814a35334

TBR=asvitkine@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=696867, 619684

Review-Url: https://codereview.chromium.org/2950013002
Cr-Commit-Position: refs/heads/master@{#481095}

This adds PageLoad histograms targeted for page loads that had other
loading tabs when the navigation started. This would help to understand
the impact of request throttling.

BUG=729951

Review-Url: https://codereview.chromium.org/2927283002
Cr-Commit-Position: refs/heads/master@{#481094}

This is hit frequently, and would benefit from inlining even in non-LTO
builds (see bug).

BUG=728324

Review-Url: https://codereview.chromium.org/2948003003
Cr-Commit-Position: refs/heads/master@{#481093}

This is hit frequently, and would benefit from inlining even in non-LTO
builds (see bug).

BUG=728324

Review-Url: https://codereview.chromium.org/2949983002
Cr-Commit-Position: refs/heads/master@{#481092}

These are hit frequently, and would benefit from inlining even in non-LTO
builds (see bug).

BUG=728324

Review-Url: https://codereview.chromium.org/2947863003
Cr-Commit-Position: refs/heads/master@{#481091}

This function is hit frequently and we'd like it to available
for inlining even in non-LTO builds (see bug).

BUG=728324

Review-Url: https://codereview.chromium.org/2949953002
Cr-Commit-Position: refs/heads/master@{#481090}

Fixes RTLTest.WrapPathWithLTRFormatting.

Bug: 706592
Change-Id: I36f629ef8cfb512e78b1a060168d9edc412b7056
Reviewed-on: https://chromium-review.googlesource.com/541997Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481089}

This should prevent confusion, because the whole instance is not
available, not just a method.

Bug: None
Test: Watch the logs
Change-Id: I39e5eedbecefbd56b03ec956838ba159306cb0e8
Reviewed-on: https://chromium-review.googlesource.com/542041Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481088}

Future PostProcessors can be validated quickly using this, or it can
be used as a starting point for more specialized tests.

BUG=internal b/62593135
TEST=libcast_governor_unittests

Review-Url: https://codereview.chromium.org/2937123005
Cr-Commit-Position: refs/heads/master@{#481087}

Along with all associated names such as clients and subclasses.

CompositorFrameSink is the name of the mojo APIs. Now that IPC is thru
mojo, these APIs are actual C++ type names. Having other C++ types with
the same name is eternally confusing.

In the future one day LayerTreeFrameSink will submit ContentFrames or
so instead of CompositorFrames, luckily its name won't need to change
at that time.

This CL is not opinionated on what things *should* be using. There are
some places that are using LayerTreeFrameSinks that clearly should not
be since they are not involved with LayerTreeHost. However this CL
makes these more obvious instead of being hidden.

Once this is done, we may rename the MojoCompositorFrameSink API to
CompositorFrameSink and be free of the mojom::Mojo conundrum.

R=enne@chromium.org, fsamuel@chromium.org
TBR=sky@chromium.org, jam@chromium.org

Bug: 722935
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I26377c13f46fc7aff9bb4f43590ee7e42c00df40
Reviewed-on: https://chromium-review.googlesource.com/538096
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481086}

I'm working on adding support for the Android spellcheck menu in
https://codereview.chromium.org/2931443003

and we need to add another color to LayoutTheme to represent what color we
should highlight a misspelled word while the menu is active. Android uses the
same red color as the spellcheck underline but with some transparency added. We
decided that it's better to add a separate method to LayoutTheme for getting the
color than to assume that we'll want to do an alpha blend on every platform that
might ever support this menu.

BUG=715365

Review-Url: https://codereview.chromium.org/2953493002
Cr-Commit-Position: refs/heads/master@{#481085}

Remove OnScreenAvailabilityNotSupported in favor of
ScreenAvailability::DISABLED.

BUG=723032
TEST=existing/updated tests.

Change-Id: I824e832ad6454adfb4b221fd101b9eb4f65b46a3
Reviewed-on: https://chromium-review.googlesource.com/530324
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481084}

Bug: 494719
Change-Id: I18072d5de766bb3bbade3b0a627abeb8f5e65715
Reviewed-on: https://chromium-review.googlesource.com/541160Reviewed-by: Bugs Nash <bugsnash@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481083}

This relands patchset #4 id:60001 of https://codereview.chromium.org/2769353002/.

Bug: 704817
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I737948ee6b81ec69a6f3ad778344b26423284554
Reviewed-on: https://chromium-review.googlesource.com/541636Reviewed-by: Chris harrelson <chrishtr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481082}

BUG=

Review-Url: https://codereview.chromium.org/2940403002
Cr-Original-Commit-Position: refs/heads/master@{#481019}
Committed: https://chromium.googlesource.com/chromium/src/+/e4da0e76b5b75d453fec094f62ad06659e66708e
Review-Url: https://codereview.chromium.org/2940403002
Cr-Commit-Position: refs/heads/master@{#481081}

This patch implements more 'text-align' values: 'left', 'center',
'start', and 'end' (and its -webkit- versions.)

'text-align: justify' is to be worked out.

Also supports the base direction, a.k.a. paragraph direction, as defined
in UAX#9[1] for 'start' and 'end' to work. This support includes the
heuristic resolution by 'unicode-bidi: plaintext'[2].

The heuristics for forced line breaks is not implemented yet. The
failure of block-plaintext-004.html is caused by this.

[1] http://unicode.org/reports/tr9/
[2] https://drafts.csswg.org/css-writing-modes-3/#valdef-unicode-bidi-plaintext

BUG=636993

Review-Url: https://codereview.chromium.org/2940153002
Cr-Commit-Position: refs/heads/master@{#481080}

This re-lands https://chromium-review.googlesource.com/535154 while fixing
a silly crash due to binding to a not-yet-initialized member.

Bug: 689520
Change-Id: I42ad68d73b9c3437dcfd97f099527a09ce1a0d09
Reviewed-on: https://chromium-review.googlesource.com/540118
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481079}

Currently, the flex-wrap property is a 'storage_only' field, so
it has no generated public getters/setters.

This patch changes it to a 'keyword' field so that its getters/setters
can be generated as well. We also generate the EFlexWrap enum and
use the generated CSSValueID <-> EFlexWrap mappings.

Diff: https://gist.github.com/cf118a1b16d0d7f12b32dbf644be638a/revisions

BUG=628043

Review-Url: https://codereview.chromium.org/2944193002
Cr-Commit-Position: refs/heads/master@{#481078}

This is a reland of e8f9d07d
Original change's description:
> Remove Remoting API Key
> 
> Chromoting host no longer needs API Key, so the key can be removed.
> 
> Change-Id: I0960660ce2ddd5f4352ab691468d7c3881530d8d
> Reviewed-on: https://chromium-review.googlesource.com/540035
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#480940}

TBR=rogerta@chromium.org,pasko@chromium.org

Change-Id: Icce0c8512c24ca8f902a9b1941232ab2c42b70b0
Reviewed-on: https://chromium-review.googlesource.com/540985Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481077}

The CoordinationUnitGraphObserver framework provides an API to observe and respond to to interesting events that occur throughout coordination unit lifetimes’ within the resource_coordinator service.

R=*lpy@chromium.org,*oysteine@chromium.org,zhenw@chromium.org
BUG=724306

Review-Url: https://codereview.chromium.org/2942403002
Cr-Commit-Position: refs/heads/master@{#481076}

The test is attempting to catch the second frame of an animated GIF
(2 x 400ms frames) using setTimeout(400).  This is super-fragile.

Refactor to use advanceImageAnimation() intead.

BUG=chromium:734733,chromium:729075

Change-Id: I1528e602bed7f9599cb3bbf9a2821354a2e7aaef
Reviewed-on: https://chromium-review.googlesource.com/541037Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481075}

Revert of Fix Harmony checkbox having an ink drop highlight on click. (patchset #1 id:1 of https://codereview.chromium.org/2939043005/ )

Reason for revert:
Breaks Chrome OS x86.

Original issue's description:
> Fix Harmony checkbox having an ink drop highlight on click.
>
> Follow-up to crrev.com/2911573002. There was a regression with a later
> refactor of the ink drop code, and this fixes that.
>
> BUG=652510
>
> Review-Url: https://codereview.chromium.org/2939043005
> Cr-Commit-Position: refs/heads/master@{#480958}
> Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b395bb60842273f

TBR=sky@chromium.org,bruthig@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=652510

Review-Url: https://codereview.chromium.org/2948753003
Cr-Commit-Position: refs/heads/master@{#481074}

The "You can search from here with Google" first run bubble is a child
window of the browser window, and is made key because it contains a
button (so you can press the button via accessibility). All of this is
fine, except the omnibox is the browser window's first responder and
displays a focus ring. So, to the user it looks like they can start
typing (and indeed, the bubble invites them to "Type to search or
enter a URL to navigate...."), but the bubble consumes all key events.
This is a jarring experience for a first-time Chrome Mac user.

This cl changes the first run bubble to dismiss itself when the user
starts typing.

R=avi@chromium.org
BUG=657592

Review-Url: https://codereview.chromium.org/2951013002
Cr-Commit-Position: refs/heads/master@{#481073}

This test has become flaky lately:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Finspector%2Findexeddb%2Fupgrade-events.html&testType=webkit_tests

TBR=tmartino

Bug: 735259
Change-Id: I352e6a27368a95750b1bd2dd6902ce16d328fd0d
Reviewed-on: https://chromium-review.googlesource.com/542036Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481072}

Bug: 732898
Change-Id: I411932f8a835a5b0144040f62b71454a16f7a1ac
Reviewed-on: https://chromium-review.googlesource.com/541858Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481071}

Introduce a Mojo struct LoginUserInfo for login users which include
basic information ash::mojom::UserInfo and other login/lock
screen specific information.
UserSelectionScreen will populate LoginUserInfo and send it back to lockscreen views.
Compare to the user info we sent to current UI, LoginUserInfo have almost everything except:
1. user's gaiaId, which doesn't seem to be used by current UI.(user_pod_row.js)
2. public session information which doesn't exist on lockscreen.
We might need it for login screen later and I have added a TODO for this.

BUG=729687

Review-Url: https://codereview.chromium.org/2937553002
Cr-Commit-Position: refs/heads/master@{#481070}

The current IME is always in the list of available IMEs, so just send
its ID.

Also get rid of ash::ImeInfo.selected since that can be inferred by
comparing the ID of an IME to the current ID.

Also cleanup some test init code in ImeControllerClientTest.

Bug: 724305
Test: ash_unittests and chrome unit_tests
Change-Id: Id830048980728e30c6ae39acd833e26beb83ff64
Reviewed-on: https://chromium-review.googlesource.com/540665
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481069}

It's difficult to figure out why the crashes are being seen, so add
explicit checks that will help track down the cause.

These will be removed before the next branch point.

BUG=733096

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic073fb288ff4084614142ff802e9a93457241c6a
Reviewed-on: https://chromium-review.googlesource.com/540781Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481068}

Move class DraggedNodeImageBuilder, DataTransfer::NodeImage(),
DataTransfer::DeviceSpaceBounds(), DataTransfer::CreateDragImageForFrame()
to DataTransfer.cpp.
Move DragController::DragImageForSelection() to DragController.cpp.

BUG=727981

Review-Url: https://codereview.chromium.org/2950793002
Cr-Commit-Position: refs/heads/master@{#481067}

This reverts commit afc31e81.

Reason for revert: WebKit_Win_x64_Builder_dbg failure

Original change's description:
> [SPv2] Rework GeometryMapper transform computation
> 
> When computing the conversion matrix between two spaces, there are two
> types of conversion that are commonly used, but with slightly different
> semantics:
> 
> m1 = destination_to_screen ^ -1 * source_to_screen
> m2 = flatten(destination_to_screen) ^ -1 * flatten(source_to_screen)
> 
> The former computes the space conversion, which is useful for mapping
> 3D points from one space to 3D points in another space. The latter
> computes the "projection through screen", which is useful for mapping
> 2D points from a plane to a backing that is expected to be drawn onto
> the screen.
> 
> To illustrate the difference, see the following example:
> <div style="transform:rotateY(45deg)">A</div>
> <div style="transform:rotateY(-45deg)">B</div>
> 
> The space conversion from A to B is equal to rotateY(90deg), but the
> projection between the two planes is identity.
> 
> Prior to this CL, GeometryMapper implemented a mixed semantics. This is
> okay because all existing code only make queries that are co-planar, in
> which case, either version returns identical result. This is because we
> only make intra-compositing-layer queries, and 3D transform makes a
> compositing boundary.
> 
> This CL changed the implementation to strictly return the "projection
> through screen". The algorithm runs in amortized O(1) by caching the
> matrix between a node and its nearest coplanar ancestor that has a
> invertible projection.
> 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: Ia526dc6feb60c902f27589d73e78dfea235c6a93
> Reviewed-on: https://chromium-review.googlesource.com/534899
> Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
> Reviewed-by: Chris harrelson <chrishtr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#481049}

TBR=trchen@chromium.org,chrishtr@chromium.org

Change-Id: I0d89ddadaa7889dd43705f9e7c0ef2876afafec2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/541943Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#481066}