- 21 Feb, 2020 40 commits
-
-
Hiroki Sato authored
AXRelativeBounds assumes that the bounds are relative to the root of the tree by default, but in ARC, every nodes' bounds are computed relative to its container. AutomationInternalCustomBindings::ComputeGlobalNodeBounds computes the bounds by first calling AXTree::RelativeToTreeBoundsInternal to compute the node's relative bounds to its root using AXRelativeBounds, and then applying the difference between the root and the container. In Dialog or Popup window, the root node can have some amount of offset to its container. As a result, every computed bounds in such window has "doubled" offset to ARC container. This CL fixes the computation. This CL also simplifies geometry_util in arc a11y because exo::WMHelper::GetInstance() never returns nullptr. Bug: b:145260260 Test: manual. With TalkBack-test app, Alerts window has correct bounds. Change-Id: I93033ad0b2771828cdf00d17d1ebe039ef1d7044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061930 Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#743386}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9a30b9cd9c174e1e0ab4d5c5b76626ed1146dfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067922Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743385}
-
Nektarios Paisios authored
TBR: dmazzoni@chromium.org, dtseng@chromium.org Change-Id: I8fb826b2993e0a032fa77f7d6281980e21fb5394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067414Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#743384}
-
Sajjad Mirza authored
This is a reland of 2131f972 Original change's description: > [mb.py] Check multiple locations for the real python. > > Sometimes the value of sys.prefix (or sys.real_prefix in vpython) > includes the bin/ directory within the python installation, and > sometimes it does not. To accommodate this, check both prefix/bin and > prefix itself for the python executable. > > Bug: 1049421 > Change-Id: Ia7c072dc0b4b8232ec8fdce20f9211e3c978a3ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055976 > Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741574} Bug: 1049421 Change-Id: Ib0d83fa1b6613e62334336cf567d9c311dba2cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067291Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@chromium.org> Cr-Commit-Position: refs/heads/master@{#743383}
-
Bettina authored
As Enhanced Protection is a superset of SBER, everywhere that checks for SBER should also have a check for enhanced protection. Bug: 1054254 Change-Id: Ie8a89d450d0a6b7fd823fb4dc802ffe8bb1a27dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065858 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#743382}
-
Mustafa Emre Acer authored
It's needed for the iOS version of the lookalike interstitial. Change-Id: Iee91e52696cbb68b119c155151e4028af3c3d066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067675Reviewed-by:
Livvie Lin <livvielin@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#743381}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Bluetooth page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: If8f294c312ba8ba4731c76839d30d683a92d6543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065400 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#743380}
-
Justin DeWitt authored
See e.g. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.photo_picker.DecoderServiceHostTest%23testCancelation Change-Id: I8c6398d741ee64148701cdde4459d78998f4ae60 Tbr: finnur@chromium.org Bug: 1054652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067739Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#743379}
-
John Lee authored
This CLs updates the drag and drop interactions such that only the DOM is updated as the user drags a tab or group element. The tab strip model is only changed once the user commits the move by dropping the element in place. The DragManager now initializes a new DragSession every time a drag begins, and uses the session to store and retrieve indices. This will also make it easier and more consistent to drop a tab or group from another window into a specific index. The idea is to create a TabElement or TabGroupElement as a drag enters from another window and keep most of the code the same. Bug: 1048894 Change-Id: I92e9866ce2b57aae2736fa81b7a5e9e1b334cdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065329Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#743378}
-
Steven Bingler authored
This flag will control if the same-site calculation will take the scheme of the site-for-cookies and the request/response url into account when determining same-site-ness or cross-site-ness. Bug: 1030938 Change-Id: I206accc412cc8e2f4d3c65b8d3ab248bb3fa66bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062636Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#743377}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/f14fa29a7b1d..c681b47a0955 git log f14fa29a7b1d..c681b47a0955 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 miu@chromium.org Clarify Alarm::Schedule() API with kImmediately. Created with: gclient setdep -r src/third_party/openscreen/src@c681b47a0955 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I1ef4fb2ab9d31f0f78402a5466097ba5f01e016a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067582Reviewed-by:
-
Brian Sheedy authored
Hides //build/android:stack_tools behind build_with_chromium. Several other projects such as V8 pull in //build, but don't pull in //third_party/android_platform, which causes issues with stack_tools. Bug: 1043646 Change-Id: I968f2435a3b941ed603ad608419a3855a0446b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067924 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#743375}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8ef250cfe144..2de1869d1c21 git log 8ef250cfe144..2de1869d1c21 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 khamu@microsoft.com High contrast pass to dropdowns, buttons and links 2020-02-20 tvanderlippe@chromium.org Remove prototype wrangling for String formatters 2020-02-20 tvanderlippe@chromium.org Remove typedefs from {object_ui,network,layer_viewer,input,inline_editor}-legacy.js Created with: gclient setdep -r src/third_party/devtools-frontend/src@2de1869d1c21 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1048378,chromium:1050549 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia17fbab8014a81526dc0893667cade5063bb423e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067225Reviewed-by:
-
Vasiliy Telezhnikov authored
Bug: 805739 Change-Id: I1ae843c3859a980704f778aa991a4182a1688d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027887 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#743373}
-
sczs authored
This crash was similar to https://crbug.com/983179, where the webState was invalid and the badgeDelegate was trying to update the badge when a banner had been dismissed. In this case it seems that by the time the InfobarBanner has been presented the webstate is no longer valid (which means the InfobarCoordinator has been stopped), so we shouldn't try to update the badgeDelegate. This CL nils the badgeDelegate on stop to prevent this. Bug: 1054661 Change-Id: Ie0da80981603ede3c4a3ffa1fc5706115e5bf28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067940 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#743372}
-
Dale Curtis authored
Now that we have an unsandboxed zygote from https://crrev.com/742875 we can spawn all process types from it. This ensures we use the same binary as the browser process even when the on disk version changes. Bug: 22703 Test: All existing tests still pass. Change-Id: I56ab870ca591d10723b19ccba2d5de4420d99249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067393Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743371}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/018d99e46edf..4a3fef3b6875 git log 018d99e46edf..4a3fef3b6875 --date=short --first-parent --format='%ad %ae %s' 2020-02-20 rmhasan@google.com [Typ] Set default string arguments to None in Expectation constructor Created with: gclient setdep -r src/third_party/catapult@4a3fef3b6875 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC crouleau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986447 Tbr: crouleau@google.com Change-Id: I24f5ab59da9864541141b7208e7e52efd5b7b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067581Reviewed-by:
-
Xiao Yang authored
1. Add OnMenuClosed to notify observers when context menu is dismissed. 2. Add OnContextMenuShown to notify observers when context menu is shown. Bug: 1020004 Change-Id: I61f8c44edd909f3ba5e0566cb60cb79b59433091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055357Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Xiao Yang <yanxiao@google.com> Cr-Commit-Position: refs/heads/master@{#743369}
-
Xing Liu authored
Currently we use DownloadForegroundServiceObservers to broadcast download foreground service events. It uses reflection to cache the class name and then persist to android shared preference. DownloadNotificationServiceObserver implements DownloadForegroundServiceObservers.Observer, and then call methods of the singleton object of DownloadNotificationService. Also, onForegroundServiceRestarted() is not getting called, which make the following calls dead code. This is extremely weird, we can just call the one line singleton method. Bug: 922929 Change-Id: I28ff5552fd7fc0fd5a111cd4971d6bf4514bb45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063853Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743368}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Device stylus page strings from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: I4698b3bf96c01251ef888cf15dd46b03615787ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067238 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Bruce Dawson authored
When ReturnsValidPath() fails it just returned false, with no indication as to which of the several checks was the issue. This adds printing of specifics, including the path when applicable. This will help with future failures and with an ongoing investigation. Bug: 1053446 Change-Id: I8071df44b20af482a0387e2f8558d878de6d05b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065358Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743366}
-
Evan Stade authored
Bug: 1045609 Change-Id: If91c5d1d796d038aa838b2421f63d841337de59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067737 Commit-Queue: Evan Stade <estade@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#743365}
-
Michael Sun authored
To support the "Rewind" event generated by media controller devices (e.g. a USB HID Keyboard or a Bluetooth headset). Add handling in media_controller_impl. One "Rewind" key press will fire a Seek backward with kDefaultSeekTime=5 seconds using the media session service. BUG=1054411 Change-Id: I87669472cc0076a28df4a4752ad8af5a41983794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065849 Commit-Queue: Michael Sun <michaelfsun@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743364}
-
Khushal authored
This is suspected to be the cause for crashes on webview. Speculatively disabling it to validate this. R=zmo@chromium.org Bug: 1042615 Change-Id: I6fb870f285c0897cd068d24e9e1497c6018d9835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067455Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#743363}
-
Raymond Toy authored
Benchmarks (https://spotify.github.io/web-audio-bench/) using default number of runs and duration: Without this CL: TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 708 708 792 804 817 1595 Delay-default 372 372 472 499 536 4723 Delay-0.1 409 409 498 527 559 1639 DelayAutomation-a-rate 640 640 814 842 874 1018 DelayAutomation-k-rate 415 415 500 524 559 1676 With this CL TEST μs MIN Q1 MEDIAN Q3 MAX Baseline 767 767 793 804 821 1295 Delay-default 262 262 332 354 388 3840 Delay-0.1 284 284 355 382 415 1773 DelayAutomation-a-rate 640 640 741 761 797 1012 DelayAutomation-k-rate 264 264 367 388 421 1812 So we see that delay tests are improved by about 30%, except for the a-rate case. The changes for a-rate didn't have any measurable impact. Bug: 1054416 Change-Id: I4d3428fad6a13fd0632e09f7c03dca051ae09b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867377 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743362}
-
Justin DeWitt authored
See e.g. https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester/13972 Tbr: boliu@chromium.org, carlosil@chromium.org Bug: 1047527 Change-Id: I2513007de4c922183ce88845a29a656df1053e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067801 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
-
Sorin Jianu authored
For UpdateApps we did not need handling of native UI messages since the execution flow is silent. I also fixed the IWYU headers. For InstallApp, there were two SingleThreadTaskExecutor objects being instantiated, which is confusing. One of them was eliminated and replaced with a SequencedTaskRunner. The thread checker was replaced with a sequence checker. The UI code has thread affinity and continues to use a thread checker. Change-Id: I43ef545a7b86ff7f8cedea7b922cd84b0c7bbb99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067686Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743360}
-
Michael Sun authored
To support the "Fast Forward" event generated by media controller devices (e.g. a USB HID Keyboard or a Bluetooth headset). Add handling in media_controller_impl. One "Fast Forward" key press will fire a Seek forward with kDefaultSeekTime=5 seconds using the media session service BUG=1054411 Change-Id: I50b9a08c07a48143c3bf8ab516374db7a7497c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064749Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of moving OS specific strings from settings_strings.grdp to os_settings_strings.grdp, specifically android app pages strings. Bug: 967883 Change-Id: Iaaa6634a11cba885ae9105d6c9de71dd8ba12bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065136 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
-
Tim Volodine authored
The Android.WebView.ShouldInterceptRequest.InterceptionType has recently expired, but this is a useful histogram as it also tracks the number of intercepted vs non-intercepted requests (i.e. non-null vs null WebResourceResponse), so I think we should keep it around. BUG=1038347 Change-Id: I320dab14ab5df993168109b9174b7354e36a7b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062129Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Sven Zheng authored
These tests are marked as experimental now, so failures won't affect CI/CQ. See "win10_chromium_x64_rel_ng" for results. After this cl submitted, any cl that changes the UI that test covers will start receiving Skia Gold comment and the owner can triage the new UI. The whole test suites takes ~150s to finish. Bug: 958242 Change-Id: I9551280ffe7389d79e67e905a1d9fa0ebec9d7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063849 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#743356}
-
Robert Liao authored
Converted FakeComObject to DispatchStub using COM best practices. No attempt was made to restructure the tests. That will come in a later change. BUG=1034666 Change-Id: I1ec95c7b792686fc964743ea43bf18d6cfdd7a8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067937 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#743355}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c9de129a..8a305558 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I88ecb16860790ecc5c3e23fcec6383d0553b0746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066662Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743354}
-
Adrian McCarthy authored
Disable the warning until we fix the cast in src\third_party\smhasher\src\PMurHash.c Bug: 1054220 Change-Id: Ib08664366f22da17d5cb1a5d801e3317de64a27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065736Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
-
Jesse McKenna authored
[sheriff] Disable PasswordSaveUpdateWithAccountStoreViewTest.ShouldShowAccountPicker and ShouldSelectProfileStoreByDefault TBR=mamir@chromium.org Bug: 1054629 Change-Id: I82ca5e994cef840d881b88aed4056ba92dfa37b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067413Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#743352}
-
Charlie Reis authored
This avoids a crash when navigating to about:blank across processes, when about:blank was being kept in the frame's current process with an initiator origin that didn't match. Bug: 1054209 Change-Id: I76d9cfcc4087127bf0677b57d4e78fb547e52e67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063965Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#743351}
-
kylechar authored
SkiaRenderer was failing to delete OffscreenSurface objects corresponding to RenderPasses that are drawn to texture because of a CopyOutputRequest but not embedded in another RenderPass. No ImageContextImpl would be created but an OffscreenSurface would be. In SkiaOutputSurfaceImpl::RemoveRenderPassResources() it ignores RenderPassIds with no corresponding ImageContextImpl. This caused a memory leak for the lifetime of the SkiaOutputSurfaceImpl unless another RenderPass with the same ID was created later. It also likely caused some size mismatches if another RenderPass with the same ID but a different size was created later. Bug: 1043676 Change-Id: I3dea76bc20171146814bf47b2fc3d3ded40f8fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067332 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#743350}
-
Sarthak Shah authored
This CL extends the milestone for experimental fling animation and percent based scrolling feature to 89. Change-Id: I953ff493c4d825bf92f52506952547219a50be33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065731Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743349}
-
Shimi Zhang authored
Currently Better Js Java is using ProxyBypassRules for its allowedOriginRules parameter, which isn't suitable for this type of usage. We introduce AwOriginMatcher to replace ProxyBypassRules. Bug: 1030110 Change-Id: Ibfee91a6974c8a1174c8b1f8b3bf718148eb9e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042758 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743348}
-
Patrick Monette authored
Bug: 986188, 1048332 Change-Id: I94391cb298fa16cb68ee47169559e3b449f02465 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062703Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#743347}
-
