- 07 Sep, 2018 40 commits
-
-
Dominik Röttsches authored
This reverts commit 5bc5a4c5. Reason for revert: Test passes only flakily on Linux Original change's description: > Connect Linux Font Unique Name Lookup to Blink > > Provide a new subclass for font unique name lookup for Linux. Connect > via WebSandboxSupport to FontLoader which provides the out of process > fontconfig calls for us. Tested by content_browsertests with a DevTools > based test checking used fonts. This test was previously active on > Android and is enabled for Linux in this CL. > > Bug: 880832 > Change-Id: I04d72fc1cfcfa55a01a9877ac8a3a45dbff38771 > Reviewed-on: https://chromium-review.googlesource.com/1206337 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Emil A Eklund <eae@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589482} TBR=dgozman@chromium.org,eae@chromium.org,drott@chromium.org Change-Id: I811960048b2f37130e4be4cb9c693dc90040f30d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880832 Reviewed-on: https://chromium-review.googlesource.com/1213168Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#589500}
-
Roman Kuksin authored
This is a reland of ebe80ad0 Original change's description: > Wait for ukm entry in TryAutoplay > > The test fails due to a race of UkmRecorder::AddEntry with DOMMessageQueue::Observe: > https://cs.chromium.org/chromium/src/services/metrics/public/cpp/delegating_ukm_recorder.cc?q=src/services/metrics/public/cpp/delegating_ukm_recorder.cc&sq=package:chromium&g=0&l=137 > > Bug: 880217 > Change-Id: Icf099c3eb1094d8a571dc6f87b152e3c838807dc > Reviewed-on: https://chromium-review.googlesource.com/1204011 > Reviewed-by: Tommi <tommi@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589317} Bug: 880217 Change-Id: I6c5cd4107f74f3102b6bd491323a6ab68f56f911 Reviewed-on: https://chromium-review.googlesource.com/1212802Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589499}
-
Jan Wilken Doerrie authored
This change implements selecting a service revision to FidoBleConnection. This is mandated by the CTAP spec when the fidoServiceRevisionBitfield characteristic is present. Furthermore, this change simplifies FidoBleConnection's interface by dropping the unused ReadServiceRevisions() and WriteServiceRevision() APIs. Appropriate tests are added. Bug: 880053 Change-Id: I35f6b39be9f90e7c668f5714f6cc26830966ae1c Reviewed-on: https://chromium-review.googlesource.com/1204013Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#589498}
-
Markus Heintz authored
This reverts commit 92df23c1. Reason for revert: Failure size on mac_rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/546 speculative revert due to: HINT: To get this list, run tools/mac/show_mod_init_func.py # HINT: diff against the log from the last run to see what changed /b/s/w/ir/cache/builder/src/out/Release/Chromium Framework.unstripped 0x0000000001fe9410 @ _GLOBAL__sub_I_mime_handler_view_frame_container.cc (in Chromium Framework.unstripped) (mime_handler_view_frame_container.cc:0) Original change's description: > Implement MimeHandlerViewFrameController > > This CL implements the renderer side of MimeHandlerView based on > cross-process frames (behind a flag). > > The new subclass of MimeHandlerViewContainerBase will use a content > frame inside a plugin element for loading the MimeHandlerViewGuest's > extension. > > The current implementation is not complete and the missing features > such as postMessage support will be added in the follow-up CLs. > > This CL also introduces a new class of parametric browser tests > (MimeHandlerViewCrossProcessTest) which will be the destination of > the current MimeHandlerViewTests as more features are integrated into > the frame-based version. The new test class runs the test on both > BrowserPlugin-based and cross-process-frame-based versions. > > Document: https://docs.google.com/document/d/10g7Y9cprYKkch9JZ0TBUWaEnHBJT1nzhskQIt1nHbWM/edit#heading=h.qw81a2bk3v6w > > Bug: 659750 > TBR=thestig@chromium.org > > Change-Id: Ia69aeed47f4fa1c7f5b81cdde71a8d8b5ff59165 > Reviewed-on: https://chromium-review.googlesource.com/1187231 > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589284} TBR=lazyboy@chromium.org,thestig@chromium.org,sammc@chromium.org,alexmos@chromium.org,ekaramad@chromium.org,wjmaclean@chromium.org Change-Id: Ice96f16404a1026693a72425535929bd883264fe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 659750 Reviewed-on: https://chromium-review.googlesource.com/1213148Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589497}
-
Mugdha Lakhani authored
This adds the following metric: BackgroundFetch.RatioOfIdealToChosenIconSize Bug: 877512 Change-Id: Id4289b13178ca9e3bd76e1ea9371f778788b5699 Reviewed-on: https://chromium-review.googlesource.com/1199591 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#589496}
-
Rob Buis authored
Add negative tests to SignedExchangeUtils unit test to test how we deal with questionable/wrong content types. Bug: 803774 Change-Id: If726951a4fb96506251ad7fd1ac26a6940174e6c Reviewed-on: https://chromium-review.googlesource.com/1203995Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#589495}
-
Arthur Hemery authored
To be able to completely get rid of pending_navigation_params_ we need to get rid of the same_document dependency on it. It is currently used to store common and request params in CommitSameDocumentNavigation, to later create a new state in DidFinishSameDocumentNavigation. We now imitate what we did for cross-document navigations, pass down to the loader the navigation information. An issue with this is that same-document navigations only update NavigationState. The structure used for now is only accessible in content. To blink it is an opaque structure. This means that for now, we just carry the structure all the way back to DidFinishSameDocumentNavigation. This adds a lot of boilerplate code but will probably be completely stateless when we have an adequate structure residing in the loader. Bug: 789577 Change-Id: If872abf20477ee6bdf42053781a2a9077960fe6c Reviewed-on: https://chromium-review.googlesource.com/1186406Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#589494}
-
Kouhei Ueno authored
This CL prepares for measuring PageLoadMetrics for pages loaded through SignedExchange. This CL adds |NavigationHandle::IsSignedExchangeInnerResponse()| getter, which can be used to distinguish signed exchange navigations. The getter will be used in the following CL to selectively enable the signed exchange page load metrics observer for recording drill-down UMAs. Bug: 863305 Change-Id: Ia3bad8d6c9daeef237879538fb8999b7f3df4a46 Reviewed-on: https://chromium-review.googlesource.com/1212375Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#589493}
-
momohatt authored
This patch adds pause_when_not_identical option for making ServiceWorkerCacheWriter::MaybeWriteData() return before writing the new body into the storage when the scripts are not identical. This option is necessary for extending byte-for-byte update check of service worker importScripts() resources. Bug: 648295 Change-Id: If33412cd6e63393ad3fdae514b1588a33f17399a Reviewed-on: https://chromium-review.googlesource.com/1198651 Commit-Queue: Momoko Hattori <momohatt@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#589492}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/104cb056..c61b09bf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I86e3dd9cc1d015cf16053a5a68572af779e17593 Reviewed-on: https://chromium-review.googlesource.com/1212747Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589491}
-
Mathias Bynens authored
This is an ECMAScript feature, implemented in V8. Proposal repository: https://github.com/tc39/proposal-global Intent to ship: https://groups.google.com/d/msg/v8-users/Vkoh0wXRwaM/Yt7MpzhkAgAJ Bug: v8:5537 Change-Id: Id322937a8368a952178a8e9049e514b4f64549d4 Reviewed-on: https://chromium-review.googlesource.com/1210803 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#589490}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/30d7c2688aa9..cfe528ef2d04 git log 30d7c2688aa9..cfe528ef2d04 --date=short --no-merges --format='%ad %ae %s' 2018-09-07 fmayer@google.com Merge "Fix incorrect references to libprotobuf in comments." Created with: gclient setdep -r src/third_party/perfetto@cfe528ef2d04 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4e7270177ae234aaa61d6a5f6295fa42841305c4 Reviewed-on: https://chromium-review.googlesource.com/1213043Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589489}
-
Eric Seckler authored
Updates prerender and safe browsing browser tests to initialize the SafeBrowsingDatabaseManager after BrowserThreads were created (but before they are started). This is required for the upcoming move of BrowserThread::PostTask to base/task/post_task.h, as construction of SafeBrowsingDatabaseManager obtains a TaskRunner for the IO thread. In the future, this has to happen after thread initialization. Bug: 878356 Change-Id: I1d4c614690ba3aacf4887fefe57d378c23668706 Reviewed-on: https://chromium-review.googlesource.com/1211735Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#589488}
-
Friedrich Horschig authored
Currently, the DeferredViewStubInflationProvider will accept null as view stub and try to inflate the non-existent stub much later. To prevent this deferred NullPointerException, assert that used stubs are never null. Fix the usage that uncovered that issue. Bug: 876215 Change-Id: I51deb6aaa1ac3d3283e6794c0cae37c536b43aa5 Reviewed-on: https://chromium-review.googlesource.com/1210783Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589487}
-
Elad Alon authored
Add a comment warning against changing WebRtcEventLogManager- related strings which may be relied upon by web-apps. Bug: 775415 Change-Id: I7717d87437c72756ed2a2ecda61d9abb30a6a778 Reviewed-on: https://chromium-review.googlesource.com/1212943Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#589486}
-
yoshiki iguchi authored
This is reland of crrev.com/c/1206551 after fixing the memory leak (crrev.com/c/1208694). The diff is completely same as the previous CL. The previous CL had been reverted due to the ASAN failure (see. crbug.com/880227). [Original description] The feature is not launched on M70. This CL should be merged to M70 branch as well. TBR: yamaguchi@chromium.org TBR: oshima@chromium.org Bug: 880227 Change-Id: Id0ca9b5ee488130d7fb0c414b4a9522117d462dd Reviewed-on: https://chromium-review.googlesource.com/1212902Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#589485}
-
Hayato Ito authored
This is in preparation for https://chromium-review.googlesource.com/c/chromium/src/+/1205924, so we don't need to do forward declarataion for template definitions in NodeTraversal and any other traversals. Bug: 880052 Change-Id: Ie2decfb0763f4dfe3f85cace21601c893f263563 Reviewed-on: https://chromium-review.googlesource.com/1212374Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589484}
-
Finnur Thorarinsson authored
Bug: 860467 Change-Id: I59392880379432fb8252db79cd8c45e9378c9922 Reviewed-on: https://chromium-review.googlesource.com/1209747Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#589483}
-
Dominik Röttsches authored
Provide a new subclass for font unique name lookup for Linux. Connect via WebSandboxSupport to FontLoader which provides the out of process fontconfig calls for us. Tested by content_browsertests with a DevTools based test checking used fonts. This test was previously active on Android and is enabled for Linux in this CL. Bug: 880832 Change-Id: I04d72fc1cfcfa55a01a9877ac8a3a45dbff38771 Reviewed-on: https://chromium-review.googlesource.com/1206337 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589482}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c39dc317. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24207 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I25d5646ff737a843bbbab5f90df76ddaac57cbae Reviewed-on: https://chromium-review.googlesource.com/1212487 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589481}
-
Olli Etuaho authored
The flag is only available on Windows and offers choices to use the OpenGL, D3D9 or D3D11 backend. TEST=manual test on Windows BUG=chromium:693090 Change-Id: Ia9ce5d58a0658af513b070e564014398f35a243e Reviewed-on: https://chromium-review.googlesource.com/1202203 Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589480}
-
Alexandre Courbot authored
The codec API specifies that when starting streaming, the OUTPUT queue should start first, followed by the CAPTURE queue. However it can happen in some reset scenarios that CAPTURE buffers are queued ahead of OUTPUT buffers, which results in the CAPTURE queue starting first. Fix this by only allowing the CAPTURE queue to start if the OUTPUT queue is already streaming. BUG=b:111670886 TEST=Checked that VDA unittest was passing on Hana and Cheza. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id27b5202dc6f910880e52099773df26e73a50304 Reviewed-on: https://chromium-review.googlesource.com/1212211 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589479}
-
Hiroshige Hayashizaki authored
Currently, UpgradeInsecureRequest() is called in WorkerFetchContext::PrepareRequest(), which is called after mixed content check. Therefore, insecure requests are blocked as mixed content before upgraded. This CL moves the UpgradeInsecureRequest() call to WorkerFetchContext::PopulateResourceRequest(), which is called before mixed content check. This is also consistent with FrameFetchContext, where insecure request is upgraded in FrameFetchContext::PopulateResourceRequest(). Bug: 880986, 880023, 880015, 880027 Change-Id: I983a40eebda8d04698b70d8c29e3707d4dcdf838 Reviewed-on: https://chromium-review.googlesource.com/1205750Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#589478}
-
Maksim Sisov authored
This CL enables partial swap support in Wayland by enabling SupportsPostSubBuffer. A damage region describes the regions where the pending buffer is different from the current surface contents, and where the surface therefore needs to be repainted. Enabling this needs requires fixing http://crbug.com/339493 as well for Intel drivers. Bug: 880726 Change-Id: I3bb2c7f876e3b5297c0d5595e309e3853772430f Reviewed-on: https://chromium-review.googlesource.com/1206370 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#589477}
-
Rune Lillesveen authored
In preparation for starting those operations from a different root node than the document root, make them separate methods on StyleEngine. Bug: 868810 Change-Id: Ic3c1308835aef9a4e7887822ad7744ae76a7dcbd Reviewed-on: https://chromium-review.googlesource.com/1206910Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#589476}
-
Maksim Sisov authored
This patch makes use of new minigbm APi names, which are aligned with Linux libgbm. Also, it defines certain definitions, which are different between libgbm and minigbm. What is more, it adds USING_MINIGBM for internal usage to be able to distinguish between system linux gbm and minigbm. Last but not least, drmPrimeHandleToFd is used in case of linux system libgbm in order to be able to get mappable fds per each plane, which is neede to add GpuMemoryBuffers support. Bug: 869206, 578890, 820047 Change-Id: I0a743aef1c8bad2bb5792a58ab29abec45ea4585 Reviewed-on: https://chromium-review.googlesource.com/1158234 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#589475}
-
Uladzimir Miniailau authored
AddIE7PasswordInfo method and LoginsTable should also be deleted. I will do it in the following changes. Bug: 456119 Change-Id: I581fd88bc1fa9bf35d0484616be9d69e939e69ef Reviewed-on: https://chromium-review.googlesource.com/1174729Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Uladzimir Miniailau <miniailau@google.com> Cr-Commit-Position: refs/heads/master@{#589474}
-
Daniel Bratell authored
Jumbo is the Chromium implementation of a Unity build system aimed at dramatically lowering the compilation times, especially for those without access to goma. In reference testing, this patch reduces the effort to compile content_shell+chrome+blink_tests by about 9 CPU minutes, 1-2% of the total effort. Earlier patches saved more so the total build effort reduction in //ui is about 41 CPU minutes. There is still some code in ui that doesn't use jumbo. Specifically most of the tests. Bug: 773275 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie59fec4b67fc1e3d6855d04a4b9a1088e0a08768 Reviewed-on: https://chromium-review.googlesource.com/834348Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589473}
-
Mihai Sardarescu authored
The feature kRemoveUsageOfDeprecatedGaiaSigninEndpoint was enabled by default in M62. This CL removes the feature flag and all the code that use it. In a subsequent CL we will also remove the GaiaUrls::deprecated_client_login_to_oauth2_url() (here https://cs.chromium.org/chromium/src/google_apis/gaia/gaia_urls.h?rcl=461cbc77709a44135a9c9fce4ac2e4d81a7cb1cb&l=44) as that should no longer be user either. Bug: None Change-Id: I0d5534472e56c7276a1ce57503e992e652068ebc Reviewed-on: https://chromium-review.googlesource.com/1210265 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#589472}
-
Fredrik Söderquist authored
Rather than converting an int argument to a float in the function (that return a FloatRect), pass a float argument and let the caller handle a conversion (if needed.) Bug: 881188 Change-Id: If3083fc19c866f003b0d60e10246b3088463dcdd Reviewed-on: https://chromium-review.googlesource.com/1209923Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589471}
-
Mike West authored
Bug: 787905 Change-Id: I2248173947ed87ff3e8f40dc86a8e9044ed2dd3b Reviewed-on: https://chromium-review.googlesource.com/966442 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589470}
-
Yuki Shiino authored
This reverts commit a11e3884. Reason for revert: Suspicious to have broken viz_browser_tests and webui_polymer2_browser_tests. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7689 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8936081737798843840/+/steps/viz_browser_tests/0/logs/CrSettingsMultideviceFeatureToggleTest.All/0 Original change's description: > [CrOS MultiDevice] Settings UI A11y labels. > > > Bug: 876796 > Change-Id: Ie369384f218fde83ae03f21add99c0573ab97912 > Reviewed-on: https://chromium-review.googlesource.com/1211915 > Reviewed-by: Jeremy Klein <jlklein@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589397} TBR=hcarmona@chromium.org,jlklein@chromium.org,jordynass@chromium.org Change-Id: Ife1c75063e197a32142604f3f05c964910721079 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876796 Reviewed-on: https://chromium-review.googlesource.com/1212212Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589469}
-
Mark Cogan authored
This CL adds metrics to track: - Use of the new Close All and Undo Close All controls. - Use of interactive tab grid reordering. Bug: 880845 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I822044ea7bd1065a987d50dd03842662fa618a41 Reviewed-on: https://chromium-review.googlesource.com/1206433Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#589468}
-
Maksim Sisov authored
Instead of blindly using a fake presentation feedback result, use the wayland provided one if available. If not, pretend there is a feedback, but provide a faked one. In order to provide feedback, the callback, which comes from the GPU, is stored in the Buffer instance. Although, both frame and presentation feedback are setup, the frame callback always comes first. Thus, we store the result and once the feedback comes, we use the previous swap result and the presentation feedback to let the GPU know the status of the request. Bug: 859012 Change-Id: I4f4628be6101149daa30b6c74f3490254ace0fad Reviewed-on: https://chromium-review.googlesource.com/1193883 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#589467}
-
Pin-chih Lin authored
Initial config has both profile and H264 level now, we then apply the configuration by passing to H264 encoder class for VAVEA, and setting up v4l2 controls for V4L2VEA, rather than using fixed profile and level in the past. According to H264 spec, there are limitations for framerate/bitrate/framesize combinations as the requested level, and we may want to fail initization for excessive configuration. For VAVEA, we add the check on H264Encoder::Initialize(). For V4L2VEA, we will let driver judge the legality on configuration. In video_encode_accelerator_unittest, a new property requested_h264_level is added to test_stream to specify requested level, and ForceH264Level test for checking output level meets expectation. BUG=863327 BUG=865302 TEST=build, deploy Chrome, and run video_encoder_accelerator_unittest on Eve TEST=build, deploy Chrome, and run video_encoder_accelerator_unittest on Elm Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I003a4f5c1c8ef149ace3dd2ad18aebd84f60dd0c Reviewed-on: https://chromium-review.googlesource.com/1209883 Commit-Queue: Pin-chih Lin <johnylin@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589466}
-
Daniel Bratell authored
A commit just introduced a second g_id_map in ui/views/cocoa, which broke jumbo builds. This renames the g_id_map globals to the longer names g_id_to_impl_map and g_id_to_host_impl_map. Bug: 859152 TBR=ccameron@chromium.org,ellyjones@chromium.org Change-Id: Id30d71b67f4bfb7c3ddc3ec8d03c759b5b7df14f Reviewed-on: https://chromium-review.googlesource.com/1212862Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589465}
-
Matthew Cary authored
webkit_layout_tests will fail if there is a non-ascii character in the stack dump. This CL encodes the stack dump to avoid that. Very probably there is some other problem that is causing the stack to contain non-ascii characters, but at this point we can't even tell what's the problem due to the crash (see the bug for details). Bug: 880246 Change-Id: I34c5582cc2d4bd98fb17053336e9084624df52a5 Reviewed-on: https://chromium-review.googlesource.com/1204015Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#589464}
-
Fredrik Söderquist authored
This implements initial values for SVGAnimatedInteger properties (which includes SVGAnimatedIntegerOptionalInteger since it is a reverse proxy for the former.) Bug: 225807 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0563b6cfe4dc22b08ed04ab508faf4fb9491b5b4 Reviewed-on: https://chromium-review.googlesource.com/1209743 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589463}
-
Brandon Wylie authored
Change-Id: I7af13ac123280be7b4b89a3b05918e2b8ea96ce3 Reviewed-on: https://chromium-review.googlesource.com/1208819Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Commit-Queue: Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589462}
-
Anders Hartvoll Ruud authored
The most important use case for css-properties-values-api is having typed (and possibly interpolated) custom properties in paint worklets. So naturally, this is the *least* well tested use case in WPT. This CL improves that by adding tests for most of the syntax types. The test works as a kind of "ref" test, which compares the output of CSSStyleValue.parse /parseAll with the value observed inside the worklet. <transform-function> and <transform-list> are not supported yet, so they will come later. Interpolations should also be tested, but that belongs in a separate test. Bug: 641877 Change-Id: I4bd310ecd61a2a8989df9c4a5c818cdc7c179b3a Reviewed-on: https://chromium-review.googlesource.com/1209711 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#589461}
-