GitLab

Roll HarfBuzz to 1.7.3 to incorporate hb_set changes which improve
dealing with fonts containing incorrectly sorted range information, such
as the Chandas Devanagari font part of the ttf-devanagari-fonts package,
as identified in
https://bugs.chromium.org/p/chromium/issues/detail?id=794896

Cherry-pick 2fe5f885..a9432bde on top of 1.7.3 to incorporate hb_set
regression fixes.

Bug: 794896, 796124
Change-Id: I9256018b6ec6c7e84f9261c97758b2bee2d410a2
Tbr: kojii, eae, behdad
Reviewed-on: https://chromium-review.googlesource.com/831946
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525317}

Change-Id: Iba70082c0c8cb01c8bcb8c5c6e7f0fa237184f30
Reviewed-on: https://chromium-review.googlesource.com/834088Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525316}

The omnibox popup is currently positioned using frames. It is not very
practical as it means that the frames need to be recalculated when the
UI changes, for example during rotations.
This CL adds a UILayoutGuide to the toolbar, allowing the popup to be
positioned and sized using the guide, including when its frame needs
to be changed after a rotation.

Bug: 795660, 788640, 786940
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I761a433f84a9c52fd73728b2c83a9ecc15f7fc02
Reviewed-on: https://chromium-review.googlesource.com/831518Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525315}

Don't get channel layout for input element since that's not supported on AUHAL[1], instead get the channel count from the stream layout.

Plus fixes in ScopedAudioUnit:
* Enable IO before setting current device which is a requirement.
* Use element 0 with global scope, which is the element to use with that scope. (This didn't cause a failure.)

[1] Follow-up on this to confirm: https://crbug.com/796163

Bug: 794501
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3879989e30449000dc9d75f756c69738ac54615a
Reviewed-on: https://chromium-review.googlesource.com/823972
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525314}

Doing this refactoring cleans the way for a much nicer looking CL for
https://chromium-review.googlesource.com/c/chromium/src/+/830946
as it can just use QueuedRequest::Args instead of adding more fields
to the mojo struct or to QueuedRequest directly.

Bug: 703184
Change-Id: Ia5c08d9173f351484b3b6ab14e10958995ac8588
Reviewed-on: https://chromium-review.googlesource.com/830846
Commit-Queue: Lalit Maganti <lalitm@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525313}

Comparison of a pointer difference to a size_t cause the compiler
to whine about the different signs: 'long' and 'unsigned long' in
this case. Fix that by using ptrdff_t for these comparisons.

No change in behavior, no new tests.

Tbr: mtklein@chromium.org
Bug: 796470
Change-Id: Ie585ba45f1e09f31f7d4cf48c41f2378a1b0808b
Reviewed-on: https://chromium-review.googlesource.com/836291
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525312}

* Moved mojom definitions from content(/public)/common to
  WebKit/common/color_chooser.

* Mojo calls are now made directly from blink in ColorChooserUIController.

* Deleted unneeded implementation files:
 - content/renderer/renderer_webcolorchooser_impl.[h|cc]
 - third_party/WebKit/public/web/WebColorChooser.h
 - third_party/WebKit/public/web/WebColorChooserClient.h
 - third_party/WebKit/public/web/WebColorSuggestion.h
 - third_party/WebKit/Source/core/exported/WebColorSuggestion.cpp
 - third_party/WebKit/Source/platform/ColorSuggestion.h

* Deleted unneeded test mock files:
 - content/shell/test_runner/mock_color_chooser.[h|cc]
 - replaced with mock-colorchooser.js to intercept mojo calls.

Bug: 788960
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I305a2abb3cba457042c877e6401abbe383611c75
Reviewed-on: https://chromium-review.googlesource.com/821954Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525311}

Both setting size IDL attribute directly as well as
indirectly setting using setAttribute were not treating
values bigger than 2147483647 correctly, so fix both code
paths.

Behavior matches Firefox and Safari.

Bug: 651762

Change-Id: I6b3f2060eac9cfa6b1b8ad1898159c632257d625
Reviewed-on: https://chromium-review.googlesource.com/812010
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525310}

When the user taps on the "Continue as ..." button in the sign-in
promo, of the Other Devices tab, the user is signed in at the
beginning of the sync confirmation animation.
Therefore the TabSwitcherModel receives the sign-in notification and
send a notification to the TabSwitcherController to reload before the
end of the animation. While reloading the TabSwitcherController
removes the current TabSwitcherPanelOverlayView that contains the
sign-in promo view and its SigninPromoViewMediator.
The issue is that SigninPromoViewMediator is supposed to live until
the end of the sign-in to handle correctly the metrics (histograms
and user actions).

To avoid that, the SigninPromoViewMediator is now owned by the
TabSwitcherController. And TabSwitcherModel asks its delegate if a
sign-in is in progress. In that case, the sign-in notification is
ignored.
Therefore the UI is not updated while the sign-in interaction is
appearing (see crbug.com/725925)

Once the sign-in is finished (cancel or success), the
TabSwitcherController is notified by SigninPromoViewMediator and then
the TabSwitcherModel can be reloaded.

Bug: 795895, 725925
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iefff5975bc251ea39cb06c5d73a4adc135ce317b
Reviewed-on: https://chromium-review.googlesource.com/832391
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525309}

https://skia.googlesource.com/skia.git/+log/acd59ef08512..59c19a3877cb

$ git log acd59ef08..59c19a387 --date=short --no-merges --format='%ad %ae %s'
2017-12-20 angle-deps-roller Roll skia/third_party/externals/angle2/ ffd27d853..37385e11d (2 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: Icc1871c584ccd8372343509c2a5eb14a6fde58e3
Reviewed-on: https://chromium-review.googlesource.com/836409Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525308}

GLImageAHardwareBuffer:
    bool Initialize(AHardwareBuffer* buffer, bool preserved)

GLImageNativePixmap:
    bool Initialize(uint32_t texture_id)

Not keeping the same signature as GLImageEGL::Initialize
to indicate how it is used. And if needed, more initialisers
can be added.

This prevents the user from doing mistakes when
instantiating a subclass of GLImageEGL but calling
the parent's initialiser.

For consolidation this CL also moves GLImageEGL::Initialize
from public to protected.

Note that GLImageEGL cannot be instantiated directly
because it does not implement a few pure virtual functions
it got from its parent, gl::GLImage.

Bug: 785201
Test: gl_unittests --gtest_filter=*NativePixmap*
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ida5834bbf964893680f449f1f5da7371e46075bc
Reviewed-on: https://chromium-review.googlesource.com/817563
Commit-Queue: Julien Isorce <julien.isorce@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525307}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/29ec7059..6a279326

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic255093d75ff23c739d41ac059435aaf5c41325a
Reviewed-on: https://chromium-review.googlesource.com/836268Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525306}

Bug: 771800
Change-Id: Id28d95a3afac31ee33711f99857f7af0b9d5e1d7
Reviewed-on: https://chromium-review.googlesource.com/836328Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#525305}

All known clients use certificate error overrides to ignore all
certificates, so we're planning to replace it with a simpler
"ignore all cert errors" mode instead. This patch deprecates the old
override command in favor of a new setIgnoreCertificateErrors command.

It also exposes the Security domain on the browser target to
facilitate applying this override globally for the whole browser.

Bug: 721739, 792468
Change-Id: I89bd929247877f43abac7c31a420d0756a8fdf89
Reviewed-on: https://chromium-review.googlesource.com/817443
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525304}

This CL adds an interface on IdentityManager to create a
PrimaryAccountAccessTokenFetcher instance. In this way, clients of
IdentityManager can create PrimaryAccountAccessTokenFetchers without
needing to know about the core signin classes on which it depends. This
interface will facilitate moving clients of
PrimaryAccountAccessTokenFetcher to depend on IdentityManager rather
than depending on these core signin classes directly.

Bug: 654990
Change-Id: I15217dabf60a8dada17ce54f76406c011d011f5c
Reviewed-on: https://chromium-review.googlesource.com/832647Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525303}

To catch up c++17 definition, this CL updates the signature
and implementation of comparator operators.

BUG=784732
TEST=Ran base_unittests --gtest_filter=OptionalTest.

Change-Id: I4a21f8af1ec5ca0af9946250f3855f198077d52c
Reviewed-on: https://chromium-review.googlesource.com/832547
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525302}

Align the behavior of navigator.credentials.store() with the spec [1]
when deciding if the |iconURL| of the passed in PasswordCredential or
FederatedCredential is an `a priori authenticated URL`.

[1]: https://www.w3.org/TR/mixed-content/#a-priori-authenticated-url

Bug: 740081
Change-Id: I2d9ae6c61cc0f3cf3687dfe99aec09b08b078efd
Reviewed-on: https://chromium-review.googlesource.com/833913Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525301}

https://chromium.googlesource.com/angle/angle.git/+log/d4529f304be7..37385e11d383

$ git log d4529f304..37385e11d --date=short --no-merges --format='%ad %ae %s'
2017-12-19 oetuaho Emulate tanh on HLSL

Created with:
  roll-dep src/third_party/angleBUG=795269


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Iaf877a7cb9c63d65eda8e8d33149e90a0fb17774
Reviewed-on: https://chromium-review.googlesource.com/836408Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525300}

Bug: 
Change-Id: Ia4a87a4fa6e98902bca8b3328399dcd4de79af3a
Reviewed-on: https://chromium-review.googlesource.com/833938
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525299}

The device_features target has definitions for base::Feature constants,
and as the target type is source_set, for component builds, constants
are being defined in multiple binaries. As a result, when feature flag
is checked from browser and services code,
FeatureList::IsFeatureEnabled will assert, as the constants have
different addresses.

This CL changes device_features target type from source_set to
component, and exports declared constants.

Bug: 
Change-Id: Ife09ba3141da360c08e4f26c24735c9fc552c7bb
Reviewed-on: https://chromium-review.googlesource.com/833920Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Alexander Shalamov <alexander.shalamov@intel.com>
Cr-Commit-Position: refs/heads/master@{#525298}

The REPONSE_START and RESPONSE_END page load metrics reported from
custom tabs should be named SEND_START and SEND_END to be consistent
with the navigation timing API.

Bug: 
Change-Id: Id6d5de07d1c3748ed2921fc94bfa7ac8dcf72252
Reviewed-on: https://chromium-review.googlesource.com/832481Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525297}

The flag #contextual-search is flipping a command-line switch
that is never read (the code is kept to run the unit tests but
not build in production).

Remove the flag and move the switches to the target
//ios/chrome/browser/ui/contextual_search:switches.

Bug: none
Change-Id: I121acb25fb98b599f109abd827a763253fd1e1c1
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/833937Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525296}

R=derat@chromium.org

Change-Id: Idbb641f8c5b522db79b6852a0c4c456176c4b672
Reviewed-on: https://chromium-review.googlesource.com/835418
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525295}

https://chromium.googlesource.com/angle/angle.git/+log/ffd27d85371b..d4529f304be7

$ git log ffd27d853..d4529f304 --date=short --no-merges --format='%ad %ae %s'
2017-12-12 oetuaho Define symbol classes in a separate file

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I75248cce855dc824dacbcb0716e91d3bb7391d8c
Reviewed-on: https://chromium-review.googlesource.com/836148Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525294}

This patch implements the upcoming specification changes:
https://github.com/w3c/sensors/pull/328

The sensors API can be used inside nested browsing contexts
in a secure way.

Bug: 
Change-Id: Ia6353d5a0d9a7c8817666a04aa859ed2c13b0520
Reviewed-on: https://chromium-review.googlesource.com/789040
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525293}

Modified document.open testcase to more accurate for url as USVString type.
Merging this test in external/wpt where all URL-related test were added
for USVString type.

Bug: 
Change-Id: Ie00b677984d973b547b43f6efd47b490ad697fcd
Reviewed-on: https://chromium-review.googlesource.com/836287Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com>
Cr-Commit-Position: refs/heads/master@{#525292}

Speculative fix for crbug.com/794878
IIUC this is the only SessionManagerObserver implementation
which doesn't call RemoveObserver() when being destructed.

BUG=794878

Change-Id: I876f3f7b24e39097208578a11515bd565c469c64
Reviewed-on: https://chromium-review.googlesource.com/826911
Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525291}

Bug: 
Change-Id: I4f492623358849f6a296bfe7d6c85ffb52b85c73
Reviewed-on: https://chromium-review.googlesource.com/833936
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525290}

Move away from WTF DataLogF to VLOG

Usage:
  chrome --enable-logging=stderr --vmodule=*/heap/*=1

Change-Id: I379bb4fffa42986ce3efe593bd63547d12afef6e
Reviewed-on: https://chromium-review.googlesource.com/834509Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525289}

Currently, Extension::version() returns a pointer to a constant
base::Version. However, all extensions are required to have a valid
version (if it does not, the Init() call fails). It's perfectly
sufficient to return a const base::Version& here and avoid callers from
having to dereference the return value (which is mostly just cognitive
load).

TBRing for mechanical changes:
TBR=jdufault@chromium.org (c/b/chromeos/login)
TBR=apacible@chromium.org (c/b/media/router)
TBR=atwilson@chromium.org (c/b/policy)
TBR=proberge@chromium.org (c/b/safe_browsing/incident_reporting)
TBR=bauerb@chromium.org (c/b/supervised_user)

Bug: None
Change-Id: I233c5822bf32d10a9a1ad0c009b6b566a80a5fd8
Reviewed-on: https://chromium-review.googlesource.com/828580
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525288}

It looks like HTML parsing on win dbg is so slow that the final
task that will end the test might get delayed for more than 30s
resulting in flaky timeouts.

Test this theory by opening the new tabs in new processes, so the
tasks has a higher likelihood of being executed on time.

R=mkwst@chromium.org
BUG=753691

Change-Id: Ia745e531a9a3f01851af199344b6863ca41758fa
Reviewed-on: https://chromium-review.googlesource.com/833939
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525287}

This reverts commit f07e903f.

Reason for revert: This CL makes net/ depend on Blink, and it makes build time of net/ very long.

Original change's description:
> net: Make net/ work with v8_context_snapshot.bin
> 
> We are planning to replace snapshot_blob.bin with v8_context_snapshot.bin.
> This CL makes net/ code to load v8_context_snapshot.bin to work with it.
> 
> Bug: 789964, 764576
> Change-Id: Ifcbe58d632dd76fd4bcc02182044d1e111f4267a
> Reviewed-on: https://chromium-review.googlesource.com/810347
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522648}

TBR=peria@chromium.org,mmenke@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 789964, 764576, 794234
Change-Id: I1e92c339914a6e2b1f33d280e4b41207213688b9
Reviewed-on: https://chromium-review.googlesource.com/836247Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525286}

MSVC noted the unsigned |n| = size_t |blocks| could be a possible
loss in precision. No loss in precision occurs since (n > blocks)
at this point: |blocks| fits in an unsigned type.

To silence compiler warnings, first update BUILD.gn for the adler
SIMD code to use chromium compiler:chromium_code rule (more error
checking), rather than the permissive "compiler:no_chromium_code"
rule. Then cast |blocks| to unsigned on assigment to |n| (this is
safe to do as mentioned above).

No change in behavior, no new tests.

Tbr: cblume@chromium.org
Bug: 762564
Change-Id: Ia97120bcca206287fd42b97674f8a6215283e4a5
Reviewed-on: https://chromium-review.googlesource.com/835927
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525285}

This might be a similar issue to https://crrev.com/c/824322 .
An idle task (callback function) is removed from the target of
wrapper-tracing during its use.

This might be a cause of crashes at ScriptedIdleTaskController.
This patch fixes it to hold the object until the end of its use.

Bug: 792604
Change-Id: I2ec7f7a78f13334778575c96708f45a4cf8da3b5
Reviewed-on: https://chromium-review.googlesource.com/824008
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525284}

Geolocation::HandleError discards TraceWrapperMembers (notifiers)
in the middle of their use, so wrapper-tracing stops working.
If V8 GC runs while the callbacks are running, as
TraceWrapperMembers are already cleared, the underlying V8 objects
will be gone.

This patch fixes the issue making Geolocation hold
TraceWrapperMembers during the invocation of the callbacks.

Bug: 792604
Change-Id: I6eedc5bc3d82806b1ab0ee2cf2fc3d7a8a018e14
Reviewed-on: https://chromium-review.googlesource.com/824322Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525283}

Bug: None
Change-Id: I4e94511f39c2d55806a2827b19a6801ee29dce19
Reviewed-on: https://chromium-review.googlesource.com/835931Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525282}

Before this CL, "base URL" was tracked only for ModuleScript (which map
to spec concept "module script"). In the latest spec, it says that the
"base URL" is now "script"-level concept (concept-script-base-url) which
both ClassicScript and ModuleScript should track. This CL aligns Blink
implementation to the spec.

No behavioral change is expected from this CL.

Bug: 796034
Change-Id: I86b8efe1f3980e3b6ab4743a35eeefaef639f0fd
Reviewed-on: https://chromium-review.googlesource.com/833434
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525281}

To know whether the test has a bug or the test is just slow.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=service-worker-v8-cache.js

Bug: 789111
Change-Id: I7aa771ca9712882c261e46d6af48241dac465a0c
Reviewed-on: https://chromium-review.googlesource.com/835967Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525280}

This removes a minor code duplication. AddRef is now only called in one place,
ie the constructor taking a raw pointer. Note that Release is already called in
one place only, ie the destructor.

Change-Id: I4fcd72ec0bcf4eb9269f593e171304223ef1dc0a
Reviewed-on: https://chromium-review.googlesource.com/835288Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525279}

See the bugs for details. This change was done using clang-tidy as
described here:
https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md

Where the tool replaces a member initializer list it leaves behind commas
(https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with:
  git diff --name-only | \
    xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/'

BUG=778959,778957
R=haraken@chromium.org

Change-Id: I522434dc0d25d1e6c4b04fbc6e17a95f5de1febc
Reviewed-on: https://chromium-review.googlesource.com/835747
Commit-Queue: Chris Watkins <watk@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525278}