- 18 Jun, 2020 40 commits
-
-
Edward Lesmes authored
METADATA.chromium are new files defined by a proto schema that accommodates team, OS, and component information, and that is extensible and structured, to replace the metadata information currently stored as OWNERS files comments. See the proposal for more details: https://docs.google.com/document/d/17WMlceIMwge2ZiCvBWaBuk0w60YgieBd-ly3I8XsbzU/preview Change-Id: I271b8f4cee03951c1fe3c64dad5aa0661234636a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248340 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779868}
-
Paul Lewis authored
Adds support for nav start times ahead of https://crrev.com/c/devtools/devtools-frontend/+/2252159 Bug: 974550 Change-Id: I67af15f1f21af81454e7683541646b1b8d4c0171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252140 Auto-Submit: Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#779867}
-
Scott Violet authored
BUG=1042771 TEST=WebMessageTest Change-Id: I36a550146fc15bcb76bbcfaca617ddbf79fa5792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250923 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779866}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d3394c28b80c..73bba61486a0 2020-06-18 shaochuan@chromium.org Fix DetermineAndroidBranch in various places 2020-06-18 chrome-bot@chromium.org Update config settings by config-updater. 2020-06-17 vapier@chromium.org gs: upgrade to gsutil-4.51 2020-06-17 vapier@chromium.org retry_util: fix bytes-vs-string handling in curl retries 2020-06-17 cjmcdonald@chromium.org cros_extract_deps: Add flag to disable solver backtracking 2020-06-17 tcwang@google.com afdo: Improve sample threshold on AFDO profile creation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia686aa57f39e94d4734b620bc8c8522b67c8d339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252023Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779865}
-
Andrey Zaytsev authored
Screenshots: Light mode: https://screenshot.googleplex.com/c5hr9M0ypqp.png Dark mode: https://screenshot.googleplex.com/iv2wB2Dih0s.png Bug: 1070620 Change-Id: Ie256680755395d0de1713af48bb8975f96f7a213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238066 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#779864}
-
Mehran Mahmoudi authored
This CL extracts the existing TabViewManager into an interface and moves it to the Tab module. It also changes the TabViewManager ownership model from being owned by UserData, to Tab. Design doc: http://go/modularize-tvm Bug: 1074348 Change-Id: Ie1d753f60daff0fab91bae71803d7672e7fa0380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230282Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779863}
-
Yves Arrouye authored
What used to be a check for zero-touch enrollment (initial enrollment) is now been shared with other features and is referred to as initial state determination. Update types etc. to use this language. A subsequent CL will deal with UMA. Bug: chromium:1093509 Test: check log messages Change-Id: Iad47ee2e4e6c687a9f05afe88d5bfdd4e52b40f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240251Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#779862}
-
Chris Blume authored
This CL adds UMA histograms for the 1st, 2nd, and 3rd-5th animation loops. The histogram tracks the number of frames skipped. We expect to see a fairly large quantity of small skips in the 1st loop. This has the effect of leaving holes in CC's cache. The 2nd loop would then have a larger number of frames skipped because filling the holes in the cache will cause multi-frame decodes. The 3rd-5th loops should begin to normalize to 0 frames skipped. Bug: 1094716 Change-Id: I85d22e1223d65bde398451fba1a9aff36698c114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245665Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#779861}
-
Xida Chen authored
This CL removes TouchAction.* related histograms. The reason of removing those is that we can't get useful info out from it. Here is the doc for compositor touch action: https://docs.google.com/document/d/1bSv_qNsLLnpXImuH7sHa6D3R_0GdDYkTiNjxso8Rgxo/edit In the doc, there are 3 phases and currently we have phase 1 completed. Here is a short summary for phase 1 & 2: phase 1: for GSU, if it is not allowed by allow lsited touch action, then let's put it in a deferred gesture event queue, and wait for the touch action comptued by blink to process that queue. phase 2: for GSU, if the allow listed touch action is PanX or PanY, then accumulate the delta on the y / x axis, and then wait for the blink computed touch action to tell whether the accumulated delta should be dropped or allowed. This isn't carried out because it will have user-facing behaviro change. So in order to evaluate how impactful phase 2 would be, we need the following info: When a GSU is put in deferred queue (which is only 0.01% of all GSUs), how often does that GSU is allowed / filtered by the blink computed touch action. Our current histograms don't give us that. Also, basically on the amount of GSUs that are put in the deferred queue (0.01%), it is probably not worth to carry out phase 2. Bug: 1089591, 1089592 Change-Id: Iaa2e1011ac3fa1d4a124a60424d97b329b39647f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246934Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779860}
-
Leonard Grey authored
This fixes a glitch when detaching tabs. See bug description for details. Bug: 979743 Change-Id: If59f7144817ef2d7da917fd483408ee082a3192a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248739Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#779859}
-
Andrew Grieve authored
Bug: None Change-Id: I17a8d301b67a8b2a5fc94f921fd2121a5469e5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242640 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779858}
-
Stephen McGruer authored
This test is flaking on all platforms and turning bots red. TBR=kolo@chromium.org Bug: 1090625 Change-Id: I0bc59e2e472e686df45265485b20ef54beea6d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251088Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779857}
-
John Lee authored
With the introduction of TabGroupChange::kMoved, there were multiple tab-group-moved events being sent, one for the group moving and one for the tabs in the group moving. This CL removes one of these events. This CL also selects a group's tabs when the WebUI tab strip moves the group to mirror the native tab strip and to allow the TabStripModelChange::kMoved events of the group's tabs to be ignored correctly. Previously, tab-moved events were being sent for each tab when a group was moved using the WebUI tab strip which caused for multiple unnecessary animations. Bug: 1082344 Change-Id: I663d46e2e9a9857cdbaba8c17d2ff526f2a2fff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246956 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#779856}
-
Eugene But authored
Some crashes required changing device orientation in order to reproduce. This CL logs specific orientation value after receiving UIDeviceOrientationDidChangeNotification Bug: 1046225 Change-Id: Iacf291b3ee561759a2ccd2d5c866349aaafacdf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250505Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#779855}
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I025073a317a6a741f37aa8518340cf2e1b9dcce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249764 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779854}
-
Viviane Yang authored
Directories do not exist anymore: //content/child/push_messaging/ //third_party/blink/public/platform/modules/push_messaging/ Bug: None Change-Id: I1fef1e66b2de1d7f6c43090cda33b800724a7fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250007Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#779853}
-
Hans Wennborg authored
38f6034998cc fuchsia: add invtsc to qemu command line 032f1aecc2ee Include-what-you-use related to logging.h Bug: 1031540 Change-Id: Iad420a52c15da204f52b1594522889c59de8f052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252139 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#779852}
-
Bartek Nowierski authored
The latest rewrite attempt revealed a couple more classes of compiler errors, that would be hard to handle automatically in the rewriter. We also found culprits for a bunch of run-time errors related to pointers being assigned invalid address with tops bits set. Bug: 1069567 Change-Id: Id8713344e602a2d995d2464a925f2892466a1652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249270 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#779851}
-
Ben Blake authored
Change-Id: Idf090e8c108c54dac39ca34e43967ad62ef432a0 Fixed: 1010212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248640Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ben Blake <fiorito@google.com> Cr-Commit-Position: refs/heads/master@{#779850}
-
Kyle Horimoto authored
This CL adds search tags for non-split sync settings when the split sync flag is disabled. Fixed: 1091061 Change-Id: I59848a1128ff6115df477918281171f3a00f1769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251170Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#779849}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55ac3e87d96a..0ca3d7910867 2020-06-18 almuthanna@google.com Add tests for breakpoint scenarios If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1091116 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I301dc21d5975a4de43ecbccf40a02d6d249e7913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779848}
-
Matt Menard authored
Reports app info activity up to the current time instead of to the end of the previous day. Account for concurrent states in app instance updates. Give better messages for app activity matchers. Bug: 1058453 Change-Id: I06274894768eb5a5c222fcfdea0bce903dc512f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249271Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#779847}
-
Kyle Ju authored
Fix importer failure due to flaky failures on external/wpt/webaudio/the-audio-api/the-audiocontext-interface/processing-after-resume.https.html Bug: 1096493 Change-Id: Ib9448cc50974b6d19df8cbc4e5cc7a178e619ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252298Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#779846}
-
Vasilii Sukhanov authored
reminder. The bubble appears after save/update password bubble reminding the user about the remaining issues. Bug: 1049200 Change-Id: I289938d66911453fce34923bf9db2b7515bc29d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249937 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779845}
-
Dominique Fauteux-Chapleau authored
The max time increases from 10 seconds to 6 minutes to get a better view of the worst times for this metric. This is achieved by replacing the histogram with SafeBrowsingBinaryUploadRequest.TimeToGetFCMToken Bug: 1094398 Change-Id: Ied5c9d53de67e349096b240f5f83b9f2f9441e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243596 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#779844}
-
Dana Fried authored
Fixes a bug where a clipped favicon was sometimes visible in a collapsed tab even when the tab is collapsed. Tabs which are in collapsed groups *and* which are zero-width (so not counting tabs which are animating to or from the collapsed state) now cause TabStrip::ShouldTabBeVisible() to return false. Bug: 1094051 Change-Id: Ie696a6e8442f6a4a761b7dee279da2e1a96ea1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251738 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779843}
-
Alexander Timin authored
Some users might want to pass NullRemote if they are not interested in observing cookie-related notifications. The network service already supports null remote, so update the mojom to reflect that. R=kinuko@chromium.org BUG=1095600 Change-Id: I8be8a319a6b06d18400c05b3d452fec44b20f024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250064Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779842}
-
Andre Le authored
Add CHAR_LIMIT attribute to strings used in Status Tray. BUG=1082967,1076307 Change-Id: Ia6819ab8c40563fb81dc9695eb15069819a6be84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250998 Commit-Queue: Andre Le <leandre@google.com> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#779841}
-
Scott Violet authored
This changes RemovePositionedObjects to remove any fixed-pos descendants. This ensures that if the removed object is added back, it doesn't end up after any descendants, which would cause out of order layout. BUG=1092887 TEST=webkit-box-fixed-position-child.html Change-Id: I41f01bad74048cf4983f0dda5fe0f073b3eb38f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248136Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779840}
-
Antonio Gomes authored
.. instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=407136 R=guidou@chromium.org Change-Id: Ibc60f16f8aab681fab91b5fff9b5c7b004d49607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248160 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#779839}
-
David Jean authored
Bug: 956511 Change-Id: I3f64f693d26d0db9f54f84ef7e2a36fa713434d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247764 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#779838}
-
Victor Hugo Vianna Silva authored
crrev.com/c/2246157 is suspect of causing failures in CrSettingsPasswordsSectionV3Test. This could be caused by click events in the new tests not being flushed, so this CL adds missing flush() calls. Bug: None Change-Id: I3abff7ddb894aa4a3cb3f7cf0dd2a06c7f05ec73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252138 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779837}
-
Daniele Castagna authored
SurfaceAggregator has an option to output only quads that intersect the damage rect computed by SA itself. crrev.com/c/2205886 re-enabled a SurfaceAggregator optimization for GLRenderer but left it disabled for SkiaRenderer/ This patch enables the optimization for SkiaRenderer. Bug: 925181 Change-Id: I1ad90ab2ec0d3a5b5444350ffadb7c3a5f2469ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250780Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#779836}
-
Sebastien Lalancette authored
The fix is to get the root VC to dismiss our hierarchy. If we simply use the current VC then, when the pop-over is presented, only that pop-over will be dismissed (as per the UIKit documentation and as per this bug). Bug: 1093908 Change-Id: Ia576910873acec1163f54abf8012210d13e016fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241995Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#779835}
-
OlivierLi authored
Bug: 1075553 Change-Id: Ie863e35e110966efa62c4a3eaf8ac4dd4b0fa46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248072Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#779834}
-
Ali Juma authored
The WKNavigation for a committed interstitial is used in the callback passed to ChromeWebClient::PrepareErrorPage, in order to commit the associated navigation item. For SSL interstitials, this callback is called later, asynchronously. This means that deleting the navigation in didFailProvisionalNavigation later leads to a crash when attempting to access the navigation's item, in the case where the error page load is triggered in didFailProvisionalNavigation. This happens in ErrorRetryStateMachine::DidFailProvisionalNavigation when the current webview URL is a restore_session.html URL. This CL fixes this crash by not deleting the navigation in didFailProvisionalNavigation when it is for a committed SSL interstital. There is already similar logic for deciding whether to delete a navigation in didFinishNavigation. Change-Id: Ib8aabeeeca33f63b313daa0772990b8b841d462a Bug: 1050808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248137 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#779833}
-
Lucas Furukawa Gadani authored
Bug: 967204 Change-Id: I276e6f8d8bdc3d317f5ce58f138d77601ee3c878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248059Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779832}
-
Christian Dullweber authored
The opt-in for account storage of passwords needs to be reset after password deletion is finished and committed to the sync server. Add integration test for password deletion for account storage. Bug: 1052005 Change-Id: I342f60b076a2ee0a7a8dfae0de4341b7ab684cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250186 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779831}
-
Xiyuan Xia authored
Replace AnimationMetricsReporter with AnimationThroughputReporter to use new code path for smoothness metrics. Bug: 1021774 Change-Id: I1d15a836b43bacb80cc244a840cbe01de6f34ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250502Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779830}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592470587-41d382284b84615cf61150faa274f216b9eaf19d.profdata to chrome-win32-master-1592481559-cd0ac58705eebf31c71fdcab35041388ee8d8f2d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I88e2910db16e04936c763fe84c8b8a01d58a8829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779829}
-