- 16 Sep, 2019 40 commits
-
-
Paul Lewis authored
Change-Id: I1ea19eee040360d3a73ffaa72ccf15bceff80317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806858 Auto-Submit: Paul Lewis <aerotwist@google.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Paul Lewis <aerotwist@google.com> Cr-Commit-Position: refs/heads/master@{#696789}
-
Paul Lewis authored
Change-Id: I5cb1c1ffe83a72cad499ae54ba513afb992797ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805668 Auto-Submit: Paul Lewis <aerotwist@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c4e80ad3bbc5..7bf7a427bfcc git log c4e80ad3bbc5..7bf7a427bfcc --date=short --no-merges --format='%ad %ae %s' 2019-09-16 nisse@webrtc.org Delete flag VideoReceiveStream::Config::Rtp::remb Created with: gclient setdep -r src/third_party/webrtc@7bf7a427bfcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2a95b1e245fe38777e8b66bb2c02a4c0dc7d0f59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805720Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696787}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia8606026c630eb3f7eb7a53cc5e3a54bd66fdcc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805910Reviewed-by:
-
Mathias Bynens authored
Previously, the third-party badges in the Network pane weren't legible with the DevTools Dark Theme enabled. This patch fixes that. Screenshot: http://goo.gle/devtools-dark-3pb BUG=1003942, 1004246 Change-Id: Idea50cd4fbe458d171fbd7468dd0394a7a28ef04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805658Reviewed-by:
-
Jan Krcal authored
This CL prepares for animating highlight+background+label color whenever a non-empty text or highlight-color gets set and animating it back when it gets removed. This CL changes the API to better match this planned behavior. The new API sets (and clears) these two properties in one call. Bug: 967317 Change-Id: I5d6d59588e35095b54af22800162bed9024b4d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793165 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#696784}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd10454c..ca6206c6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I009a0869b2018902fd493b10237809ac1b3017bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806973Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696783}
-
Yann Dago authored
Bug: 1002307 Change-Id: Idb6c44387a7e8f89127610a8a7ac2524919ad145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802539Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#696782}
-
Giovanni Ortuño Urquidi authored
This reverts commit 79901dcd. Reason for revert: Breaks cc_unittests https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20CFI/builds/14983 https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14997 [ RUN ] LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor15_ScrollChild ../../cc/trees/layer_tree_host_unittest_scroll.cc:671:9: runtime error: control flow integrity check for type 'cc::FakePictureLayerImpl' failed during base-to-derived cast (vtable address 0x55dc2aba43f0) 0x55dc2aba43f0: note: vtable is of type 'cc::LayerImpl' dc 55 00 00 70 1b a3 29 dc 55 00 00 d0 1c a3 29 dc 55 00 00 90 22 a3 29 dc 55 00 00 e0 cd cc 28 ^ #0 0x55dc29270c7d in cc::(anonymous namespace)::LayerTreeHostScrollTestCaseWithChild::DidActivateTreeOnThread(cc::LayerTreeHostImpl*) ./../../cc/trees/layer_tree_host_unittest_scroll.cc:671:9 #1 0x55dc29c10044 in cc::LayerTreeHostImplForTesting::ActivateSyncTree() ./../../cc/test/layer_tree_test.cc:289:18 #2 0x55dc29bdeba4 in cc::ProxyImpl::ScheduledActionActivateSyncTree() ./../../cc/trees/proxy_impl.cc:640:15 #3 0x55dc29aa86fd in cc::Scheduler::ProcessScheduledActions() ./../../cc/scheduler/scheduler.cc:821:18 #4 0x55dc29bdbe36 in cc::ProxyImpl::NotifyReadyToActivate() ./../../cc/trees/proxy_impl.cc:323:15 #5 0x55dc29c0f83a in cc::LayerTreeHostImplForTesting::NotifyReadyToActivate() ./../../cc/test/layer_tree_test.cc:249:26 #6 0x55dc29b09dda in cc::TileManager::IssueSignals() ./../../cc/tiles/tile_manager.cc:1448:16 #7 0x55dc29b05bbb in cc::TileManager::CheckPendingGpuWorkAndIssueSignals() ./../../cc/tiles/tile_manager.cc:1698:3 #8 0x55dc29b021c8 in cc::TileManager::FlushAndIssueSignals() ./../../cc/tiles/tile_manager.cc:1436:3 Original change's description: > Remove viewport features from PropertyTreeBuilder > > These features are not used in ui compositor, so PropertyTreeBuilder > doesn't need to support them. > > Bug: 994361 > Change-Id: I5159cf8ab36cd42e4807a1d190f987b4e07c0407 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804383 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696658} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 994361 Change-Id: I919048adf9c88511a8c58aae6170c8944035d64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804943Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#696781}
-
Henrik Boström authored
This attempts to fix various failures in https://crbug.com/999136 due to our browser tests expecting non-standard stats even after chrome://webrtc-internals/ was updated to use standard getStats() by default. Bug: 999136, 1004239 Change-Id: Ia22ab8ab36213253801109a23b43838ffa24dc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806677Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#696780}
-
Ivan Sandrk authored
Extending the histogram for another 6 months as the bug this was introduced for isn't fully fixed yet. Bug: 988722,864672 Change-Id: If9b738f3600f7a0343cbc748679f8e430405961e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801768Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#696779}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b8a20f9d9f71..51ac9ed8487b git log b8a20f9d9f71..51ac9ed8487b --date=short --no-merges --format='%ad %ae %s' 2019-09-16 zhuohao@chromium.org puff: add board and paladin Created with: gclient setdep -r src/third_party/chromite@51ac9ed8487b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ifb4779762e9544e865e10cd7b28c98384c26c418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805909Reviewed-by:
-
Nikita Podguzov authored
This observer is called when new print job is saved. This is required to fire corresponding chrome.printingMetrics events. Bug: 992889 Change-Id: I9c8c980201e2ea181cf80b5b40bc7806bcd6c559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780830 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#696777}
-
Hans Wennborg authored
They were previously disabled on Windows, Mac, and ChromeOS. It turns out they also don't pass for me locally on Linux, or on the Clang ToTLinux bot (see bug), presumably for the same reason. Disabling until these tests can be fixed properly. Bug: 1004245 Change-Id: I82a14fb2d0c9be7ab051319ddeb85e98e0c22adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804480 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#696776}
-
Boris Sazonov authored
Error example (lines wrapped): ui/android/java/src/org/chromium/ui/UiUtils.java:85:12: "private" modifier out of order with the JLS suggestions. The correct order: public protected private abstract default static final transient volatile synchronized native strictfp. See https://crbug.com/1003711 for details. Bug: 1003711 Change-Id: Ib71d5e948dfc8a59581c7080d9241ac5523b2556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803140 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#696775}
-
Jan Scheffler authored
Until now, selected but not focused items with a network error in the network pane where not distingushable from items without a network error. This patch fixes the problem by keeping the font red. Bug: chromium:843014 Change-Id: I43097fdcd41b3fe4e7a4c893f1b61f9cd3dbeebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787501 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11fbf615cfd5..31815d4a1d20 Created with: gclient setdep -r src-internal@31815d4a1d20 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic73161f76a17cbf8db5004e90dd30e4d83c06468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805906Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696773}
-
Dominic Farolino authored
This reverts commit 04dc0257. Reason for revert: This was a debugging CL to help get information on a DumpWithoutCrash. Original change's description: > Add referrer DumpWithoutCrash to WebURLLoaderImpl > > The network service's > OnCancelURLRequestWithPolicyViolatingReferrerHeader method is called > after it has been determined that a URLRequest's referrer does not match > what the policy demands. This method performs a DumpWithoutCrash for > debugging. However, this is called within the network service, so the > path of the request's creation is not captured in the stack trace, > making it less useful. > > This CL checks whether or not a request's referrer matches what its > policy demands earlier, when a network::ResourceRequest is created by > WebURLLoaderImpl. This captures a better picture of a renderer-initiated > request's origins in the stack trace, which is much more useful for > debugging. > > Bug: 1004083 > Change-Id: I867e488a860e2ac042a1eb93bff04e5f10a3126e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803936 > Commit-Queue: Dominic Farolino <dom@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696684} TBR=yhirano@chromium.org,mmenke@chromium.org,dom@chromium.org Change-Id: If4759af2fa77deb36fd36a75b0a09f496f06a79f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1004083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806617Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#696772}
-
Colin Blundell authored
I no longer need to be broadly observing changes to these directories given the evolution of the projects. TBR=jochen@chromium.org Change-Id: Icccc6eafcd490c22e0a0f9d2e93989c5d78d210b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806577Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#696771}
-
Nikita Podguzov authored
This is the main service responsible for maintaining print job history. There is one instance of the service per profile. Bug: 992889 Change-Id: I627c606e58384d8fcdc977be4e181017308c596d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778765 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/746bc59b27a5..b452682a79ea git log 746bc59b27a5..b452682a79ea --date=short --no-merges --format='%ad %ae %s' 2019-09-16 hjd@google.com Merge "Replace uses of tolower/toupper" 2019-09-16 tneda@google.com Merge "perfetto-ui: Checking counter information is not undefined" 2019-09-16 fmayer@google.com Merge "Fix x86 build." Created with: gclient setdep -r src/third_party/perfetto@b452682a79ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic5c8428aa4caeb97058da253b8e85f1d73d2e8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805908Reviewed-by:
-
Ioana Pandele authored
This reverts commit b8d7b695. Reason for revert: This looks like it breaks Incognito/ExtensionWebRequestApiAuthRequiredTest.WebRequestAuthRequiredAsync/0 and UserProfile/ExtensionWebRequestApiAuthRequiredTest.WebRequestAuthRequiredAsync/0 on ASan bots Bug:1004250 Original change's description: > Speculative fix for WebRequest memory leak > > It seems the WebRequest is leaking InProgressRequest objects (see bug). > We were not catching errors on the loader binding, which may have caused > us to miss the errors. > > Bug: 999681 > Change-Id: Iab30e74f6af4649548528feeddceeeb297b92e2d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772060 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696216} TBR=karandeepb@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 999681 Change-Id: I3943981a16f1ee4f7b3827c3a7272628010bd625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804477Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#696768}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7af1bb3f90b3..c4e80ad3bbc5 git log 7af1bb3f90b3..c4e80ad3bbc5 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 nisse@webrtc.org Delete forward declarations from peer_connection_interface.h Created with: gclient setdep -r src/third_party/webrtc@c4e80ad3bbc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I44b51759d4fae979a1500ed82c1d60f1ddff30e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805907Reviewed-by:
-
Ioana Pandele authored
This reverts commit 100a20fb. Reason for revert: BookmarkAppTest.EngagementHistogramNavigateAwayFromAppTab/0 failing on Mac and Windows Bug:1004259 Original change's description: > desktop-pwas: port BookmarkAppTest to use WebAppControllerBrowserTest > > In preparation for testing with WebAppBrowserController, change > BookmarkAppTest to use WebAppControllerBrowserTest. > > Similar to reverted CL > https://chromium-review.googlesource.com/c/chromium/src/+/1787758 > which experienced win-asan failures with observer lists on shutdown. > > Observer list issues on shutdown have been addressed by > https://chromium-review.googlesource.com/c/chromium/src/+/1800884 > > Bug: 966290 > Change-Id: I1180a12ad4a2f23255f9c711a40da21e71a5d205 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801401 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Auto-Submit: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696705} TBR=ericwilligers@chromium.org,alancutter@chromium.org Change-Id: Ic7b4ad74c7bff32d6986d92245c979123d4de164 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966290 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806856Reviewed-by:
-
Nico Weber authored
Also replace two assert()s with the newer and here more-appropriate not_needed() Bug: none Change-Id: I48445701b0d15d648d3083fc0103def9a5b2aa68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804319 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#696765}
-
Ioana Pandele authored
TBR=danan@chromium.org Bug: 1004237 Change-Id: I4046bbc005ee6bd26b337542f0c535b315ac3126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806854Reviewed-by:
-
Aya ElAttar authored
Bug: 459238 Change-Id: Ib30d853a2662543f806cb47199cf4659d02822d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782481Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#696763}
-
Jan Krcal authored
This CL prepares for animating the button smoothly with AnimatingLayoutManager. It sets the inset on the label view itself so that: - GetUnclampsedSizeWithoutLabel() does not include this inset. - The inset works well with showing and hiding the label by an animation. Bug: 1002160 Change-Id: I402c211bb5ce9b8dae7f452d2c85d9d05ce09c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793086 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Tim van der Lippe authored
The new compiler caught a lot of pre-existing issues in the codebase. Sadly, the old compiler version was not smart enough to understand the new changes. Therefore, the changes have be included in the same CL as the compiler update. Most of the changes are related to better handling of prototype and class inheritance, as well as handling of null/undefined tracking. Change-Id: I3941a3a240a4d09c4945e1e20d2521090ef837c9 Bug: 991710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762081Reviewed-by:
-
Ioana Pandele authored
TBR=estade@chromium.org Bug: 1004228 Change-Id: I1ac3a8dc1bad8b53a02dd83648337f1355f8c552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806873Reviewed-by:
-
Ioana Pandele authored
This reverts commit 41edd5e1. Reason for revert: external/wpt/orientation-sensor/AbsoluteOrientationSensor.https.html external/wpt/orientation-sensor/RelativeOrientationSensor.https.html are consistently failing on Mac. Bug:1004253 Original change's description: > Use computed font-size for em/rem resolution. > > This makes us match how Firefox applies minimum font-size and makes us > not break relative length computation when pages use a font-size less > than the user's minimum font-size as a basis for widths, heights, > margins, padding, etc. > > This is a behavioral change for relative lengths for the following > cases: > > - minimum-font-size does not affect em lengths > - minimum-logical-font-size does not affect em lengths > - text autosizing does not affect em lengths > - text scaling accessibility setting in Chrome for Android does not > affect em lengths > > Test expectation changes and reasons: > > Text scaling no longer applies to relative lengths (text zoom set from testRunner): > > svg/zoom/text/zoom-hixie-mixed-008.xml > svg/zoom/text/zoom-hixie-rendering-model-004.xhtml > svg/zoom/text/zoom-svg-float-border-padding.xml > > Minimum logical font-size not applying to relative lengths (minimum logical font-size set to > 9px when running layout tests): > > fast/backgrounds/background-position-parsing.html > virtual/controls-refresh/fast/forms/controls-new-ui/password/password-eye-icon-zoom-0.5x.html > http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm > > Bug: 308862 > Change-Id: I5e5fb99e69b516c9c0c3758d232cbae8f7f5894a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803281 > Reviewed-by: Emil A Eklund <eae@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696694} TBR=pdr@chromium.org,eae@chromium.org,drott@chromium.org,futhark@chromium.org Change-Id: Iaca7d3c69056f1b8f77ea4f212bf4abd08c613d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 308862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804478Reviewed-by:
-
Mikhail Khokhlov authored
This CL splits the processor module into two: * command_line module which is responsible for defining and processing command-line options. * processor module which is responsible for processing of intermediate results. Bug: 981349 Change-Id: I408697751e2425eeaa2cacecc0e15ab04f99c284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795765 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#696758}
-
Nico Weber authored
On x86_64 Windows, asm volatile("int3"); __builtin_unreachable(); now produces just "int3" instead of "int3; ud2" previously, so change immediate_crash.h to make sure TRAP_SEQUENCE() keeps expanding to "int3; ud2". The Windows code now matches the code we use for other x86_64 platforms (except macOS which is still different). Ran `./tools/clang/scripts/upload_revision.py b4160cb94c54f0b31d0ce14694950dac7b6cd83f`. Bug: 1002492,958373,1002498 Change-Id: I3c0c553fecb02468c62e8ee14ebd803aae966861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802536 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#696757}
-
Henrique Ferreiro authored
Migrate the remaining interface from input_handler.mojom. Bug: 955171 Change-Id: Ie384350201e81bd5c0a3e6869dbbb0c5c3f123c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798351 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#696756}
-
arthursonzogni authored
It was content/public exported, but not used at all. TBR: clamy@chromium.org Bug: None. Change-Id: I357f8190f6c24f772edb7f4e7b426976cbc59a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798607Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#696755}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/899716dc3240..746bc59b27a5 git log 899716dc3240..746bc59b27a5 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 fmayer@google.com Merge "Update docs about x86 known issue." Created with: gclient setdep -r src/third_party/perfetto@746bc59b27a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ic5373b2ce1724d816577e113e33c5b40a544af38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806416Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f02b13925471..11fbf615cfd5 Created with: gclient setdep -r src-internal@11fbf615cfd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I461d56710cb93446c0af51b3554b37033a75330a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805483Reviewed-by:
-
Morten Stenshorne authored
This will set temporary proper override sizes. We already use this mechanism in NGBlockNode::RunLegacyLayout(), but that one only has an effect for things that are done from within legacy layout (LayoutObject::Layout()). Overflow calculation happens after layout, and is done by the legacy engine, even for NG objects. Bug: 908083 Change-Id: I2b4e88c096f138aa820856e3c79e1ddcef07a3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801770Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#696752}
-
Clemens Arbesser authored
The UMA histogram AutofillAssistant.DropOutReason is currently showing incorrect data, because the number of autobot drop-outs adds up to more than the number of autobot starts. This likely happens because the shutdown procedure for autobot is different between closing autobot from the user interface versus closing Chrome entirely. As a consequence, dropout reasons are logged in two different places in code. We might be able to refactor such that we can avoid this in the future. For now and as a hotfix, this CL ensures that every instance of autobot can record at most one dropout reason. Bug: b/140371674 Change-Id: I17b882e1327be6228867321b4ba6536b45a6822f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780834Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#696751}
-
Alex Clarke authored
Previously the executors where using OnceCallbacks. The problem with that is we're going to redundantly invoke the callback destructor when we run the callback. This is redundant because the executor will overwrite itself (and the callback it contains) with the promise result. This patch takes advantage of the way Callbacks operate in chromium and casts the callback to the repeating version and passes a const ref to the executor. This eliminates the overhead of passing a scoped_refptr<Callback> by r-value. We still respect the once-ness of these callbacks despite these binary size shenanigans. Note Promises are experimental, not used in production code at this time. We are landing this only to make it easier to experiment with binary size. Bug: 906125 Change-Id: Ifd8f53e6dfdc6a65921b53222e05bdf384ac8df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803135 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#696750}
-
