- 07 Jun, 2019 40 commits
-
-
Natalie Chouinard authored
Before scheduling new notifications for prefetched offline pages, check the state of the Content Suggestions Notification preference setting. Start displaying the notification preference page on pre-O devices when the prefetched pages feature is enabled. On O+ devices, notifications are handled at the system level by Notification channels, so this pref can be ignored. Bug: 944912 Change-Id: I9e53fa2037952af4e98400416ed307ef8bbc3968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1586595 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#667278}
-
Liquan(Max) Gu authored
Currently FCP++ is not enabled during web-test because the feature_list override the config of runtime_enabled_features. As FCP++ has now been enabled by default, we should change this config of feature_list as well. Bug:966216 Change-Id: I8785b6c31cf6fe7af3f9662c3af50262cd137977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645897Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#667277}
-
Zhenyao Mo authored
1) The unsandboxed GPU process exit message becomes an empty message. This is a regression. 2) We are still referring the GpuProcessHostUIShim class, which no longer exists in code base. BUG=971931 TEST=about:gpu R=piman@chromium.org Change-Id: I84caee9721fd6a9030fd310ba07505245245ff6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649184Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667276}
-
Harley Li authored
In Application's service workers view, pass through the registrations' scope URLs directly from the backend to the frontend. Bug: 972106 Change-Id: Ieb20976e28e11c884d104a2a7f537fd78d7c686b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649305Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Harley Li <hhli@chromium.org> Cr-Commit-Position: refs/heads/master@{#667275}
-
Alex Moshchuk authored
This is a reland of https://crrev.com/c/1647151, with the change to shorten one key's length to below 40 characters to avoid a failed breadpad assert on dbg bots. (See https://cs.chromium.org/chromium/src/third_party/breakpad/breakpad/src/common/simple_string_dictionary.h?l=206&rcl=1fc9cc0d0e1dfafb8d29dba8d01f09587d870026) Bug: 970046 Change-Id: I7564761b098ad7f8b64cc33527e01df135db9a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650202 Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#667274}
-
Chris Harrelson authored
Instead of computing deadlines and lifecycle counts relative to last observation, inject the latest lifecycle count of the releveant frame generator (LocalFrameView) and the actual start time of the lifecycle. This simplifies the code somewhat, improves dependencies, and has two concrete benefits: 1. Uses the same deadline for all locks executed on the same frame. Previously each lock would compute its own deadline at the time WillStartLifecycleUpdate was called. 2. Allows skipping lifecycles if desired. e.g. if a lock is updating, but we decide not to doing anything for it for a given frame, we can skip it. This CL achieves benefit #2; benefit #1 is a possible future addition. Note that WillStartLifecycleUpdate is still required for all locks which are currently acquiring, updating or committing (but not quiesecent locks). The reason it's required is that there may be forced style or layout computations between lifecycles, and those end up clearing the dirty bits of the lifecycle. There needs to be a mechanism to re-set those dirty bits, and WillStartLifecycleUpdate is that mechanism. Bug: 968928 Change-Id: Ibe7e2c51631e7a93101563db41a444d01ae54162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642789 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#667273}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=mattreynolds@chromium.org Change-Id: I36fdabd895249be6a9c2c00952b90a2ba3b0855e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648203 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#667272}
-
Sky Malice authored
Bug: 968213 Change-Id: I5270ccb000096f0517cb7c15ff14055a1bfb8471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649176Reviewed-by:
-
Michael Thiessen authored
Fixes https://chromium-review.googlesource.com/c/chromium/src/+/1639639 disabling shortcuts. Bug: 972130 Change-Id: I4947ba268586ee22832da795dea104be6a2f2b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649404Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change replaces usages of base::ContainsKey() and base::ContainsValue() with base::Contains() in //device/fido. Reproduction: - sed -i 's/\bbase::ContainsKey\b/base::Contains/g' - sed -i 's/\bbase::ContainsValue\b/base::Contains/g' - git cl format This CL was uploaded by git cl split. R=engedy@chromium.org Bug: 970209 Change-Id: I00e6c5235e4e4e53429eed3cf3c3ac7d7df62165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648171 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#667269}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c843aa75..96e0999f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I59f0fae9aaedb0e16245843073fd6fe89f0cdb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649149Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667268}
-
Lambros Lambrou authored
This changes OAuthTokenExchanger's default mode to offline. This ensures that a non-empty refresh token will actually be delivered to the caller on Windows, instead of an empty string. This CL also updates OAuthTokenExchanger so that it no longer triggers every hour if offline-mode is used to provide a refresh token. The effect of this CL on non-Windows platforms is that OAuthTokenGetter will get an exchanged refresh token and will cache it in memory, using it to get new access tokens every hour. This will avoid hitting the TokenExchange server every hour. Bug: 971920 Change-Id: Ic0d3e3a9ca5a5e627ae135bb005dc186ebfb4e0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648730 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#667267}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/af0e045c2ee1..ac6fd191f872 git log af0e045c2ee1..ac6fd191f872 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 eashanbhatt@google.com vm_unittest: Add helper functions Created with: gclient setdep -r src/third_party/chromite@ac6fd191f872 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I899a6f4386b4a9dab8a3271d9a706b4bbdf10e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649642Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667266}
-
Clark DuVall authored
DataUseAscriber was deprected in favor of PageLoadMetrics (see http://crbug.com/836029). This removes all the old code that does not work with network service. Bug: 836029, 934009 Change-Id: Id07d1e3def8fbd50c7fbf5784c604db03cba6b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648818Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#667265}
-
Jun Cai authored
If user blocks the usage of Bluetooth scanning API, all previously granted permission should be revoked. This CL adds code to do that. Bug: 969112 Change-Id: I4040673c8ddbc49e6de4657cf43ce7a148e03f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636645 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#667264}
-
Wei-Yin Chen (陳威尹) authored
Bug: 971840 Change-Id: I8e105401276130c3d690c24e37228d80d18eddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648939 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#667263}
-
Yun Liu authored
Also change to use mixin for existing bots. Bug: 967011,961808 Change-Id: I68334b0c223a12ee0e0db48a86256ff20fbe0058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649057Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#667262}
-
Suman Nelson Kancherla authored
Bug: 972153 Change-Id: I7f2edf4621af6007d548214fdffbf4af4c4a0e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650082Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#667261}
-
Jose Dapena Paz authored
They depend on LockRequest, that depends on WeakPtr, none of them noexcept. Bug: 819294 Change-Id: I04ec15901ca627358df727540597f21f135c129b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646252Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#667260}
-
Kurt Horimoto authored
This CL adds the classes to support showing JS alerts via OverlayPresenter, and adds the alert coordinator to the OverlayModality::kWebContentArea supported classes list. Bug: 941745 Change-Id: I8fe4986cadedf80cb673d9b5f311f1320318af02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639517 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#667259}
-
rbpotter authored
See bug for screenshots. Bug: 971960 Change-Id: I1c85419251460630de612dd465773d80bfd6010a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649189 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#667258}
-
Josh Nohle authored
Bug: 951969 Change-Id: If21acded7077b018a15c61dd2b30a9b3d161bef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650029 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#667257}
-
Becca Hughes authored
Fix a race condition when notifying observers that a session was abandoned. BUG=971827 Change-Id: Ib0ec8188e7936cee2cd6676709dde408bc3ab3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648951Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#667256}
-
chrome://gpukylechar authored
1. Remove surface_synchronization. It's on everywhere at this point so it's not neessary to list it. 2. Make metal and surface control platform specific. They aren't relevant outside of MacOS and Android respectively. 3. Make features that are experimental or ongoing finch controlled roll out not show up in problems detected list when disabled. 4. Remove |needs_gpu_access| attribute since it's not used. Bug: none Change-Id: I9e9909d33d849e2025a550e0bd0d42eb90c00d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648650 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
-
Andrew Weintraub authored
Bug: pdfium:1320 Change-Id: I766c1207b42822b58ba1c142d5ae34017880fd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648777Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Andrew Weintraub <asweintraub@google.com> Cr-Commit-Position: refs/heads/master@{#667254}
-
Mihai Sardarescu authored
This CL is the first CL to remove the per-UnifiedConsent code from the sync confirmation dialog. The pre-UnifiedConsent sync confirmation HTML and JS are still for the case when sync is disabled by policy. Follow-up CLs will attempt to do the clean-up for these cases. Bug: 971183 Change-Id: I9b24b5b23fad9a0658ebea0ab0c80f3157e530ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645358Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#667253}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13f3e6190c83..cf4f55b6edc4 Created with: gclient setdep -r src-internal@cf4f55b6edc4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: Ic9913a274dc25f4d09ec517ae1d6f8c7a4cff522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650061Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667252}
-
Jeffrey Cohen authored
The new BVC command to show the send tab to self UI will be handled by this new coordinator. Bug: 970284 Change-Id: Ib57e91d8beee9f99ffa9de2b1ab57e07a25e6dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645209 Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#667251}
-
Yi Xu authored
Change-Id: I7ca3f8d00a48b0f61872363a36b565d68258dfad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646077Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#667250}
-
Aleks Totic authored
We already had a fix for inline, misssed fixing it for block. Bug: 967977 Change-Id: Iad883eca7761f0db203fc6e01d48466d7b09dfd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648299Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#667249}
-
Erik Chen authored
This makes the generated build files deterministic with respect to build path. Bug: 871574 Change-Id: Icf30415f6505710d45743d3921b0ae73b83c6a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649301Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667248}
-
Matthew Mourgos authored
Bug: 883163 Change-Id: I49b5c18601bb53f3f199aff9363d84a0ae1f7dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644597Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#667247}
-
Vincent Boisselle authored
This is a reland of a2d78e6e Original change's description: > Reland "Reland "Added handling of large requests to Autofill API."" > > This is a reland of 4149e2e9 > > Original change's description: > > Reland "Added handling of large requests to Autofill API." > > > > This is a reland of c6677df1 > > > > Original change's description: > > > Added handling of large requests to Autofill API. > > > > > > Increased the limit of Query GET requests, added a POST Query fallback, and > > > added UMA metrics to keep track of URL length and associated events. > > > > > > This change might be needed when metadata is enabled. > > > > > > Bug: 948862 > > > Change-Id: If0934a685758ab8999ceea6ce22a27499e4f772f > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549615 > > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#656080} > > > > Bug: 948862 > > Change-Id: I29eee8f16ae6c3775eb31e8e95d4a289c31f1485 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594618 > > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > > Commit-Queue: Vincent Boisselle <vincb@google.com> > > Cr-Commit-Position: refs/heads/master@{#656452} > > Bug: 948862 > Change-Id: I8fdc33c0e496862232dfed6e13349e55fbd36e07 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594190 > Reviewed-by: Roger McFarlane <rogerm@chromium.org> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Commit-Queue: Vincent Boisselle <vincb@google.com> > Cr-Commit-Position: refs/heads/master@{#662780} Bug: 948862 Change-Id: Ie27a8325eaba03a2158e3a441436fcebcab1a56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642815Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#667246}
-
Dan Beam authored
while on chrome:// URLs This allows us to use this mechanism in CSS: @media (prefers-color-scheme: dark) { } to vary styles for Chrome web UI in dark mode while also disabling via feature on certain platforms. This unblocks us from migrating to the @media query (from the existing [dark] attribute syntax) and later removing a bit of JS/C++ custom code in favor of simply using the web platform. R=futhark@chromium.org BUG=965811 Change-Id: I79f4582ce21661d7ba2f6a33f3f054f5ff62d0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626024 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#667245}
-
cjamcl@google.com authored
Change-Id: I29fce7fafe5ab0923eed465fb58fcf5def079689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1355195Reviewed-by:
-
Alexander Hendrich authored
SCREEN_OOBE_WELCOME was (mostly) removed in https://chromium-review.googlesource.com/c/chromium/src/+/1520310/8/ui/login/display_manager.js except for one occurrence. This occurrence prevents the ctrl+alt+E key combination to work on network and eula screen and also produces error log output. This CL removes the remaining occurrence. This change is safe since its old behavior was already replaced by attributes.postponeEnrollmentAllowed, which is true for the welcome screen. Bug: 965391 Change-Id: Ie8d80c25b8c240f1f5d36ab7c28d15143e48474d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640407 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#667243}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=bialpio@chromium.org Change-Id: I39077687bd9eadfa2b1ce2c05b00b3687d2b8aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648268 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#667242}
-
Anne Lim authored
Add CloudTokenData to WalletMaskedCreditCard. This is a part of b/133228158. Change-Id: I18a8d58d0ef42921fa47158c0fc519de8e88c60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647377 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#667241}
-
Vincent Boisselle authored
Reland "Changed the way the Query URL is matched in the JSON file and re-added unittests (only for Linux)" This is a reland of 4e636d5e Original change's description: > Changed the way the Query URL is matched in the JSON file and re-added unittests > (only for Linux) > > Bug: 954379 > Change-Id: I0fa6d80dd56cc239ed2eaa554c89b0700950acf6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574899 > Commit-Queue: Vincent Boisselle <vincb@google.com> > Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656495} Bug: 954379 Change-Id: Ie4f82545a4828f757461f81c1296497105d60547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641987 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
-
Yue Zhang authored
Currently, changes by setRootId() in Tab are not reflected in TabState and will be lost when tabs are restored. This CL fixes this issue. Bug: 971327 Change-Id: Ia7daf36d4feb23f79b9c364d1232090671a7b9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647134 Commit-Queue: Yue Zhang <yuezhanggg@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
