- 29 Jan, 2020 40 commits
-
-
Yoichi Osato authored
This CL deletes the default copy constructor and introduce a move constructor and CopyFrom method instead. That's because we are planning to add a non-copiable member for streaming body to ResourceRequest ("fetch() upload streaming" design doc/ http://bit.ly/2RlBw6x), which is a instance member of WebURLRequest. Bug: 787704 Change-Id: I86f1b094df4df56e98172b46e63982f80fb510f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000402 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#736284}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I55b0dc09f7de94760e7690e2b4943846446eb901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026918Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#736283}
-
Makoto Shimazu authored
ServiceWorkerTerminationOnNoControllee is originally implemented as stopping a service worker with a delay. However, it may causes abortion of inflight evetns dispatched to the service worker. This CL is to make the termination respect the idleness of the service worker. When all controllees are gone, the service worker's idle delay is made shorter and the worker will be terminated soon by using the logic of idle timeouts. Bug: 1043845 Change-Id: I420f174beb198177888625d4f33baafee55bc3bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022446Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736282}
-
Gabriel Charette authored
R=etiennep@chromium.org Bug: 1026641 Change-Id: I68c6e40f080ac5808cd9c67e227695ca921e1691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026714 Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#736281}
-
Dominik Röttsches authored
Two identical FontDescriptions with identical font-variation-settings axis + value pairs should produce the same FontCacheKey hash. Fix an issue in FontCacheKey computation that only performs pointer comparisons on the FontVariationSettings. This fixes a smaller percentage of FontCache misses during variable font animations. Bug: 1046257 Change-Id: I05ae3ac64b289dc7e1c41b03ab15d7e651195d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023650Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#736280}
-
Morten Stenshorne authored
If we're in a nested fragmentation context (multicol in multicol, for instance), we may end up in a situation where we have no outer fragmentainer space left to lay out inner columns. In such cases, if we cannot fit anything at all, we'll now abort the column layout algorithm, produce no fragment, and break before the multicol container (or even earlier), and try again in the next outer fragmentainer. This introduces another non-successful status for NGLayoutResult, which all Layout() invokers need to handle as part of block fragmentation. This doesn't really add much complexity, though: To participate in block fragmentation, one needs to invoke MovePastBreakpoint() somehow (possibly via BreakBeforeChildIfNeeded()) anyway, which will refuse to move past if layout aborted. Apart from that, the only thing callers need to take care of, is check if layout was successful before trying to access the physical fragment of the result (since there'll be none if layout was unsuccessful). This CL only aborts multicol layout - we still lay out regular blocks even in cases where we could have told up front that we're past the fragmentainer boundary. Actually, even if there's a forced break before a child, we'll lay it out, and let the container break before it afterwards (and thus discard the fragment that we wasted time on producing). We might want to change that as well in the future, if it gives any benefits apart from minuscule performance improvements. Bug: 829028 Change-Id: I473e7106fcc62921d71567d9496ca4c8a9729b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023833Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#736279}
-
Alexandre Courbot authored
This reverts commit 12bbfb47. Reason for revert: this breaks video_decode_accelerator_unittest (and probably others) when built in Debug mode: hardware_display_plane_manager.cc(368)] Check failed: state.properties.active.id. Original change's description: > Replace drmModeSetCrtc by Atomic APIs > > If the device supports atomic APIs, use drmModeAtomicCommit to modeset > and disable instead of drmModeSetCrtc. > Abstracted Modeset and Disabled code to HDPM to handle both atomic and > legacy call. > Updated tests to support Connector and CRTC props. > > BUG=987274 > TEST=HardwareDisplayControllerTest.CheckModesettingSetsProps, > HardwareDisplayPlaneManagerLegacyTest.Modeset, > HardwareDisplayPlaneManagerLegacyTest.DisableModeset, > HardwareDisplayPlaneManagerAtomicTest.DisableModeset, Tested on > Nautilus(Intel), Grunt(AMD) and Cave(Legacy). > > Change-Id: Ic6d3873c94cb657fbe8de6dcd0faf97aeea05bd5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020809 > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Commit-Queue: Mark Yacoub <markyacoub@google.com> > Auto-Submit: Mark Yacoub <markyacoub@google.com> > Cr-Commit-Position: refs/heads/master@{#736021} TBR=dnicoara@chromium.org,dcastagna@chromium.org,markyacoub@google.com Change-Id: Ic116c75d0eb1d81dfe45b6bcd76bcc2e27aaa4e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026779Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#736278}
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I282656edadc4c309878b7cd8e3b8695e2689d87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027012 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Hayato Ito authored
Change-Id: I74fee102764e9313f510f2b825df992c3771defd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027013Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#736276}
-
Peter Kasting authored
This makes InitializeChildData() easier to understand, allows a tiny bit of code reuse, and will make future changes to both these functions and their callers simpler. Bug: none Change-Id: If19e736dbdc00d252c6043d6cf499cffd5d33386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026352 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#736275}
-
Alexandre Courbot authored
GL or EGL image creation happens on the child thread, which should not access any of the members that belong to the decoder thread. Yet this is precisely what we were doing by reading the visible size of the buffer to be imported, without any guarantee that the decoder thread will not have changed it following a resolution change event. Fix this by making the visible size a parameter of the bound method run on the child thread. That way, it is read from the decoder thread and is guaranteed to be consistent. BUG=b:148421581 TEST=video.Seek.switch_vp8 passing on Kevin. TEST=video.Seek.switch_vp8 passing on Hana. TEST=video.Seek.switch_h264 passing on Krane. Change-Id: Id8bc87ac50d6ebd2d74b2f6c25d42da83c933605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026852Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#736274}
-
Friedrich Horschig authored
This CL should have no visible effect. (maybe metrics, see below) Currently, the same popup suggestions are built in two different places and a third one reuses one of the methods. For updating, there will be at least two more code paths building suggestions which cannot reuse the current code. To prevent code duplication, this CL moves building the suggestions into helper methods. One notable change: previously, we would record the metric "PasswordManager.ShowAllSavedPasswordsShownContext" when the suggestion entry was added to the list of suggestions. This might have recorded the metric prematurely since there is another check that occasionally prevents showing the popup (and with it, the "Show all" button). Bug: 1043963 Change-Id: Ia305c9102d6f1b2f6430e02617e83de02f9253e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020704 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#736273}
-
Peter Kasting authored
This also adds a move constructor (since there's no obvious reason not to, and Optional has them) and copy and move assignment (since constructors and assignments should be defined together per style guide). This also makes the comparison operators non-members since this is preferred when feasible (e.g. makes implicit conversion for comparisons apply equally to both sides). Bug: none Change-Id: I5b593f078063b8f9502dae232ed28e01ae41cd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026688 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
Macros are more efficient than functions, but increase the binary size by a non-trivial amount. Given that the histogram calls in the folder are emitted infrequently (less than about ten calls per hour), functions are preferred. Histogram emissions to PrintPreview.UserAction and PrintPreview.PrintSettings will still be done using macros, given the greater volume of emissions. Change-Id: I19321a3648b1b361931369e47d41817250711f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026601Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#736271}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b5b51de558d..3d23fc123c37 git log 1b5b51de558d..3d23fc123c37 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps Created with: gclient setdep -r src/third_party/skia@3d23fc123c37 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Idd5720985687ac8b0243d3deb5ba229b30211dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027193Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736270}
-
Yusuf Sengul authored
Bug: 1046066 Change-Id: Ifdf8b55ad7f2bcbb556483445eee0fb3d7c13e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023353 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#736269}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/44c75073811b..5ca050d1fdbb git log 44c75073811b..5ca050d1fdbb --date=short --first-parent --format='%ad %ae %s' 2020-01-29 syoussefi@chromium.org Vulkan: Set fragment output locations in SPIR-V 2020-01-29 syoussefi@chromium.org Vulkan: Set vertex attribute locations in SPIR-V 2020-01-29 syoussefi@chromium.org Vulkan: Set set/binding in SPIR-V 2020-01-29 spang@chromium.org Fuchsia: Blacklist swiftshader on Fuchsia Created with: gclient setdep -r src/third_party/angle@5ca050d1fdbb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I88598b98ea817c2d414376456f9e9027c83d3a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027192Reviewed-by:
-
Takuto Ikuta authored
This follows crbug.com/955013, but added -swarming suffix due to builder name in test_suite_exceptions.pyl. test_suite_exceptions.pyl does not distinguish android-marshmallow-arm64-rel under chromium.android or chromium.swarm Bug: 955013 Change-Id: I5be20bbf312bda9353071f9d11540492d7f57a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026917 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#736267}
-
Hitoshi Yoshida authored
We, in team, agreed not to break include header file paths written in code generator. Breaking them makes it difficult to find or sort lines. Bug: 839389 Change-Id: I882d9bd37fa85bd1359933757e491c4db65a7971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026560Reviewed-by:
-
Koji Ishii authored
|NGPaintFragment| has two offsets; one relative to its parent and the other relative to the container block. |NGFragmentItem| has only one, so it was named as |Offset()|, but r736251 <crrev.com/c/2024133> revealed that this can be confusing and mis-used, even by myself. This patch adds |InContaininerBlock| suffixes to all functions that return the offset relative to the container block. This patch has no behavior changes. Bug: 982194 Change-Id: I64f5ae133c11b4d21e455b7c13c2a8884273b6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024190Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#736265}
-
chrome://help-appchrome://flagRachel Carpenter authored
enums.xml numbers come from the suggested values given by the unit test. See https://chromium.googlesource.com/chromium/src/tools/+/refs/heads/master/metrics/histograms/README.md#flag-histograms for more information. Bug: 1012578 Change-Id: Idf5aacf0aae6b6c2e5f4bdad621d028710e26052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026916 Commit-Queue: Rachel Carpenter <carpenterr@google.com> Reviewed-by:
dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#736264}
-
Isabella Scalzi authored
Currently when the |get-info| command is caught by an element, the event continues to propagate, which causes |display_| to be called twice in some cases. Fix this: stop propagation of the event when handled. No change in behavior, no new tests. Bug: 1044448 Change-Id: I670bb872b414f18265cb68688d704ab4c0088976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026532Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#736263}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1fbc1b7f92be..c768c76138f9 git log 1fbc1b7f92be..c768c76138f9 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 abennetts@google.com Fix 'git_hash' KeyError when posting bug updates about patches. Created with: gclient setdep -r src/third_party/catapult@c768c76138f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1046618 Tbr: skyostil@google.com Change-Id: Ie3f513cfa5fba0d06b5737676b5e034b9d30d7ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027190Reviewed-by:
-
Hitoshi Yoshida authored
A user defined type is defined with a non-partial and non-mixin definition of an IDL definition. Following it, this CL defines a Union's component as a set of components where its member types are defined. Bug: 839389 Change-Id: I8632364d72cc33680ed30086f42777bb42f0ce43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026554 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Bug: 839389 Change-Id: I4b86d896e527caa15a2150e2a1544cc080e227df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026835Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dcc8c5431bcb..1b5b51de558d git log dcc8c5431bcb..1b5b51de558d --date=short --first-parent --format='%ad %ae %s' 2020-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 77c4d4c4..243744c2 (487 commits) 2020-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 34e16df059f8..6c3dc3581eaf (2 commits) 2020-01-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 086aded3cb74..2bc9cc12f0b0 (19 commits) 2020-01-29 mtklein@google.com remove more vtune references 2020-01-29 mtklein@google.com start on 2pt conical gradients Created with: gclient setdep -r src/third_party/skia@1b5b51de558d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: Ib5adec88e352db347bb4f6c86cc9591f74b3b57a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027002Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/07a55839eed5..9a80305c0897 git log 07a55839eed5..9a80305c0897 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 johnkslang@users.noreply.github.com Merge pull request #2068 from jljusten/standalone-fix-long-help Created with: gclient setdep -r src/third_party/glslang/src@9a80305c0897 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,tobine@google.com Change-Id: I9a4d1e7af760ffe779a482e7f4ac4bc1c3b93f6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027189Reviewed-by:
-
tby authored
Right now we're not loading saved files ranking models from disk on dev channel, for debugging reasons. We don't need this any more, so this CL removes the logic. Bug: 955893 Change-Id: I4159ca99c020f422861480a4c24b39db362ce242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010596Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736257}
-
Takuto Ikuta authored
Before renaming swarming builders for crbug.com/955013, let me fix build config so that each builder uses the same build config with typical builders. Bug: 943176 Change-Id: Ie203ee1ccd05491fe8332e1206d75ad6235b022c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026556 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
This makes easier to navigate in the DOM when using the DevTools, because the list of <cr-menu>'s is too long distracting from the main part of the Files app content. Bug: 992821 Change-Id: I1833a3742bfa6fd8329c27f43bfbf65bf318e649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026510 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
yilkal authored
This CL updates SupervisedUserErrorPage html page so that users are notified when they have successfully request for permission. This CL updates SupervisedUserErrorPage javascript so that the focus moves away from the ghost button after request for permission. Bug: 1045154, 1045148 Change-Id: I0e5c554b92af68794c9a12e3f97fd2c5d368e8f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024119 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#736254}
-
Rachel Sugrono authored
Add a public CommandHandler method to get a handler by name. Not used yet but required for Quick View to get hold of the delete handler. Bug: 803259 Change-Id: Iddca1284363d40de64629458b28a6d646636d859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026331Reviewed-by:
-
Yoichi Osato authored
ResourceRequestContainer is a wrapper class of ResourceRequest to keep the instance on heap since historycally ResourceRequest had been stated DISALLOW_NEW. However crrev.com/c/776407 has changed ResourceRequest to be newed. This CL refactors the structure simplify. Bug: 787704 Change-Id: I8cf85085d939e9053b84513bc0e23824991a98c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024392 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch matches text snap-to-pixel to the current behavior. Legacy and |NGPaintFragment| snaps the top of the padding box of the parent box. Before this patch, |NGFragmentItem| snaps the top of the content box. This makes different snapping behavior for fractional paddings. This patch adds |parent_offset| to compute the same snapping behavior, because |NGPaintFragment| has both the offset to parent and the offset to container block but |NGFragmentItem| only has the latter. Fixes ~12 tests. Note, the snapping behavior will need to be revisited. Bug: 982194 Change-Id: If2b52c3ae986d5ff06dc993016ad2eb0ff66de39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024133Reviewed-by:
-
David Trainor authored
Remove the reference to the //chrome/android/java class GlobalDiscardabeReferencePool. Download home only needs the base class in //base, and we can pass in the global reference through the factory. Bug: 1046219 Change-Id: I18e084992ef82230d3d2f9ee40ce7460bd7d6480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024750 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#736250}
-
matterchen authored
Port forwarding in Cros will allow users to add, activate, remove and deactivate ports. This CL includes the implementation of the remove and deactivate port utilities and unit tests. The tracking of the port forwarding preferences in the user's profile preferences has not been implemented yet. Bug: chromium:848127 Test: crostini_port_forwarder_unittest.cc and everything builds Change-Id: Ie7b5358813ca9cf454e0e216467c6d1ec8344c08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015868Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Matthew Chen <matterchen@google.com> Cr-Commit-Position: refs/heads/master@{#736249}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1e5460f07009..4d88bb065eda Created with: gclient setdep -r src-internal@4d88bb065eda If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ieb5736b217a87dfe0da5b2b07e7049e98d955277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027001Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736248}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/74f5054ec925..7b6246a2ade8 git log 74f5054ec925..7b6246a2ade8 --date=short --first-parent --format='%ad %ae %s' 2020-01-28 kainino@chromium.org Generators for Emscripten Created with: gclient setdep -r src/third_party/dawn@7b6246a2ade8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I29bd31538c448acd6565a5763348569bf8b227d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027187Reviewed-by:
-
Rachel Sugrono authored
Add subroutines to compose the Delete command handler, so the it is easy for some special clients to access these subroutines, e.g. the QuickView dialog. Add an optional dialog argument to the deleteEntries_() subroutine. The default argument is null which shows the default delete confirm dialog, so no change in behavior. For Quick View, the delete confirm dialog is provided by Quick View when calling this helper. No change in behavior, no new tests. Bug: 803259 Change-Id: I4b2fe2d7cfd35a3c602bf7aa0b869b11a51bb691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026827Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e0a0cb9ad54..1fbc1b7f92be git log 2e0a0cb9ad54..1fbc1b7f92be --date=short --first-parent --format='%ad %ae %s' 2020-01-29 fancl@chromium.org Fix sheriff-config tests Created with: gclient setdep -r src/third_party/catapult@1fbc1b7f92be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: Icce5d3cfad3bc69c4e81915b3acec850122f4034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027000Reviewed-by:
-
