- 27 Feb, 2019 40 commits
-
-
Karolina Soltys authored
Bug: 863341 Change-Id: I932ac6853e431d8629ff0b98035cfb878882411e Reviewed-on: https://chromium-review.googlesource.com/c/1477685 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635959}
-
Sam McNally authored
Bug: 931469 Change-Id: Ifddf61cb092b0870a841a908d131ccbc8ce3e747 Reviewed-on: https://chromium-review.googlesource.com/c/1485612Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#635958}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I95837633f8ffffc82d6fc43b1ca05fad19d3f914 Reviewed-on: https://chromium-review.googlesource.com/c/1490352 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#635957}
-
Stephane Zermatten authored
With this patch, the Autofill Action reports a MANUAL_FALLBACK or FAILED_PRECONDITION error and let the server decide what to do about it. Before this patch, the Autofill Action would handle these case specially, displaying an error and then interrupting the script. The goal of this change is to allow configuring the way the errors from Autofill Action are handled from the server, allowing retries for MANUAL_FALLBACK. Nowadays, FAILED_PRECONDITION is the sign of a script error instead of an expected manual fallback case. This is why it's now reported separately. Bug: b/125245527 Change-Id: I79a0babd32affd2f2413813d377c458541dd2cac Reviewed-on: https://chromium-review.googlesource.com/c/1488890 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635956}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/695af944c472..7b3f4a203570 git log 695af944c472..7b3f4a203570 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 brandtr@webrtc.org Remove unused |keyframe_interval| from codec tests. 2019-02-27 benwright@webrtc.org Add const to variables in openssl_stream_adapter.cc that can use it. 2019-02-27 amithi@webrtc.org RtpSender's RtpParameters were invalidated in a call to SLD/SRD. 2019-02-26 Peter) Slatala Add ::Connect method to the media transport interface 2019-02-26 sprang@webrtc.org Remove VCMEncodedFrameCallback and VCMGenericEncoder 2019-02-26 srte@webrtc.org Respects min ALR probing interval. 2019-02-26 Peter) Slatala Remove deprecated CreateMediaTransport method 2019-02-26 jonaso@webrtc.org Add field trial for adding remote ufrag CreatePermission 2019-02-26 yvesg@webrtc.org clang-tidy helper script, with clang static analyzer included. 2019-02-26 sprang@webrtc.org Remove VCMEncoderDataBase and put remaining code into VideoStreamEncoder Created with: gclient setdep -r src/third_party/webrtc@7b3f4a203570 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I238f2f6f9adaa6b034ac57b7510cf0431dec6ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1491181Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635955}
-
Balazs Engedy authored
Turn on the flag by default to restrict Device{Orientation|Motion}Events to secure origins. Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5yqfAXibz1I Bug: 932078 Change-Id: I8f46a90a12375b734ba3d9a89b835c754960ef48 Reviewed-on: https://chromium-review.googlesource.com/c/1486091 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Reilly Grant <reillyg@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#635954}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/738567f148b2..b2c5023c9c1f git log 738567f148b2..b2c5023c9c1f --date=short --no-merges --format='%ad %ae %s' 2019-02-27 jiawei.shao@intel.com Remove RenderPassDescriptorBuilder Created with: gclient setdep -r src/third_party/dawn@b2c5023c9c1f The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6dc211fba48825ef9e1439187e18971b95164879 Reviewed-on: https://chromium-review.googlesource.com/c/1490777Reviewed-by:
-
Nick Diego Yamane authored
PrepareForAnimation does nothing when tab_drag_controller is set (tab dragging is started), so we can safely remove its needless call from TabStrip::StartedDraggingTabs method, which is called from TabDragController::Attach. R=sky@chromium.org Change-Id: I0b084512d2ee2804cf602d2a4e71bea2fd7c80ff Bug: 896640 Reviewed-on: https://chromium-review.googlesource.com/c/1489214Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#635952}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/49d0ee8be197..aca6308fdf25 Created with: gclient setdep -r src-internal@aca6308fdf25 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8752a76e544dfa109469b21178041f5cf140c347 Reviewed-on: https://chromium-review.googlesource.com/c/1490776Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#635951}
-
Ioana Pandele authored
This reverts commit 56aac4d8. Reason for revert: see crbug.com/936372 Bug:936372 Original change's description: > Add HTTP protocol scheme of the main frame origin to UKM > > Approval doc here: http://shortn/_FVcQvJsxmu > > Change-Id: I1b79f2be75a7fceef5c596ceda8372c62ac9e4ec > Bug: 893923 > Reviewed-on: https://chromium-review.googlesource.com/c/1484739 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635713} TBR=holte@chromium.org,tbansal@chromium.org,ryansturm@chromium.org Change-Id: Ic466a05a0974ab8bb461604805cd04ebe7bbf48d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893923 Reviewed-on: https://chromium-review.googlesource.com/c/1491432Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#635950}
-
Miyoung Shin authored
- unsigned short / unsigned -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: I2195aa9d8daf5168273d0b3a03ad2669d041cf78 Reviewed-on: https://chromium-review.googlesource.com/c/1491062Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#635949}
-
Lukasz Suder authored
Generic details parameters takes precedence, when they are provided. Otherwise old logic of creating Details based on vertical specific parameters is used. Bug: 806868 Change-Id: I0bc0f77af3f86c9e7482c0893dc10be65b797883 Reviewed-on: https://chromium-review.googlesource.com/c/1488882 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#635948}
-
Julie Jeongeun Kim authored
This CL removes GaiaCookieManagerService, AccountTrackerService, ProfileOAuth2TokenService, AccountFetcherService and SigninClient. It also updates DomainsClearedOnBrowsingDataRemoved and DomainsClearedOnBrowsingDataRemoved2 to use IdentityManager, not GaiaCookieManagerService. It checks whether OnAccountsInCookieUpdated() is triggered or not after OnBrowsingDataRemoved() is called as it forces to call OnCookieChange(). Bug: 797931 Change-Id: I247370add1ed670a8b2aad99c7905bbe655f5d63 Reviewed-on: https://chromium-review.googlesource.com/c/1488476Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#635947}
-
Jinsong Fan authored
When the WebView Shell receives an error, the URL of mUrlBar will be red, while WebView goes back by onBackPressed(), the URL is still red, even though it is correct. Bug: Change-Id: I80a5b1c02eeaae8d99105955f2900acf81f0118f Reviewed-on: https://chromium-review.googlesource.com/c/732858 Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#635946}
-
Hirokazu Honda authored
The former way to enable kVaapiVp9Encoder in VEA unittest is wrong. It enables kVaapiVp9Encoder in the begging of main() function in the test. Features are overwritten later by base::TestSuite::Initialize(). Furthermore, it is too late if the feature is enabled in each test case. base::TestSuite::Initialize() queries the driver and the obtained capabilities will be used in the test case. Hence, we have to enable kVaapiVp9Encoder between base::TestSuite::Initialize() and media::VaapiWrapper::PreSandboxInitialization(). Bug: 811912, 930532 Test: VEA unittest with VP9 stream Change-Id: Id1601d5ce985c189820f380df5c2e23ea265e17c Reviewed-on: https://chromium-review.googlesource.com/c/1490987 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Pawel Osciak <posciak@chromium.org> Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635945}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If0438689f9caeb70e83764e6fe8a691576a14843 Reviewed-on: https://chromium-review.googlesource.com/c/1491332Reviewed-by:
-
Jinsong Fan authored
No change to logic. Bug: 812553 Change-Id: Iaef19776322056885bb05fb80a5b234e7042b820 Reviewed-on: https://chromium-review.googlesource.com/c/1238093Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#635943}
-
Abhishek Bhardwaj authored
This change adds power manager implementation to be used by libassistant on Chrome OS. This implementation implements the API - To acquire and release Chrome OS wake locks. - To set wake up alarms on Chrome OS. BUG=chromium:913128 TEST=Set timers using assistant on Chrome OS. Change-Id: Ia54cf6508e2dd695fd3c76ee6d732e7aab5d15aa Reviewed-on: https://chromium-review.googlesource.com/c/1372830Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#635942}
-
Luciano Pacheco authored
Migrate tests for <files-tooltip> component from unittest to integration tests, because unittest environment can't load chrome://resources which is required for our setup for Polymer. The unittest will be removed in follow up CL. Bug: 924873 Change-Id: I2c17fd07e2a2f2c1f062a6c4e7f29105a6917613 Reviewed-on: https://chromium-review.googlesource.com/c/1485623 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635941}
-
Gyuyoung Kim authored
BlinkMemoryMgt: Annotate DatabaseVersionCache and SQLiteFileSystem classes with the macros of Allocator The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/modules/webdatagbase have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of SQLiteFileSystem class, it makes sense to use STATIC_ONLY because it only has static functions. To annotate SQLiteFileSystem class with STATIC_ONLY, this CL removes the default constructor. In DatabaseVersionCache class case, it makes sense to use USING_FAST_MALLOC because it's used by DEFINE_THREAD_SAFE_STATIC_LOCAL macro. Additionally, this CL annotates DOMWebSocketTestScope with STACK_ALLOCATED. Bug: 919389 Change-Id: Iaad117a1edf152bee6dbe43b2979aaee5ca4ce0d Reviewed-on: https://chromium-review.googlesource.com/c/1491070Reviewed-by:
-
Hiroshige Hayashizaki authored
https://chromium-review.googlesource.com/c/chromium/src/+/1476144/ Bug: 906850 Change-Id: I79bbcdddd8361e91b70af1b366c089b5496a924b Reviewed-on: https://chromium-review.googlesource.com/c/1476172 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#635939}
-
Dana Fried authored
Location bar now grabs everything up to its preferred size, hiding extensions, before space is given to extensions. Only after all extensions are visible does it continue to expand past its preferred size. Note that because of the new minimum width on the browser window to accommodate WebUI dialogs, with no security chip etc. some extensions may still be visible when the window is at minimum width (i.e. the omnibox is now not always the limiting factor for minimum size). Also note that this is not a fix for issue 935216, which appears to be a bug in the extensions (i.e. "browser actions bar") view. Bug: 935218 Change-Id: I94380f6aa1bb2386c486ce8764c68e6250cfca4d Reviewed-on: https://chromium-review.googlesource.com/c/1490735 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#635938}
-
Kush Sinha authored
Revert "[Sheriff] Disable some tests in ArcRobotAccountAuthServiceTest and ArcAuthServiceChildAccountTest on MSan" This reverts commit 2d44e6e5. TBR=khmel@chromium.org Bug: 934796 Change-Id: I849372fc59002a8439769e84814aee7b9d2afb3f Reviewed-on: https://chromium-review.googlesource.com/c/1488913Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#635937}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3c9baa37c2b7..f2eb10133f86 git log 3c9baa37c2b7..f2eb10133f86 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 benjhayden@chromium.org Add report-template for spa 2019-02-27 benjhayden@chromium.org Add report-table for spa Created with: gclient setdep -r src/third_party/catapult@f2eb10133f86 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193,chromium:918193 TBR=sullivan@chromium.org Change-Id: I48041d41a746f119643e8f3c17a720ee62e99c29 Reviewed-on: https://chromium-review.googlesource.com/c/1491115Reviewed-by:
-
Oleg Davydov authored
Years ago DebugLogWriter used runners from SequencedWorkerPool to gather and archive logs, thus requiring sequence_token_name argument to identify pool. In b116e3b7 this was deprecated, work migrated to TaskScheduler. But sequence_token_name argument persisted and was passed into different methods without any real usage. Also migrate from legacy Callback to OnceCallback. Change-Id: If2b650fd6d7221be75002db28dd4afb46c14d6a5 Reviewed-on: https://chromium-review.googlesource.com/c/1480520Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#635935}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2fe8f49257b7..49d0ee8be197 Created with: gclient setdep -r src-internal@49d0ee8be197 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icf0796e0e4f9b271240451e8c7edc0d782155b2c Reviewed-on: https://chromium-review.googlesource.com/c/1491116Reviewed-by:
-
Dana Fried authored
This would have been expected behavior for a flex layout, but was not previously implemented. Along with re-implementing LocationBar::CalculatePreferredSize(), the associated bug should be addressed. Bug: 935218 Change-Id: Ib003672a89636e7d4e45bd5dc509eb810a6112e5 Reviewed-on: https://chromium-review.googlesource.com/c/1490524 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#635933}
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I8dabef308839aca8957226db91f7b98bae31c01e Reviewed-on: https://chromium-review.googlesource.com/c/1489206 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Fredrik Söderquist authored
Since we no longer include the dash-effect when computing (appromixating) the stroke bounds, we don't need to trigger (re)layout when they change. This can help eliminate layouts for example for "line animations" like the one on https://jakearchibald.com/2013/animated-line-drawing-svg/ Bug: 435097 Change-Id: Iaf5298620889b6ed0cb10437514bb8af3104cc35 Reviewed-on: https://chromium-review.googlesource.com/c/1489202Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#635931}
-
tzik authored
This fixes a build failure of base_bind_rewriters, that seems broken by an autogenerated CL for IWYU. Change-Id: Ia872fde31ab9bc58b4e49aebfc326f6308e948e5 Reviewed-on: https://chromium-review.googlesource.com/c/1491067Reviewed-by:
-
Alex Danilo authored
Change https://chromium-review.googlesource.com/c/chromium/src/+/1474873 extended the information returned from handler matching for a file by retaining the reason for the matching (MIME type and/or file extension). This CL removes the old method call and replaces it with the extended method to clean up the code. Bug: 936296 Tests: Ran all browser and unit tests. Change-Id: I791c3885298fa480df9363f7e423047cb59ecd0d Reviewed-on: https://chromium-review.googlesource.com/c/1491063Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#635929}
-
Tim Song authored
TEST=manually tested with chrome://user-actions/ BUG=921250 Change-Id: I914462bf6fda10e9fd3d88d0f808ae04a44130ca Reviewed-on: https://chromium-review.googlesource.com/c/1488173 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#635928}
-
Rijubrata Bhaumik authored
Rename NFCMessage to NDEFMessage. nfc_message.idl -> ndef_message.idl git grep -l 'NFCMessage' | xargs sed -i 's/NFCMessage/NDEFMessage/g' git grep -l 'NfcMessage' | xargs sed -i 's/NfcMessage/NdefMessage/g' Java does not allow to import same className from different packages, which in this case is NdefMessage So not importing android.nfc.NdefMessage and using fully qualified name to avoid ambiguity. Repeat the same for NFCRecord -> NDEFRecord. Spec changes for this corresponding CL: https://github.com/w3c/web-nfc/commit/5b74305be004a8e758d4931f8409bd354bc4039e Bug: 520391 Change-Id: Ib88e0db5c9cd7fa973170f93c5f5352dcda6630e Reviewed-on: https://chromium-review.googlesource.com/c/1481296Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Jan Krcal authored
After a full launch of UssWalletData on Stable, this CL simplifies parametrization for sync_intgration tests. From now on, we only switch between Directory and USS implementation of WalletMetadata. Bug: 853688 Change-Id: I500bbb66b5aed65d27ea9e4955bbfb4e31023630 Reviewed-on: https://chromium-review.googlesource.com/c/1489194 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#635926}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/620621059b29..ab3f8674c9d2 git log 620621059b29..ab3f8674c9d2 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@ab3f8674c9d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I2e02ca72c0c8c273d40a023112acb43d296afcb5 Reviewed-on: https://chromium-review.googlesource.com/c/1491113Reviewed-by:
-
François Beaufort authored
This CL adds a mute button in the Picture-in-Picture window that reflects the muted state of the video. If there is no audio track, mute button will be hidden. This button is working only if experimental blink feature MuteButton is enabled or if the Origin Trial with the same name is enabled. Screenshot: https://i.imgur.com/UqIhaIV.png Change-Id: Ibe91abdbcf54d01122010dfe0bf5b99a15415cec Bug: 935080 Reviewed-on: https://chromium-review.googlesource.com/c/1473271Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#635924}
-
Noel Gordon authored
Running tests will require a http server, puppeteer and some .js files to do the actual testing in a browser. Add a script to drive the whole testing process. Output: % npm run test tests PASS If there was a test failure, a test.log is available to figure out the problem. Bug: 935285 Change-Id: I12f69008d37c67433901ed6a37a3d7e9375abac3 Reviewed-on: https://chromium-review.googlesource.com/c/1491155Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#635923}
-
Adam Rice authored
Some worklet contexts lack MessagePort and so cannot implement tranferable streams. This is detected by looking for the MessagePort_postMessage function on the binding object, which is initialised during context creation. Previously MessagePort_postMessage was only placed on the binding object when it was available, meaning when it was absent the prototype chain was searched for it. Since this could be interfered with by code running on the page, initialise it to undefined instead. BUG=934201 Change-Id: Ic114d92300207f41a8b762457504a4d70009ee34 Reviewed-on: https://chromium-review.googlesource.com/c/1488402Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#635922}
-
Julie Jeongeun Kim authored
This CL moves mime_registry.mojom to public/mojom/mime in order to organize mojom files at mojom folder. Bug: 919393 Change-Id: I4c718d3560371e12ab7ca2522a0d43f1eddfe33c Reviewed-on: https://chromium-review.googlesource.com/c/1478650Reviewed-by:
-
Adam Rice authored
Make const accessors return const pointers. Mark more method arguments as const. BUG=902633 Change-Id: I4d743be2ab56af4d3a9be493ba4b322d5ef40b41 Reviewed-on: https://chromium-review.googlesource.com/c/1488396Reviewed-by:
-
