- 16 Jul, 2020 40 commits
-
-
Adithya Srinivasan authored
This is a reland of c615367a Original change's description: > Portals: Fix flakes in testTouchTransferAcrossReactivation > > The flakes were caused by crbug.com/1098773. As a workaround until the > issue is fixed, this wraps the activate call in a setTimeout. > > Bug: 1024850 > Change-Id: I36e2b948818d81578acc97a9a60758b281ff6764 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264856 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782379} Bug: 1024850 Change-Id: Ie6ad8a764f493de62cc2ab25f8b48b5d3c22375b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295835Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#788863}
-
Miguel Casas authored
Said https://crrev.com/c/2292780 inadvertently restored VP9.1 and .3 entries in the test and removed a const. Having those profiles is harmless but I expect it to be confusing, so let's remove them. Bug: 1105103 Change-Id: I601edb3e9534cec12245058a10ad1f7b01aa8e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300920 Auto-Submit: Miguel Casas <mcasas@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788862}
-
Peter Kasting authored
This adds a helper, UpdateButtons(), to set all buttons' visibility, text, and enabled state based on the current mode; this replaces the scattered pieces throughout other functions. This also removes the places that set |dropdown_state_| to NORMAL. Since this is supposed to track the actual button state, it only makes sense to toggle it in places like ButtonPressed() and ReleaseDropdown(). It also doesn't make sense to change this variable directly instead of going through SetDropdownState(), since then the state and the visual appearance could be out of sync. Bug: none Change-Id: I444fd3b14ab1ec8a4b0aed37ce2d80539d54f199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299139 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788861}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f4db4dad69d7..0ea0cd51026f 2020-07-15 cduvall@chromium.org Set WebView implementation for any WebView APK If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1105096 Tbr: skyostil@google.com Change-Id: I4cb375c28570c91da606b71c3031b2c22ae02d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300941Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788860}
-
Garrett Beaty authored
The builder's machines were restored to n1, but with the goma outage, compiles are still taking a long time. A temporary boost to the timeout will allow for getting some results in the meantime. Bug: 1106029 Change-Id: I6148d08455f66ebabed1f3f1e0f1415b826b7c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301199 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#788859}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: None Change-Id: I22b14c4c8ffaab00f5544aff48f28de43851edfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295932Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#788858}
-
Peter Kasting authored
The ultimate goal here is to eliminate duplication of code and work and make the actual effects of state transitions obvious. This CL combines the various TransitionTo...(), Show...(), Clear...(), and SetMode() functions into a single UpdateMode() function and does some initial basic combining of shared code. It makes the following two assumptions: * The item does not transition from one warning state to the other, or from one mixed content state to the other; it transitions into or out of one of these states from an unrelated state (most commonly kNormal). This seems true from my reading of the various model-side state transitions, and the existing code would not have properly handled such state changes anyway (e.g. |mode_| would never have been updated). Making this assumption lets us do conversions akin to this: OLD: if (is_mixed_content(mode) && !is_mixed_content(mode_)) { ... } NEW: if (is_mixed_content(mode)) { ... } * It's undesirable to trigger LoadIcon()'s functionality again when the file path hasn't actually changed. While only one call chain actually checked for this, it seems correct in principle in all cases (such repeated calls would just be extra work). Making this assumption lets us put that check in LoadIcon(), and then call it unconditionally at the end of UpdateMode() instead of in many other places. The UpdateMode() function here is far too sprawling, but even making fairly few actual logic changes, this CL already pushes the bounds of what a reviewer can verify is still correct. Further refactoring to turn this into something shorter and more comprehensible will come in a subsequent patch. Bug: none Change-Id: I6b0e6dfcfef5c1057c4e59e593adcee27e537950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296271 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788857}
-
Sara Kato authored
AX-Relnotes: n/a. Bug: None Test: AXTreeSourceArcTest.*, AccessibilityNodeInfoDataWrapperTest.* passes Change-Id: I97ef734a8770c68a4245e40dad25d897062e8ede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294502 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#788856}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie039eecf251930d107ba65fcea4a64a12eeb0506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788855}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/f48a33827db6..01ee4caa5ab5 $ git log f48a33827..01ee4caa5 --date=short --no-merges --format='%ad %ae %s' 2020-07-14 jdrago v0.8.0 2020-07-14 jdrago Update CHANGELOG 2020-07-14 jdrago Fix usages of rgb in README 2020-07-10 wtc Set encoder chroma sample position 2020-07-10 wtc avifenc: add --tilerowslog2 and --tilecolslog2 2020-07-10 jdrago Build nasm from source in GitHub the way it is built in Travis 2020-07-09 wtc Update avifBitsReadUleb128 with latest dav1d code 2020-07-09 wtc Do not set cfg.kf_mode = AOM_KF_DISABLED 2020-07-09 jdrago Remove monochrome from this new check 2020-07-09 jdrago Fix lossless monochrome checks; this needs another pass (...) 2020-06-22 wtc avifImageRGBToYUV() cleanup 2020-06-22 jdrago Stub out a contrib directory for future PRs 2020-06-22 wtc Build LIB_FILENAME from CMake variables 2020-06-22 wtc avifRWStreamWriteFullBox() cleanup 2020-06-22 jdrago Avoid known crash in libaom's monochrome encoding, and simulate it with YUV420 as a fallback 2020-06-22 wtc Remove yShift out param from avifImageCalcAOMFmt() 2020-06-22 E.M.terHoeven Changelog.md: Add line for dav1d 0.7.1 update 2020-06-22 E.M.terHoeven Ext: Update to dav1d 0.7.1 2020-06-19 jdrago Partially fix my grammar in my run-on sentence 2020-06-19 jdrago Add some additional comments explaining the usage of ID 0 when calling avifDecoderDataFindMetadata() Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1105148 Change-Id: I79ff72c7533a2b6228336663388af997056eef41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300629Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#788854}
-
Lei Zhang authored
This code was used in the initial download implementation, prior to Chromium becoming open source. The caller to SaveFileManager::DeleteDirectoryOrFile() got removed at some point, so this code has been dead ever since. Make save_file_manager.* lint free as well. Change-Id: I09768c555cc3447539d67f98ca83ca8ea57f0787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296864Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#788853}
-
Johann authored
With the default HeapMojoRemote setting there was a bad interaction between service_ and the GATTServer cleanup. service_ would get cleaned up in its own OnContextDestroyed method but then the GattServer would try to access it in Dispose. This was worked around by using kForceWithoutContextObserver. In BluetoothGATTServer there should not be any need for manual cleanup: service_ can use the OnContextDestroyed method and the other object being cleaned up, active_algorithms_, is a HeapHashSet with its own associated garbage collection. Bug: 1049056 Change-Id: Ia81e99743c1f8bdccf37b54d0761258571a3ad4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275515Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#788852}
-
David Schinazi authored
This flag was verified last week, and was then set `chrome_value: false` because it was breaking tests. After digging further, I realized that the failing test was incorrect: it would create a dispatcher with no versions, which triggers a DCHECK. This used to pass because draft-25 was a version that could support WebTransport but wasn't part of the origin trial versions. I don't think this test adds much value, because if there are no versions on the server we don't really care about validating that everything fails. So this CL removes that test, and flips the flag back. Change-Id: I80bc8bd3ee76238311d3ac21b034b5a526e6202a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297964 Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788851}
-
Kristi Park authored
TBR=tkent@chromium.org Bug: 1104381 Change-Id: I7512014896786a50469d9eaf65a3090d0030ea83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300030Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#788850}
-
Tommy Steimel authored
This CL adds some deps and reenables gn check for chrome/browser/image_decoder. Bug: 1106053 Change-Id: I6a424059a39bb02880d13a6e916198615e1f4582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299850Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#788849}
-
Guillaume Jenkins authored
Moves ReportRequestQueueGenerator from chrome/browser/enterprise to components/enterprise so it can be reused in iOS code. Note that the associated unit tests are harder to move because of their extensive use of TestProfileManager, which is in chrome/browser. They will be reworked and moved in a separate CL. crbug.com/1103732 has been created to track that, with a TODO in the code. Bug: 1091938 Change-Id: I24a2c2e258eb772e3910cdf99e8e1e7a83eb57a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290250Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#788848}
-
Stephanie Kim authored
Bug: 1072012,1103490 Change-Id: Ieb61903d53e527c4cedee12d099668e96503f68b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300838Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#788847}
-
Ted Meyer authored
Pass by constref and only copy up to the first 1000 characters, rather than copying it all and inserting a nullptr and ellipsis Also removed the old definition of kMaxUrlLength from media_log.h and the old truncate method definition Bug: 1090752 Change-Id: I6665f010937c802b94da9fd344ab3baf6af88a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299195 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#788846}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I26c6fc435b301179a125fd2b0cda42c4252d7d59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788845}
-
Karandeep Bhatia authored
Since r786851, the docserver integration test is hanging causing presubmits to fail. Also, the cron script which we use to update the docserver is hanging. This is because r786851 added dependencies on behavior features. However behavior features are not accounted for in features_bundles.py which is used to resolve feature characteristics like channel, platform etc. Since the code in the file expects that all features will eventually be resolved, it keeps running indefinitely. To fix: - Ensure behavior features are ignored for the purpose of evalauting feature characteristics for the docserver. - Break out of the loop in GetFeatures if no new features are resolved after a top level iteration. This'll ensure that the script terminates eventually. Also, log an error if any features are left unresolved. Other fixes: - Delete cloudPrintPrivate.html. It was causing presubmit to fail since beginning r785624, cloudPrintPrivate is disabled for extensions. - Disable pylint checking in chrome/common/extensions/docs/server2/PRESUBMIT.py. There are multiple failures there already and it is causing the presubmit step to timeout. BUG=1103846, 1105211 TEST=python chrome/common/extensions/docs/server2/integration_test.py -- apps/developerPrivate doesn't hang Change-Id: I640ea35a66ecd863e39ca7b9b2e3e5469bfae2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296866Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#788844}
-
Christoph Schwering authored
This CL refactors AutofillHandler::OnFormsParsed() to take a vector of FormData pointers instead of a vector of FormStructure pointers. That way, refilling still has access to the seen FormData and does not need to use the cached form for that purpose, which would mix up the last-seen values with the initial values. Bug: 966873, 949094, 1075533 Change-Id: Iba0e030b4dfa58edc05d125550e4a8ee56413f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291070 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#788843}
-
Kunihiko Sakamoto authored
- Adds WebBundleLoader class which loads a WebBundle resource using ThreadableLoader, and creates a WebBundleSubresourceLoaderFactory. - LinkWebBundle is registered in ResourceFetcher, and used to forward subresource requests that match the corresponding <link>'s resources= attribute to the WebBundleSubresourceLoaderFactory. This is done via the SubresourceWebBundle interface. Bug: 1082020 Change-Id: I3f26bd6b1fbd5855caa5175cdcb3db0fe103a093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291809Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#788842}
-
Kristi Park authored
These were introduced in https://crrev.com/c/2300231 TBR=hiroshige@chromium.org Bug: 1068175 Change-Id: I85d1dde6fdb29d955e74f5c464de47510ed4ca16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300991Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#788841}
-
Leonid Baraz authored
Add a test for all possible sizes of record - to see that padding works correctly for all. Bug: b:157943388 Change-Id: Iafb432365fb57ff4fad3fbebd81f8ece93c32033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300683Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#788840}
-
Robert Sesek authored
Bug: 1105916, 1052560 Change-Id: I603aad0284ce6177332ab47f60e06c55bd9d52a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300601Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#788839}
-
Orin Jaworski authored
This feature is soon to enter BrApp design review, then experiments, etc. so it needs more time. Change-Id: I300a30a2233cf4748eace60085b55cd5c8e734bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300236Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#788838}
-
Emily Stark authored
The previous CL in this chain reveals trivial subdomain and scheme when the URL is unelided on hover. This CL adds a hover animation to the omnibox even before the user interacts with the page (in the hide-on-interaction field trial). This allows the user to hover over the omnibox to bring back the scheme and trivial subdomain even before the URL has been elided to the simplified domain, thereby minimizing the potential of having an edit bump before interacting the page as well as after. The main change is that we need to create the hover animation earlier. Previously, we were creating it once the user interacts with the page; now we create it on page load. Each elide/unelide operation decides whether to use the full URL, partially elided URL (just scheme and trivial subdomain hidden), or simplified domain based on whether the user has interacted with the page yet or not. Bug: 1101486 Change-Id: Id747929df56becadc34f0cb7a581494f4d90df5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291310 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#788837}
-
Sinan Sahin authored
crrev.com/c/2269197 added animations for the tab switcher using translationY and avoided changing margins of the layout too often. This was likely an over-optimization since the cards don't need to be re-measured every time the margin is updated. This "optimization" also caused a jump during the animation if the layout was scrolled all the way to the down when the animation to hide the offline indicator started. This CL changes the animation to update the margins in every frame and removes translationY from the properties. Bug: 1104426 Change-Id: Ida177aa08d657b7d0f1535abf9b0ad709697aec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277075Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#788836}
-
Giovanni Ortuño Urquidi authored
To get more visibility into System Web App changes. Change-Id: Ic6cb9a80910460842fb2b7ff09d7115b0494a7c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298785Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#788835}
-
Dale Curtis authored
This shouldn't have been left to expire, but owner wasn't set right so we didn't see the notice. Change-Id: I60bc276353198d368f8449897ff95f674ddd607f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299852 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#788834}
-
Joey Arhar authored
The current TestExpectations for this test seem too widely scoped - this test is either timing out or passing. Bug: 1105957 Change-Id: I34733445a33907d185da03155aa83b31e6070261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300772Reviewed-by:
Yu Han <yuzhehan@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#788833}
-
Trent Apted authored
4 of the 5 allowed extensions are "quickoffice" and they all want to handle the same mime types, when multiple are installed. And this is not the right place to attempt to protect against multiple copies of the extension being installed. Fixed: 970227 Change-Id: I83922b6973c252dc497a04b623582878bfcde23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282545 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#788832}
-
Yuke Liao authored
This CL cleans up the merge script by: 1. Remove unused logic. 2. Remove unless loggings as there are too many of them that clutters the stdout. 3. Fixes some wording. Change-Id: Ifa0e90a13ff2bf8f1cf99c41be0574fe2f7577bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231095 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#788831}
-
Zhenyao Mo authored
This driver is old and buggy and should not be used. We tried to disable accelerated video decode first, but crashes/hangs arose again recently on these old drivers. Let's just follow AMD advice and disable this driver entirely. BUG=1069262 TEST= R=sunnyps@chromium.org Change-Id: I7d29cc86162eeaa4ec175030d761447a6fcb6106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297711Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#788830}
-
Sorin Jianu authored
This CL is trying to reland a combination of https://chromium-review.googlesource.com/c/chromium/src/+/2293461 and https://chromium-review.googlesource.com/c/chromium/src/+/2297696 with an additional fix to make NetworkFetcherFactory a thread-safe type. The original CLs were reverted since the code had a race condition on the destruction of CrxDownloader instances, which triggered various sequence checkers when the objects were destroyed by a sequence other than main. Bug: 1105924 Change-Id: I84f071518f930964ec08611bb14b7fb2aa243fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300599 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#788829}
-
Robert Ma authored
testdriver-vendor.js must be included after testdriver.js. This CL fixes all the affected tests; there will be a new lint rule to prevent regressions later. Bug: 1105751 Change-Id: I793c5d3c65f4cdeeed3f120f6fad063dffaaa406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300261 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#788828}
-
Tibor Goldschwendt authored
Previously, the titles honored the theme setting. However, the title is shown in a white pill and, therefore, was invisible if the theme set a light color. Thus, this CL always sets the title color to dark. This is also what the local NTP does. Before: https://screenshot.googleplex.com/3W85KAw7sbv After: https://screenshot.googleplex.com/d2pAxBWjRx9 Fixed: 1105941 Change-Id: I4ca38bd3e70cf0e669ea2f5d23f6821ef822bf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300662 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#788827}
-
Nodir Turakulov authored
Dash is more typical in builder names Bug: 1102997 Change-Id: I1edbb1f78cc77cccac56e34c23cce5a5d9ab90ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300837Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#788826}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9d9199a509bf..ed9e5acd61d7 2020-07-15 ehmaldonado@google.com bot_update: Don't checkout 'master' after clone. 2020-07-15 ehmaldonado@google.com gclient: Unset core.worktree after cloning on Windows. 2020-07-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-07-15 thestig@chromium.org Add default filters to git cl lint. 2020-07-15 thestig@chromium.org Simplify a block of conditionals for git cl lint. 2020-07-15 ehmaldonado@google.com presubmit_canned_checks: Add DIR_METADATA presubmit checks. 2020-07-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1070694,chromium:1097674,chromium:1102997,chromium:1104182,chromium:1106028 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I10f82704f3dfa69e14262ce504f22e49888d5923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300737Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#788825}
-
W. James MacLean authored
This CL completes the renaming process started in https://chromium-review.googlesource.com/c/chromium/src/+/2246923 for Android webview. Bug: 1067389, 846155 Change-Id: Ie5d20a0b18bd4eaf56c3eb4296941978d78ffb05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300682Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#788824}
-