- 27 Mar, 2020 40 commits
-
-
Gyuyoung Kim authored
This CL moves flex-item-contains-strict.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, a proper title, and test description. Bug: 1063749 Change-Id: I5559de07cc72a44a36ed39c951562a156dfeabca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123695Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754029}
-
Rafael Cintron authored
DX12 and 11on12 have issues working with GpuAppContainer without enabling lpacPnpNotifications. Hance, we enable it for the GPU and XR compositing process. Restructured AppContainer unit tests for easier failure debugging. Bug: 1064110 Change-Id: Id0268d4f46dba83cdc9c7d6d06f8c3651efd970f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123028Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#754028}
-
Sorin Jianu authored
This callback is going to be needed shortly when --ua implementation is going to use COM RPC and UpdateServiceOutOfProcess. A couple of smaller fixes: * Added missing callback on success in UpdateServiceOutOfProcess::UpdateAllOnSTA * renamed "done" to "callback" to match the existing naming style in this code and update_client. * the actual implementation of the repeating callback is mechanical but provided in the existing code to show the state mapping and ensure the code is not crashing when a repeating callback is invoked. * similar work is needed on macOS. Bug: 1058858 Change-Id: I509b01ae4970478ecb617b6361715f62706cde45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123318Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754027}
-
Finnur Thorarinsson authored
The instructions seem to assume running the script from /src and the intent is to create two directories /tmp/coverage /tmp/coverage_report but the lack of a slash prefix results in the creation of... /tmp/coverage /src/tmp/coverage_report Bug: None Change-Id: Ib10050a577fc8e9494a903386d5886ccbef8aa1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124256 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#754026}
-
Leonard Grey authored
The original code retained the window's content view in the controller because it "might be needed in dealloc". Turns out, this was sort of true. In some circumstance (can't repro), if fullscreen is ended after the content view has dealloced, we blow up trying to remove the mouse tracker's tracking rect from the view. Since we can't test a more targeted fix due to lack of repro, Patchset 3 adds a view retain directly in the mouse tracker with a less vague comment. This is a reland of 5407de10 Original change's description: > Mac: clean up FullscreenToolbarController > > - Remove some structure that was previously necessary for Cocoa browser > - the visibility lock controller is vestigial: we release the lock, > but never acquire it > > Bug: 1063417 > Change-Id: I55ccc6b14b0ffed7d81beb640a54ec8b1110e831 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117321 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753211} Bug: 1063417 Change-Id: I2d88c1bec50cc2ff116ff66372e51fa05cc10361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122389Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#754025}
-
Tim Schumann authored
This reverts commit cf6a800a. Reason for revert: Breaks the build https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20Full/159520? app_launch_predictor.proto still referenced from chrome/browser/ui/app_list/search/search_result_ranker/app_launch_predictor_test_util.h Original change's description: > [Search ranking] Delete unused Roselle code. > > Roselle was our original framework for app ranking, which we've since > moved to the RecurrenceRanker. Roselle isn't used any more, so let's > delete it. > > Bug: 1028447 > Change-Id: I8f8739d2bd7d17027eff8f743e1b5d4c3e1a5b49 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119459 > Reviewed-by: Charles . <charleszhao@chromium.org> > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753848} TBR=jiameng@chromium.org,charleszhao@chromium.org,charleszhao@google.com,tby@chromium.org Change-Id: I601f66c16c2b93670e18f18484c763222b56a97c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1028447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124747Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#754024}
-
Nohemi Fernandez authored
Adds the policy for handling user data when switching signed-in accounts to the new sign-in architecture. Uses the MERGE DATA policy for first-run and USER CHOICE for all other instances of sign-in. Bug: 971989 Change-Id: Ibd719b8be8d3cb0abd0f37f55091d1abc7ae8fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122487 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#754023}
-
Yuly Novikov authored
Allocated in https://chrome-internal-review.googlesource.com/c/infradata/config/+/2812313 This allows limiting number of concurrent builds on these bots, and consequently, limiting number of GCEs used to run for SwANGLE tests. Moving SwANGLE trybots into a separate file, since they now use different GCE pools from the rest of Chromium trybots. Bug: 1007018 Change-Id: Ifedba2f78d547ad1eb256509c1cc540489cb9f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123327Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#754022}
-
Christian Dullweber authored
In settings we already set CookieControlsMode to On if third-party cookie blocking is enabled. We should migrate existing users as well. Additionally, an enforced BlockThirdPartyCookies policy should also set CookieControlsMode to On. Bug: 967668, 1040091 Change-Id: I15cedad06a11572c2f0503db23bd73854efa699f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120307Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#754021}
-
Bartek Nowierski authored
Change-Id: I98d2e1663db0b3bbc9780a078d249696e8c6ecfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123696 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#754020}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8c4f7654a023..22e477b2ce1d Created with: gclient setdep -r src-internal@22e477b2ce1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I4d77e63f4b1a6d0c399fac779f0bfa47be11d986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123869Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754019}
-
Renato Silva authored
Adds shadows to the OOBE sign in screen when the contents of the webview is too long and has to be scrolled. Without the shadows, it is hard to tell that there is more content to be shown. Fixed: 1061476 Change-Id: I33fccb22fc3611bbcad15f061e5ad4a638482e93 Bug: 1061476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114170 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754018}
-
David Bertoni authored
The ExtensionsContextMenuLazyTest.TopLevel was disabled on Windows because it was flaky. I tested this with 2000 iterations and it is no longer flaky. This is presumably due to recent improvements in the Extensions Service Worker layer. Bug: 1046114, 251590 Change-Id: Ie421747a46e315df3ac0d7b30f932f5d362fa554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123031Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#754017}
-
Etienne Bergeron authored
Simplify the code by inlining the common values in the nitialisation list. This CL has no functional change. R=morlovich@chromium.org, gab@chromium.org Bug: 1065004 Change-Id: Ib52c6f910975ef109901171d499eee870826cc42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121765Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754016}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/48f3f6cb2acb..14b1e3f3d10a git log 48f3f6cb2acb..14b1e3f3d10a --date=short --first-parent --format='%ad %ae %s' 2020-03-27 sugoi@google.com Update SPIR-V Tools to fd773eb50 2020-03-27 sugoi@google.com Update SPIR-V Headers to f8bf11a02 Created with: gclient setdep -r src/third_party/swiftshader@14b1e3f3d10a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If2ced46e8698a25c1b609302e6a50c3a40620312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124415Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754015}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7fa53f2a9685..a27ec02e9e1e git log 7fa53f2a9685..a27ec02e9e1e --date=short --first-parent --format='%ad %ae %s' 2020-03-27 szuend@chromium.org Move 'issues' module from 'shell' to 'devtools_app' and 'worker_app' 2020-03-27 szuend@chromium.org [issues] Clicking on affected requests will open the details view 2020-03-27 tvanderlippe@chromium.org Remove unused global exports from common-legacy.js 2020-03-27 changhaohan@chromium.org add check to ensure style pane update 2020-03-27 tvanderlippe@chromium.org Remove unused global references in workspace-legacy.js 2020-03-27 aerotwist@chromium.org [e2e] Adds support for logs and errors 2020-03-27 aerotwist@chromium.org [e2e] Adds support for setting a timeout 2020-03-27 tvanderlippe@chromium.org Add test that verifies Ninja does not do any work when no changes are made Created with: gclient setdep -r src/third_party/devtools-frontend/src@a27ec02e9e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060267,chromium:1062614,chromium:1064287,chromium:1064958 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I45465867a265cbeedc8550cdc2f1dd8bc2c152f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123871Reviewed-by:
-
Lukasz Anforowicz authored
This CL migrates BackgroundXhrWebstoreTest.PolicyContentScriptXHR to the CrossOriginReadBlockingExtensionAllowlistingTest test suite (into new tests, called ContentScriptVsHostBlockedByPolicy_NoSniffXml and ContentScriptVsHostBlockedByPolicy_AllowedTextResource). This way the tests covers the following setup aspects: - CorbAllowlistAlsoAppliesToOorCors feature is enabled or disabled - Extension is allowlisted or not - OOR-CORS vs InBlinkCors After this CL the old test can be deleted. Note that the old test always tested with: - CorbAllowlistAlsoAppliesToOorCors disabled - Non-allowlisted extension - The default OOR-CORS state (enabled by default since r728462) Bug: 1061567 Change-Id: Ic76ac9e48510953fd130141776e66b1fde11c404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107431 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754013}
-
Benoit Lize authored
The orderfile build doesn't prefetch the native library, creating unreached code, which is a compile time error with the flags we use. Move the unreached code out of the build in this case. See the linked bug for the detailed error message. Bug: 1065182 Change-Id: Ic8c5b17e6077c4639a82b9caf574a7ae4018e64f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124258Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754012}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I18ad203905c3dfa511d0a5cc9b9fefc5616a4e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123873Reviewed-by:
-
Gauthier Ambard authored
When a navigation is cancelled, the NTP should still be presented. Currently, as the navigation starts, the NTP is hidden and it is not restored when the navigation is cancelled. Fixed: 1063154 Change-Id: I0844fa735ae4e0f9e184d46ac6c96e809b873807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120352Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754010}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/651fc45d3a29..fd3480d22624 git log 651fc45d3a29..fd3480d22624 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src acbf316040c3..cc481ef27631 (1 commits) Created with: gclient setdep -r src/third_party/angle@fd3480d22624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: Ia3fdc2e2a6d2b9fb748f8e67693970071c330bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124411Reviewed-by:
-
Mikhail Khokhlov authored
The target will wrap the uploader script with path to trace_processor_shell as an argument. The Perfetto revision will be determined automatically by the script itself. This target is intended to be built by perfetto-uploader CI bots. Bug: 1050517 Change-Id: I57a93f8268181250a85400b5899e845b5cfa9d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120427 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#754008}
-
Yaron Friedman authored
They passed 20/20 times locally. BUG=1062568, 727310, 999361 Change-Id: I3741560e7195d7d19f4bd17d97374d540b83fc24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122851 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#754007}
-
Antonio Gomes authored
As part of this move, the test was renamed to flexbox-overflow-auto-002.html. BUG=1063749 R=dgrogan@chromium.org Change-Id: I35b258bed47050051139020a1fc3147d08333fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120544 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754006}
-
Hans Wennborg authored
Looks like the space between the two right angle brackets is gone with recent Clang. The test expectation is already a regex, so insert a '?' to make the space optional. TBR=tzik Bug: 1064986 Change-Id: I3075116ff2b344a5e13658cd2fd6b92522d58aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124453Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#754005}
-
Eric Kuo authored
Add a routine to calculate prime number repeatedly and validate the calculation results are correct in a duration. Bug: b:146513388 Test: chromeos_unittests --gtest_filter=CrosHealthdServiceConnectionTest.* Change-Id: I29c3d71d2b0f9d86043e552e135bc9178c95014f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049986 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#754004}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7e40936b1d81..42f548873cf8 git log 7e40936b1d81..42f548873cf8 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 treehugger-gerrit@google.com Merge "client API: Add missing PERFETTO_EXPORT definitions" 2020-03-27 treehugger-gerrit@google.com Merge "profilers: treat unset and =0 persist props the same" Created with: gclient setdep -r src/third_party/perfetto@42f548873cf8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I24627c657f96315dd311bf12914fdefdbe676f58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124040Reviewed-by:
-
Fredrik Söderqvist authored
The |bounding_box| argument isn't actually used, so drop it. Also turn the check at the beginning of StrokeShape() into a DCHECK since the (only) caller already checks it. Change-Id: Ib5ff5d462c440a55361f9051e91e528ac3b82a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124373Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#754002}
-
Mark Cogan authored
Removes direct use of the BVC in MainController. The most common uses of the BVC through the interface provider are (a) access to the dispatcher, and (b) marking the BVC as the primary one. (This CL doesn't address whether the notion of a BVC as "primary" is still useful). The dispatcher can be accessed through an interface's Browser. This CL adds the -setPrimary: API to BrowserInterface for cases where it is needed. Additionally, updates removeBrowsingDataForBrowserState: to handle -- possibly correctly -- multiple connected scenes. This just repeats all of the setInteractionEnabled/showActivityOverlay calls for each scene. Change-Id: Ia6bebf86a991a977f83f3f3a8da086fe5de519e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124447Reviewed-by:
-
Benoit Lize authored
Scheduler group detection doesn't work on Android P x86 (see bug), but isn't used anyway on M and above. Disable the tests for these releases. Bug: 1061173 Change-Id: Ic0982c68387e9c77a9e55182b4ab059708ffc33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124379Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754000}
-
Nico Weber authored
The code looks like the break should be inside the if, so that the loop has a chance of running more than once. I tried reaching out to the author of this code, but didn't hear back. But with this change, header_exist should become true more often and the test code is stricter when it's true. So since tests still pass with this, this might help catch problems in the future. Bug: 346399,686247 Change-Id: I25e8c1a38043af09936e35c58e87db3bee103e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120048 Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#753999}
-
Richard Townsend authored
Adds a temporary fix to vs_toolchain.py to use the previous version of MSVC's header files and documents how to install the previous version alongside 19.25. Bug: 1058860 Change-Id: I6e96af3c71b23e5c5430237d00125a5830c37855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117732 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#753998}
-
Colin Blundell authored
This CL adds test coverage of WebLayer's handling of browser fallback URLs in external intents: - If the intent is launched, then the presence of a browser fallback URL doesn't change anything. - If an intent can't be launched with no browser fallback URL, there is a failed navigation. - If an intent can't be launched with a browser fallback URL, there is a successful navigation to the browser fallback URL. Bug: 1029710, 1031465 Change-Id: I6386ab44d6ffc9a58e93966c00516cb360fbdcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121266Reviewed-by:
-
Hans Wennborg authored
Bug: none Change-Id: I87c0dd47fef41e9ada7dfc192bae3a1aff55897b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124380 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#753996}
-
Anders Hartvoll Ruud authored
Not resetting this didn't lead to any bugs, because it's just a performance optimization. Even if a given bit is set, nothing will happen if the corresponding property is missing from the cascade. Also, we only really Reset for DCHECK_IS_ON. Still it's proper to actually reset the value. Change-Id: I57b023316c46c8f8def9c634319116d63c4503f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124250 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753995}
-
Nicolas Ouellet-Payeur authored
This refactors the InstallationTracker, and splits it into 2 classes: - InstallationTracker: listen for pref changes, and keep track of force-installed extensions' installation state. Fire `OnAllExtensionsLoaded()' when they're all done. - InstallationMetrics: listen for `OnAllExtensionsLoaded()', and report metrics to UMA when it fires. With this refactor, other classes can listen to this event to get notified when force-installed extensions are done loading. Bug: 1057999 Change-Id: Ib3ff409b460411020b3dee586aba3413a3e1d93f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088295 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#753994}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4ff1b1de0e8d..7fa53f2a9685 git log 4ff1b1de0e8d..7fa53f2a9685 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 petermarshall@chromium.org [ui] Fix color picker switcher style for dark-mode 2020-03-27 aerotwist@chromium.org [e2e] Migrate selection-after-delete layout test 2020-03-27 szuend@chromium.org Prepare IssuesModel for 1:n mapping between backend and frontend issues Created with: gclient setdep -r src/third_party/devtools-frontend/src@7fa53f2a9685 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I942f257ad1747868fcf457f39beae26097a9cc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124408Reviewed-by:
-
Sebastien Lalancette authored
Bug: 1064990 Change-Id: Ia865919514d57b4e7611bdfe7fa5828035b9ec26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122750Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#753992}
-
Huanzhong Huang authored
This change is to align with the corresponding Finch config Bug: 1045348 Change-Id: Ia5cceb550520cb31127057e5be61e84998b017e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121120Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#753991}
-
Abigail Klein authored
Make it possible to drag the caption bubble by clicking any part of it. To do this, introduce a CaptionBubbleFrameView which overrides the NonClientHitTest to return HTCAPTION whenever the hit point is inside of the bubble and is not on the close button. Bug: 1055150 Change-Id: I9ee8cdd064b87210ea05599cb01f7d42d64451e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095881Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#753990}
-
