- 19 Oct, 2020 40 commits
-
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Iad5b936d495d48cae46e6c119a542c1d650d592d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485136Reviewed-by:
Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#818581}
-
Martin Kreichgauer authored
This removes logic for obtaining a pinUvAuthToken in MakeCredentialRequestHandler in favor of using AuthTokenRequester. There should be no behavior changes as to whether PIN or internal UV is requested for a given makeCredential request. (And existing PIN/UV-related test cases in authenticator_impl_unittest.cc provide decent coverage to ensure that this is indeed the case.) There is a small change in handling authenticator removal mid-request: This would previously only abort the request if the handler was waiting for a PIN. It now generally aborts the request as long as an authenticator has been chosen, but the request hasn't finished (e.g. because a it is waiting to enroll a biometric template). Also changes VirtualCtap2Device to return CTAP2_ERR_UV_BLOCKED if a failed UV attempt locks the authenticator, as the spec prescribes. Bug: 1139111 Change-Id: I4c07b16294ffba4a15ea813e182ad669645bf703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469445 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#818580}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e6d60bea7801..46e1bcace932 2020-10-19 tvanderlippe@chromium.org Remove pre_generates_legacy from module.json files 2020-10-19 tvanderlippe@chromium.org Unconditionally use object notation for dispatchers 2020-10-19 tvanderlippe@chromium.org Remove rollup_module from build_release_applications 2020-10-19 tvanderlippe@chromium.org Remove Dispatcher protocol types 2020-10-19 karntino.c.areros@gmail.com enable CTRL key operation on value widget/decoration 2020-10-19 sigurds@chromium.org Add API section to frame details view 2020-10-19 pfaffe@chromium.org Fix two minor issues in node.py 2020-10-19 aerotwist@chromium.org TypeScriptify AnimationTimeline.js 2020-10-19 alexrudenko@chromium.org Fix grid labels rendering 2020-10-19 sigurds@chromium.org Add more information to error reporting on connection close If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1090846,chromium:1131500,chromium:1138492,chromium:1139897,chromium:1139899 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I32f6e230e96465f5eff9f6614a2039392410582e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485600Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818579}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6883db53569f..6d3d381e7251 2020-10-19 geofflang@chromium.org GL: Update BufferGL to use ANGLE_GL_TRY. 2020-10-19 jmadill@chromium.org Test Runner: Disable watchdog when debugger attached. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I0588d2df0313d197d59fa74ac9be23f4fb9a8357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485601Reviewed-by:
-
Devlin Cronin authored
TBR=jdonnelly@chromium.org Bug: 11401539 Change-Id: Ia9963196b784a1e1b923d488af722df2bff000de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485440Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#818577}
-
Alison Maher authored
This change adds support for the prefers-contrast media query and adds PreferredContrast to settings. The logic for updating PreferredContrast from its default state based on the OS will be implemented in a follow-up change. Spec: https://drafts.csswg.org/mediaqueries-5/#prefers-contrast Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/I0e2_nAwW7E Bug: 1107431 Change-Id: Ie09df9069c979caf944d8af1d5f6bde80f40e8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410646 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#818576}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/abdfd39bb64e..bcd1fc030a2b 2020-10-19 johnstiles@google.com Avoid changing built-in symbol tables during lookup. 2020-10-19 kylechar@chromium.org Add context option to disable mipmap support 2020-10-19 johnstiles@google.com Add builtin flag to SymbolTable. 2020-10-19 mtklein@google.com fix forward/backward jump logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1138979 Tbr: egdaniel@google.com Change-Id: Ieace4fcdc667f15bf303181cc235039a3d0752b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485611Reviewed-by:
-
John Delaney authored
Uncomments per-file owner now that alexmt@ is a committer Change-Id: I501de30a9afde3c7a758c8957a6923dd3149829a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481703Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Ravi Mistry <rmistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#818574}
-
Theresa Wellington authored
BUG=1138236 Change-Id: Ice5140053b6216c6a2f9300a9da71f6d079f4550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482182 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#818573}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6ce4cd4c98d1c689d1526d5877d803cab31ac5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485638Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#818572}
-
Owen Min authored
The extension request will be uploaded to DM server right after user request it. This may significantly increases the DM server traffic. Put this functions behind feature flag so that we could turn it off just in case. Bug: 1137964 Change-Id: Ia056ddd356d068680c63d1e7650b4f1ea3a923be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472459 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#818571}
-
Daniel Murphy authored
This fixes an issue I introduced in m85 here: https://chromium-review.googlesource.com/c/chromium/src/+/2181827 during our migration of all "bookmark apps" off of the extensions system and onto the WebAppProvider system. Making YouTube no longer a 'bookmark app' (and back to a hosted app) had the side effect of making its storage protected, because apparently all hosted apps have their storage protected. This change marks all potential default hosted apps as no longer receiving protected storage. The long term fix for this issue is to have the WebAppProvider system support default apps, and migrate these old hosted apps (which is a double-deprecated system) onto the WebApp platform: https://bugs.chromium.org/p/chromium/issues/detail?id=1140122 R=cmp@chromium.org Bug: 1139902 Change-Id: I0d09eed3bf232407192fd07e621b82bcac4263f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485436Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#818570}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4277.0-1602497703-benchmark-88.0.4294.0-r1 to 88-4280.20-1603104419-benchmark-88.0.4296.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ifa6b3c76d5c0c9f481fe4664cf5fbdd2837f5d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485605Reviewed-by:
-
Carlos IL authored
Mixed content autoupgrades are currently completely disabled for webview, this makes them controllable with a webview specific variations flag. Flag is also exposed in AW devtools. Bug: 1139424 Change-Id: I9095cdd98eef0136106d087af3f1f104784d3dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480817Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#818568}
-
Richard Coles authored
This reverts commit ed41365b. Reason for revert: Newly added tests failing consistently on android-pie-x86-rel Original change's description: > Introduce LayoutStateObserver to notify the state for all Layouts > > This CL introduces a generic LayoutStateObserver for getting > notifications from the Layout system about every supported layouts > show/hide state changes. This LayoutStateObserver is added to the Layout > system via the LayoutStateProvider. > > Additionally, this CL merges the SceneChangeObserver interface into > LayoutStateObserver: > * SceneChangeObserver#onTabSelectionHinted -> > LayoutStateObserver#onTabSelectionHinted > * SceneChangeObserver#onSceneChange -> > LayoutStateObserver#onStartedShowing > > Note: > 1. This CL breaks from crrev.com/c/2353875. > 2. This new notification system has been integrated to production > code with zero callers. > > Change-Id: I23bd2b5b1b674a6df554a2edd1ffbfb32da5d6b1 > Bug: 1108496 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463850 > Commit-Queue: Mei Liang <meiliang@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818290} TBR=twellington@chromium.org,mdjones@chromium.org,meiliang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108496 Bug: 1139943 Change-Id: I05c7b7d97d389e7498bfc58d6a073c68ec08e5bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485636Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#818567}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/875091308b04..aff4c0366314 2020-10-19 enga@chromium.org Fix unused variable warnings on ChromeOS 2020-10-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from c9a3e4739678 to 7156d3e3140b (1 revision) 2020-10-19 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 89042538376b to c9a3e4739678 (1 revision) 2020-10-19 enga@chromium.org Add missing include in SwapChainVk 2020-10-19 dsinclair@chromium.org Fixup cmake file 2020-10-19 enga@chromium.org Reland "Replace the wire serializer with a no-op impl on disconnect" 2020-10-19 jiawei.shao@intel.com Add the entry point of CreateReadyComputePipeline 2020-10-17 cwallez@chromium.org Initial new swapchains on Vulkan. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:951558 Tbr: dsinclair@google.com Change-Id: Ib016997050dc5ce881fc8bd21de57971687bec0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485598Reviewed-by:
-
Luke Zielinski authored
Usage of this option is deprecated and was dropped in https://github.com/web-platform-tests/wpt/pull/26118 Bug: 1139500 Change-Id: I55ba3accd355eb61fd865007294517a8e8aaac4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485011Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818565}
-
Sergey Ulanov authored
initialized. FuchsiaAudioRenderer was not handling this correctly. It was trying to call AudioConsumer.BindVolumeControl before the AudioConsumer is connected. As result it was logging an error message about disconnected VolumeControl without setting the volume. Updated SetVolume() implementation to persist the volume value and send it as soon as AudioConsumer is connected. AudioRenderer: :SetVolume() may be called before the renderer is Change-Id: Ic5418c2c002c1181da01e8a278b0b53845baee47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481958 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#818564}
-
Richard Knoll authored
If a notification does not need the Settings button and only has one action button we don't need the overflow menu as it would only have a single entry. Instead just show the action as the second button in the notification. Before: https://imgur.com/SUvMXlW After: https://imgur.com/QRijUhf Bug: 1139892 Change-Id: Ia8b95aeffcea95345a9d483d065f818d03584939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485153 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#818563}
-
Mikel Astiz authored
No behavioral changes, the code is moved as is, the SyncService and SyncClient's public API are temporarily extended to avoid behavioral changes. Change-Id: I150423896d413dafdba61e891f55d4164be89440 Bug: 1137346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476273Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818562}
-
Mehran Mahmoudi authored
This assertion can fail because this path is now also accessible if PAINT_PREVIEW_SHOW_ON_STARTUP flag is enabled. It was added here: crrev.com/c/2472432 Bug: 1134752 Change-Id: I20d8937b24de77c366a8bf552a68ff787d488959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485395 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#818561}
-
Gavin Williams authored
For browser settings add the "Subpage button" role description to <cr-link-row>'s to clarify the button's action to the user. Fixed: 1012105 Change-Id: Ic5836c656adf119ea3da0ae3d1319ee7e2cafe8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485036Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#818560}
-
Peter Wen authored
- CustomViewStyleable - DefaultLocale - DrawAllocation - EllipsizeMaxLines - ExportedContentProvider - ExportedService - HandlerLeak - IconColors - IconLauncherFormat - IconLauncherShape - Instantiatable - InconsistentLayout - InflateParams (Permanently skipped) - InlinedApi (Permanently skipped) - JobSchedulerService Bug: 1116130,1081240 Fixed: 1081240 Change-Id: I37dfb048198cbbed198408f74ecce1d0876d6dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429808 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#818559}
-
bttk authored
Bug: 1133482 Change-Id: I30d0131ca1eba153d8f2b1ac725dccf4fe7072d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476625Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: who/bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#818558}
-
Cattalyya Nuengsigkapian authored
- In non-logged-in screens, update accessibility insets of work area bound in shelf layout manager. - Add a shelf observer to system modal layout manager to update work area when a docked magnifier is enabled and disabled. - Add unit tests for checking that display work area and modal window bounds are updated correctly and consistently when enabling and disabling the docked magnifier. ## Testing - a video showing fixed and make sure that there's no ghost shelf issue https://drive.google.com/drive/folders/1VO032gh3Ha3csIzpyRZzsEI7_7fiAqlG?usp=sharing 1. make sure unmodified code fails a new unit test DockedMagnifierTest.WindowBoundsChangeInNonActiveState before bug fixing. https://screenshot.googleplex.com/S2pzpBHxawVvRr5.png 2. make sure to check update in work area to catch the bug that work area doesn't expand back when disabling a docked magnifier. (CL2465874 that fails manual test should fails unittests) - https://screenshot.googleplex.com/84nhosyUMEFmM5F.png - https://screenshot.googleplex.com/6xpA99WvQPvGt7b.png 3. make sure the modal window bound doesn't overflow. - https://screenshot.googleplex.com/9ExRpjFesGqBuga.png 4. make sure the modal window is centered correctly in the secondary screen. (avoid using inconsistent coordinate system in GetUsableArea). - https://screenshot.googleplex.com/8Hzdy6UfECjE6gU.png Bug: 1057062 Change-Id: Icdb554dbdea21a7191a64bfd31cf519205980fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429743 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#818557}
-
Chris Sharp authored
This policy doesn't have to be platform_only=True Bug: 1140118 Change-Id: I5c4f3432137c9e65e3c8173bbb24ce953577f7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485753Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#818556}
-
Alex Turner authored
Whenever an execution context (whether a window or worker) becomes a client of a service worker, the renderer will now inform the respective ServiceWorkerContainerHost of the client's ukm::SourceId once it is execution ready. This id will be passed to SWIdentifiabilityMetrics, a new SWContextCoreObserver. This observer will them emit a UKM event (Worker.ClientConnected) in order to associate the ServiceWorker's ukm::SourceId with the client's. DedicatedWorkers' ukm::SourceIds are not included as they exactly match that of their parent execution context. This association is required both for attributing entropy consumption of workers to sites, but will also help to gain insight into the cross- connectivity between first-party contexts via shared and service workers. Design doc (internal-only): https://docs.google.com/document/d/1mx4-zI53cskB8j75Mis2q3rVrO8uHeJpwGuT8psbURA/edit?usp=sharing Bug: 1085645, 1134193 Change-Id: I7d1728ebe15d162b980dd2e552622e4c4f91edc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321059 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#818555}
-
Dale Curtis authored
The way the kConfigChange state was used is not safe and ultimately useless. It was set atomically on the main thread, but operations on the decoder thread would query multiple times within a single function call and were not expecting kConfigChange. It's ultimately useless since we just end up stopping the decoder thread regardless. Except for cases of destruction or error, it's incorrect to invalidate the WeakPtr posted tasks too. These manage picture buffer allocation and client notifications that should never be dropped. This also applies a temporary fix for a DCHECK() crash and removes some stale debugging code. Bug: 1111273, 1139489 Change-Id: I42a9c76f7ea272c57b8c7aa3e78bd379c3120c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481945 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#818554}
-
harrisonsean authored
This removes the tap animation for safety check rows that are not currently tapable. Bug: 1078782 Change-Id: I5cd6bd50480a613c0de02eb9c06b6631746181bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479525 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#818553}
-
Fredrik Söderqvist authored
No longer flaky. Tbr: schenney@chromium.org Fixed: 1137716, 1138589 Change-Id: Ib8e0cf43abc1ae3df570c70f386f6b6fd3c1cf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484595 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#818552}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/af704183574c..d40c764ba81e 2020-10-19 nisse@webrtc.org Delete leftover mention of AsyncInvoker If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia6c9897b7c2786106f078f993d902b09a345ad6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485594Reviewed-by:
-
Ian Struiksma authored
On some test bots, mac dock or external values cause the browser to make minor resizings of the frame. These are extraneous to our tests so we would like to ignore those during tests. This CL provides a test hook by adding test access methods to ChromeAutofillClient to make the autofill popup more resistant to hiding from frame resizes, and then has AutofillUiTest access that hook when running Interactive UI tests. This re-enables autofill interactive tests on mac bots. Bug: 967588 Change-Id: Id9e25988f0cf64f0aa0631a48d48eb982b116c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473802 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#818550}
-
Devlin Cronin authored
Forgot the MAYBE_ prefix in test itself (yay, Mondays!) TBR=jdeblasio@chromium.org NOTRY=True Bug: 1139955 Change-Id: Ic94974f53c57faede67731b41126dd91ec4b2999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485496Reviewed-by:
-
Leonid Baraz authored
Bug: b:169248924 Change-Id: I8ca3f363d7b616d06707b6dd3639ddc29a334351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481004Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#818548}
-
Matthew Mourgos authored
This change has the clipboard nudge observe the hotseat state and will animate the bounds of the clipboard nudge so that the nudge is always placed above the hotseat. Also, because the ClipboardNudge uses RootWindows the clipboard_history_controller_ must be reset in before the window_tree_host_manager_ is shutdown. This fixes the original CL which was reverted due to msan issues. Bug: 1137019 Change-Id: Ibbe8f06132f51d569a5ea4993df77ef042eabeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477524 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Carlos IL authored
The histogram logs anytime an app calls WebSettings.setMixedContentMode Bug: 1139424 Change-Id: I88533e1a81bd9228e599201304f89346e5d5a8cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482029 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#818546}
-
Ilya Sherman authored
R=gab Bug: none Change-Id: I60b4f00c3ebe5b61c14f25fe4ef4bf38bfed07fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477475Reviewed-by:
-
Akihiro Ota authored
Bug: N/A Change-Id: Ibc913eaefe212b621b7ffdd83e05bdd75f62920b AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480733Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#818544}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/89042538376b..7156d3e3140b 2020-10-19 dsinclair@chromium.org [wgsl-reader] Add parsing of named structs. 2020-10-19 dsinclair@chromium.org Roll Tint dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: dsinclair@google.com Change-Id: I00a603b6f01a65c5bc522d8bec8b0d9c82b718b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485591Reviewed-by:
-
Austin Eng authored
Dawn is not supported on Win7. The tests were inadvertently enabled in https://chromium-review.googlesource.com/c/chromium/src/+/2480584 which changed test set up. Now, the TestGPUServiceHolder is not created at all on unsupported platforms. Use it as a signal to skip the test. Tbr: cwallez@chromium.org Bug: 1139941 Change-Id: I68b4fcf733ca83978b544f7d065866760fc056db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485674Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#818542}
-
