- 28 Sep, 2018 40 commits
-
-
momohatt authored
This patch enables ServiceWorkerSingleScriptUpdateChecker to check if there are any differences between the stored scripts and its counterparts loaded from the network. The comparison is only performed for scripts that are used in the instance of requested SWVersion. This impl doesn't yet allow SWNewScriptLoader to continue the aborted comparison, but future patches will implement: * passing the result of update check to SWNewScriptLoader * record the info about scripts which are already compared and known to be identical Bug: 648295 Change-Id: If89dd415578b1c5809159f196d398447a96a812f Reviewed-on: https://chromium-review.googlesource.com/1224610 Commit-Queue: Momoko Hattori <momohatt@google.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#595072}
-
François Doray authored
This reverts commit 5cae37b5. Reason for revert: Find-it identified this as culprit for multiple failures as shown on https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.linux/builders/linux-xenial-rel/builds/3696 Failures in: virtual/layout_ng_experimental/fast/multicol/balance-float-with-margin-top-and-line-after-break.html virtual/layout_ng_experimental/fast/multicol/dynamic/remove-abspos-next-to-spanner.html Original change's description: > [LayoutNG] Make constraint space for column balancing intermediate > > Fragment caching and paint needs to know if fragments created > for a constraint space are for the regular layout that are to > be painted, or it's for intermediate computation. > > Since the layout results for column balancing should not be > painted, this patch marks so. > > This change alone doesn't fix all weird paint data > inconsistencies when block fragmentation is turned on. Other > issues need further investigation. > > Bug: 714962 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: I14d44ca10fd23726f2c08be45b10c2b0abe16bf7 > Reviewed-on: https://chromium-review.googlesource.com/1250685 > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595051} TBR=kojii@chromium.org,mstensho@chromium.org Change-Id: Id550d1f9cafa348eebf378e2aeb7c213cf16a75f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1251228Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#595071}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/89f64d305eff..cbcbc225687f git log 89f64d305eff..cbcbc225687f --date=short --no-merges --format='%ad %ae %s' 2018-09-28 nisse@webrtc.org Reland "Replace VideoDecoder with VideoDecoderFactory in VideoReceiveStream config." 2018-09-28 kron@webrtc.org Parse two-byte header extensions. 2018-09-28 henrika@webrtc.org Improves threading model in AudioDeviceTest. Created with: gclient setdep -r src/third_party/webrtc@cbcbc225687f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I047923cf7501cf353a3b50b6c560e0ab42a550da Reviewed-on: https://chromium-review.googlesource.com/1250948Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595070}
-
Justin Cohen authored
Bug: 807330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iaa0935d3d3c10a5ad80a9cf4e758d84e9af95c3a Reviewed-on: https://chromium-review.googlesource.com/1249885 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#595069}
-
Tonko Sabolčec authored
Chrome doesn't handle failures when initializing PasswordStore. This causes a bug that user is asked to save passwords when Chrome is not able to save them. This CL includes: - Check if encryption is available on Mac. - Check if login database was successfully initialized. Bug: 479725 Change-Id: Ic491e2b04c98270b984a6f08a431b99863419116 Reviewed-on: https://chromium-review.googlesource.com/1243069 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#595068}
-
Lei Zhang authored
One small missing bit from r560988. Change-Id: Ib6afc4957fdc8eae24b1f21f7929cedbe056cac2 Reviewed-on: https://chromium-review.googlesource.com/1250205Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#595067}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76007858f065..bea5a39cb895 Created with: gclient setdep -r src-internal@bea5a39cb895 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I083213f356df89843320d60f041e66b5c9aaf12e Reviewed-on: https://chromium-review.googlesource.com/1250950Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595066}
-
Tsuyoshi Horo authored
This reverts commit 4762a830. The difference from the original patch is that in this patch SignedExchangeAcceptHeaderBrowserTest uses SetUp() instead of SetUpOnMainThread() to avoid the failures in TSAN bots. Bug: 887201 TBR=kinuko@, kouhei@, ksakamoto@ Original change's description: > Send SXG accept header of navigation only to limited origins for Origin Trial. > > Before this patch: > The SXG accept header is sent to all origins when SignedHTTPExchange feature > or SignedHTTPExchangeOriginTrial feature is enabled. > > After this patch: > The SXG accept header is sent when > - SignedHTTPExchange feature is enabled. > or > - SignedHTTPExchangeOriginTrial feature and SignedHTTPExchangeAcceptHeader > feature are enabled and the origin of the URL is in the OriginList of > SignedHTTPExchangeAcceptHeader field trial. > > Bug: 887201 > Change-Id: Ic67a8bc0644b1b6172030ff75162c04663dd33f0 > Reviewed-on: https://chromium-review.googlesource.com/1242768 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#595002} Change-Id: Iff188ffe2096c35d2c9fb4eee3723e78f5901b26 Reviewed-on: https://chromium-review.googlesource.com/1251144Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#595065}
-
Yuta Kitamura authored
Bug: 826203 Change-Id: I0d8a2ad46df93e3bf50b71a34b4abb315844a84e Reviewed-on: https://chromium-review.googlesource.com/1250522Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#595064}
-
Yuta Kitamura authored
This CL moves most of the actual work of initializing compositor thread from RenderThreadImpl to Platform. This further reduces //content's dependency to WebThread. A new virtual function is introduced to Platform so we can change the thread priority of the created compositor thread on Linux, where we need to talk to the browser process to change the thread priority. Additionally, a new function Platform::CompositorThreadTaskRunner() is introduced, because RenderThreadImpl needs to post tasks to the compositor thread after the thread is initialized. Bug: 826203 Change-Id: Ic80e6452cdfe8af25ae2b277125687854859d106 Reviewed-on: https://chromium-review.googlesource.com/1249424 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595063}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e14a15df1635..76007858f065 Created with: gclient setdep -r src-internal@76007858f065 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I54e330693fa5e39e6d7eb48e4bb0c61778146008 Reviewed-on: https://chromium-review.googlesource.com/1250947Reviewed-by:
-
Stephane Zermatten authored
This change introduces support for the action navigate, which tells the browser to go to a specific URL. The action finishes without waiting for the new page to load. Bug: 806868 Change-Id: Ibe354eb627b836e6e1d5ad5ff461a8b392102faa Reviewed-on: https://chromium-review.googlesource.com/1248783 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#595061}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1ee9160a2e0b..89f64d305eff git log 1ee9160a2e0b..89f64d305eff --date=short --no-merges --format='%ad %ae %s' 2018-09-28 crodbro@webrtc.org Move network trace calculation from analyzer to rtc_event_log_parser. 2018-09-28 mbonadei@webrtc.org Remove deprecated field_trial_default and metrics_default. 2018-09-28 peah@webrtc.org AEC3: Remove killswitches in AecState 2018-09-28 phensman@webrtc.org Add option to call VMAF in compare_videos.py. Created with: gclient setdep -r src/third_party/webrtc@89f64d305eff The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:b/116768521 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf84f48258437048eba24462cabc1b0971408fc1 Reviewed-on: https://chromium-review.googlesource.com/1250946Reviewed-by:
-
Rayan Kanso authored
The BackgroundFetchCrossOrigin filter is conservative and does not expose any headers if something shouldn't be exposed. Bug: 838837 Change-Id: I3a9f91ba5f2e7c57f2975419f192b5de64c6d886 Reviewed-on: https://chromium-review.googlesource.com/1249210Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#595059}
-
Jamie Madill authored
This reverts commit 9803c0eb. Reason for revert: WebGL 2 video test failures on Win/Mac. Blocking the ANGLE CQ. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28NVIDIA%29/2542 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Release%20%28Intel%29/6848 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/2571 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/2795 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20Retina%20Release%20%28AMD%29/8042 Also reverts "[media] Fix video frame copy when context is lost." Bug: 890281 Original change's description: > [media] Fix video to canvas GPU-CPU race. > > VideoFrames marked with VideoFrameMetadata::READ_LOCK_FENCES_ENABLED > must be retained until all reads have been completed. Such frames are > produced when software frames are uploaded to GpuMemoryBuffers. The > VideoResourceUpdater handles this, but PaintCanvasVideoRenderer > implemented only sync tokens. > > As a result, WebGL reads of software-decoded frames can tear when the > storage is reused for later frames. > > This CL adds a GL_COMMANDS_COMPLETED_CHROMIUM query after each potential > VideoFrame read in PaintCanvasVideoRenderer, and retains a reference to > the VideoFrame until it completes. This ensures that the memory is not > reused until after the reads complete in the GPU process. > > Bug: 819914 > Change-Id: I3e6e5f83cff86beedbd76a406aa31c4eb84a0929 > Reviewed-on: https://chromium-review.googlesource.com/1244835 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594900} TBR=pfeldman@chromium.org,tedchoc@chromium.org,sandersd@chromium.org,dcastagna@chromium.org,sunnyps@chromium.org,piman@chromium.org Change-Id: Ib21a4879a9ca6fc4b84f6f2c2f1171c794db54b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819914 Reviewed-on: https://chromium-review.googlesource.com/1251321 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#595058}
-
Alex Clarke authored
The intent of this patch is to define the interfaces which will be implemented by subsequent patches. The interfaces are a subset of the C++ ones including what we believe is the minimum requried to be useful. Design doc: https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit# Bug: 863341, 872372 Change-Id: Ic608660a13c55c4b17d3ba5fa3bb636783735645 Reviewed-on: https://chromium-review.googlesource.com/1245790 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#595057}
-
Michael van Ouwerkerk authored
This reflects the implementation of onNavigationEvent. Bug: 882442 Change-Id: I15a96adf98707e6c18fe19646724076623db85c4 Reviewed-on: https://chromium-review.googlesource.com/1246161Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#595056}
-
Vadym Doroshenko authored
That's good both for privacy and storage reasons. Bug: 831123 Change-Id: Ie41b6d1f25fe37f86aea9eb4625d8aa878e0a52e Reviewed-on: https://chromium-review.googlesource.com/1249205 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#595055}
-
Tanja Gornak authored
Bug: 801985 Change-Id: I182041d580aff43661c227e421fc596506280cee Reviewed-on: https://chromium-review.googlesource.com/1203998Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#595054}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b89897915c5..e14a15df1635 Created with: gclient setdep -r src-internal@e14a15df1635 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib84c6ec4132160f5eb272c9a61dbd6e8038fff82 Reviewed-on: https://chromium-review.googlesource.com/1250944Reviewed-by:
-
Daniel Bratell authored
Jumbo compilation in components/sync broke when a kInvalidId clone appeared with the same name. This build unbreaking patch renames it to kInvalidNodeId. A longer term fix is probably to move the constant to modules/sync/base or another shared location. Regression from https://chromium-review.googlesource.com/c/chromium/src/+/1164742 TBR=mastiz@chromium.org,treib@chromium.org Bug: 870624 Change-Id: Ie300cf3338c8ffb93a2a0b3b656838bdbf10248a Reviewed-on: https://chromium-review.googlesource.com/1250965 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#595052}
-
Koji Ishii authored
Fragment caching and paint needs to know if fragments created for a constraint space are for the regular layout that are to be painted, or it's for intermediate computation. Since the layout results for column balancing should not be painted, this patch marks so. This change alone doesn't fix all weird paint data inconsistencies when block fragmentation is turned on. Other issues need further investigation. Bug: 714962 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I14d44ca10fd23726f2c08be45b10c2b0abe16bf7 Reviewed-on: https://chromium-review.googlesource.com/1250685 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#595051}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d50988f0..686dfc3f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I30cfb03e8ddeda5c99f5ed7626ad7d7ca625ba39 Reviewed-on: https://chromium-review.googlesource.com/1251021Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#595050}
-
Sam Zackrisson authored
Bug: webrtc:9535 Change-Id: I4bf1136184c4d09b7381f53d4ce85937b929f748 Reviewed-on: https://chromium-review.googlesource.com/1250961Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#595049}
-
Kent Tamura authored
We changed the coverage of :unresolved and :defined in crrev.com/594582. But the CL didn't invalidate style correctly. This CL fixes it. * node.cc: - Invalidate :unresolved on V1 custom element state change - Invalidate :defined on V0 custom element state change * Tests: Add v1 custom element + :unresolved test to existing unresolved-pseudo.html. Add :defined invalidation test. Bug: 889336 Change-Id: Id69ba3f9cb62d2805877b648762f4f94bd02e1f9 Reviewed-on: https://chromium-review.googlesource.com/1250721 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#595048}
-
Finnur Thorarinsson authored
They remain disabled on KitKat, which was the problematic version before. Bug: 888931, 656015 Change-Id: I853ea893bfbb60dc6e08095a303ecd32a39325d4 Reviewed-on: https://chromium-review.googlesource.com/1245710 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#595047}
-
Jérôme Lebel authored
Adding implementation to open sync passphrase and restart authentication flow. This is related to: + SyncSetupService::kSyncServiceUnrecoverableError + SyncSetupService::kSyncServiceNeedsPassphrase Bug: 849754 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If8ac0eb0f5b93adf5d16685085a07f9ad127e777 Reviewed-on: https://chromium-review.googlesource.com/1246065 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#595046}
-
Oriol Brufau authored
GridAreaPositionForInFlowChild could return a wrong end position for grid items adjacent to a collapsed track, because it didn't take into account that gutters collapse in that case. Therefore, "center" or "end" alignments displayed the item at the wrong position. BUG=801881 TEST=external/wpt/css/css-grid/alignment/grid-gutters-013.html Change-Id: I8223f102e3fd581ab0a2d6f23d18c188e23807c7 Reviewed-on: https://chromium-review.googlesource.com/1245727Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#595045}
-
Ramin Halavati authored
As bookmarks are shared between incognito and regular mode, partner bookmark mapping is added to incognito persistent list. Bug: 861722 Change-Id: I98a10094b2734c32316a6aea0e477391305b19f2 TBR: wychen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1251101 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
-
Eric Seckler authored
Bug: 878356, 882872 Change-Id: I16af203c203b82efc408d2153c43eb3cb6fcc7b9 Reviewed-on: https://chromium-review.googlesource.com/1246361Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Patrik Höglund authored
I forgot to rename these in the last patch. No-try since no trybots run these configs. Tbr: justincohen@chromium.org. Bug: 877018 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If9213ceabdeb70b2feb21fddbb446d7b742bbccc No-try: True Reviewed-on: https://chromium-review.googlesource.com/1251084 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#595042}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7f0def7921b..40a2e1ea2449 git log f7f0def7921b..40a2e1ea2449 --date=short --no-merges --format='%ad %ae %s' 2018-09-28 primiano@google.com Merge "trace_processor: change cursor class to be scoped to a filter operation" Created with: gclient setdep -r src/third_party/perfetto@40a2e1ea2449 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Icac7a74ced7d89ae597c2af391c3d3aad24ed8c2 Reviewed-on: https://chromium-review.googlesource.com/1250943Reviewed-by:
-
Mirko Bonadei authored
While working on removing field_trial_default and metrics_default (in order to avoid link time replacement and use better defaults), we discovered that runtime_enabled_features (which also has a _default implementation) is not used (more info on this here: https://bugs.chromium.org/p/webrtc/issues/detail?id=9631#c21). Usage of this code has been removed in WebRTC with this CL: https://webrtc-review.googlesource.com/c/src/+/102361. Bug: webrtc:9631 Change-Id: Ief33059cd329f429b9bbdd7520808e62e3f6f62b Reviewed-on: https://chromium-review.googlesource.com/1249029Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#595040}
-
Hajime Hoshi authored
This CL is pure refactoring. We aim to reduce ThreadTaskRunnerHandle: :Get() usages as much as possible. Change-Id: I13cb655c77f5b6c78d977e680fa92aa4278f38f5 Reviewed-on: https://chromium-review.googlesource.com/1249477Reviewed-by:
-
Yoichi Osato authored
This patch is refactoring. Since we have only inserted Text node rather than Node(see L263), we should type the internal hash map key to Text rather than Node. Bug: 868229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I582b3b0b5f3090ac94d89dfb99a32f1fd43527d4 Reviewed-on: https://chromium-review.googlesource.com/1248362 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#595038}
-
Ryo Hashimoto authored
BUG=None TEST=None Change-Id: I27db32e1fe44e2c3ab2d39f79790396959f2cf61 Reviewed-on: https://chromium-review.googlesource.com/1250562Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#595037}
-
Mikel Astiz authored
A USS bridge has been recently introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1164742 to allow integrating legacy SyncableService sync datatypes into the most modern USS architecture. In this patch, a controller is introduced to do the necessary plumbing and use the new codepath behind feature toggles. We do this for a first set of datatypes that are simplest, i.e. the ones that live in the UI thread and without complex logic in their controllers. Follow-up patches will add support for more. Bug: 870624 Change-Id: Ibdcc01133103296bd9c53e165a37b63cc32dcb87 Reviewed-on: https://chromium-review.googlesource.com/1251102Reviewed-by:
-
Marc Treib authored
This solves a (presumably) rare case where we'd get the same invalid token again and again. Bug: 889896 Change-Id: I10f569f195a91c6912ac700ccc5dd0c1c8f3c06c Reviewed-on: https://chromium-review.googlesource.com/1249087 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b5c6dd434907..1ee9160a2e0b git log b5c6dd434907..1ee9160a2e0b --date=short --no-merges --format='%ad %ae %s' 2018-09-28 oprypin@webrtc.org Don't use nonstandard tryjobs for autoroller 2018-09-28 buildbot@webrtc.org Roll chromium_revision 2985a247..f63f90fb (594820:594935) Created with: gclient setdep -r src/third_party/webrtc@1ee9160a2e0b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:888417,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib740628d8c18e1d56650279c9efdaaaa636f1f71 Reviewed-on: https://chromium-review.googlesource.com/1250802Reviewed-by:
-
Patrik Höglund authored
I have a green waterfall which confirms the experimental src-side config works now, so make BuildBot use the new config. This will make it easier to switch from BuildBot to LUCI. This CL needs to land concurrently with the infra CLs + restart of the WebRTC Chromium FYI master since the bots change names as a part of this process. Bug: 877018 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2811718874bb9f6079488fc0ee17e6f324ae50b0 Reviewed-on: https://chromium-review.googlesource.com/1249103 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#595033}
-
